From nobody Mon Jun 8 06:36:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68B593D4103; Fri, 5 Jun 2026 23:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701117; cv=none; b=oADePNdI/UTWTMLXYTWYMwjj8tXJaAxS9+KhDFpiXvJFkmU7d55O2+MF9uRBgDBvz3ePk0xvtqT+maYVkPqI3zFEjlZz0N511c4EsH9rNHRrpcCp64MeIo8X287XIl9TqUDGTnLWqIkzXq3ROF1LMRgWCh5+lqbYh3TmD1g/+U0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701117; c=relaxed/simple; bh=jpBTqInRbgQxdCIwDI4YdK9vHSjJaqxKka/nVdGlfLk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=COayaaFSXarztAunm06SqFHwSPj2l+ov9emLF7SbJQg4hD+Spiy4vZjVmJkfzNiEEKZ/ZGvv1L7cyoiO6uzNbxeRP3yYBI13OwXCqxTGjNT+ErYkiR2yMNpiCdGLVh0dFtVFrvIwUM46LYVlFttulQtywsYoncyLmaroqHcYHSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DX78hrkK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DX78hrkK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 101451F0089B; Fri, 5 Jun 2026 23:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780701116; bh=YPIoOh7krPlHLe1es6eCkUrkktxwGB9Au0T9+DGZFTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DX78hrkKcBB53scyNOMsIOEbHHVa8ezQJ0qB/ndXBZVzaNjEFbHzFmhocPnZqkSPR 04grE5O7VXXa8Ow4O/U/Jd2wZT7QY4P1/7mdZQs92uT777ku9sM++qAzcIDDJUlm5+ o303JR4Ttdik2WE/FE2ZLDJxSe7cxDOo7SNWntnyoEwXIXMtxxQN0RUBHZD8dAwCvc V/tTW5/P26fQqTHk/nRv8Apr4xh1nD77M2PvxGu0goyn5Qa7bV+W94KmUhl1T/FSiY VUwXBUhHB20mY2BjMhWWE1lNqeiLHkKF72H+RgZY2YXk1/g3nhjtTcET012/dPS8+E tiLx+rgsc2ckg== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH 1/4] perf timechart: Release event samples at the end Date: Fri, 5 Jun 2026 16:11:52 -0700 Message-ID: <20260605231155.2415760-2-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605231155.2415760-1-namhyung@kernel.org> References: <20260605231155.2415760-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add timechart__release() to free all data structures added during the sample processing. Signed-off-by: Namhyung Kim --- tools/perf/builtin-timechart.c | 54 ++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 04dbb944a42720b4..7c4ace51302e260c 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1548,6 +1548,59 @@ static void write_svg_file(struct timechart *tchart,= const char *filename) svg_close(); } =20 +static void timechart__release(struct timechart *tchart) +{ + struct per_pid *p =3D tchart->all_data; + struct power_event *pwr =3D tchart->power_events; + struct wake_event *we =3D tchart->wake_events; + + while (p) { + struct per_pid *next_pid =3D p->next; + struct per_pidcomm *c =3D p->all; + + while (c) { + struct per_pidcomm *next_comm =3D c->next; + struct cpu_sample *cs =3D c->samples; + struct io_sample *ios =3D c->io_samples; + + while (cs) { + struct cpu_sample *next =3D cs->next; + + free((char *)cs->backtrace); + free(cs); + cs =3D next; + } + + while (ios) { + struct io_sample *next =3D ios->next; + + free(ios); + ios =3D next; + } + + free(c->comm); + free(c); + c =3D next_comm; + } + p =3D next_pid; + } + + while (pwr) { + struct power_event *next =3D pwr->next; + + free(pwr); + pwr =3D next; + } + + while (we) { + struct wake_event *next =3D we->next; + + free((char *)we->backtrace); + free(we); + we =3D next; + } +} + static int process_header(struct perf_file_section *section __maybe_unused, struct perf_header *ph, int feat, @@ -2079,6 +2132,7 @@ int cmd_timechart(int argc, const char **argv) =20 ret =3D __cmd_timechart(&tchart, output_name); out: + timechart__release(&tchart); zfree(&cpus_cstate_start_times); zfree(&cpus_cstate_state); zfree(&cpus_pstate_start_times); --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F7C3F9F5B; Fri, 5 Jun 2026 23:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701117; cv=none; b=TI8IRYxJwfuFsBwATIwewFSHDphj9D/bAPy1/nJnjDHqQFNGpMcRD9vrLJH7z3o+LfDemY2gRSnrkijleK1p0m00p1c2dn611mw9rRAKbp+UJH0Q/jAs+iBAcWWW+ruC5TnjEoCa64DiVoQnCgl9TRA/EWgDGElzIEfAlzmfXTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701117; c=relaxed/simple; bh=zzZxP5dL3VYdAtHIfBjTCt5UciWrf0qX9ZIJRBQFogo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E/Q/j4xe+rTYlVkrCkziWV0ecE86720YB7JQjAQhsZEtt+TDg2hnWid9HlaaR0FiYqHCZX2zeVH/VcKPcjGSbRZG74eatKOiAZetjQ/ufFJew5gvG9e9RTYnV8H5Ut3N/2PLeDCO5RXHAy5H7rWpEFzh9LomfAjEiBNjUMiyoC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QxyEpJ9Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QxyEpJ9Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 720611F0089C; Fri, 5 Jun 2026 23:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780701116; bh=4UKnr9aeBspxTmKS1xV7DqZNI5XVC2ZtAsPnopJVUwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QxyEpJ9Q5241Ob/PnG/hPnu22aPnSgJyzkJyp2+OnoBLYJgT1jQqpN5JVxQfIgtDI Fg8ni44ViRUNWhfFQ2TNMCYOK1Gav+6jjP4ZFfCmRwzBAyo7K5Ww0KMOSokk2n2m0j i5J5tC+5BmrSJXjEbO1q/Z7Pq8aplaZyGkilxTlF2DTtlb+4jm3nQQTAU5tqkAP53Q TmxS1dU72TXGbJFTH2cEcwjtZ4SVvJU7W5oWsAHgIr+ZyH1Z4Qo3tCRgav7Hu116eZ M86SzXTmYZuDee3ZtJS1mKZn7z6qwBcR7K5zzf815FOI39LuP4v8/ajgrJr4QJUwaA EOHJbGg65AGmw== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH 2/4] perf timechart: Fix memory leaks during record Date: Fri, 5 Jun 2026 16:11:53 -0700 Message-ID: <20260605231155.2415760-3-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605231155.2415760-1-namhyung@kernel.org> References: <20260605231155.2415760-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The command line options can be passed without copy as their lifetime is limited within the same function. Signed-off-by: Namhyung Kim Acked-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-timechart.c | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 7c4ace51302e260c..d56adb41dcf9bb69 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1582,6 +1582,8 @@ static void timechart__release(struct timechart *tcha= rt) free(c); c =3D next_comm; } + + free(p); p =3D next_pid; } =20 @@ -1820,6 +1822,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ "syscalls:sys_exit_select", }; unsigned int poll_events_nr =3D ARRAY_SIZE(poll_events); + int ret; =20 rec_argc =3D common_args_nr + disk_events_nr * 4 + @@ -1838,7 +1841,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ =20 p =3D rec_argv; for (i =3D 0; i < common_args_nr; i++) - *p++ =3D strdup(common_args[i]); + *p++ =3D common_args[i]; =20 for (i =3D 0; i < disk_events_nr; i++) { if (!is_valid_tracepoint(disk_events[i])) { @@ -1847,7 +1850,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(disk_events[i]); + *p++ =3D disk_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1858,7 +1861,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(net_events[i]); + *p++ =3D net_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1869,7 +1872,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(poll_events[i]); + *p++ =3D poll_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1877,7 +1880,11 @@ static int timechart__io_record(int argc, const char= **argv, const char *output_ for (i =3D 0; i < (unsigned int)argc; i++) *p++ =3D argv[i]; =20 - return cmd_record(rec_argc, rec_argv); + ret =3D cmd_record(rec_argc, rec_argv); + + free(rec_argv); + free(filter); + return ret; } =20 =20 @@ -1888,6 +1895,7 @@ static int timechart__record(struct timechart *tchart= , int argc, const char **ar const char **rec_argv; const char **p; unsigned int record_elems; + int ret; =20 const char * const common_args[] =3D { "record", "-a", "-R", "-c", "1", "-o", output_data, @@ -1952,24 +1960,27 @@ static int timechart__record(struct timechart *tcha= rt, int argc, const char **ar =20 p =3D rec_argv; for (i =3D 0; i < common_args_nr; i++) - *p++ =3D strdup(common_args[i]); + *p++ =3D common_args[i]; =20 for (i =3D 0; i < backtrace_args_no; i++) - *p++ =3D strdup(backtrace_args[i]); + *p++ =3D backtrace_args[i]; =20 for (i =3D 0; i < tasks_args_nr; i++) - *p++ =3D strdup(tasks_args[i]); + *p++ =3D tasks_args[i]; =20 for (i =3D 0; i < power_args_nr; i++) - *p++ =3D strdup(power_args[i]); + *p++ =3D power_args[i]; =20 for (i =3D 0; i < old_power_args_nr; i++) - *p++ =3D strdup(old_power_args[i]); + *p++ =3D old_power_args[i]; =20 for (j =3D 0; j < (unsigned int)argc; j++) *p++ =3D argv[j]; =20 - return cmd_record(rec_argc, rec_argv); + ret =3D cmd_record(rec_argc, rec_argv); + + free(rec_argv); + return ret; } =20 static int --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C4093FBB6F; Fri, 5 Jun 2026 23:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701118; cv=none; b=bd9qKbCVtZRM7hu082sgXVKtP6uCnocKY+U+LTP75qe2Ih8tmfdP491UiqFrmXe4/j7d7lVqm9lh+9JG3LL6uWRtAXKmnaPIywtqJO67yDM5kZS2hBIYEpopaGRRtzFf0+NvhFbgVpsNrNeZcXS5bUUMsWoTeUeGGbjqZjTklO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701118; c=relaxed/simple; bh=Lqlmcsk5Lgf5Xs/v38e+14b+p32qOTDIWKOvSddURWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XGjRV89fLbhdCbJHGVwTy2SAOMf1nY3onM50a6ZU6Q5sKVzs9nKF+tsi3XuW4FJXK+ilRkSZvZnYiM1qB8YGKYinasArAWJ2kEx+jHhWjGVmnFeo7kZ7Nalt3rNhFsz8c3Dsd0EEvqBb5mRw8uzZdLKD+78V8szTmI6BcLPCxmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bcN+oB3o; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bcN+oB3o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D38D31F00898; Fri, 5 Jun 2026 23:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780701117; bh=6pXxrcFAudnc6PlL7iAOib1DFz07jJcwVVd648vjHxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bcN+oB3oujF3+2IgpZNfkoS/vFVJF6AzxUvVZD0NwLhjlBJwx6mroZcTDznlpWZor U0d7AIYTAjufrd5T3Ys80tadnkf5l1YUXukfBCfHq+kSBJxffAyFuJSKv3D2U+liwc uCLQ8jyifK4rjefmkT/vRNSflC31+0vcLTXwC3oLV8KP4DYuYvT6vnJ8GTDLYxTnyJ d/KjhUOTbL0xFBQmZJ7RHy3WhMgWbtEm3g5tbLvyWCF58gLD/IfmFdmVzpUYbOnmLC +tg+LrOmwfSGS4mJwgSO2oiZuX7nkO+gW+nZAV0+69qTsnE+LP+OGCZkg7xDnjS6/P gyhJJxP5KDfzw== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH 3/4] perf timechart: Fix memory leaks in draw_wakeups() Date: Fri, 5 Jun 2026 16:11:54 -0700 Message-ID: <20260605231155.2415760-4-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605231155.2415760-1-namhyung@kernel.org> References: <20260605231155.2415760-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The second loop for per_pidcommd is meaningful only when it doesn't have from and to tasks. Also make sure c->Y is set before copying the comm string otherwise it will be overwritten by next one. Signed-off-by: Namhyung Kim --- tools/perf/builtin-timechart.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index d56adb41dcf9bb69..e8d01c8723959e80 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1110,12 +1110,12 @@ static void draw_wakeups(struct timechart *tchart) c =3D c->next; } c =3D p->all; - while (c) { - if (p->pid =3D=3D we->waker && !from) { + while (c && !from && !to) { + if (c->Y && p->pid =3D=3D we->waker && !from) { from =3D c->Y; task_from =3D strdup(c->comm); } - if (p->pid =3D=3D we->wakee && !to) { + if (c->Y && p->pid =3D=3D we->wakee && !to) { to =3D c->Y; task_to =3D strdup(c->comm); } --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:43 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A873940B36C; Fri, 5 Jun 2026 23:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701119; cv=none; b=ZaPAajoVjxYyJKb1tVUsi+AYeSQY+dvAlpwSwFhEbMLxKTSLQAQL3dWO047Ngymz42uaGFa2nrkC78BceAHWz5XlMILa/kfVhjJtU1+02AENA7yJDf6tmyMP6E0t0Sf6V6QdSokIYRXivZhJZKWSvmYzr1cCE9/r5H7P+mZiU70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780701119; c=relaxed/simple; bh=z3w19A16NH7NdvirA4opVoS2O6lRMszvIMrx9KkbOWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hQV8zFbyUMw0NWXmdsyfp/YCn6maVm7kINt2SwRXALo5zDuodM1+Rhk9jFIWFhjgjG2H3DpLIKxDQfitc9bS+BsbbUVLOiofLD9Xh+tirtjKooAFt0Lm2F5eKzxTbCvpreM0q6DsQzWshFhbz4uTZe2fjbUadYnO2wZ0EhzzfGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sd6sxBSO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sd6sxBSO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C221F00893; Fri, 5 Jun 2026 23:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780701117; bh=/4otRSM6EtEjjXJGLXf1QzGjALVdbnQQ4hssMzx/+os=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sd6sxBSORFKKyuwdZPKu+0b9VYic9HQY/zMeFi2J9QYgQ1tQ/mn+aydIojywe+J3z KxT8jajpi3nZLSpOLedxUV3WKADJy5xFmyr3Hjmy/lRapvhrQTUbV9i4B9yTnle2Q8 UEhPXhcbYgcr0J1+W9YYWHV52kMVygY5mj1ZjTW0j5EDDFHTq43Mi0EtcMy2M0e7mE pEedrr9HybXBoh1qsjXOi/ZJD5od52FS3ifN/40Pb4CWcGCg8l/vpE66JqCE7AW4qC gAXj6vkatbtEW6P7naM1gQrx4DGr0sOamWK35Lc3FKSZ9tGzJ+h1C9P+HSUDQCInvV LfR0W/XnQv9Aw== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH 4/4] perf test: Update perf timechart test Date: Fri, 5 Jun 2026 16:11:55 -0700 Message-ID: <20260605231155.2415760-5-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605231155.2415760-1-namhyung@kernel.org> References: <20260605231155.2415760-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To include IO-only and backtrace modes to test different code paths. $ sudo perf test -vv timechart 135: perf timechart tests : Running 135: perf timechart tests: ---- start ---- test child forked, pid 2413665 perf timechart Basic test perf timechart Basic test [Success] perf timechart IO-only test perf timechart IO-only test [Success] perf timechart Backtrace test perf timechart Backtrace test [Success] ---- end(0) ---- 135: perf timechart tests : Ok =3D=3D=3D Test Summary =3D=3D=3D Passed main tests : 1 Passed subtests : 0 Skipped tests : 0 Failed tests : 0 Signed-off-by: Namhyung Kim --- tools/perf/tests/shell/timechart.sh | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tools/perf/tests/shell/timechart.sh b/tools/perf/tests/shell/t= imechart.sh index b14b3472c2846b32..40072b32171a9a1c 100755 --- a/tools/perf/tests/shell/timechart.sh +++ b/tools/perf/tests/shell/timechart.sh @@ -9,7 +9,7 @@ perfdata=3D$(mktemp /tmp/__perf_timechart_test.perf.data.XX= XXX) output=3D$(mktemp /tmp/__perf_timechart_test.output.XXXXX.svg) =20 cleanup() { - rm -f "${perfdata}" + rm -f "${perfdata}"* rm -f "${output}" trap - EXIT TERM INT } @@ -22,38 +22,41 @@ trap_cleanup() { trap trap_cleanup EXIT TERM INT =20 test_timechart() { - echo "Basic perf timechart test" + NAME=3D$1 + OPTION=3D$2 + + echo "perf timechart ${NAME} test" =20 # Try to record timechart data. # perf timechart record uses system-wide recording and specific tracepoin= ts. # If it fails (e.g. permissions, missing tracepoints), skip the test. - if ! perf timechart record -o "${perfdata}" true > /dev/null 2>&1; then - echo "Basic perf timechart test [Skipped: perf timechart record failed (= permissions/events?)]" + if ! perf timechart record -o "${perfdata}" ${OPTION} true > /dev/null 2>= &1; then + echo "perf timechart ${NAME} test [Skipped: perf timechart record failed= (permissions/events?)]" return fi =20 # Generate the timechart if ! perf timechart -i "${perfdata}" -o "${output}" > /dev/null 2>&1; then - echo "Basic perf timechart test [Failed: perf timechart command failed]" + echo "perf timechart ${NAME} test [Failed: perf timechart command failed= ]" err=3D1 return fi =20 # Check if output file exists and is not empty if [ ! -s "${output}" ]; then - echo "Basic perf timechart test [Failed: output file is empty or missing= ]" + echo "perf timechart ${NAME} test [Failed: output file is empty or missi= ng]" err=3D1 return fi =20 # Check if it looks like an SVG if ! grep -q "svg" "${output}"; then - echo "Basic perf timechart test [Failed: output doesn't look like SVG]" + echo "perf timechart ${NAME} test [Failed: output doesn't look like SVG]" err=3D1 return fi =20 - echo "Basic perf timechart test [Success]" + echo "perf timechart ${NAME} test [Success]" } =20 if ! perf check feature -q libtraceevent ; then @@ -62,6 +65,9 @@ if ! perf check feature -q libtraceevent ; then exit 2 fi =20 -test_timechart +test_timechart "Basic" "" +test_timechart "IO-only" "-I" +test_timechart "Backtrace" "-g" + cleanup exit $err --=20 2.54.0.1032.g2f8565e1d1-goog