[PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions

Juergen Gross posted 10 patches 2 days, 13 hours ago
arch/x86/events/intel/ds.c                   | 11 +--
arch/x86/include/asm/msr.h                   | 28 +-----
arch/x86/kernel/cpu/mce/amd.c                |  6 +-
arch/x86/kernel/cpu/mce/inject.c             |  8 +-
arch/x86/kernel/msr.c                        |  8 +-
arch/x86/lib/msr-smp.c                       | 89 +++-----------------
drivers/cpufreq/amd-pstate.c                 |  2 +-
drivers/cpufreq/amd_freq_sensitivity.c       |  6 +-
drivers/cpufreq/p4-clockmod.c                | 32 +++----
drivers/cpufreq/speedstep-centrino.c         | 27 +++---
drivers/hwmon/coretemp.c                     | 44 +++++-----
drivers/hwmon/via-cputemp.c                  | 16 ++--
drivers/thermal/intel/intel_tcc.c            | 43 +++++-----
drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 +++---
14 files changed, 128 insertions(+), 217 deletions(-)
[PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions
Posted by Juergen Gross 2 days, 13 hours ago
Drop the variants using 2 32-bit values instead of a single 64-bit one
of the *_on_cpu() MSR access functions.

Changes in V2:
- patches 1+2 split out from other patch
- keep the *q() variants instead of those without suffix

Juergen Gross (10):
  x86/msr: Switch rdmsrl_on_cpu() users to rdmsrq_on_cpu()
  x86/msr: Remove rdmsrl_on_cpu()
  x86/msr: Switch rdmsr_on_cpu() users to rdmsrq_on_cpu()
  x86/msr: Remove rdmsr_on_cpu()
  x86/msr: Switch wrmsr_on_cpu() users to wrmsrq_on_cpu()
  x86/msr: Remove wrmsr_on_cpu()
  x86/msr: Switch rdmsr_safe_on_cpu() users to rdmsrq_safe_on_cpu()
  x86/msr: Remove rdmsr_safe_on_cpu()
  x86/msr: Switch wrmsr_safe_on_cpu() users to wrmsrq_safe_on_cpu()
  x86/msr: Remove wrmsr_safe_on_cpu()

 arch/x86/events/intel/ds.c                   | 11 +--
 arch/x86/include/asm/msr.h                   | 28 +-----
 arch/x86/kernel/cpu/mce/amd.c                |  6 +-
 arch/x86/kernel/cpu/mce/inject.c             |  8 +-
 arch/x86/kernel/msr.c                        |  8 +-
 arch/x86/lib/msr-smp.c                       | 89 +++-----------------
 drivers/cpufreq/amd-pstate.c                 |  2 +-
 drivers/cpufreq/amd_freq_sensitivity.c       |  6 +-
 drivers/cpufreq/p4-clockmod.c                | 32 +++----
 drivers/cpufreq/speedstep-centrino.c         | 27 +++---
 drivers/hwmon/coretemp.c                     | 44 +++++-----
 drivers/hwmon/via-cputemp.c                  | 16 ++--
 drivers/thermal/intel/intel_tcc.c            | 43 +++++-----
 drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 +++---
 14 files changed, 128 insertions(+), 217 deletions(-)

-- 
2.54.0
Re: [PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions
Posted by Dave Hansen 2 days, 13 hours ago
On 6/5/26 07:43, Juergen Gross wrote:
>  arch/x86/events/intel/ds.c                   | 11 +--
>  arch/x86/include/asm/msr.h                   | 28 +-----
>  arch/x86/kernel/cpu/mce/amd.c                |  6 +-
>  arch/x86/kernel/cpu/mce/inject.c             |  8 +-
>  arch/x86/kernel/msr.c                        |  8 +-
>  arch/x86/lib/msr-smp.c                       | 89 +++-----------------
>  drivers/cpufreq/amd-pstate.c                 |  2 +-
>  drivers/cpufreq/amd_freq_sensitivity.c       |  6 +-
>  drivers/cpufreq/p4-clockmod.c                | 32 +++----
>  drivers/cpufreq/speedstep-centrino.c         | 27 +++---
>  drivers/hwmon/coretemp.c                     | 44 +++++-----
>  drivers/hwmon/via-cputemp.c                  | 16 ++--
>  drivers/thermal/intel/intel_tcc.c            | 43 +++++-----
>  drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 +++---
>  14 files changed, 128 insertions(+), 217 deletions(-)

This is wonderful. Thank you for doing this!

My only real complaint is the lack of changelog for 07/10. Otherwise, it
looks great to me. Ideally, you'd collect a few more reviews and post a
v3 rebased right after the next -rc1.

Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
Re: [PATCH v2 00/10] x86/msr: Drop 32-bit variants of *_on_cpu() MSR functions
Posted by Jürgen Groß 2 days, 13 hours ago
On 05.06.26 17:08, Dave Hansen wrote:
> On 6/5/26 07:43, Juergen Gross wrote:
>>   arch/x86/events/intel/ds.c                   | 11 +--
>>   arch/x86/include/asm/msr.h                   | 28 +-----
>>   arch/x86/kernel/cpu/mce/amd.c                |  6 +-
>>   arch/x86/kernel/cpu/mce/inject.c             |  8 +-
>>   arch/x86/kernel/msr.c                        |  8 +-
>>   arch/x86/lib/msr-smp.c                       | 89 +++-----------------
>>   drivers/cpufreq/amd-pstate.c                 |  2 +-
>>   drivers/cpufreq/amd_freq_sensitivity.c       |  6 +-
>>   drivers/cpufreq/p4-clockmod.c                | 32 +++----
>>   drivers/cpufreq/speedstep-centrino.c         | 27 +++---
>>   drivers/hwmon/coretemp.c                     | 44 +++++-----
>>   drivers/hwmon/via-cputemp.c                  | 16 ++--
>>   drivers/thermal/intel/intel_tcc.c            | 43 +++++-----
>>   drivers/thermal/intel/x86_pkg_temp_thermal.c | 25 +++---
>>   14 files changed, 128 insertions(+), 217 deletions(-)
> 
> This is wonderful. Thank you for doing this!
> 
> My only real complaint is the lack of changelog for 07/10. Otherwise, it
> looks great to me. Ideally, you'd collect a few more reviews and post a
> v3 rebased right after the next -rc1.
> 
> Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>

Thanks, will do as you suggest.


Juergen