spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses()

[PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses()

Posted by Fenglin Wu 3 days, 1 hour ago

Call of_node_put(child) to reduce its reference count when
bailing out from the for_each_available_child_of_node() loop
upon an error in bus registration.

Also, return 0 directly if there are no errors in bus
registration.

Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
---
 drivers/spmi/spmi-pmic-arb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 2e2cb4774103..26e804ad95a1 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -2055,12 +2055,14 @@ static int spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb,
 	for_each_available_child_of_node_scoped(node, child) {
 		if (of_node_name_eq(child, "spmi")) {
 			ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
-			if (ret)
+			if (ret) {
+				of_node_put(child);
 				return ret;
+			}
 		}
 	}
 
-	return ret;
+	return 0;
 }
 
 static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb *pmic_arb)

---
base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a
change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e

Best regards,
--  
Fenglin Wu <fenglin.wu@oss.qualcomm.com>

Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses()

Posted by Greg Kroah-Hartman 3 days, 1 hour ago

On Thu, Jun 04, 2026 at 10:46:03PM -0700, Fenglin Wu wrote:
> Call of_node_put(child) to reduce its reference count when
> bailing out from the for_each_available_child_of_node() loop
> upon an error in bus registration.
> 
> Also, return 0 directly if there are no errors in bus
> registration.
> 
> Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
>  drivers/spmi/spmi-pmic-arb.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses()

Posted by Jie Gan 3 days, 1 hour ago


On 6/5/2026 1:46 PM, Fenglin Wu wrote:
> Call of_node_put(child) to reduce its reference count when
> bailing out from the for_each_available_child_of_node() loop
> upon an error in bus registration.
> 
> Also, return 0 directly if there are no errors in bus
> registration.
> 
> Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
>   drivers/spmi/spmi-pmic-arb.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 2e2cb4774103..26e804ad95a1 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -2055,12 +2055,14 @@ static int spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb,
>   	for_each_available_child_of_node_scoped(node, child) {
>   		if (of_node_name_eq(child, "spmi")) {
>   			ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
> -			if (ret)
> +			if (ret) {
> +				of_node_put(child);

We dont need of_node_put here. The 
for_each_available_child_of_node_scoped will handle the refcnt 
automatically.

Thanks,
Jie

>   				return ret;
> +			}
>   		}
>   	}
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb *pmic_arb)
> 
> ---
> base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a
> change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e
> 
> Best regards,
> --
> Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>

Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses()

Posted by Fenglin Wu 2 days, 23 hours ago

On 6/5/2026 2:15 PM, Jie Gan wrote:
>
>
> On 6/5/2026 1:46 PM, Fenglin Wu wrote:
>> Call of_node_put(child) to reduce its reference count when
>> bailing out from the for_each_available_child_of_node() loop
>> upon an error in bus registration.
>>
>> Also, return 0 directly if there are no errors in bus
>> registration.
>>
>> Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
>> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>> ---
>>   drivers/spmi/spmi-pmic-arb.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index 2e2cb4774103..26e804ad95a1 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -2055,12 +2055,14 @@ static int 
>> spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb,
>>       for_each_available_child_of_node_scoped(node, child) {
>>           if (of_node_name_eq(child, "spmi")) {
>>               ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
>> -            if (ret)
>> +            if (ret) {
>> +                of_node_put(child);
>
> We dont need of_node_put here. The 
> for_each_available_child_of_node_scoped will handle the refcnt 
> automatically.
>
> Thanks,
> Jie

Ahh, thanks for pointing out. Just trying to send a patch which was 
applied in our downstream code base. I didn't notice this was fixed on 
the tip.

Anyway, still need to fix the minor one on the "ret" value 
initialization. Will resend.

>
>>                   return ret;
>> +            }
>>           }
>>       }
>>   -    return ret;
>> +    return 0;
>>   }
>>     static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb 
>> *pmic_arb)
>>
>> ---
>> base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a
>> change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e
>>
>> Best regards,
>> -- 
>> Fenglin Wu <fenglin.wu@oss.qualcomm.com>
>>
>