From nobody Mon Jun 8 08:32:27 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B869346FA4 for ; Fri, 5 Jun 2026 05:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780638369; cv=none; b=JQjWxWLECx0F0cxA/iTSsXyMD0Yj6riJbJez77ALSMFWU5RdfHlohQnL0oj2VNcR5EOAKlEuW9uJqFNcjgTrOBwurtg1dyh3g/s1EZhpSh+SWpPa+ZDvn0olfzGx3tUD/yMUUl6akz+MS1JGdF55R3bWcSQ5Ndurbklsix06vO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780638369; c=relaxed/simple; bh=hNoDdHVVN8I98D586YtDBc9mOh/0UwkJNkG/q3AzSXc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=INPArjHyLMpQrfbc4kpWBp0N7M33sVUlEMRZi6DLAV4LRKh5WKuI7CF5nVI/RBnDvIDuZM0/j53ZwsnUTOjcGhZxNqC6vBC6YnUI4F4B79Sz7pjxM+aGYlQONYVUPXEECD1Os3NrBuKYRW4timHwUBxfQIlyX+xrN/uI+NNKj+E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fQbzSzmm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TFTl5LpO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fQbzSzmm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TFTl5LpO" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 654NqJuO528695 for ; Fri, 5 Jun 2026 05:46:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=aKF0JlBKTA3Y/Q72qEhmnX LjLL6QWIzPFLpvb4RPfS4=; b=fQbzSzmmOyCHzuHcZCQo/zlmnimcgQNVq2i18k xmTWOVibJ9qXI6ZVOfoc1BMpXi+Hzwx9bm9IvxyuMzf2xuaEpDatLap+u7bzZDZN gGaGTIVhj6riYEw9HHO99eCCYl+tlZhPYiXndnV0kOqk3UDV0jDL2Ck5tecD8uEW KTSfRhZx3NYEt+9v834hk984qxJa9hMvw+aHAcQhoVv1aaMyBopMJJzqG3FrrzL8 PvYMpTEBoS8Xo1Yj74t81zJB1bi6BI3t250L9uX8LLXvLDJ2jR3EI4i22KaCOpMY iO0p8Hib/wdTHPQmzcnAmJDxao8x1jHIssAL5tDp+P2u9dvQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ekbgdudm8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 05:46:07 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-304ee7d1368so1416922eec.0 for ; Thu, 04 Jun 2026 22:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780638366; x=1781243166; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=aKF0JlBKTA3Y/Q72qEhmnXLjLL6QWIzPFLpvb4RPfS4=; b=TFTl5LpO5YebhR8xJfPVqS9RncqJ2fprlDGw1R9Eo53B6hhJ+zoGTYLMPbodAfiCo2 aTSbRy2ELwJExFGD9JCwDAEqmAa808MmLEemVAfX7Mut7WLogy8VKqynppNXolZbMin8 EBpuLpZ0gFWdKwHJSDH4eGerdAw9w4fZYRMIVXQuoA+yYQpxvQGNG6JlNhQOldRG5+Fz HpKXmM7NjbWE5lzTOp+tfcNu4KC80bstKIxpEYEGDB3QJQDRydUwbtyePwhjdyHsGR58 8Qvc1kNY4N0oFkReJPJXRYoEWGlrXr1A3Uuxlg2kJ8kbymb8cUcP+K7jAHowh6sBW5uX GsqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780638366; x=1781243166; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aKF0JlBKTA3Y/Q72qEhmnXLjLL6QWIzPFLpvb4RPfS4=; b=erhMyI6V1b6va7/HqtKzRuzdeAqvbZ1LFQLnGZW6j4GW8U4rhBwc9aztFqtbJutvWk Jw5zaFimniG/r8pLsHxUxDFRZ7+NzSoGYPnFR0uWpKGQX6E68mZEbRB6ZtSM1nU4wwv+ iJz2QHDkAb8To72T19h/1wj6hxPYHdUTZ6ynZK4FKrWPPdF0JoIU3EFRs4bMdaV1kbpu 18iL/QQQBT0dIRhVnP0fKTXBOim+h5Q+7dzOASfw+uYNQ+kDY4/Ut0dR/Ea7zGlaq2HB QnoohpMIg8UlpGCI7S6grnHLTMOOoQGzYW7TUFF8ZJ7qaQOy4FqVsdMufz3uQZveC39j 1h0Q== X-Forwarded-Encrypted: i=1; AFNElJ/Khdec//wK9gNL+zs+VxymU+AcyYrvu2beP73cWIwxvazzD8XksyiuU7Exd0P7MXsSEeo0pS1HcDdnTW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf6h0eFAAarL5Uj64z2c1KjiKuM2yLA+NgjVQG5fcn82yEgLVg VCsviQoIo0LSgoiIg7rPzQkh7Rcrjv4Wpug33BEGwz9FCXALVxKLn4/3Qv3taXf6vAOgB4g58VO VXZ3vnmgmaGBaNMXGfNAAEYKsS/xR1TYHPUi4kCIx5DG7hWbijhLcTQgzIGhUGXlIpBnTelY27p 0= X-Gm-Gg: Acq92OETdFKWux+36NL0lO96JKGh10vB7xhRU9BX8z9W29wKGAOtJPIqzSMCDzTLJJF KfIjz6F6I3D1yCrMuLOzF51eyaK+X4SEODotA4ek89AsCahdoKeirAkNrNPjy3AR1HEZmVXeIft GRE8fLO99vTJ2yjxuH50xMTcwM4tFjvYqv3y9hUgIDGkIlqTIhbR8iJC2AWJmPtVB7wVScpoSu5 Y/rz66xugOFdEgE4hXEtQsTw7aMQ0kL3HObOw2Opq0jCs3TM+5V/ebIT2OPW/UNiLuwEJi+IbZw PUA3ARsPm9BC1j0rtIXNCT6zciixorCvPZ2zuBxTfDr+wEjq1T8gyQ3AV9ouulcvZUltKrtbn8s z2Jkdz2rNZCD2Z/TEB5dWr+ER3DTZ/6X2T1zPcd2lybdbHzky4/wqZYvRaPDR2AakuaXwXTvDwg 08RxrUQH03 X-Received: by 2002:a05:693c:2d82:b0:304:9b48:53da with SMTP id 5a478bee46e88-3077b260fe3mr868203eec.26.1780638365991; Thu, 04 Jun 2026 22:46:05 -0700 (PDT) X-Received: by 2002:a05:693c:2d82:b0:304:9b48:53da with SMTP id 5a478bee46e88-3077b260fe3mr868186eec.26.1780638365474; Thu, 04 Jun 2026 22:46:05 -0700 (PDT) Received: from hu-fenglinw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074dba046esm6259317eec.9.2026.06.04.22.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 22:46:05 -0700 (PDT) From: Fenglin Wu Date: Thu, 04 Jun 2026 22:46:03 -0700 Subject: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAJpiImoC/yXMUQqDMBCE4avIPnch1SC2Vyl9MGaiW6iVXRVBv Ltp+/gNzL+TQQVG92InxSomnzHjeimoG9qxB0vMptKVtaudZ5vewmExVvRiM5STbBxTDDcfUlN 5UP5Oijz/uo/n37aEF7r5G6PjOAEEbjpReQAAAA== X-Change-ID: 20260604-spmi-bus-register-fix-dfdb94bf834e To: linux-arm-msm@vger.kernel.org, Stephen Boyd , Neil Armstrong , Abel Vesa , Greg Kroah-Hartman Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org, Fenglin Wu X-Mailer: b4 0.16-dev-17187 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780638364; l=1283; i=fenglin.wu@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=hNoDdHVVN8I98D586YtDBc9mOh/0UwkJNkG/q3AzSXc=; b=i8gLviUOerzhIISqWQsIA3qybUaeTiHrllV0oUS1UelvC4PT3nqALEzuHp97CjkPS73mD6Afb WIr9Q4bTQFMAA3V8NA+I0dtuWo0lIFi+8usblvZzDdPMWFWRK1kzjB+ X-Developer-Key: i=fenglin.wu@oss.qualcomm.com; a=ed25519; pk=hJdt3E7o54lql+miD2GaxwF74cDyhgNwMbmFOZ46bRU= X-Proofpoint-GUID: rOgVS4CMOlVaeuQw2fQZRUZenyHTix6T X-Proofpoint-ORIG-GUID: rOgVS4CMOlVaeuQw2fQZRUZenyHTix6T X-Authority-Analysis: v=2.4 cv=a8cAM0SF c=1 sm=1 tr=0 ts=6a22629f cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=vTbStt9xRa3esVon5YYA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA1MiBTYWx0ZWRfX57oE/aik/3kB WNPOQZtoy2rdTbCI7mvCdnwb1P3cnotKRpE48mNVS/uKN139SYtsTlgGcNuM0yTravUiXZzgKWk n6EsLb03AGCEjlPkvudl8yqRNaKaLL4295MZ5DcK60TgzTrZvLtmXqDcNnq67n9QqOMuqvrR0vB M4zHTS2nnxm7kUmlZeMDcXUBwMvNM5Mja545or6kuEhg1iaLMZG95BelJegaOqGoFPeFMRnM2eI cxgsiQn6SJ1IpX87yWblU4N7snt+5LpdSuFtKEPL9KIWgf0celCRM2tU7KaHiw5kcMMHxKd75Za 4112N2YazfUhskQEGob8czyabA7axO4UQ4WUfM8iM41epRzCFRLRsbaRbmE5s19aOqUukdmq75O CthWgL7Bw6DBDsX4M2NoFkvHkVCVoStbkrwww3Qnn6zR9HAR94CL4w/dM3zG7gIZoTw6RL03djU BZrFCKesGVJOJM+nG6Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050052 Call of_node_put(child) to reduce its reference count when bailing out from the for_each_available_child_of_node() loop upon an error in bus registration. Also, return 0 directly if there are no errors in bus registration. Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support") Signed-off-by: Fenglin Wu --- drivers/spmi/spmi-pmic-arb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 2e2cb4774103..26e804ad95a1 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -2055,12 +2055,14 @@ static int spmi_pmic_arb_register_buses(struct spmi= _pmic_arb *pmic_arb, for_each_available_child_of_node_scoped(node, child) { if (of_node_name_eq(child, "spmi")) { ret =3D spmi_pmic_arb_bus_init(pdev, child, pmic_arb); - if (ret) + if (ret) { + of_node_put(child); return ret; + } } } =20 - return ret; + return 0; } =20 static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb *pmic_arb) --- base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e Best regards, -- =20 Fenglin Wu