[PATCH 0/4] qcom-rng fixes and cleanups

Eric Biggers posted 4 patches 1 week, 2 days ago
arch/arm/configs/multi_v7_defconfig |   2 +-
arch/arm/configs/qcom_defconfig     |   2 +-
arch/arm64/configs/defconfig        |   2 +-
drivers/char/hw_random/Kconfig      |  11 ++
drivers/char/hw_random/Makefile     |   1 +
drivers/char/hw_random/qcom-rng.c   | 132 +++++++++++++
drivers/crypto/Kconfig              |  12 --
drivers/crypto/Makefile             |   1 -
drivers/crypto/qcom-rng.c           | 276 ----------------------------
drivers/gpu/drm/ci/arm64.config     |   2 +-
10 files changed, 148 insertions(+), 293 deletions(-)
create mode 100644 drivers/char/hw_random/qcom-rng.c
delete mode 100644 drivers/crypto/qcom-rng.c
[PATCH 0/4] qcom-rng fixes and cleanups
Posted by Eric Biggers 1 week, 2 days ago
This series fixes several bugs in qcom-rng, including failure to enable
the clock before accessing the hardware, generating biased random
numbers, and generating duplicate or non-random numbers due to missing
locking.  To fix the latter bug, it drops the support for the
duplicative crypto_rng interface, which isn't used in practice, leaving
just hwrng which is the one that actually matters.

This series is targeting cryptodev/master

Eric Biggers (4):
  crypto: qcom-rng - Enable clock in hwrng case
  crypto: qcom-rng - Allow zero as a random number
  crypto: qcom-rng - Remove crypto_rng interface
  hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/

 arch/arm/configs/multi_v7_defconfig |   2 +-
 arch/arm/configs/qcom_defconfig     |   2 +-
 arch/arm64/configs/defconfig        |   2 +-
 drivers/char/hw_random/Kconfig      |  11 ++
 drivers/char/hw_random/Makefile     |   1 +
 drivers/char/hw_random/qcom-rng.c   | 132 +++++++++++++
 drivers/crypto/Kconfig              |  12 --
 drivers/crypto/Makefile             |   1 -
 drivers/crypto/qcom-rng.c           | 276 ----------------------------
 drivers/gpu/drm/ci/arm64.config     |   2 +-
 10 files changed, 148 insertions(+), 293 deletions(-)
 create mode 100644 drivers/char/hw_random/qcom-rng.c
 delete mode 100644 drivers/crypto/qcom-rng.c


base-commit: 5624ea54f3ba5c83d2e5503411a31a8be0278c1e
-- 
2.54.0