[v1] netconsole: Fix reported problems

[PATCH net 0/3] netconsole: Fix reported problems

Posted by Breno Leitao 1 week, 3 days ago

These are some of the issues that LLM reported to netconsole, and they
are being addressed here before big refactors.

I was doing some big refactors, and got some "pre-existent-issues"
during LLM review of the refactor, that make them hard to guarantee that
refactor is not introducing any bug, so, let's clean these pre-existent
bugs first, and then submit the refactor.

The issues fixed in this patchset were reported during the review of
https://lore.kernel.org/all/20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org/

Not all of them got fixed, but, those that were easy to reason about.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
      netconsole: do not schedule skb pool refill from NMI
      netconsole: do not dequeue pooled skbs that cannot satisfy len
      netconsole: take target_cleanup_list_lock in drop_netconsole_target()

 drivers/net/netconsole.c | 26 ++++++++++++++++++++++++--
 include/linux/netpoll.h  | 16 ++++++++++++++++
 net/core/netpoll.c       |  7 -------
 3 files changed, 40 insertions(+), 9 deletions(-)
---
base-commit: e7e28506af98ce4e1059e5ec59334b335c00a246
change-id: 20260528-netcons_fix_before_move-cd6cfec4e8f5
prerequisite-change-id: 20260528-netconsole_fixes-35d4e1f88828:v1

Best regards,
--  
Breno Leitao <leitao@debian.org>

Re: [PATCH net 0/3] netconsole: Fix reported problems

Posted by Breno Leitao 1 week ago

On Fri, May 29, 2026 at 03:45:10AM -0400, Breno Leitao wrote:
> These are some of the issues that LLM reported to netconsole, and they
> are being addressed here before big refactors.
> 
> I was doing some big refactors, and got some "pre-existent-issues"
> during LLM review of the refactor, that make them hard to guarantee that
> refactor is not introducing any bug, so, let's clean these pre-existent
> bugs first, and then submit the refactor.
> 
> The issues fixed in this patchset were reported during the review of
> https://lore.kernel.org/all/20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org/
> 
> Not all of them got fixed, but, those that were easy to reason about.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Somehow this patch haven't applied to 'net' tree and the tests haven't
run.

https://patchwork.kernel.org/project/netdevbpf/patch/20260529-netcons_fix_before_move-v1-1-cb2d1426dd75@debian.org/

I will respin it.

--
pw-bot: cr