These are some of the issues that LLM reported to netconsole, and they
are being addressed here before big refactors.
I was doing some big refactors, and got some "pre-existent-issues"
during LLM review of the refactor, that make them hard to guarantee that
refactor is not introducing any bug, so, let's clean these pre-existent
bugs first, and then submit the refactor.
The issues fixed in this patchset were reported during the review of
https://lore.kernel.org/all/20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org/
Not all of them got fixed, but, those that were easy to reason about.
Why net-next and not 'net' tree.
Most of the functions that are being fixed here moved from netpoll to
netconsole, thus, fixing this on net will cause merge conflicts from
'net' to 'net-next', thus I decided to fix it on 'net-next', given we
are on 7.1-rc6 already. Sorry if that is not the right approach.
---
Changes in v3:
- Fix a regression in the first patch, where warning was called in
a potential NMI context.
- Fix additional issues reported by sashiko. They never end.
- Link to v2: https://lore.kernel.org/r/20260602-netcons_fix_before_move-v2-0-eca3f8a8b1a3@debian.org
Changed in v2:
* Change it from 'net' to 'net-next'.
---
Breno Leitao (5):
netconsole: do not schedule skb pool refill from NMI
netconsole: do not dequeue pooled skbs that cannot satisfy len
netconsole: take target_cleanup_list_lock in drop_netconsole_target()
netconsole: clean up deactivated targets dropped before the cleanup worker
netconsole: close netdevice unregister window during target resume
drivers/net/netconsole.c | 76 ++++++++++++++++++++++++++++++++++++++++++++----
include/linux/netpoll.h | 16 ++++++++++
net/core/netpoll.c | 7 -----
3 files changed, 87 insertions(+), 12 deletions(-)
---
base-commit: cd5077cccf13effebf7ff4cb1c7fa080c1738d0f
change-id: 20260528-netcons_fix_before_move-cd6cfec4e8f5
Best regards,
--
Breno Leitao <leitao@debian.org>