[PATCH] pinctrl: qcom: Remove unused macro definitions

Navya Malempati posted 1 patch 1 week, 3 days ago
There is a newer version of this series
drivers/pinctrl/qcom/pinctrl-qcs8300.c |  6 ------
drivers/pinctrl/qcom/pinctrl-qdu1000.c | 24 ------------------------
drivers/pinctrl/qcom/pinctrl-sa8775p.c |  6 ------
3 files changed, 36 deletions(-)
[PATCH] pinctrl: qcom: Remove unused macro definitions
Posted by Navya Malempati 1 week, 3 days ago
The macros QUP_I3C and UFS_RESET are defined in some platforms
and yet not used. Remove these macros as they are unnecessary.

Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/pinctrl-qcs8300.c |  6 ------
 drivers/pinctrl/qcom/pinctrl-qdu1000.c | 24 ------------------------
 drivers/pinctrl/qcom/pinctrl-sa8775p.c |  6 ------
 3 files changed, 36 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-qcs8300.c b/drivers/pinctrl/qcom/pinctrl-qcs8300.c
index 852cd36df6d5..9a904d809e11 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcs8300.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcs8300.c
@@ -100,12 +100,6 @@
 		.intr_detection_width = -1,		\
 	}
 
-#define QUP_I3C(qup_mode, qup_offset)			\
-	{						\
-		.mode = qup_mode,			\
-		.offset = qup_offset,			\
-	}
-
 #define QUP_I3C_6_MODE_OFFSET	0xaf000
 #define QUP_I3C_7_MODE_OFFSET	0xb0000
 #define QUP_I3C_13_MODE_OFFSET	0xb1000
diff --git a/drivers/pinctrl/qcom/pinctrl-qdu1000.c b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
index 77da87aa72aa..1ef77f82820c 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdu1000.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
@@ -75,30 +75,6 @@
 		.intr_detection_width = -1,		\
 	}
 
-#define UFS_RESET(pg_name, offset)				\
-	{					        \
-		.grp = PINCTRL_PINGROUP(#pg_name, 	\
-			pg_name##_pins, 		\
-			ARRAY_SIZE(pg_name##_pins)),	\
-		.ctl_reg = offset,			\
-		.io_reg = offset + 0x4,			\
-		.intr_cfg_reg = 0,			\
-		.intr_status_reg = 0,			\
-		.mux_bit = -1,				\
-		.pull_bit = 3,				\
-		.drv_bit = 0,				\
-		.oe_bit = -1,				\
-		.in_bit = -1,				\
-		.out_bit = 0,				\
-		.intr_enable_bit = -1,			\
-		.intr_status_bit = -1,			\
-		.intr_target_bit = -1,			\
-		.intr_raw_status_bit = -1,		\
-		.intr_polarity_bit = -1,		\
-		.intr_detection_bit = -1,		\
-		.intr_detection_width = -1,		\
-	}
-
 static const struct pinctrl_pin_desc qdu1000_pins[] = {
 	PINCTRL_PIN(0, "GPIO_0"),
 	PINCTRL_PIN(1, "GPIO_1"),
diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
index e9a510d3583f..5dbaa50cbff0 100644
--- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
+++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
@@ -101,12 +101,6 @@
 		.intr_detection_width = -1,		\
 	}
 
-#define QUP_I3C(qup_mode, qup_offset)			\
-	{						\
-		.mode = qup_mode,			\
-		.offset = qup_offset,			\
-	}
-
 #define QUP_I3C_6_MODE_OFFSET	0xAF000
 #define QUP_I3C_7_MODE_OFFSET	0xB0000
 #define QUP_I3C_13_MODE_OFFSET	0xB1000

---
base-commit: d387b06f7c15b4639244ad66b4b0900c6a02b430
change-id: 20260526-macros_pinctrl-3609843a2519

Best regards,
--  
Navya Malempati <navya.malempati@oss.qualcomm.com>
Re: [PATCH] pinctrl: qcom: Remove unused macro definitions
Posted by Konrad Dybcio 57 minutes ago
On 5/29/26 12:43 PM, Navya Malempati wrote:
> The macros QUP_I3C and UFS_RESET are defined in some platforms
> and yet not used. Remove these macros as they are unnecessary.
> 
> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
> ---

Wonder if we can/should turn on -Wunused-macros for pinctrl/qcom..

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad