drivers/pinctrl/qcom/pinctrl-eliza.c | 24 ------------------------ drivers/pinctrl/qcom/pinctrl-qcm2290.c | 23 ----------------------- drivers/pinctrl/qcom/pinctrl-qdu1000.c | 6 ------ drivers/pinctrl/qcom/pinctrl-sm4450.c | 7 ------- 4 files changed, 60 deletions(-)
Remove SDC_QDSD_PINGROUP, QUP_I3C and UFS_RESET macros as on some
platforms they are unused.
No functional impact.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
---
Changes in v2:
- Rebased on linux next-20260428 tag
- Link to v1: https://lore.kernel.org/r/20260406-eliza_pinctrl-v1-1-52fbf0ebc56c@oss.qualcomm.com
---
drivers/pinctrl/qcom/pinctrl-eliza.c | 24 ------------------------
drivers/pinctrl/qcom/pinctrl-qcm2290.c | 23 -----------------------
drivers/pinctrl/qcom/pinctrl-qdu1000.c | 6 ------
drivers/pinctrl/qcom/pinctrl-sm4450.c | 7 -------
4 files changed, 60 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-eliza.c b/drivers/pinctrl/qcom/pinctrl-eliza.c
index c1f756cbcdeba3fac95364f5d7dde2c24de3acbd..c395ca7e6081b752c51a924a3bcfddbfabfdb403 100644
--- a/drivers/pinctrl/qcom/pinctrl-eliza.c
+++ b/drivers/pinctrl/qcom/pinctrl-eliza.c
@@ -54,30 +54,6 @@
.intr_detection_width = 2, \
}
-#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv) \
- { \
- .grp = PINCTRL_PINGROUP(#pg_name, \
- pg_name##_pins, \
- ARRAY_SIZE(pg_name##_pins)), \
- .ctl_reg = ctl, \
- .io_reg = 0, \
- .intr_cfg_reg = 0, \
- .intr_status_reg = 0, \
- .mux_bit = -1, \
- .pull_bit = pull, \
- .drv_bit = drv, \
- .oe_bit = -1, \
- .in_bit = -1, \
- .out_bit = -1, \
- .intr_enable_bit = -1, \
- .intr_status_bit = -1, \
- .intr_target_bit = -1, \
- .intr_raw_status_bit = -1, \
- .intr_polarity_bit = -1, \
- .intr_detection_bit = -1, \
- .intr_detection_width = -1, \
- }
-
#define UFS_RESET(pg_name, ctl, io) \
{ \
.grp = PINCTRL_PINGROUP(#pg_name, \
diff --git a/drivers/pinctrl/qcom/pinctrl-qcm2290.c b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
index 3b28ac4988859238417d0c4f483e718065ccf48f..844d3dc9e72cdc4b77a58ce8c11a0ff85cb8d6fa 100644
--- a/drivers/pinctrl/qcom/pinctrl-qcm2290.c
+++ b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
@@ -75,29 +75,6 @@
.intr_detection_width = -1, \
}
-#define UFS_RESET(pg_name, offset) \
- { \
- .grp = PINCTRL_PINGROUP(#pg_name, \
- pg_name##_pins, \
- ARRAY_SIZE(pg_name##_pins)), \
- .ctl_reg = offset, \
- .io_reg = offset + 0x4, \
- .intr_cfg_reg = 0, \
- .intr_status_reg = 0, \
- .mux_bit = -1, \
- .pull_bit = 3, \
- .drv_bit = 0, \
- .oe_bit = -1, \
- .in_bit = -1, \
- .out_bit = 0, \
- .intr_enable_bit = -1, \
- .intr_status_bit = -1, \
- .intr_target_bit = -1, \
- .intr_raw_status_bit = -1, \
- .intr_polarity_bit = -1, \
- .intr_detection_bit = -1, \
- .intr_detection_width = -1, \
- }
static const struct pinctrl_pin_desc qcm2290_pins[] = {
PINCTRL_PIN(0, "GPIO_0"),
PINCTRL_PIN(1, "GPIO_1"),
diff --git a/drivers/pinctrl/qcom/pinctrl-qdu1000.c b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
index 5125df7eb12722912ecf0a14d65d6da4f77f9933..77da87aa72aa2b631fdc24def7d651b6c8a8ffff 100644
--- a/drivers/pinctrl/qcom/pinctrl-qdu1000.c
+++ b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
@@ -99,12 +99,6 @@
.intr_detection_width = -1, \
}
-#define QUP_I3C(qup_mode, qup_offset) \
- { \
- .mode = qup_mode, \
- .offset = qup_offset, \
- }
-
static const struct pinctrl_pin_desc qdu1000_pins[] = {
PINCTRL_PIN(0, "GPIO_0"),
PINCTRL_PIN(1, "GPIO_1"),
diff --git a/drivers/pinctrl/qcom/pinctrl-sm4450.c b/drivers/pinctrl/qcom/pinctrl-sm4450.c
index 83650f173b0132e7f96f6c558868f57f63d7158a..51a66a20dc6635fb74e083c8fb1012491a8cb055 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm4450.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm4450.c
@@ -99,13 +99,6 @@
.intr_detection_width = -1, \
}
-#define QUP_I3C(qup_mode, qup_offset) \
- { \
- .mode = qup_mode, \
- .offset = qup_offset, \
- }
-
-
static const struct pinctrl_pin_desc sm4450_pins[] = {
PINCTRL_PIN(0, "GPIO_0"),
PINCTRL_PIN(1, "GPIO_1"),
---
base-commit: 9974969c14031a097d6b45bcb7a06bb4aa525c40
change-id: 20260405-eliza_pinctrl-382bd31c3eef
Best regards,
--
Maulik Shah <maulik.shah@oss.qualcomm.com>
On Wed, Apr 29, 2026 at 8:15 AM Maulik Shah <maulik.shah@oss.qualcomm.com> wrote: > Remove SDC_QDSD_PINGROUP, QUP_I3C and UFS_RESET macros as on some > platforms they are unused. > > No functional impact. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com> Patch applied. Yours, Linus Walleij
On 4/29/26 8:15 AM, Maulik Shah wrote: > Remove SDC_QDSD_PINGROUP, QUP_I3C and UFS_RESET macros as on some > platforms they are unused. > > No functional impact. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
© 2016 - 2026 Red Hat, Inc.