[PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC

Matthew Leung posted 2 patches 1 week, 3 days ago
.../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 204 +++++++++++++++++++++
drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
2 files changed, 205 insertions(+)
[PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Matthew Leung 1 week, 3 days ago
This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
platform features two PCIe controllers: one capable of Gen3 x2 operation
and one capable of Gen4 x1 operation. The first patch adds the device
tree bindings documentation for the Hawi PCIe controller, and the second
patch adds driver support by enabling the Hawi compatible string in the
existing qcom PCIe driver.

This series depends on the following series queued on linux-next:
- [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
  upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
- [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
  (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)

These provide the necessary headers for running dt_binding_check.

This series was rebased onto linux-next and applies cleanly without
additional prerequisites.

Signed-off-by: Matthew Leung <matthew.leung@oss.qualcomm.com>
---
Changes in v2:
- Rebased onto a newer linux-next snapshot
- Previously required dependency series are now queued on linux-next
- Added minItems constraint for clocks
- Moved description comments for clock-names, reg-names, and reset-names
  into 'description' entries in the devicetree bindings.
- Removed maxItems constraint for clocks, regs, resets for the fixed
  size 'items' list
- Link to v1: https://patch.msgid.link/20260508-hawi-pcie-v1-0-0c910906f7e5@oss.qualcomm.com

To: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Krzysztof Wilczyński <kwilczynski@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
Matthew Leung (2):
      dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
      PCI: qcom: Add support for Hawi

 .../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 204 +++++++++++++++++++++
 drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
 2 files changed, 205 insertions(+)
---
base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
change-id: 20260506-hawi-pcie-f61435ca420c

Best regards,
--  
Matthew Leung <matthew.leung@oss.qualcomm.com>

Re: [PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Krzysztof Kozlowski 1 week, 2 days ago
On Fri, May 29, 2026 at 01:10:07AM +0000, Matthew Leung wrote:
> This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
> platform features two PCIe controllers: one capable of Gen3 x2 operation
> and one capable of Gen4 x1 operation. The first patch adds the device
> tree bindings documentation for the Hawi PCIe controller, and the second
> patch adds driver support by enabling the Hawi compatible string in the
> existing qcom PCIe driver.
> 
> This series depends on the following series queued on linux-next:
> - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
>   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
> - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
>   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)

It cannot depend there it makes it unmergeable and untestable. I skip
review in such case, please follow standard documented practices about
decoupling independent works.

Best regards,
Krzysztof
Re: [PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Matthew Leung 5 days, 14 hours ago

On 5/30/2026 3:06 AM, Krzysztof Kozlowski wrote:
> On Fri, May 29, 2026 at 01:10:07AM +0000, Matthew Leung wrote:
>> This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
>> platform features two PCIe controllers: one capable of Gen3 x2 operation
>> and one capable of Gen4 x1 operation. The first patch adds the device
>> tree bindings documentation for the Hawi PCIe controller, and the second
>> patch adds driver support by enabling the Hawi compatible string in the
>> existing qcom PCIe driver.
>>
>> This series depends on the following series queued on linux-next:
>> - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
>>   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
>> - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
>>   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
> 
> It cannot depend there it makes it unmergeable and untestable. I skip
> review in such case, please follow standard documented practices about
> decoupling independent works.

Thanks for the feedback. On checking the dependencies, the changes are
applied in their respective maintainer trees:
- clk: applied to qcom/linux.git for-next, commit d6cd9d5692ba
- icc: applied to djakov/icc.git icc-next, commit 07548b04dc36

Both commits are present in my linux-next base-commit and have checked
dt_binding_check passes cleanly.

I can resend with the dependency references updated accordingly.

> 
> Best regards,
> Krzysztof
>
Re: [PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Manivannan Sadhasivam 4 days, 1 hour ago
On Wed, 3 Jun 2026 01:26:53 +0200, Matthew Leung
<matthew.leung@oss.qualcomm.com> said:
>
>
> On 5/30/2026 3:06 AM, Krzysztof Kozlowski wrote:
>> On Fri, May 29, 2026 at 01:10:07AM +0000, Matthew Leung wrote:
>>> This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
>>> platform features two PCIe controllers: one capable of Gen3 x2 operation
>>> and one capable of Gen4 x1 operation. The first patch adds the device
>>> tree bindings documentation for the Hawi PCIe controller, and the second
>>> patch adds driver support by enabling the Hawi compatible string in the
>>> existing qcom PCIe driver.
>>>
>>> This series depends on the following series queued on linux-next:
>>> - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
>>>   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
>>> - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
>>>   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
>>
>> It cannot depend there it makes it unmergeable and untestable. I skip
>> review in such case, please follow standard documented practices about
>> decoupling independent works.
>
> Thanks for the feedback. On checking the dependencies, the changes are
> applied in their respective maintainer trees:
> - clk: applied to qcom/linux.git for-next, commit d6cd9d5692ba
> - icc: applied to djakov/icc.git icc-next, commit 07548b04dc36
>
> Both commits are present in my linux-next base-commit and have checked
> dt_binding_check passes cleanly.
>
> I can resend with the dependency references updated accordingly.
>

No. It will still break the pci tree when this series gets merged. Please
resubmit after v7.2-rc1.

- Mani
Re: [PATCH v2 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Matthew Leung 3 days, 12 hours ago

On 6/4/2026 5:09 AM, Manivannan Sadhasivam wrote:
> On Wed, 3 Jun 2026 01:26:53 +0200, Matthew Leung
> <matthew.leung@oss.qualcomm.com> said:
>>
>>
>> On 5/30/2026 3:06 AM, Krzysztof Kozlowski wrote:
>>> On Fri, May 29, 2026 at 01:10:07AM +0000, Matthew Leung wrote:
>>>> This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
>>>> platform features two PCIe controllers: one capable of Gen3 x2 operation
>>>> and one capable of Gen4 x1 operation. The first patch adds the device
>>>> tree bindings documentation for the Hawi PCIe controller, and the second
>>>> patch adds driver support by enabling the Hawi compatible string in the
>>>> existing qcom PCIe driver.
>>>>
>>>> This series depends on the following series queued on linux-next:
>>>> - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
>>>>   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
>>>> - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
>>>>   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
>>>
>>> It cannot depend there it makes it unmergeable and untestable. I skip
>>> review in such case, please follow standard documented practices about
>>> decoupling independent works.
>>
>> Thanks for the feedback. On checking the dependencies, the changes are
>> applied in their respective maintainer trees:
>> - clk: applied to qcom/linux.git for-next, commit d6cd9d5692ba
>> - icc: applied to djakov/icc.git icc-next, commit 07548b04dc36
>>
>> Both commits are present in my linux-next base-commit and have checked
>> dt_binding_check passes cleanly.
>>
>> I can resend with the dependency references updated accordingly.
>>
> 
> No. It will still break the pci tree when this series gets merged. Please
> resubmit after v7.2-rc1.

Okay, I will resubmit after the dependencies merge on mainline.

> 
> - Mani