drivers/irqchip/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Add description to bool to do so.
Remove ARM_GIC_V3 as the driver does not need it to compile.
Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.
Assisted-by: Codex-GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: add GENERIC_MSI_IRQ
drivers/irqchip/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index eb8428d9fa61..e7d559472790 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -208,9 +208,9 @@ config FARADAY_FTINTC010
select SPARSE_IRQ
config HISILICON_IRQ_MBIGEN
- bool
- select ARM_GIC_V3
- select ARM_GIC_V3_ITS
+ bool "HiSilicon MBIGEN interrupt controller"
+ depends on ARCH_HISI || COMPILE_TEST
+ select GENERIC_MSI_IRQ
config IMGPDC_IRQ
bool
--
2.54.0
On Sun, May 10 2026 at 12:52, Rosen Penev wrote: > Add description to bool to do so. > > Remove ARM_GIC_V3 as the driver does not need it to compile. True, but you fail to explain that GIC_V3* is always selected for ARM64 builds. > Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away. That's not a sensible explanation either. It's required for COMPILE_TEST builds because it's not longer selected by the removed ARM_GIC_V3_ITS. > Assisted-by: Codex-GPT-5.5 This thing clearly lacks any competence for writing comprehensible change logs. What a waste of time and energy.
On Mon, May 11, 2026 at 7:15 AM Thomas Gleixner <tglx@kernel.org> wrote: > > On Sun, May 10 2026 at 12:52, Rosen Penev wrote: > > Add description to bool to do so. > > > > Remove ARM_GIC_V3 as the driver does not need it to compile. > > True, but you fail to explain that GIC_V3* is always selected for ARM64 > builds. OK. > > > Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away. > > That's not a sensible explanation either. It's required for COMPILE_TEST > builds because it's not longer selected by the removed ARM_GIC_V3_ITS. OK. > > > Assisted-by: Codex-GPT-5.5 > > This thing clearly lacks any competence for writing comprehensible > change logs. User error. AGENTS.md needs tweaking locally. Speaking of which it would probably make sense to commit one here similar to .clang-format. > > What a waste of time and energy. Not my call. I've found it very useful to avoid having to resend multiple patches because of a boneheaded description.
© 2016 - 2026 Red Hat, Inc.