[PATCH v4 0/3] iio: adc: ti-ads1298: Minor driver cleanups

Md Shofiqul Islam posted 3 patches 1 month ago
drivers/iio/adc/ti-ads1298.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
[PATCH v4 0/3] iio: adc: ti-ads1298: Minor driver cleanups
Posted by Md Shofiqul Islam 1 month ago
This series fixes three minor issues in the TI ADS1298 8-channel
medical ECG ADC driver.

Patch 1 adds missing parentheses around the macro parameter in
ADS1298_REG_CHnSET() to follow kernel macro coding style and prevent
potential operator-precedence issues when the argument is an expression.

Patch 2 corrects an incorrect comment: at the lowest supported data
rate of 250 Hz, one conversion takes 4 ms, not 40 ms. The 50 ms
timeout value itself is correct and is not changed.

Patch 3 removes an unnecessary CONFIG2 write from the init path.
The driver was enabling the internal test signal generator (INT_TEST,
TEST_AMP, TEST_FREQ_FAST), which is inappropriate for normal ECG
operation. CONFIG2 defaults to the correct value after reset (RESERVED
bit only), so the write is removed entirely.

Changes in v4:
  - Add this cover letter (pointed out by Andy Shevchenko)

Changes in v3:
  - No code changes; resent to correct the recipient list

Changes in v2:
  - Patch 3: Rework following Mike Looijmans' feedback: remove the
    CONFIG2 write entirely instead of just stripping the test signal
    bits, since CONFIG2 defaults to the correct reset value
  - Patch 3: Add Suggested-by: Mike Looijmans <mike.looijmans@topic.nl>
  - Patch 3: Rename subject to "Remove unnecessary CONFIG2 write during init"

Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>

Md Shofiqul Islam (3):
  iio: adc: ti-ads1298: Add parentheses around macro parameter
  iio: adc: ti-ads1298: Fix incorrect timeout comment
  iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init

 drivers/iio/adc/ti-ads1298.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

-- 
2.54.0.windows.1