From nobody Sat Jun 13 06:00:30 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688AC281525 for ; Sat, 9 May 2026 15:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340007; cv=none; b=TVc+knMdD5/Z2rEbr8lOG0tKazWemJe0ngBTHUIWstpGx1trwItrOTr+W/Zc8zBQeNC09j84UY5wC1ZnJW5LlAbI7RuaHH6Jo199yFGprvkbq9b+KRxu+lQqJA1uelaMrEyyjLpkg+wDGi0SFT3IN4wWE7+ubLdIDXvoVD/DKZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340007; c=relaxed/simple; bh=H08BrTRalR0jUvy/90S50ZaX5dzgHvM0nJcBr5ocsmg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hhq3yo/2NFRhYBwJ/433jqiR1t6Jk7wCd5rEUDdkGvX4sFQE8cAzD0IN5zpEt1cKxJqY6yqZMxhoNSccDueLXUPz3W5mjRAB1ehgVzFcJlzr6yPWWlj5wM03S+3IgvoZ5MoVGKGe+uBG0EkHUkAuA/b5sXL5VrvR+xRDr40ZXIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMg5l84l; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMg5l84l" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a858881ad2so2959103e87.3 for ; Sat, 09 May 2026 08:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340005; x=1778944805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=cMg5l84lng+0+onmHTBQ6QMwpCQYP+ssvrxiiZfPQBGd+gEuCeSCGrkh++q4fJDr9e f4oQdJJzt+4cDgoeBW8KOLr0tX9l9h3FqUlL0kvuHfVNC6/Z5I9yTaMKN43MkyRAz5uw hk3Kt9qIbmczbNAnMHcvaRRbyGYNq9KN9nsTBVDMw1dOPvYThbJyjxyxozwq6kRU5nhe 2V2xz0uup7SLS4sVbYho5QhQsmIck4pdYTU2/OHm2Iuh0wraz8q+my4EGs7cH3D7r7Tx PurXMmaiTMAhCK7J2Ai1q7Sv0HbQe+3o4juDzJB9kbsHmZbG2qymMwN/hvq8hk10539y i4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340005; x=1778944805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qnRfUwgP4GDJT73gEU34kWTDXjMinDYaY8kcXfNdp88=; b=I4QkEqL3vO0CK+40YLnFKD6BtqyyTs108Hgo6s532Pw+esi6ziqtzr31WfwiYghJGq 4sRbYarxEBZu0G9sWl+ik7YQQ+dn1pvwlZROxZRvKGNSvrwt1hGH0UrqFf5OwSlcLdne CuDig+UJ8Y5HfoSXeHJEYGP6Zbm/7P1MqKzYl+AUThoiQVj+pvNCARax4k9RLSaMMSJC uM6138YlDeNzM2DB9RHACZDQBbUJYEVyg3/PCv4kMzNLxQhE2F4R62fmaBwLYM1CVYBn 1VbWkJ163tOF3PWnVYMOWIGNENnj2jDIomM088yvwRxCLtT3MBLxnTUgVFP0BNsafnfY u7pg== X-Forwarded-Encrypted: i=1; AFNElJ8HIpvf5bMbwZAxPWXoGpezNK1T7WHd8sqTS2P+U4VzkA4LBug7ohs0vMK/cIpG2bDmnLra3ZQ8q6glyH8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm1Q6g3O/DbJ+MpA1vzYdcIdKqlkj/xiaITZdnvSEmhOTia4BU +0wGIDIXspcL9FoKL7UNa5qICArmQUiMfbTM7dI5Do9nWvUbRuMTSmMY X-Gm-Gg: Acq92OGHM5rkMTJgrwBVVCDWnql6Hj/luV0TzQDomi0tFiAqbi/2u7uHaVUYDwR2pns 4mR/+QaTMg2IXYIKUcVh6Gb5rG/CCsz8sP/OZs0CzvBY6qyiRJBrqk9lcOBGQeT8kV6PyQBVM6Z IYOCDiSkPqHuSyGJOe+0vBetZcTYwuQelrJMsBonD2Vvt5GWwWvAol44LcTjo/K6ZlZnw8Bmr2Y h1yRfIvt+pJipivC2xT4UV6q0CPN2dyqL4Cf3M3H4lJ5IaqZDfGxOotPVreL4R5s9x0bFq47e9T odqUuphhcjD0cl2JC5vq8/HF0i9ZJ82c+tI2zyIfcTRZqRx+ERPEzQ9sbklML889cY+uApdRg+A RStlPmOmZ6z4Fca/FGaMNhSofVYyOmEhqcqcbck9WCP5tI7/ILBo+2zQbjfwJ8fMmnK1ImuYlfg VRLGWZtUeLOd4i+av5ic3mHhKXcEojkGGlOlbHrEgXIrM0XvYiP2ydpVwtNFoDLz1R X-Received: by 2002:a05:6512:128d:b0:5a8:6b81:6694 with SMTP id 2adb3069b0e04-5a887ce5e99mr5594650e87.30.1778340004274; Sat, 09 May 2026 08:20:04 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95664easm1301975e87.70.2026.05.09.08.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:20:03 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, Md Shofiqul Islam Subject: [PATCH v4 1/3] iio: adc: ti-ads1298: Add parentheses around macro parameter Date: Sat, 9 May 2026 18:19:57 +0300 Message-ID: <20260509151959.3475-2-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260509151959.3475-1-shofiqtest@gmail.com> References: <20260509151959.3475-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ADS1298_REG_CHnSET() is missing parentheses around the parameter 'n'. Add them to follow kernel macro coding style and prevent potential operator precedence issues if the argument is an expression. Signed-off-by: Md Shofiqul Islam Reviewed-by: Stepan Ionichev --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index ae30b47e45..cf5f954206 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -66,7 +66,7 @@ #define ADS1298_MASK_CONFIG3_VREF_4V BIT(5) =20 #define ADS1298_REG_LOFF 0x04 -#define ADS1298_REG_CHnSET(n) (0x05 + n) +#define ADS1298_REG_CHnSET(n) (0x05 + (n)) #define ADS1298_MASK_CH_PD BIT(7) #define ADS1298_MASK_CH_PGA GENMASK(6, 4) #define ADS1298_MASK_CH_MUX GENMASK(2, 0) --=20 2.54.0.windows.1 From nobody Sat Jun 13 06:00:30 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009DB2BEFEF for ; Sat, 9 May 2026 15:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340008; cv=none; b=tG87rqnRwd03wqeWauNejgsNc55TQVco/bwBdUn9f2frEldjtSZqfd9trxtppM0biz0q9l2XXy5KN3c7hgYFC2DN2OaSmG2zSEWFOwEQ1wVjUB0FYVDgtUfAi2Vw8H/5l7/5Ekf3ghadmfcSNUE5cUCrDdmUFT3gREorfy/hrq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340008; c=relaxed/simple; bh=7wwEeddHxhCClQzgwuisu1/1yJfMaAt2aMlXmyRxTYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e2eyDpz0sUzmZ1+9Pc+GU/54DG4k4nLMHhXqmjYzNPPnqsJpSE7AqvFmZ5IAJ+7jWtvDjN4dWvGiFUCMQmH9f7Zo4jsIvywFKBKkwEim6Fg4WSWUgYDrIRxIKgLlxQPQAMyz5E1pVc33GsecmKwzoKI86pqj8WTs04Opixj3+SA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fyo/wmTs; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fyo/wmTs" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a865004748so3957251e87.0 for ; Sat, 09 May 2026 08:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340005; x=1778944805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=Fyo/wmTslXXmIURYnN1/A8q7jgKHYLaukpB3ruT2nlnpH8XNyq3E6qTvrxs9ExecRa E56k6YJdU5WlsHaGrWzLms+cx/2j5O46HYBvXRnHR750Zjmo7PmbYVWykxdMANBVCVii /NN6BUVpjkzkYrZdLL/NokxV6I+IblwYr/UBahhmRo2ltb5NsVjhJlpD/eRdl8wAO0Pv LgoFjjLIN/ZKVtHtMziBJe+U8Ygi0Y7effNd09dW/WVzqcvGsjm+DhIBYgWgN7JXSrql /i1rGQGZjIjviXfOYfOWFBoKKceY1hw6hv/0H17Ktu8TZBcTFneIGDEahjtX5/MknuKE eFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340005; x=1778944805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=tIdjYysBoSRgTAEJ8GnMN6SLX+jr83p2cL3OaxGMHN/lQN7KXzBpO2sRxP9WS1Rum4 nba6CDp+Ory0jpGkxE49FjJEQasorCeE8T1z+ZRO5cmYyqnY0ql/jB64DnSsiPbXUGle nmtBf+4TyuYR7P0ZoPMobdHKVj76zqMWxOt2aKzmQC29wicX10ifzXmeHmqonGVKgEIQ Az7XGuhidG9IBQ3K6Xu1KdqhhZZpYonCffuI2uhQgXY2/IybVAzTO8nK7BEUDkCvPfI4 QsaFN07+2QdsJXnu7sZdZsCEjuCYg//wB4D7/TO987gF/l5WBd2DTB3Q8Dt6mz7fXLhy yd+g== X-Forwarded-Encrypted: i=1; AFNElJ/TLzTlo9azgz/JtmMzUBq7eHE5NY2TJG356Vht3nWKCcfsUVA0kcRH7kvRQ7O+uL/GhNT8wXRih4z/NTY=@vger.kernel.org X-Gm-Message-State: AOJu0YwgElCOnSX03pB4UooUuyMAiyH75LBbrL4Anm/3g3IkbRXZHAeW YMXX3E+gY02KhO8KBWwPQd5kHlHiQhH7h1EI5JB5RCtp3rDHAFd7xUiZvtqxz8PX X-Gm-Gg: Acq92OFI43K/YEBOxSFxiMD9S06SMQ5QJEnBo+75DeKfNtwitxdHNOWQq1zCSwPgaBB dFWEO4QWHDluYXsb4dGGHrOODxAAF+3f/z5gL1a/qw+z/9NPoypuE62LtkK5gctJ7hR/NRW8lKV 1G0CR5QO/O7LXnqrXRETwisTQuhD2YfPuEMT5ER3s1KhBI6+HXl5lf2I2v9M2YLZCq6XYwZKktv ThVQUsqznyWH162joGVFvUcPdEVYITewEzP3jd41E8a6PgE97k0O/u5MQAof5UKofChXYhGsWuO Iejc+eFggezJbTCiO59d3qGpqXjSKGBOxSIRtBkkIRtHuQ1mLcmFgnapB3EDTEFqAvxNy6vucu6 Z1jvlKDpmq7ZJPWGcZvTdbso0VcDu7/0Qs9SkOOBkoAdMHFZbEPNszDzogzIsFooWaQJL5TZHt/ tswB1VYrWFoTwz3g8kTuDM3sh/cwgjQ/Q/6wbhPRZ05wl0bt/tINGO3YxEuZOOGb6hsNc9zqW46 4w= X-Received: by 2002:a05:6512:33c5:b0:5a8:9157:ad3b with SMTP id 2adb3069b0e04-5a899b90653mr3650746e87.5.1778340005091; Sat, 09 May 2026 08:20:05 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95664easm1301975e87.70.2026.05.09.08.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:20:04 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, Md Shofiqul Islam Subject: [PATCH v4 2/3] iio: adc: ti-ads1298: Fix incorrect timeout comment Date: Sat, 9 May 2026 18:19:58 +0300 Message-ID: <20260509151959.3475-3-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260509151959.3475-1-shofiqtest@gmail.com> References: <20260509151959.3475-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" At the lowest supported data rate of 250Hz, one conversion period is 4ms, not 40ms. Fix the comment to correctly reflect the timing. The 50ms timeout value itself is correct as a conservative margin. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index cf5f954206..186bda3087 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -210,7 +210,7 @@ static int ads1298_read_one(struct ads1298_private *pri= v, int chan_index) return ret; } =20 - /* Cannot take longer than 40ms (250Hz) */ + /* Cannot take longer than 4ms at the lowest rate (250Hz) */ ret =3D wait_for_completion_timeout(&priv->completion, msecs_to_jiffies(5= 0)); if (!ret) return -ETIMEDOUT; --=20 2.54.0.windows.1 From nobody Sat Jun 13 06:00:30 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B552D2D738F for ; Sat, 9 May 2026 15:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340009; cv=none; b=pAGhoum35nH/YlvwbXY2f8dwvm9f9LQjYtPzq9yZD1AYyyHVufl5yzLa31S9JOtMsl/YKM3/ahIowmg+UVv/8jGhi8UANVIIytG8BYvKzt3SCZSmBgI09QlRFHeFx+XSB/hgU/J1+Vo9cl9uQvmGHWTjwVjvA590A7Mu/L/jc3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340009; c=relaxed/simple; bh=8be50cgUO97dUmyXY8QEaFaIeWcvbyn4FZHCMFnyX9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MQJtIHCGOiIaZQgtHspfbwWd4jk/VTcbtp+i7ONrj0ogE05OT1+MAilpLkKNO9nN1D2wEqHc5HZu71Da2KLE8EbU093tXcnfTkidcxPsUQvMpWtGFA3QIisbU4XEaV/gdl6FZlj+Vyx5UXfWpDiS2SZ0I777u2FBtfjqUSa5KaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZURlWW/l; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZURlWW/l" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5a87782588cso3610820e87.3 for ; Sat, 09 May 2026 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340006; x=1778944806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=ZURlWW/lJtg8POJYfBq7LjpIXVzfMdfwB+hbk7WrqXxG/2xAnz63baepHvUq1p3Aed sRJTVJDoJUQNPxsp6rVL2VgKCmGuOP4Ny17WgomCytD/o+9vrGvW1JBqCP0aooePb0aZ Wf17QFFuPiWU2soLxtm0j0pthAdueE9nLJ7dg6fXylgpE/5hj6eg9Hu1bLNV+Ttx/KxV asE+cRjjQdUUKEYkxHy053udQJt+qMab0gwbuCzeeqqZkL4Hvu5MdVnYynVoN7UrBwmN qUxTR7hWjJ7txXV1sTVprRMeMpzRDhB12AUzauw0kOsJSgXvuj81POijeUCAQu6RBduR IH6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340006; x=1778944806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=lHdjqvrAk39UW7VpiWpSEtqS/az0JzOl+n8AEGefwmeORUHyxaeIOrodx/tW5krAuS S3dKqG2VuG/UXfr5WlU+YdCqS9pt94FBy2xiUMLjiq8HP/8D4LbzE7n9BXSyaXmToKvp Ob/OzlnYV7dUnxUadpzS92YmykxZwWfdi1AFpmdzh3ghU88/O3V6lktGHyrQ1H9y6vye RVcv2PVEE1R4yF8u1CfqMn1wF7tL8crjcqbIf6SrwFY2nFr4cbnCqjRQbzP7jy04O0T9 BZSY/FI8xYgB9kRvw+PfC84uX3GbXqVwNFtS/K2uEQBJSirGmX5K8N+O6pC3Ur7s7tWh C3kg== X-Forwarded-Encrypted: i=1; AFNElJ+L7s9qaUGBX49oBWDSyYli2ASz9Uu2JNWk10rzR0Qsbkl6SyiaJaLqUwVHHP8s1L47PAB0OIyqo3v+OW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwScropLjWTARcFEmG7x0h2/OWulsxn7JvGIBIiTo/JtcxFtDGp DHHLzP3on+RykNNWWptc+s/KyKrrhwVppV9aPyMolbDMSpPvuuGAcKmDLj343VX2 X-Gm-Gg: Acq92OFNE0CZNbqxUeT1lWoLaUkNFcZJRHoF61lMLE1jo8GcovOksXUh9+LzdYez9x3 sTm8QXvYBvRmt5mBWDaiEGU1c2WdJ55DoQcbIDV3niRwmXTfFLf2eUoP+IlYonvb9onMVvrA9u6 KyweJvZsG2HgZdr6lzsDvif7Q/m0mdQkGu2RIJ8pmbHlkrpTxB85xozOL9qohB5gz2OpfxPhLO6 O2xLvyyVTf3hWjQiwfmMbT4AmMHqafzjX6Vt8ZxHT3tfut2DQaKVMxJ1E7b8a4yJ1HCMgXpyb2p H262CRoexr9JokG/bjbJAwtBEzzm7wKjkOAQew2idhsaSXf0uXNOpE7K1qrq5giMCOwrPYub62f LU5oNjzpctteen8SUJqJhiLgU79tTroPVFrvgVJdGncbLqNzAnXjJJtMKZ7PDpFOfPJOBlyymzJ ZTbiAhb5zjoZ9RH2fdVtzMFY0TJ6jbz4JExBPRDImem64Eh4Dwdjfs85/tJKIWgfht X-Received: by 2002:a05:6512:ad3:b0:5a8:9c2f:5712 with SMTP id 2adb3069b0e04-5a8b70926a4mr979997e87.21.1778340005784; Sat, 09 May 2026 08:20:05 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95664easm1301975e87.70.2026.05.09.08.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:20:05 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, Md Shofiqul Islam Subject: [PATCH v4 3/3] iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init Date: Sat, 9 May 2026 18:19:59 +0300 Message-ID: <20260509151959.3475-4-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260509151959.3475-1-shofiqtest@gmail.com> References: <20260509151959.3475-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver was enabling the internal test signal (INT_TEST), double amplitude (TEST_AMP), and fast frequency (TEST_FREQ_FAST) bits in CONFIG2 during initialization. These bits activate an internal square wave generator intended for device testing and calibration, not normal ECG operation. CONFIG2 defaults to having only the RESERVED bit set after reset, which is the correct value for normal operation. Remove the write entirely since it would just be writing the reset default value. Suggested-by: Mike Looijmans Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 186bda3087..8957e873e1 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -615,15 +615,6 @@ static int ads1298_init(struct iio_dev *indio_dev) if (!indio_dev->name) return -ENOMEM; =20 - /* Enable internal test signal, double amplitude, double frequency */ - ret =3D regmap_write(priv->regmap, ADS1298_REG_CONFIG2, - ADS1298_MASK_CONFIG2_RESERVED | - ADS1298_MASK_CONFIG2_INT_TEST | - ADS1298_MASK_CONFIG2_TEST_AMP | - ADS1298_MASK_CONFIG2_TEST_FREQ_FAST); - if (ret) - return ret; - val =3D ADS1298_MASK_CONFIG3_RESERVED; /* Must write 1 always */ if (!priv->reg_vref) { /* Enable internal reference */ --=20 2.54.0.windows.1