[PATCH 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC

Matthew Leung posted 2 patches 1 month ago
There is a newer version of this series
.../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 188 +++++++++++++++++++++
drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
2 files changed, 189 insertions(+)
[PATCH 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Matthew Leung 1 month ago
This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
platform features two PCIe controllers: one capable of Gen3 x2 operation
and one capable of Gen4 x1 operation. The first patch adds the device
tree bindings documentation for the Hawi PCIe controller, and the second
patch adds driver support by enabling the Hawi compatible string in the
existing qcom PCIe driver.

This series depends on the following prerequisite series:
- [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
  upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
- [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
  (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)

These dependencies add necessary headers for running dt_binding_check
against the binding.

Signed-off-by: Matthew Leung <matthew.leung@oss.qualcomm.com>
---
Matthew Leung (2):
      dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
      PCI: qcom: Add support for Hawi

 .../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 188 +++++++++++++++++++++
 drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
 2 files changed, 189 insertions(+)
---
base-commit: 4cd074ae20bbcc293bbbce9163abe99d68ae6ae0
change-id: 20260506-hawi-pcie-f61435ca420c
prerequisite-change-id: 20260316-clk-hawi-1ad4cad36d6a:v3
prerequisite-patch-id: c4fbb0620d748d7f1ee675ade5167775bd31c8ac
prerequisite-patch-id: ae5e212518cc333a1a93564cabfc6abd128df664
prerequisite-patch-id: 3c3816e0d595589fc02383f10e48c83a61fdc9d1
prerequisite-patch-id: cbc13fb819d1c1ee77957393f0958f05db8db864
prerequisite-patch-id: 17e2c0cfbbea826fefa1c67d0f5dc2094ab73d76
prerequisite-patch-id: 150dc74750377f4558deab6b179632872bcbb71c
prerequisite-patch-id: 38fe0da5b18610aeb32c7154f9e50187ccaec6a4
prerequisite-change-id: 20260311-icc-hawi-d6dc165f8935:v4
prerequisite-patch-id: a1ff655f0b21d6259b158ad9f99a95bde31257e6
prerequisite-patch-id: db21b6b20451be8475129faece7ef4191d41273c

Best regards,
--  
Matthew Leung <matthew.leung@oss.qualcomm.com>
Re: [PATCH 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Bjorn Helgaas 4 weeks, 1 day ago
On Fri, May 08, 2026 at 01:02:13AM +0000, Matthew Leung wrote:
> This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
> platform features two PCIe controllers: one capable of Gen3 x2 operation
> and one capable of Gen4 x1 operation. The first patch adds the device
> tree bindings documentation for the Hawi PCIe controller, and the second
> patch adds driver support by enabling the Hawi compatible string in the
> existing qcom PCIe driver.
> 
> This series depends on the following prerequisite series:
> - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
>   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
> - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
>   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
> 
> These dependencies add necessary headers for running dt_binding_check
> against the binding.

These apply cleanly to v7.1-rc1.  I suppose the dt_binding_check thing
is the only real dependency?  Is there anything we need to do to
enforce the dependency when these get merged upstream during the merge
window?

> Signed-off-by: Matthew Leung <matthew.leung@oss.qualcomm.com>
> ---
> Matthew Leung (2):
>       dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
>       PCI: qcom: Add support for Hawi
> 
>  .../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 188 +++++++++++++++++++++
>  drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
>  2 files changed, 189 insertions(+)
> ---
> base-commit: 4cd074ae20bbcc293bbbce9163abe99d68ae6ae0
> change-id: 20260506-hawi-pcie-f61435ca420c
> prerequisite-change-id: 20260316-clk-hawi-1ad4cad36d6a:v3
> prerequisite-patch-id: c4fbb0620d748d7f1ee675ade5167775bd31c8ac
> prerequisite-patch-id: ae5e212518cc333a1a93564cabfc6abd128df664
> prerequisite-patch-id: 3c3816e0d595589fc02383f10e48c83a61fdc9d1
> prerequisite-patch-id: cbc13fb819d1c1ee77957393f0958f05db8db864
> prerequisite-patch-id: 17e2c0cfbbea826fefa1c67d0f5dc2094ab73d76
> prerequisite-patch-id: 150dc74750377f4558deab6b179632872bcbb71c
> prerequisite-patch-id: 38fe0da5b18610aeb32c7154f9e50187ccaec6a4
> prerequisite-change-id: 20260311-icc-hawi-d6dc165f8935:v4
> prerequisite-patch-id: a1ff655f0b21d6259b158ad9f99a95bde31257e6
> prerequisite-patch-id: db21b6b20451be8475129faece7ef4191d41273c

I don't know where any of these change-ids or patch-ids come from.
Re: [PATCH 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Matthew Leung 4 weeks, 1 day ago
On Thu, May 14, 2026 at 12:21:51PM -0500, Bjorn Helgaas wrote:
> On Fri, May 08, 2026 at 01:02:13AM +0000, Matthew Leung wrote:
> > This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
> > platform features two PCIe controllers: one capable of Gen3 x2 operation
> > and one capable of Gen4 x1 operation. The first patch adds the device
> > tree bindings documentation for the Hawi PCIe controller, and the second
> > patch adds driver support by enabling the Hawi compatible string in the
> > existing qcom PCIe driver.
> > 
> > This series depends on the following prerequisite series:
> > - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
> >   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
> > - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
> >   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
> > 
> > These dependencies add necessary headers for running dt_binding_check
> > against the binding.
> 
> These apply cleanly to v7.1-rc1.  I suppose the dt_binding_check thing
> is the only real dependency?  Is there anything we need to do to
> enforce the dependency when these get merged upstream during the merge
> window?
> 

Yes, the dependencies are only needed for running dt_binding_check as
the example dts snippet would produce an error on the missing headers.
The patches should apply and build cleanly otherwise.

I thought this check could be a problem for merging so added the
dependencies for completeness. If the binding check isn't a concern, I
can drop the dependencies.

> > Signed-off-by: Matthew Leung <matthew.leung@oss.qualcomm.com>
> > ---
> > Matthew Leung (2):
> >       dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
> >       PCI: qcom: Add support for Hawi
> > 
> >  .../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 188 +++++++++++++++++++++
> >  drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
> >  2 files changed, 189 insertions(+)
> > ---
> > base-commit: 4cd074ae20bbcc293bbbce9163abe99d68ae6ae0
> > change-id: 20260506-hawi-pcie-f61435ca420c
> > prerequisite-change-id: 20260316-clk-hawi-1ad4cad36d6a:v3
> > prerequisite-patch-id: c4fbb0620d748d7f1ee675ade5167775bd31c8ac
> > prerequisite-patch-id: ae5e212518cc333a1a93564cabfc6abd128df664
> > prerequisite-patch-id: 3c3816e0d595589fc02383f10e48c83a61fdc9d1
> > prerequisite-patch-id: cbc13fb819d1c1ee77957393f0958f05db8db864
> > prerequisite-patch-id: 17e2c0cfbbea826fefa1c67d0f5dc2094ab73d76
> > prerequisite-patch-id: 150dc74750377f4558deab6b179632872bcbb71c
> > prerequisite-patch-id: 38fe0da5b18610aeb32c7154f9e50187ccaec6a4
> > prerequisite-change-id: 20260311-icc-hawi-d6dc165f8935:v4
> > prerequisite-patch-id: a1ff655f0b21d6259b158ad9f99a95bde31257e6
> > prerequisite-patch-id: db21b6b20451be8475129faece7ef4191d41273c
> 
> I don't know where any of these change-ids or patch-ids come from.

These were generated by b4 after adding the change-id metadata for the
dependencies.

They should refer to the change-ids of the respective patch series:
- https://lore.kernel.org/all/20260506-clk-hawi-v3-0-530b538679f1@oss.qualcomm.com/
- https://lore.kernel.org/all/20260506-icc-hawi-v4-0-35447fdc482b@oss.qualcomm.com/
Re: [PATCH 0/2] PCI: qcom: Add PCIe support for upcoming Hawi SoC
Posted by Manivannan Sadhasivam 3 weeks, 3 days ago
On Thu, May 14, 2026 at 12:32:01PM -0700, Matthew Leung wrote:
> On Thu, May 14, 2026 at 12:21:51PM -0500, Bjorn Helgaas wrote:
> > On Fri, May 08, 2026 at 01:02:13AM +0000, Matthew Leung wrote:
> > > This series adds PCIe support for the Qualcomm Hawi SoC. The Hawi
> > > platform features two PCIe controllers: one capable of Gen3 x2 operation
> > > and one capable of Gen4 x1 operation. The first patch adds the device
> > > tree bindings documentation for the Hawi PCIe controller, and the second
> > > patch adds driver support by enabling the Hawi compatible string in the
> > > existing qcom PCIe driver.
> > > 
> > > This series depends on the following prerequisite series:
> > > - [PATCH v3 0/7] clk: qcom: Add initial clock controllers for the
> > >   upcoming Hawi SoC (Change-ID: 20260316-clk-hawi-1ad4cad36d6a:v3)
> > > - [PATCH v4 0/2] interconnect: qcom: Add support for upcoming Hawi SoC
> > >   (Change-ID: 20260311-icc-hawi-d6dc165f8935:v4)
> > > 
> > > These dependencies add necessary headers for running dt_binding_check
> > > against the binding.
> > 
> > These apply cleanly to v7.1-rc1.  I suppose the dt_binding_check thing
> > is the only real dependency?  Is there anything we need to do to
> > enforce the dependency when these get merged upstream during the merge
> > window?
> > 
> 
> Yes, the dependencies are only needed for running dt_binding_check as
> the example dts snippet would produce an error on the missing headers.
> The patches should apply and build cleanly otherwise.
> 
> I thought this check could be a problem for merging so added the
> dependencies for completeness. If the binding check isn't a concern, I
> can drop the dependencies.
> 

No, the dependencies are needed. It is also an indication that we cannot merge
this PCIe binding change, until the dependent headers are merged to mainline.

dt_binding_check should not fail in linux-next or in mainline.

- Mani

> > > Signed-off-by: Matthew Leung <matthew.leung@oss.qualcomm.com>
> > > ---
> > > Matthew Leung (2):
> > >       dt-bindings: PCI: qcom: Document the Hawi PCIe Controller
> > >       PCI: qcom: Add support for Hawi
> > > 
> > >  .../devicetree/bindings/pci/qcom,hawi-pcie.yaml    | 188 +++++++++++++++++++++
> > >  drivers/pci/controller/dwc/pcie-qcom.c             |   1 +
> > >  2 files changed, 189 insertions(+)
> > > ---
> > > base-commit: 4cd074ae20bbcc293bbbce9163abe99d68ae6ae0
> > > change-id: 20260506-hawi-pcie-f61435ca420c
> > > prerequisite-change-id: 20260316-clk-hawi-1ad4cad36d6a:v3
> > > prerequisite-patch-id: c4fbb0620d748d7f1ee675ade5167775bd31c8ac
> > > prerequisite-patch-id: ae5e212518cc333a1a93564cabfc6abd128df664
> > > prerequisite-patch-id: 3c3816e0d595589fc02383f10e48c83a61fdc9d1
> > > prerequisite-patch-id: cbc13fb819d1c1ee77957393f0958f05db8db864
> > > prerequisite-patch-id: 17e2c0cfbbea826fefa1c67d0f5dc2094ab73d76
> > > prerequisite-patch-id: 150dc74750377f4558deab6b179632872bcbb71c
> > > prerequisite-patch-id: 38fe0da5b18610aeb32c7154f9e50187ccaec6a4
> > > prerequisite-change-id: 20260311-icc-hawi-d6dc165f8935:v4
> > > prerequisite-patch-id: a1ff655f0b21d6259b158ad9f99a95bde31257e6
> > > prerequisite-patch-id: db21b6b20451be8475129faece7ef4191d41273c
> > 
> > I don't know where any of these change-ids or patch-ids come from.
> 
> These were generated by b4 after adding the change-id metadata for the
> dependencies.
> 
> They should refer to the change-ids of the respective patch series:
> - https://lore.kernel.org/all/20260506-clk-hawi-v3-0-530b538679f1@oss.qualcomm.com/
> - https://lore.kernel.org/all/20260506-icc-hawi-v4-0-35447fdc482b@oss.qualcomm.com/

-- 
மணிவண்ணன் சதாசிவம்