When power control for downstream devices was introduced in the
mediatek-gen3 PCIe controller driver, only the power to the downstream
devices was cut when the controller driver is removed. This matched
existing behavior, but in hindsight a proper power down sequence should
have been followed.

Call mtk_pcie_devices_power_down() on driver removal so that in addition
to removing power from the downstream devices, PERST# is asserted.

Fixes: 1a152e21940a ("PCI: mediatek-gen3: Integrate new pwrctrl API")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index b0accd828589..e6acca7e79a0 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -1260,7 +1260,7 @@ static void mtk_pcie_remove(struct platform_device *pdev)
 	pci_remove_root_bus(host->bus);
 	pci_unlock_rescan_remove();
 
-	pci_pwrctrl_power_off_devices(pcie->dev);
+	mtk_pcie_devices_power_down(pcie);
 	mtk_pcie_power_down(pcie);
 	pci_pwrctrl_destroy_devices(pcie->dev);
 	mtk_pcie_irq_teardown(pcie);
-- 
2.54.0.545.g6539524ca2-goog

On Tue, 05 May 2026 18:59:16 +0800, Chen-Yu Tsai wrote:
> When power control for downstream devices was introduced in the
> mediatek-gen3 PCIe controller driver, only the power to the downstream
> devices was cut when the controller driver is removed. This matched
> existing behavior, but in hindsight a proper power down sequence should
> have been followed.
> 
> Call mtk_pcie_devices_power_down() on driver removal so that in addition
> to removing power from the downstream devices, PERST# is asserted.
> 
> [...]

Applied, thanks!

[1/1] PCI: mediatek-gen3: Do full device power down on removal
      commit: 2b16d6b9de2f00fd8ecc433b15205c18f8276b3e

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>