From nobody Sat Jun 13 21:04:07 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0C938422E for ; Tue, 5 May 2026 10:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777978767; cv=none; b=kHNwsVLu9YwDaHWE7ZmtWmLksZEHRGOJeiIfy+mluFpcR5QLZhIkHDm+5q/eKcZTxXWQemtKY+tDeyyYvSOqOO1BRLUHyqoJge4r/eaqe15ijwamRvhItCfDW97hXbF0lmIbVFInI7voIOJ/tVh3F1obfSNiQ20aOOJNX93wIR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777978767; c=relaxed/simple; bh=+1OMtPQnjvsrjv2z1oNYsQPynllgk0fbt+9DPHqnSdU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rcuY0XCFLT/mGqijn2CNeeubezfx0OJXoxVU9dVuEkcI/gmgSwUkvmDsCCfywriP8EXCtQlrc7X9gnnmS5o5P4ihcEed92TO5WYrl99ZyYCFLAqZbFB6bXSMDpLufl99gPSETNc4d3oLpccnQ8eGATU35dOYM50yh+l7rGdJomo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LjXdg19f; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LjXdg19f" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82f9fdfc965so2245748b3a.1 for ; Tue, 05 May 2026 03:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777978765; x=1778583565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Jm/1AnMDt5e46hwN56ltGnjEOkXvSOu1rxl9OIWCxKE=; b=LjXdg19fHxOUvmD7neSNQ/4DswaPpPhcSmslLnDZnjqxeVpo+ChvspGfZx9P+jIuTx SsucXBUwOVPVg4rStcn7XF1grySGocbnCSKZGrSwURtrP5YqQfwqe7p2lsG6yP8diTLC zvDB+lHmI+a/DlaYPTkUfDDT0C+LWkZe3cjTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777978765; x=1778583565; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jm/1AnMDt5e46hwN56ltGnjEOkXvSOu1rxl9OIWCxKE=; b=LASvtF2wxEuK40N7Ycumg3Dli+mzVFMjLn5FgcUvKJFL+aqOWytq47/9yEPvCNU7Xe u5RLTUE6rPQ8zji0fYW5eISKcWg+8zeAVVrSGk17ROGBI+aEKz/Tg9vAyyVb31ryTc0O 8AWh+vNtOfEmsjubGNMn6Kxkx9neu3JXeV6JnCrBQAf4Iy4yx45iFFgx0sk3fzg87QSY 1X29ax65GoXzxevEQEHN5o1R3WynEgpFDFvWw77YWTnvERiAI+Nif3nfAwdGZ5nAiEk7 Y9FaRM+M7UQ/ZbeCeyM9isJqt6a6e2wOiViyrvW50SNrqysINj4sVXoOrLaOPfaJX7I0 kuHw== X-Forwarded-Encrypted: i=1; AFNElJ8qghBwkG5VntHPxTFhZpPFluyn0BDAAYM6CMojDKJDxFbtCpDcrmeeY4izo2L1b47INZ0ywPQMM1Y2JNM=@vger.kernel.org X-Gm-Message-State: AOJu0YwyuGtAhvFqHzB0SW94B8jh6ldimSfAVrFZd983jJ5OW1q99cMH BHnArmXC2k0+P9h3E+emXGux4QMHLsALUqF+fKJ/jpp4KL1qv2KWaqotpZjd2YpPdQ== X-Gm-Gg: AeBDietqGGtPigzIsrXFdf3c7E1O8WabWhBPz665PZ2D+6YfmvXQpgHzXCEn41ILn3C Q7apPGcT5R5ZPKHeri4m9sxfJwkmBcQSnNvRAF6iKJz5BFXiETgANJOqNbCZ39zEkog9CVWlLd9 DiqxalAhKVuAmYoMoemly4iRKGJRCmCUDqvEx4AgXD6ym9+Bb/gucoPqk7YLY7yRd2bYfQQ4KmW MQUjOJUdk6Nxv6+0oLopbLoz1iarbJf0o1LfamSKzPg4K9p9oNQokAxnlpPm0wuNodwMgZQHtDY NVKxts5piAP1l7Ad6eWsujKNhjiZBNPdwUPC37EXURJWUBYr0bIC4mBkI0eF2DXWxmaQpmqtxzk KbRuTqyQ9ej+jhKMEMAz59zdsPWS/IAnZMku6yuy4ezsYeIfB7++v/NVjnpNt+yehYtQfpwQd5Q FSErcBUh5sbuCA2+9JOY6rCmk325R/7mc/i9M2gE97lDME5/Y2G00IHC5+4miy1O5ecqUIC901h C9fsqq+EUifUPEsivk= X-Received: by 2002:a05:6a20:e210:b0:398:7ffe:472f with SMTP id adf61e73a8af0-3a7f1a1e096mr14432341637.2.1777978765661; Tue, 05 May 2026 03:59:25 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f1d4:2ef0:7d08:9dd8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbba71b0sm13005611a12.2.2026.05.05.03.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:59:24 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas Cc: Chen-Yu Tsai , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: mediatek-gen3: Do full device power down on removal Date: Tue, 5 May 2026 18:59:16 +0800 Message-ID: <20260505105918.1823170-1-wenst@chromium.org> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When power control for downstream devices was introduced in the mediatek-gen3 PCIe controller driver, only the power to the downstream devices was cut when the controller driver is removed. This matched existing behavior, but in hindsight a proper power down sequence should have been followed. Call mtk_pcie_devices_power_down() on driver removal so that in addition to removing power from the downstream devices, PERST# is asserted. Fixes: 1a152e21940a ("PCI: mediatek-gen3: Integrate new pwrctrl API") Signed-off-by: Chen-Yu Tsai --- drivers/pci/controller/pcie-mediatek-gen3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/cont= roller/pcie-mediatek-gen3.c index b0accd828589..e6acca7e79a0 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -1260,7 +1260,7 @@ static void mtk_pcie_remove(struct platform_device *p= dev) pci_remove_root_bus(host->bus); pci_unlock_rescan_remove(); =20 - pci_pwrctrl_power_off_devices(pcie->dev); + mtk_pcie_devices_power_down(pcie); mtk_pcie_power_down(pcie); pci_pwrctrl_destroy_devices(pcie->dev); mtk_pcie_irq_teardown(pcie); --=20 2.54.0.545.g6539524ca2-goog