On 5/4/26 18:29, Neil Armstrong wrote:
> Now the bindings and driver was merged for the SPMI PMIC5 Gen3 ADC
> found on the PMK8550 which allow reading ADC data on the PMK8550
> and other PMICs on the system.
>
> First, add the PMIC5 Gen3 macros to calculate the channel numbers which
> is a combination of SPMI bus number and a constant for the sensor
> type and configuration.
>
> The macros definitions were taken out of [1] where it was initially
> in the dt-bindings include directory but since those are not hardware
> bindings but logical numbers, they can be moved to local includes
> instead to make the DT source more readable.
>
> [1] https://lore.kernel.org/all/20250826083657.4005727-4-jishnu.prakash@oss.qualcomm.com/
>
> Finally add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
> other PMICS on the system.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Changes in v2:
> - Removed stray line from patch 2, added review tag
> - Added missing header file
> - Link to v1: https://patch.msgid.link/20260427-topic-sm8x50-adc5-gen3-v1-0-8a70f7b90a75@linaro.org
>
> ---
> Neil Armstrong (6):
> arm64: dts: qcom: add PMIC5 Gen3 macros for channel numbers
> arm64: dts: qcom: pmk8550: add VADC node
> arm64: dts: qcom: sm8550-qrd: add SPMI ADC channels and thermal nodes
> arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes
> arm64: dts: qcom: sm8650-qrd: add SPMI ADC channels and thermal nodes
> arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes
>
> arch/arm64/boot/dts/qcom/pmk8550.dtsi | 30 +++
> arch/arm64/boot/dts/qcom/qcom,adc5-gen3-channels.h | 88 +++++++
> arch/arm64/boot/dts/qcom/qcom,pm8550-adc5-gen3.h | 46 ++++
> arch/arm64/boot/dts/qcom/qcom,pm8550b-adc5-gen3.h | 85 +++++++
> arch/arm64/boot/dts/qcom/qcom,pm8550vx-adc5-gen3.h | 22 ++
> arch/arm64/boot/dts/qcom/qcom,pmk8550-adc5-gen3.h | 52 ++++
> arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 279 +++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 279 +++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 279 +++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 279 +++++++++++++++++++++
> 10 files changed, 1439 insertions(+)
> ---
> base-commit: b9303e6bff706758c167af686b5315ad00233bf8
> change-id: 20260427-topic-sm8x50-adc5-gen3-edf94fbd335b
>
> Best regards,
> --
> Neil Armstrong <neil.armstrong@linaro.org>
>
Gente ping, any other comments on this patchset ? PMIC ADC entries have been missing for too long on those platforms.
Neil