1. Patchew
  2. linux
  3. View series

[PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name

Bentley Blacketer posted 1 patch 1 month, 2 weeks ago
There is a newer version of this series
drivers/staging/greybus/bootrom.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
[PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
Posted by Bentley Blacketer 1 month, 2 weeks ago 
The original dev_info call was intentionally temporary, with a FIXME
comment noting it should be downgraded to dev_dbg once modules with
valid VID/PID values were common. Project Ara was cancelled in 2016,
so that time has long passed.

Remove the FIXME comment and downgrade to dev_dbg as originally intended.

Tested via code inspection only, as Project Ara hardware is no longer
available.

Signed-off-by: Bentley Blacketer  <sonionwhat@gmail.com>
Signed-off-by: Bentley Blacketer <sonionwhat@gmail.com>
---
 drivers/staging/greybus/bootrom.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
index 83921d90c..058044ba7 100644
--- a/drivers/staging/greybus/bootrom.c
+++ b/drivers/staging/greybus/bootrom.c
@@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
 	 *
 	 * XXX Name it properly..
 	 */
-	snprintf(firmware_name, sizeof(firmware_name),
+snprintf(firmware_name, sizeof(firmware_name),
 		 FW_NAME_PREFIX "%08x_%08x_%08x_%08x_s2l.tftf",
 		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
 		 intf->vendor_id, intf->product_id);
 
-	// FIXME:
-	// Turn to dev_dbg later after everyone has valid bootloaders with good
-	// ids, but leave this as dev_info for now to make it easier to track
-	// down "empty" vid/pid modules.
-	dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
+	dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
 		 firmware_name);
-
 	rc = request_firmware(&bootrom->fw, firmware_name,
 			      &connection->bundle->dev);
 	if (rc) {
-- 
2.54.0
Re: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
Posted by kernel test robot 1 month, 2 weeks ago 
Hi Bentley,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Bentley-Blacketer/staging-greybus-bootrom-replace-dev_info-with-dev_dbg-for-firmware-name/20260505-034304
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260430173045.4619-1-sonionwhat%40gmail.com
patch subject: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
config: hexagon-randconfig-r071-20260505 (https://download.01.org/0day-ci/archive/20260505/202605050911.O85GmqxE-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
smatch: v0.5.0-9065-ge9cc34fd

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605050911.O85GmqxE-lkp@intel.com/

smatch warnings:
drivers/staging/greybus/bootrom.c:166 find_firmware() warn: inconsistent indenting

vim +166 drivers/staging/greybus/bootrom.c

f1e941a6e4b71a drivers/staging/greybus/firmware.c Viresh Kumar       2015-11-26  142  
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  143  /* This returns path of the firmware blob on the disk */
68793c4c8824a0 drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  144  static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  145  {
5a53e02eaf223c drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-04-03  146  	struct gb_connection *connection = bootrom->connection;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  147  	struct gb_interface *intf = connection->bundle->intf;
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  148  	char firmware_name[49];
fc41c2da44c510 drivers/staging/greybus/firmware.c Eli Sennesh        2016-01-08  149  	int rc;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  150  
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  151  	/* Already have a firmware, free it */
5a53e02eaf223c drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-04-03  152  	free_firmware(bootrom);
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  153  
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  154  	/* Bootrom protocol is only supported for loading Stage 2 firmware */
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  155  	if (stage != 2) {
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  156  		dev_err(&connection->bundle->dev, "Invalid boot stage: %u\n",
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  157  			stage);
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  158  		return -EINVAL;
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  159  	}
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  160  
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  161  	/*
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  162  	 * Create firmware name
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  163  	 *
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  164  	 * XXX Name it properly..
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  165  	 */
af0b4d5a19e3d4 drivers/staging/greybus/firmware.c Johan Hovold       2015-08-28 @166  snprintf(firmware_name, sizeof(firmware_name),
8a704565ebda96 drivers/staging/greybus/bootrom.c  Greg Kroah-Hartman 2016-07-20  167  		 FW_NAME_PREFIX "%08x_%08x_%08x_%08x_s2l.tftf",
b32a5c5346bdaa drivers/staging/greybus/firmware.c Viresh Kumar       2015-12-22  168  		 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
56c78715eaaeba drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-16  169  		 intf->vendor_id, intf->product_id);
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  170  
6472c9b9299508 drivers/staging/greybus/bootrom.c  Bentley Blacketer  2026-04-30  171  	dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
eb8fafdfb9fce9 drivers/staging/greybus/firmware.c Greg Kroah-Hartman 2016-01-20  172  		 firmware_name);
5a53e02eaf223c drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-04-03  173  	rc = request_firmware(&bootrom->fw, firmware_name,
0a72bd36df9478 drivers/staging/greybus/firmware.c Greg Kroah-Hartman 2015-10-14  174  			      &connection->bundle->dev);
2d6f1c29988c0f drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  175  	if (rc) {
68793c4c8824a0 drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  176  		dev_err(&connection->bundle->dev,
68793c4c8824a0 drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  177  			"failed to find %s firmware (%d)\n", firmware_name, rc);
2d6f1c29988c0f drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  178  	}
2d6f1c29988c0f drivers/staging/greybus/bootrom.c  Viresh Kumar       2016-07-22  179  
fc41c2da44c510 drivers/staging/greybus/firmware.c Eli Sennesh        2016-01-08  180  	return rc;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  181  }
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar       2015-08-12  182  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
Posted by Greg KH 1 month, 2 weeks ago 
On Thu, Apr 30, 2026 at 01:30:45PM -0400, Bentley Blacketer wrote:
> The original dev_info call was intentionally temporary, with a FIXME
> comment noting it should be downgraded to dev_dbg once modules with
> valid VID/PID values were common. Project Ara was cancelled in 2016,
> so that time has long passed.
> 
> Remove the FIXME comment and downgrade to dev_dbg as originally intended.
> 
> Tested via code inspection only, as Project Ara hardware is no longer
> available.
> 
> Signed-off-by: Bentley Blacketer  <sonionwhat@gmail.com>
> Signed-off-by: Bentley Blacketer <sonionwhat@gmail.com>

Why twice?

> ---
>  drivers/staging/greybus/bootrom.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

No list of what changed from previous versions?

> 
> diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
> index 83921d90c..058044ba7 100644
> --- a/drivers/staging/greybus/bootrom.c
> +++ b/drivers/staging/greybus/bootrom.c
> @@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
>  	 *
>  	 * XXX Name it properly..
>  	 */
> -	snprintf(firmware_name, sizeof(firmware_name),
> +snprintf(firmware_name, sizeof(firmware_name),


Why this change?

Please always run your patches through checkpatch.pl before sending them
out.

thanks,

greg k-h

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.