[PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues

Salman Alghamdi posted 5 patches 1 month, 3 weeks ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_mlme.c | 286 +++++++++++++++-------
1 file changed, 197 insertions(+), 89 deletions(-)
[PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Salman Alghamdi 1 month, 3 weeks ago
This series addresses review feedback on v2 of the rtw_mlme.c
line length cleanup patch.

Patch 1 fixes a pre-existing buffer over-read bug in
rtw_update_protection() identified during review.

Patches 2-5 address the line length cleanup, dead code removal,
line consolidation, and readability improvements as separate
atomic changes.

Salman Alghamdi (5):
  staging: rtl8723bs: fix buffer over-read in rtw_update_protection
  staging: rtl8723bs: rtw_mlme: fix lines exceeding 100 columns
  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
  staging: rtl8723bs: rtw_mlme: add blank line for readability

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 286 +++++++++++++++-------
 1 file changed, 197 insertions(+), 89 deletions(-)

-- 
2.54.0
Re: [PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Salman Alghamdi 1 month, 3 weeks ago
I noticed the function signature continuation lines appear misaligned
in the mailing list archive. I've verified the alignment in the file
using cat -A which shows correct tabs+spaces:

  ^I^I^I^I^I    struct wlan_network *network)

The misalignment appears to be a rendering artifact in the email
client or archive. If you can verify by applying the patch locally
I'd appreciate confirmation, or if there's a known fix I'm happy
to address it.

Regards,
Salman Alghamdi.
Re: [PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Luka Gejak 1 month, 3 weeks ago
On Mon Apr 27, 2026 at 1:12 AM CEST, Salman Alghamdi wrote:
> I noticed the function signature continuation lines appear misaligned
> in the mailing list archive. I've verified the alignment in the file
> using cat -A which shows correct tabs+spaces:
>
>   ^I^I^I^I^I    struct wlan_network *network)
>
> The misalignment appears to be a rendering artifact in the email
> client or archive. If you can verify by applying the patch locally
> I'd appreciate confirmation, or if there's a known fix I'm happy
> to address it.
>
> Regards,
> Salman Alghamdi.

I am confused in email it's misaligned but when I apply and check file 
it's looking good. Anyone knows why?
Best regards,
Luka Gejak
Re: [PATCH v3 0/5] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Dan Carpenter 1 month, 2 weeks ago
On Mon, Apr 27, 2026 at 08:11:27AM +0200, Luka Gejak wrote:
> On Mon Apr 27, 2026 at 1:12 AM CEST, Salman Alghamdi wrote:
> > I noticed the function signature continuation lines appear misaligned
> > in the mailing list archive. I've verified the alignment in the file
> > using cat -A which shows correct tabs+spaces:
> >
> >   ^I^I^I^I^I    struct wlan_network *network)
> >
> > The misalignment appears to be a rendering artifact in the email
> > client or archive. If you can verify by applying the patch locally
> > I'd appreciate confirmation, or if there's a known fix I'm happy
> > to address it.
> >
> > Regards,
> > Salman Alghamdi.
> 
> I am confused in email it's misaligned but when I apply and check file 
> it's looking good. Anyone knows why?

It's because in a diff every line starts with an extra [ +-] char.

regards,
dan carpenter