[PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues

Salman Alghamdi posted 8 patches 1 month, 2 weeks ago
drivers/staging/rtl8723bs/core/rtw_mlme.c | 276 ++++++++++++++--------
1 file changed, 183 insertions(+), 93 deletions(-)
[PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Salman Alghamdi 1 month, 2 weeks ago
This series addresses review feedback on v5. Changes from v5:

- Fix variable declaration ordering that broke compilation due to
  dependency on uninitialized pointer (per Luka Gejak)

Salman Alghamdi (8):
  staging: rtl8723bs: fix buffer over-read in rtw_update_protection
  staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length
    subtraction
  staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns
  staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
  staging: rtl8723bs: rtw_mlme: extract local variables for long
    expressions
  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
  staging: rtl8723bs: rtw_mlme: add blank line for readability

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 276 ++++++++++++++--------
 1 file changed, 183 insertions(+), 93 deletions(-)

-- 
2.54.0
Re: [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Luka Gejak 1 month, 2 weeks ago
On April 28, 2026 6:44:30 PM GMT+02:00, Salman Alghamdi <me@cipherat.com> wrote:
>This series addresses review feedback on v5. Changes from v5:
>
>- Fix variable declaration ordering that broke compilation due to
>  dependency on uninitialized pointer (per Luka Gejak)
>
>Salman Alghamdi (8):
>  staging: rtl8723bs: fix buffer over-read in rtw_update_protection
>  staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length
>    subtraction
>  staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns
>  staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition
>  staging: rtl8723bs: rtw_mlme: extract local variables for long
>    expressions
>  staging: rtl8723bs: rtw_mlme: remove dead commented-out code
>  staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines
>  staging: rtl8723bs: rtw_mlme: add blank line for readability
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 276 ++++++++++++++--------
> 1 file changed, 183 insertions(+), 93 deletions(-)
>

LGTM, so unless Dan has something to add, for the patch series:

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak
Re: [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Salman Alghamdi 1 month, 2 weeks ago
> LGTM, so unless Dan has something to add, for the patch series:
> 
> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Thank you for your patience and detailed reviews throughout this process.
This is my first kernel contribution and your guidance has been invaluable.
Looking forward to contributing more! -hopefully fewer silly mistakes :P

Kindest regards,
Salman Alghamdi
Re: [PATCH v6 0/8] staging: rtl8723bs: rtw_mlme: fix long lines and related issues
Posted by Luka Gejak 1 month, 2 weeks ago
On April 28, 2026 8:43:31 PM GMT+02:00, Salman Alghamdi <me@cipherat.com> wrote:
>> LGTM, so unless Dan has something to add, for the patch series:
>> 
>> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
>
>Thank you for your patience and detailed reviews throughout this process.
>This is my first kernel contribution and your guidance has been invaluable.
>Looking forward to contributing more! -hopefully fewer silly mistakes :P
>
>Kindest regards,
>Salman Alghamdi
>

No problem, I'm here if you need any help in the future and feel free 
to cc me in any future patches. One more thing, silly mistakes are 
part of the process and you will do them less as time goes by. Hope to
see more patches in the future :)
Best regards,
Luka Gejak