[PATCH v2 0/7] media: qcom: iris: miscellaneous code-quality fixes

Dikshita Agarwal posted 7 patches 1 month, 3 weeks ago
There is a newer version of this series
drivers/media/platform/qcom/iris/iris_buffer.c     | 123 +++++----------------
drivers/media/platform/qcom/iris/iris_buffer.h     |   2 +-
.../platform/qcom/iris/iris_hfi_gen1_command.c     |   2 +-
.../platform/qcom/iris/iris_hfi_gen2_command.c     |   7 +-
.../platform/qcom/iris/iris_hfi_gen2_response.c    |   4 +-
drivers/media/platform/qcom/iris/iris_state.c      |   4 +-
6 files changed, 40 insertions(+), 102 deletions(-)
[PATCH v2 0/7] media: qcom: iris: miscellaneous code-quality fixes
Posted by Dikshita Agarwal 1 month, 3 weeks ago
This series addresses a set of independent code-quality issues found 
during review of the Qualcomm iris video driver.

No functional changes are intended.
 

Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
---
Changes in v2:
- Updated variables names for iris_get_int_buf_tbl helper (Bryan)
- Removed un-necessary fixes tags (Bryan, Konrad)
- Addressed other comments (Bryan, Konrad)
- Link to v1: https://lore.kernel.org/r/20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com

---
Dikshita Agarwal (7):
      media: qcom: iris: Centralize internal buffer table selection
      media: qcom: iris: fix state-change debug log printing stale value
      media: qcom: iris: Fix bitmask test in iris_allow_cmd()
      media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier()
      media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry
      media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec()
      media: qcom: iris: Make iris_destroy_internal_buffer() return void

 drivers/media/platform/qcom/iris/iris_buffer.c     | 123 +++++----------------
 drivers/media/platform/qcom/iris/iris_buffer.h     |   2 +-
 .../platform/qcom/iris/iris_hfi_gen1_command.c     |   2 +-
 .../platform/qcom/iris/iris_hfi_gen2_command.c     |   7 +-
 .../platform/qcom/iris/iris_hfi_gen2_response.c    |   4 +-
 drivers/media/platform/qcom/iris/iris_state.c      |   4 +-
 6 files changed, 40 insertions(+), 102 deletions(-)
---
base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9
change-id: 20260420-iris-code-improvement-19409f16258c

Best regards,
-- 
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Re: [PATCH v2 0/7] media: qcom: iris: miscellaneous code-quality fixes
Posted by bod@kernel.org 2 weeks, 3 days ago
On 2026-04-23 17:30 +0530, Dikshita Agarwal wrote:
> This series addresses a set of independent code-quality issues found 
> during review of the Qualcomm iris video driver.
> 
> No functional changes are intended.
>  
> 
> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> ---
> Changes in v2:
> - Updated variables names for iris_get_int_buf_tbl helper (Bryan)
> - Removed un-necessary fixes tags (Bryan, Konrad)
> - Addressed other comments (Bryan, Konrad)
> - Link to v1: https://lore.kernel.org/r/20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com
> 
> ---
> Dikshita Agarwal (7):
>       media: qcom: iris: Centralize internal buffer table selection
>       media: qcom: iris: fix state-change debug log printing stale value
>       media: qcom: iris: Fix bitmask test in iris_allow_cmd()
>       media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier()
>       media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry
>       media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec()
>       media: qcom: iris: Make iris_destroy_internal_buffer() return void
> 
>  drivers/media/platform/qcom/iris/iris_buffer.c     | 123 +++++----------------
>  drivers/media/platform/qcom/iris/iris_buffer.h     |   2 +-
>  .../platform/qcom/iris/iris_hfi_gen1_command.c     |   2 +-
>  .../platform/qcom/iris/iris_hfi_gen2_command.c     |   7 +-
>  .../platform/qcom/iris/iris_hfi_gen2_response.c    |   4 +-
>  drivers/media/platform/qcom/iris/iris_state.c      |   4 +-
>  6 files changed, 40 insertions(+), 102 deletions(-)
> ---
> base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9
> change-id: 20260420-iris-code-improvement-19409f16258c
> 
> Best regards,
> -- 
> Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
> 
> 

Everything is RB now but not applicable.

Please rebase and resend.

---
bod