From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 560193EC2C2 for ; Thu, 23 Apr 2026 12:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945643; cv=none; b=uy6FHzs2A833cRTjTzW7Yxhb2L5+FgAB68mwzGuSnxTv7rYZEUI9tgP1vYSZiAguxL3swmX4LwhpFJNga/GKzLZQs2/UaJqIXgCnDGP6CjxmHqlCenLRoIdq322d7wuJR0nktNzvK4qqIn+3eH6+EkJQ62bdw5RilTVWAtNhUK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945643; c=relaxed/simple; bh=/4u0s68y0bWzXBNSs/02FvXVElc68mI24erTIfYoe/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kNKATEsgW36I01Eu8YSB/2DRnjO5RoXgyiue206UJg0ZvOK16NNyytsNo/H6AgH7V95x3wZJi2aza4qNsgqmn0ZIa2RvUmUe4mtx1TFeznDDhohGe2o16pix38Cv3De+fNrn9yh/1n40FuJoWwYsrLDfPl9tJCmAY3cgW7NauB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FHG0VN0Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gqGu6Zjl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FHG0VN0Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gqGu6Zjl" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEwo3044048 for ; Thu, 23 Apr 2026 12:00:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o5jbzVWWdj9OVgnOnF4MDpI7MkUgPzEgugSFsM8ZzIc=; b=FHG0VN0YYIyONPdl OQgyXaS5n0Jf8nCM4nFsvp3ucGFFMe9HWtEldvb2xOcG5HhviisgNSuWIXIczxw1 FqbgyB6XYsDiDhwt5KaMjIhFRgYnLbWcY3is1s4Z0ub2CtmS1lHBlrXpBkKW8Tqa 7dPRck2oFzQ2An0pYEtW3TzPH9400ioT7KRn9S/Pg5+H7mzTvmTpmDDLW/cRQjbI 3qFeETHYvedCR5bNGD9AAD4BuSpXbzqP4OiAIo3ZSOW3VVATM3SL+aeOTUiQJmzJ C9fWKOSEuTRwUYTbXxCE/RjRDFjOIbV786NG65fCmLUDQn6FiKoW5WzP+k2Y9j3a qmns/A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3rug-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:41 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b24e9b4d82so68140345ad.1 for ; Thu, 23 Apr 2026 05:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945640; x=1777550440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o5jbzVWWdj9OVgnOnF4MDpI7MkUgPzEgugSFsM8ZzIc=; b=gqGu6ZjlY1hRd/pMInJ8fX0opSVZqvEIe3IfugsZz+MzM7Ju1++VLFfL4A/4bmBabJ wmWJ6NvSlN5kkiniqarq51TYyU/u5Mpj76pD5RsAc68R/baXzIph0fnos4aWD9Sl4wYr A3ZiVtpHV2rJqvGvJesKM2gk8bGp5mqf83SMTh3BHeOexAlxw1rWec2KcT6HwvNcHcFD 8jzO08iG7wLgdF2Obf6pWgzZoQlRekRBduoBnJxs7ZKuUs3zSHGvVakJ6S0sEfA9ReiM RVdgUa9mFCiiAlJOcxwzFKxHrh/tiJM5aZdGi86R0uUXtoKZzpTN5xvg7GWX1yq3oPiQ Su3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945640; x=1777550440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=o5jbzVWWdj9OVgnOnF4MDpI7MkUgPzEgugSFsM8ZzIc=; b=aOqsuGH7FdkoXkXBHJOKBeCZRwRGikdzqjcynpXo0gsKT3w+wLw/SNLHh22I0Jgsxv m9bEQsA+CqeUd/+1V0+6ph8nPCSb9qoS+ciVmrnFN75zYneRsknWDdnKUR8kyYo6Yb0Q ZFKIsklOrt+blSfrKU2c+va4/tqL0r/oszT6IrEjVpoPAZHg1CJuyZ1KEMIb1Xpc3HfG 3E/OhMk1hhgEP1zLSvewYXnBqfctpwpkKQIUVUzb695UFEz57U955JIgMoIPTWQ/KxJS PUS+MMyfbioY7RPLLbRyE9+NSLmFD2cGTgTarmzHqrZkIppvJgvbexOmHVmWCnPAttoF 2vxQ== X-Forwarded-Encrypted: i=1; AFNElJ+gW7HaCv4q2Va8VNK9f1i9o0WkAdMY6JjqNd46kch+GU/qW/nBUbmnPU6ZS3VptwsqAWcnOvksrcf20DU=@vger.kernel.org X-Gm-Message-State: AOJu0YwSayRDeHEUBbu/3ZuuW/0/G8sfN9HDRpSy3Q7Q9VUoH5Ipxlf5 7QGaqaEsgTedCVSWx0q+I9PoaaYU8O0RX2KJdUrp+5cHtZOhdqbE5gTDeTZUKLURI6672PD7OSP E+PfI7xFxmD4grofW5FB9FAaWeGVCgSuomg1FmH8eOIsYM6ZYsQOyJ3Fh+NFy0mDSxVE= X-Gm-Gg: AeBDiesPPtB0aDMgF2DamxqZ3AZQAnUu1rcn4ILxz+7ahUrw7Rx4zldFbGcf9mgarii /oEtWbvgcmEYMPfyzDHqonWmaw9LkYoPNTEYCDutVi5njm1VvlT2SlyL3GNmiRek31beWQjVZug iZ1U3Wg7eRiZqSIvXYS29Dl9RbyQaYdvZJX2qpD7ZbAia4Afx2bqREfoa/qSGm8IpcyMdWMXONX t9er1ocGfO3luiYVWYxd/tLeGfVkVpHnIZ7Yeh3mmVJTs1CPTAS5fu8p4G7u+nB22Lwenjzo7gE bKVtkynpDI7j4LiYcC8EhEMv5BIbgx8C6LUkCw/e9hy8rpHwIkTteLzuRq4dtQxOdlbzYGhcXrs kAGhwao76U+lwfYj59H12Hu2EU1tjLGKXI3kXLgJmNhfhbhJZEMRSBRioVz5M2O3S8QCxzQ== X-Received: by 2002:a17:903:3910:b0:2b7:88f9:9c28 with SMTP id d9443c01a7336-2b788f9a0c6mr98978095ad.5.1776945639813; Thu, 23 Apr 2026 05:00:39 -0700 (PDT) X-Received: by 2002:a17:903:3910:b0:2b7:88f9:9c28 with SMTP id d9443c01a7336-2b788f9a0c6mr98976455ad.5.1776945637034; Thu, 23 Apr 2026 05:00:37 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:36 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:05 +0530 Subject: [PATCH v2 1/7] media: qcom: iris: Centralize internal buffer table selection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-1-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=8089; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=/4u0s68y0bWzXBNSs/02FvXVElc68mI24erTIfYoe/4=; b=uVLutiKCBlDPAHjHyZPNgKYlQUw3O79i35dizeLGIlZU5EuGoFp85LH87npx6bP+mK9iV7SPE fklTvPnX1VPB7+cH+K+pCWvbXg/WR25pu+z0Inb6M5DzMZMJ3fFZDnb X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX3ZvFn5azE5ZU nhawkTNBuO9qvRSxDKjp+7Lg9BH84Care9arM24uewqnGJ27b1o5iVtUAPFDP+qr2+WJgj3JFrn C0q3cJLMTdyQV31cMS+/hWscZj32KYQpo9A2zf4PlaHCpcxRnhBMM6faAaQ1wg7FNafevrmZznt cZwLh6mk0BFTW/UQtpbh23RFkUzWKZfJMSbbczXdwAvtAXWUf5VrUrdU4ua1Il2qer6cM3BFjdg mefOYr9FNfpaNMBo2MbwHE1btktlmJed+o0kQ02x6uqZweAhzQqu1CnwpOLpsPBRFzh6kd599Zd BMTfX+mIpZMVqKjG7n7czf225yFzGhQRCrIfrWv5fkNOEIqOVxdtxsupRYvQucpVjOSDzw359yD W+BKHWFuxVxxm//ki89CAC53rqnPa7HD3CKs1rcRWLM8ZeGhjZ+lruiiDiswbaquJJQehBI9gsY iIWBMIKfecNd3lZZnYg== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea09e9 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=YO4-hHwgDu7wuGDVLqgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: NWwTCEGq65YzZZpgyHuIdGiypDzk78ei X-Proofpoint-ORIG-GUID: NWwTCEGq65YzZZpgyHuIdGiypDzk78ei X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 Internal buffer table dispatch is duplicated across multiple Iris code paths, which is error=E2=80=91prone and makes future changes harder to reas= on about. Consolidate the buffer dispatch logic into a single helper so that table selection is defined in exactly one place and keep call sites minimal. No functional change intended. Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/iris/iris_buffer.c | 107 ++++++---------------= ---- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 9151f43bc6b9c2c34c803de4231d1e6de0bec6c4..5b31c511da6e735943e25616830= 16cb9414d760c 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -299,39 +299,41 @@ static void iris_fill_internal_buf_info(struct iris_i= nst *inst, buffers->min_count =3D iris_vpu_buf_count(inst, buffer_type); } =20 -void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +static void iris_get_int_buf_tbl(struct iris_inst *inst, u32 plane, + const u32 **internal_buf_type, u32 *internal_buffer_count) { const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; - const u32 *internal_buf_type; - u32 internal_buffer_count, i; =20 if (inst->domain =3D=3D DECODER) { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; + *internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D platform_data->dec_op_int_buf_tbl; + *internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; } } else { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; + *internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D platform_data->enc_op_int_buf_tbl; + *internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; } } } =20 +void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +{ + const u32 *internal_buf_type; + u32 internal_buffer_count, i; + + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); + + for (i =3D 0; i < internal_buffer_count; i++) + iris_fill_internal_buf_info(inst, internal_buf_type[i]); +} + static int iris_create_internal_buffer(struct iris_inst *inst, enum iris_buffer_type buffer_type, u32 index) { @@ -366,29 +368,12 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, =20 int iris_create_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; u32 internal_buffer_count, i, j; struct iris_buffers *buffers; const u32 *internal_buf_type; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -442,30 +427,13 @@ int iris_queue_internal_deferred_buffers(struct iris_= inst *inst, enum iris_buffe =20 int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; struct iris_buffer *buffer, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -501,30 +469,13 @@ int iris_destroy_internal_buffer(struct iris_inst *in= st, struct iris_buffer *buf =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; struct iris_buffer *buf, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - len =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->dec_op_int_buf_tbl; - len =3D platform_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - len =3D platform_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_op_int_buf_tbl; - len =3D platform_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 for (i =3D 0; i < len; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -593,18 +544,12 @@ static int iris_release_internal_buffers(struct iris_= inst *inst, =20 static int iris_release_input_internal_buffers(struct iris_inst *inst) { - const struct iris_platform_data *platform_data =3D inst->core->iris_platf= orm_data; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - internal_buf_type =3D platform_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D platform_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D platform_data->enc_ip_int_buf_tbl_size; - } + iris_get_int_buf_tbl(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + &internal_buf_type, &internal_buffer_count); =20 for (i =3D 0; i < internal_buffer_count; i++) { ret =3D iris_release_internal_buffers(inst, internal_buf_type[i]); --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EA73E92A9 for ; Thu, 23 Apr 2026 12:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945646; cv=none; b=ryvYYKS9kBBhuHtp147HqB1/7URvQ0f/sIsOlo5mkefFJGN9MpupmPDpP9jslwClOFvZowuir/iSRNMpmPuvHEODcXG2jb5XnPVIsvhTdRaxFCZn/2WRMzw7VIRrTMny3NhY8aCMOkXnjfXbg3ZgnnX8uFMJ6Bt784XZA1xfSHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945646; c=relaxed/simple; bh=i29lXDR220N9S/ZCltewSH2m1udYLebrd2wvWU1dcKI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q/61lHRqjVn1qoUZmPDldkh82wY7tDYGJrS2LpVpQY+9k/J9MlSaCSA00HDI+qsdj+jaD1Dw7Jav/NRq/K4O2Pj4GwDFEu6x2IOL1PvYofuNQ9n2HH+IYzEo55uy9lGzfYhDbJ97SWtX/DHmc+Un0Y/Fhj2JI12WkO9WvP/WSRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oopMWBFN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aXfB8S06; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oopMWBFN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aXfB8S06" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u2nd366192 for ; Thu, 23 Apr 2026 12:00:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=oopMWBFNUqDHxJ1f 8s0BBoh7oQ2oUzN57gQW8Cl5ZLn7tiK8UIqUTppahGzx3BX/pudEpQ8YpdWNeNfy 9uARNbs3BpSPu23gB3ummYCXvAe6qvIX04fm9XRSEsUwkIQFPIFRL37sP1bdHhGl R9FuPxP0aMR46mdkGXkyvnmeyBvmTtyLm5VFZ0X1QCaiUFk0M3WM746Y5sAKHhDY 8jTi5cvXjibGCyFhtnYK9CO0l9ONFaako8fB0p48xdAmd+DCU3pJykGADlvsmvFL v35EyrbHwhwt3sPsfcgBn81aeJ6OHfmVmyAl2oXhkDEeIjaFjRq1duhFQo9NMUk/ IYu/bQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq35rbbur-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:43 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adc527eaf5so52463035ad.0 for ; Thu, 23 Apr 2026 05:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945642; x=1777550442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=aXfB8S06sdtr6af5IopjaRjbnIfmg5LEpb5X5QiLlrvR4SlLlbNeB/sy4ER8MEx7Vn cvbx1QodEObNBOMXXkmVt50g6A9xihMV1L5kAoZziW264xF4BsOw6mi0RDlutxSfH2pR TW53hSLoAeVwmD6kjcklrXqsyH3n5RS8PGI0HCsV6HXX2CiteiXlkSzraQ8I4ZxCoCXq I2CkIEvLUIjvt7V3gUO/eYuHg4heqgA0iaQI0gWTtR9bY/e4I8WwMqyh0L50O2yczWl2 hQwj/lGOlFIpx3ar/MdIDX4clhV+1CICYk18HfileZeLVB6LBvIrdftojwkJxD7ptZG2 U6KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945642; x=1777550442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b2aLu8tVOEk23kPdNH5kca74rbgoKNO8p6b0S6AIX50=; b=EhZlERI5ikawD9PLmcHve6TATfFsz5CgwB+zmAjH0EiuPMQcV4YRRWSR8mmZ5c+/n5 EyRrpENMr1s0JHiF6GtvELlyZiJSr2A9WbXxBAWTwM0lQq+qwKO4gBC2uf3o7PmTEaFK zog+Uxd9MFc867G5By920L8Zgb8CcGud2CC1yQRaqWC3sZwjuqp81GApQr+B4zM9BvJX C4kF/1UiykRioP/8Am2QNbepCp3ndhiCyG6yXxGTfptgFuZMJnOgrjnhN7CVOPSqyG6g fcrmEH8jA3I2E2F65dbsWIOOR2/t9JVsYjmDRpvfqCdEOw+vzmEa4SmJD57bU7nPxlfu dJ6g== X-Forwarded-Encrypted: i=1; AFNElJ8uNUkoteLR9DzM+kmCJf15g7JXvtbyQQZVgDCrfmOd//IVUkh97Mpnf7pS8LduM4Jh5HWQGIiCm3C8pvk=@vger.kernel.org X-Gm-Message-State: AOJu0YyB/5mJAvbj2ij5+5DBZx01C2VPS6IsBZxiGGhNM/exdyoE7e01 NyqtBrAzdB7qQyl2/zt+W/YM+PT6e1d/N+WO/Dg8B30WCiQ6GJMmxjzQ8fIVOAs8k7pod/XwfV8 0o1T9Hw8mhWrUPKbql/7TEIn/zyPDtpfa6gac1XnwVEMMIZcrsm1CD3tmDi3j2b4NtVs= X-Gm-Gg: AeBDieuL8SpsKvP8TWpFH+XfWDxC3tXThmDMZ2DVytyOUiw6oSV/snCgJ9mLuMZwaux N0rITya8uOFfC0DvsL+IomC2srTsGPUj9NWGsQm5hZ6pMYpa8sXiDVQTdXMoHCSVACJY8LZmk9i 90XV7fcn53YqJuPZZrGZkQ71Tfpey27CzAs3DRLwBzHuvEjA4fUyEy/iobgwhTL6pP8kbtg13G3 dhDKOVCa+ZNkvnCjLUMGIbD2J13nc6m3X8y/K+sZZN4u8ed6buiaBC3fnhYU8uwpH7iwDYDNMf1 ohzAhomUZ2G6R29qadY14V8PDW5S/jmn5KU2YtCJswdgxDFVkpGjE3ET+Td/RkekDwC+HZMoFGy hT8gT8bGOU/bYFgVjRoxIsXQ8+o3DO1at6ZGSnGtNI3sJ5YcOEBPSbFuedG1lDpv+jOW+Bw== X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr256862115ad.20.1776945642436; Thu, 23 Apr 2026 05:00:42 -0700 (PDT) X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr256861585ad.20.1776945641792; Thu, 23 Apr 2026 05:00:41 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:41 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:06 +0530 Subject: [PATCH v2 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-2-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1339; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=i29lXDR220N9S/ZCltewSH2m1udYLebrd2wvWU1dcKI=; b=xeE+GZHhbHPYXGZ//YHmYFmemxBp85msmf6bNdSFq+mGc775eeXFdc8EWaFwwrGuU+8PW8+AD M/Mxj15Vd/iBIYFYMzdZWoX1K90Lp3POzb6/M6QHD2vAM7VGuVVHeuK X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX788EbUaVO8t2 Acf/LBIrQP1DNyLCoZFtbpEBGPPYPa1Od12/auNOfV6iw9JyEuMZG8O3hkyy6d8jLuqRBaDsaui otPobG+yX6dt7MAl+kR9/UAQbkwJMZnFzBmf1XD8JTcqaZXpUGaiFFn8o1kcRjT3JoCovFRqnkG whxCwSvUPxAP7Bxn8/AsM2u5E6p+AVyWN22e0SzjiRfcdAfCxlQqSbDeVNwYC+VTzIL5X+qx2Sp oEdFrHMCy/MK8xnI3tGK9cy1nRq4IQ7tFWNAsfzB2saa3dIazay4PhwSiGQVXewDmArgIpcidyi qZLOYobz867YHbuyc0EIkVGYauc1WukE861d9xXAxiVB7BG2TyY1H0T/gfHQSsXoMJYGbzoVzV+ xdFzCKuoJGM5Fe0KRlAQoniPczNmPDSWtvAbFIaZtZObiZIioVO06IA+53kz//nrtfuGYsHDawP U4suEGIJNJUG3TQQfMQ== X-Proofpoint-ORIG-GUID: m9FAU3w-zYqhfTCBmWwJVynXxzaFaObG X-Proofpoint-GUID: m9FAU3w-zYqhfTCBmWwJVynXxzaFaObG X-Authority-Analysis: v=2.4 cv=f5J4wuyM c=1 sm=1 tr=0 ts=69ea09eb cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=xFg6UwmA3-Dp8VzUGb0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 The state=E2=80=91change debug log in iris_inst_change_state() always print= s the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub=E2=80=91state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index d14472414750dc7edc4834f32a51f2c5adc3762e..e991f34916ec6e74f3d2cf98bd6= 1b8b1e12a3ca8 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; =20 change_state: - inst->state =3D request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state =3D request_state; =20 return 0; } --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821883EBF37 for ; Thu, 23 Apr 2026 12:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945650; cv=none; b=u1QY82gqRnLy6H03XwOxvz4jglPjKKgtT1Tz3MshypKRw/7sF3nvImtgnkAQmFpMpuKKuTq5dYhUxGBe5IZO4xNJRiifbw0F8ASJjgdiW836O0iswuM2XOkll8m3zpTvMF/ER6Uhq1rBB41FzrmcW+PQdhOvJ69C7onLoziF2a0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945650; c=relaxed/simple; bh=YmQXvtkYvIze5TqdErB6gc5at7BcNjGJMakZ7uOJLvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BhXoQuWZjovKe47Tcid/57g3BmrRoYMSqXQeSqrk3jaHit+Bd/RAl/bjLUasj/e1dzcGUZtYQ6spo1CNC+2nZudRdRG+BXDdOZ1YLVGfNztusurGBVIvwuKZHSr6aQQQzDgwnoi2CcAB8ZFSjYO59jBp9QcJQhWNlNAaHGwURi8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UDMbyINx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JTnS2v8p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UDMbyINx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JTnS2v8p" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uEP53044072 for ; Thu, 23 Apr 2026 12:00:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=UDMbyINxPeKxhxPJ 8zWcK6eiU9XewZV4cKRGdj5Y2heZwa9MLKo8tx7pPXJjKi7vVRPdNQYNDvOVE4as fWnij5yUeW4XMv/u/Buiw4cNI55dWYUiN2wr9Qya4agR1QkmY4NnnNpnMBJ3DWft D5QEz6LV+74dRcSFu7giAOWXWE8qx4L98FIzMYmFr+Rtwj4jesJblMF52Zf3IiXx i0uB63dunLAFzjU5F3xjBCkx21Tp4teEUqLL6ELzhqpYWWIZyYrbFqgJvFvdkb8Z WFmMpdQ4y0/7LQrty9TO0YKM5DTbS89o8Mik0OPklC8AfGksx4qz2sjxZMK1AZMf WDK/hA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3rva-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:48 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b4654f9bb6so69230585ad.2 for ; Thu, 23 Apr 2026 05:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945647; x=1777550447; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=JTnS2v8pWLI9OUdSmM2ECqOA5Vt5bL9+q3JApodDs7/8LJyXkHNo7Z5YZ1Zy9lgzp6 vyypNf8BjaDViYpMl4zntvhhO2Y26pDjxfm8xEykGXG8QuLTv3TA7sNgKkRU18H5QSQs yI5q0tANqRggiQuko+ywF9v9qBfzYlyYBuhwH49J7oiT7KBhffCkJ/5KexX1rGYS2l09 LWUp3iZ+zsIyqSjFF41RIFwjBHgVMXSicFqLt1yUrHWiv+sz4mF1QXrwUGuIZZ88qocl sdt4g8YGc0sM9j+yoSiBs2BMlGGreWvSnNbHlJppUS9LWhmaITYL1Haa3WNm9rl1XqW9 yKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945647; x=1777550447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R8N1jbkdytVOL6T6kzcN2pMzXZVTuqMNODxZcTrhm10=; b=PZiaM8NmMuLOYGH/Erqz8+f7utgWVj3Uf7ZQSnYlsHcVZs/gmfEq9ngbhIo+svPHvS oDlY0QmeLLJNGgAr/bnMhsmCMSbEVSu7AjURav7+p+WkFyKEq19pk1bx+vWMlxIE+K0l XfrDT6NDtQfUJHDqgItckBb8yqmLR34CfjpM3WR7w1dV/qJq5i/KBrKSCVNi+lwDC1KR a3JUNNEqxZTxlG14R7XBLq70ujIcPRLyDtuhTyKxcRj/lUvMRnc0+H57USsyA0RZpgQy /YXeHfOkZH+EpKv0oomAr6YPAr05m1lZTiM2sBXbIJsc8QOBjmhfxPvhPrnYcoMKjllk g/Hg== X-Forwarded-Encrypted: i=1; AFNElJ/Yjnb0rwst2OoXoBoP/vMKnpTuLVAFg1JbTewNITYNhXARC7hb1BfiYtTRqzdDRwdZD2m1IciiphQftY8=@vger.kernel.org X-Gm-Message-State: AOJu0YxigPquQ2klkzVxzFPXu+9LUOlpW9kEWDZsmue5pj1t17d1hEIX ZsgtWCLowvH5W/Tod9ugTkIqc7Cif1YY6inqx203S/QtdNXdOH486WeQuTyDyEg1NamJLBZiXsB NNHV6DKbx7y6WkBgiQCKHKO8nc0KmO7eKnXRJHeEJCLvtfwkPgjGOss/W05AJXxuqHDo= X-Gm-Gg: AeBDievv6YJO5voby3zHWgInmye6TK65Ge1M/E2/S46nAI1M0iTT4lTSYwtrHGwYyJN Q0BkEmhgxNuP6RMPjZ3blVePNm6w91dg1GYv+8qtOodMEZK93SJbWi1dGnlS7DlP6bBQXogxwjq +7NB5e3nPgw//8AHoju6wbOTBrC9ZfC+32If+LXao8s5Kmd1y2mBXcWxFh4QFMyyk7xC4lukghW IlO1NFZpTaoGsg2tAVkeixEwOCrRCCBIWa3GiBtDu190rbwXDX9UUZb93GURmOWyB3HB/ke/NBr zg5uckL6mFEQAoB/Jd9L0OWTMvzLp4Bj0GFViTgxa6IHNDCA4eHonl8fsMklQPx94V1vG7mxSFV /KgJGXSy9erESrJeCSfu3ibizgaCce2JIMZr1WTI1xNDH81ywgX2yK7WPIRkmIjMvZBz3TA== X-Received: by 2002:a17:903:b8f:b0:2b2:5857:583e with SMTP id d9443c01a7336-2b5f9fc0641mr279156765ad.31.1776945647182; Thu, 23 Apr 2026 05:00:47 -0700 (PDT) X-Received: by 2002:a17:903:b8f:b0:2b2:5857:583e with SMTP id d9443c01a7336-2b5f9fc0641mr279156065ad.31.1776945646343; Thu, 23 Apr 2026 05:00:46 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:45 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:07 +0530 Subject: [PATCH v2 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-3-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1245; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=YmQXvtkYvIze5TqdErB6gc5at7BcNjGJMakZ7uOJLvU=; b=CicWEKM32YbJeZj+8rDmclj4jgAMm2g2Xo00NlYwdv1tBeeNIwPsJ3PubdoF/sp2WdCF/ufXi jwKsVsGl7vmDJ2kHFB58jS90/aSacL9BuxKJ7RuYxx2jMDGvSAYPwTB X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX1DcDVik593cw INBm1ydlpWznNYRr6OrjEKWflx3bh70v7JKWcRaTTGBeBsAKfGkupMbt8qgjbvlHFb677N5f2yf q/+v5hXF5isCCY42Bghxfcw//ivUW9ULJiLRxAKz8LvyhFuxvKI89xmSIzCgjlcR6s2ugZGIuqm lvuxVuQnhXvDUff1To0/avDdX/QvfVrM+7I4qzv2+SLWBAZJfidsT5+HvvT97FDeZD73KOUBOxr cKS3mgxWp2K9FGlrwhDNHJDcDo5so6i5Gxt0+iblulegOJyUqJYEX+tw44VWdwXh1G9wHY9U4cp dtZExRxXiKPLsGl+thBmTeV2phIbw1oLsKpN9K9EgIHahBHK/1RCQiQ5xakNIF4hErr5rHdJTt1 s83yWojdUGtTeyE4rCA/WkKEWHcRr8HFam53Da+Nun2V7jS8aoHLMqgIz/n5UZHVTb5FCTJARpX Bio5uhu9cOh1bqJ+28A== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69ea09f0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=cLE5npzMka_F6uTWaO8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: YDR3WA2z9kZ9FSgt0Q5EiMzMN98PIZwQ X-Proofpoint-ORIG-GUID: YDR3WA2z9kZ9FSgt0Q5EiMzMN98PIZwQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 iris_allow_cmd() incorrectly checks a sub=E2=80=91state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8..5552725c614ea2e336e25489827= 0302fafa646c3 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd =3D=3D V4L2_DEC_CMD_STOP || cmd =3D=3D V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state !=3D IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } =20 --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43443ECBCE for ; Thu, 23 Apr 2026 12:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945655; cv=none; b=c0a4tvgFIINCYB4K5wzFNL+fjAnJY6K7xtiU/nvf4rpp5Dm9SD4DKj+TPogoezhh9FvAovBPQqs1M7F4VraJCtmS1r7iwHj5akLlErLpQpXGGrxI3VUr0uSdmtkuRHhxpHRpLYDqzn9JDxpy/Xlf53zRnqPgCZypTLpI5n7NQ8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945655; c=relaxed/simple; bh=6erPIlXGx13GlJZwWabtQ127np/SDC9i/rMkHX7eIHM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p5Tvvw6GDK62A0FRMRADLyaJCOI1EUe54F9Xpg1vh6lyximE0jD7TgsLx/pyamdBHdmibVmC8wvSFjtWsPERs9rT0us3Xb+QW6stS3p76ZVbT9KukIBNDHlrX0q3L6uX8Wzj6K2ClGknrylLaZdZKd7Gga+8PSsPSIDo9SPlECM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GqO/A+Wg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eiQ62Q1M; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GqO/A+Wg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eiQ62Q1M" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uMeQ987864 for ; Thu, 23 Apr 2026 12:00:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cbQ90sXiYZv9VCLd9FROakxbCP8MmB1zAyP6+Do3MCg=; b=GqO/A+WgGXGd2GTS YXXdneToYWIa7Ogl/yZV3jhp8/AKH/Nd1d3OxwKyoNiYgvZcZKQtB6exto8aHXpX ywkWfwJ4Vq5PUYI0awQsG468orCI93gyWkUh5hh6annJTCe1j8xPPUkt+nu0U/uj eFAe5uk0DzMg4WLYTL98m5VPupWqrO/TRL3ZRnuDNwiPf0YistsmNCmDpY16IKp8 U+WU+xy6HVY1JM+qnF9KZuYlw+V48d1Q22W6Xizu8I7wW0kt8y/A0fbJVwajL/af dYBnUbKijn/YfF19FRmPAoVZdF8E9I0g8EImRrKTLslTUu9n87Oi7YFUNwcGPVh+ h3jIug== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16q3u4q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:52 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aad5fec175so92503255ad.2 for ; Thu, 23 Apr 2026 05:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945652; x=1777550452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cbQ90sXiYZv9VCLd9FROakxbCP8MmB1zAyP6+Do3MCg=; b=eiQ62Q1Mq/akqDz/mOPkK5zKsJUN5uNeoFk5jGDDfjKpC7LZ9m+oVJWUii/zfzgP+D H616rD1sCpIHtey8J64QKPP0EyeMxP2aZJGUqztRCQHHE0I2H9ufdPk1whUdYY0+JoTZ hp55EUAjXs0mDfIeLN/bzaa3iRmrhWKEd44d9+mzPUn27CC3IdbQyRvJ2NbpCrCUksnT BkHar9Nek9+cB2Q5muA6vZ7Tjf1h3T03a//bt7Ug1rrUbbmshRqy1prlpHw2Z8vTm9em JrIy0lv+8IZCun4Cm/sMxShqRPRwADZ6aXlLeFtd9FGh8gj8uMep1+n6oI4WdITX6EiA LgbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945652; x=1777550452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cbQ90sXiYZv9VCLd9FROakxbCP8MmB1zAyP6+Do3MCg=; b=MyMr+YpGmzPo5tSpvT9TlH732JK2rgC5ia7HD8RqBN6f4rEpFyiYiCEyndaR8OEqlA PTWp/Ep6xjEuSFWYkIR3DuS08FjjAxZGtekQlEvG/GzFiVzosRR1r5S/gxX4o47RqHYi fKLqPrDNcUwAWhTL88/dmJhC4mMxdV4Bn4+ya89H3Ee3Rdzz2YuvFrT6yvZWjFt7Wf0I BxpEihFTDHXVhppzKhg1xdc2J9F7U34/giltr7dgx0ZqufYGl2EYtNz4QXp7nZfGxDuo 6Xr9c5zuZYeXvTZzz4NT1//7Vm4gSulkqQ5YcVxt6lY+JaqPasHcM6tk9kobn/doN8Dr ERLw== X-Forwarded-Encrypted: i=1; AFNElJ9tr1Hd4e20FPHeEpO3ZNV9OChmo95J8lqihsugRktiSCba8056Joab9KP80i9eyZfODbp5B58mFHniTVc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2A2vfBCv4hzZNBX67cLAk+pYJQe1p9Hu9PrSA4+4VGVzOvo/3 YDY9g+iGzv0CfVjU3LxahwW7RYIxZxKFqigKUgbcspVQwbQDRIAqbf7hu18UCSogB/hyPK/mIyG 7j3WlsY3ogqpNXtguZPO2zBTxOASri8CbKPUHzYIHrMIyvMy++WQXfrr5WJeVWh+IPq8= X-Gm-Gg: AeBDieuknM7aMSc/avQ1v8axkwPNVenzzAEnGsTXLdwpE13d76ZyROymGRFhi7md22c PaMhAwTCmakMc0KzKY1WjEg0fblGEzNdhBuAL7OqKNWuG4F1dWiwvIX2TvsAnm4Ta5/CBRDwQKm A5E71u11FVkwk3eWxwu9reXAZLkDHkPUMCZ+oBySaPfIKLTcbP7wKHhYenJj4HQnhjDQ3jE48+s qX+r5QWTp1P1jEHAkX2N9E6bzEaPLJNOy0jREWN8alkn5TceGe7RpzSTOR43e+KxiZEZ6BRu3jp 1T13SnwjjaY//2gKqihpf1nu5cJbwzEizoV/Tc9WcurTYweiCPkITLF78TN5kcwAyZuZ7APUdZi so8AQMhmVFhd4cO5zZXWoBEeRMbYBNIKsJiXtA2+bx//rbA/3mGS+Eckpgfji1DypMNVcXg== X-Received: by 2002:a17:902:9342:b0:2b0:a980:3687 with SMTP id d9443c01a7336-2b5f9eb06f8mr207924715ad.3.1776945651469; Thu, 23 Apr 2026 05:00:51 -0700 (PDT) X-Received: by 2002:a17:902:9342:b0:2b0:a980:3687 with SMTP id d9443c01a7336-2b5f9eb06f8mr207924205ad.3.1776945650856; Thu, 23 Apr 2026 05:00:50 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:50 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:08 +0530 Subject: [PATCH v2 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-4-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1321; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=6erPIlXGx13GlJZwWabtQ127np/SDC9i/rMkHX7eIHM=; b=KvFXP2o4HqAnoKvG0uWQ3CIArqpVh9HUWwK6d7xBDzErjhMCHTveDAwooAfI2ZwweckiQapzj iEbGDGXZjBwBe360+Z2RA5nH8QSQNLzKusfPnLdbTqxO3X9E9XPEVgO X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Authority-Analysis: v=2.4 cv=KPNqylFo c=1 sm=1 tr=0 ts=69ea09f4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=7A-KeLSbcoVXy4yL1OsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: N2QP1qEbRep9sCUPjBdWbi_djPiQ9pVm X-Proofpoint-ORIG-GUID: N2QP1qEbRep9sCUPjBdWbi_djPiQ9pVm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfXz5rufQZoJq/l FEKDWwRhaLx9pCr9DhVslbACcvIc2Qlbqkfm3slnlOtROHWTVQky4kKR4CZN+iVAWcBhAQsI9s1 kDbQDKTzcckmhK/4y2TjGG0i5MlQHo39XcdYs0A7M/0CGfZZNZRYCv+7nmxo05dNo9JEOWTz4KQ AqpHVcr1a3Fkea0dMcne0d5bXL8SSLVdUN327kla6dQDaF9Nq+IAS8Rcjdu2zovsRW5MQY+xuWo wStjf2RBMdXhjVs6aEa5TcShb5oy5a/26wfYlGVKXEKwGySV2zrFcUO2dCUQRH8OMwWrBS2lste iwacvVGE+McGq4QzK5op85obs53j5o1sdsCKLONcGtzpziZb85A/6f6RzlNPAghWTgFiuuzqCbx R3HNgXcIMM9uf+o2rOuWm+Rb/mro34+Hp0zumXkdjh7t4bmcfWpleLsWQr0JgBCkpX2B/V2eQwo oVAEyemqkGJeA5vu63g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 Fold the ternary initialiser directly into the variable declaration, removing the dead store that was immediately overwritten. Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 30bfd90d423ba024caf6ececc827f7102e8f3324..bbecee1cc2d02a8283b3465afa6= 86319792d98c7 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst *in= st, u32 plane) { u32 port =3D iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLA= NE); struct iris_inst_hfi_gen2 *inst_hfi_gen2 =3D to_iris_inst_hfi_gen2(inst); - u32 tier =3D inst->fw_caps[TIER].value; + u32 tier_cap =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? TIER_AV1 : TIER; + u32 tier =3D inst->fw_caps[tier_cap].value; =20 - tier =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_AV1].= value : - inst->fw_caps[TIER].value; inst_hfi_gen2->src_subcr_params.tier =3D tier; =20 return iris_hfi_gen2_session_set_property(inst, --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B16F3ED117 for ; Thu, 23 Apr 2026 12:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945661; cv=none; b=hY42O0PzgVZDnXD9aR0E8lWcUdhsFSLPoypc0FKb32lesN1XAYhIkMbFPxTY/+f8PLYCGYKtgyEoPgg/R4K/+nUlSc+mDWzOWgc5FJ3Ruoyq8vyMZwFZ1+32i3QxPqWp1AegEVz94W6kLe3bukPznt+Xh5HGDCAUVU3Zkkd1I9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945661; c=relaxed/simple; bh=sQLrP2R+ayqIMN4Y0Qvfw1jSXTWgtZe2Gt3wtSGJnbM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ceyKUMztGFd3r4DMeajxxjnb+nbCYv8Pv5D1ndkadqKJv6S2zwBdUfXMFN8Nl/lbAUUJa3GA21UFqU4F52FVlYi5yl4UgIzMgJYGDFENtW6kNafEY0aK0pFQay3sXih3bAuVMer6dYHMnnuh1Uz8tJHcCjocs7Zrn6C5Ac6a52w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lxj1HHni; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZdKKlpk2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lxj1HHni"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZdKKlpk2" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uNMt1565810 for ; Thu, 23 Apr 2026 12:00:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jkn3LpTIrdDz42ur7AeOGZMVRe40daDRbFlXQrDd3X8=; b=lxj1HHniDK/0snW7 FygrDycC3kGRxJiNppCqgUH24bjl4Od9ITRuiIhwmxD07DoPyTd861iHdiWNVp8c 9Q8MqYx9aFzxxx2tVPi8jV9mCczdmANdb5kWjbgfOkoTpX1w45p3+QIyogLUfrU2 eLmVuxPnJqVdk458dnkMegKFQNFwLCxPpBkHfQ3WQ61TVtbq3uTBYNgAiwmSy2aU X9kkXG7Bcu7UyAKz8ByQEfJVrGum+tH+ac9LYk7RMgSAoAZc6XooHaNEoNGRt8CH uDGnv5Y5HLADF9PKlTLFPsgLw9j9Meex/31G65EUPDPJhG6K9o9Z9HNzNIlQHEbP 9q61Cg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq16wuwgc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:00:58 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2eba42b8dso59363275ad.0 for ; Thu, 23 Apr 2026 05:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945658; x=1777550458; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jkn3LpTIrdDz42ur7AeOGZMVRe40daDRbFlXQrDd3X8=; b=ZdKKlpk209JOBXtQPdNQPZP1og4Zgtj/EADjMHD5S2Sk1zZ8Jo1ecO5V4hffJuDGg1 nlZkJns7sOVdWXOw8ZhCvmuFgEoQp6WN6arQr7VwfmJLTDZ+JzabxQM8VY0I83Yl9hPf yz8ODniLpEnxvAd3b4LfExc7EEtNwCON9UKfpHbzJjGVAvZ8qMAJ5PwxCVPg24rtKBqy dkRnpt59lYaETNMxKfaf0plI6f/va1BjAt47mBqPtA31d0sIszvTyNElzUtiJ5SV/Dg1 +bckH1dI/t6nPSGV3koUpN8b4Iw/4kVoJutISxBzFKvB4sG+mTp3L6CUU1HkzXOqp0aS 2Zcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945658; x=1777550458; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jkn3LpTIrdDz42ur7AeOGZMVRe40daDRbFlXQrDd3X8=; b=ewnlS5au9bGeyOCUI4wKhQH4V286xaGnSSnuksSPz+isDwg1JYawrcPbE2i+97WwS3 3ZbukUMwO1yGBANXSd1JGuYhi/fFemm+mpgMHkD24Hqu35Tu7NNi56K6L2oausrhso9C vnY12g6j+g+9vEDIlfdyXaYb9QnBLXnnenZpUn8gUpUP3Ap6Qx3LFFHXkcLKFCh4vpgl mD8aNzqDaC2OU5CX42wCSC9Cod42njO91yR/30WWSDgpsrKOSiXTqvFZOdJV4gqLbMDH sb/0jW8Ug4VDpBAZCerIuJLlb1HFJC30KSIFMueS3/qXrguHLVzoFfg57IGMjyNtCIzK Bdiw== X-Forwarded-Encrypted: i=1; AFNElJ87JU2ISDhtISAaISOnnYPPO+PK5HenMGDPEt8t7x7I6Ydpw7vxQF3yitFu6/1fjgCAeJeYs+SN9vAw8wo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6HVVTS0kJVRSdwNf3gDtqDj/CTUcuQT3DUkrfnk2Qds852CeQ IscJsgzansGFc7aH/oqO6BPYTSZPrUCMKnh3r2BPhp2nHZ5RKQHtU7LwyZGBCOzRMBBMw78a/hA wHiH8gEHh2HfvQsV1iu2oE4Ba2BpVLwwb6vAiyd5ncCZLkakWZJQ9TU9MNRKXa61cigw= X-Gm-Gg: AeBDiev/JJy8+JOFk45YYu4Y/N/8m+TG5r4aONJFBQ1F6vr4GOEQfj0rX/X5wSL0eWu WAJNL0ztgzgqEGuP2D1GfWSFhoKtpKXR31GRHuItwGh7g8sxo95eTnY2QaXFoH54GyUteIEz+Pu Sk7rVQb0LyXomHZRyEiPmUaN1X99zxiqoqY18Bqs9RRjpMYfCPdN2jFi4ZxSjO9JTQQq6IqeLhS Tb1Vo/9wVXipXy5OAKJm1cVdCna6aPZRpjjOr6bNSdao2EZh44XbqmhjR0tq6mLzKnhhme6mc3X sGcG0ssSkEut7LS9LnVKaOO4a7ahpf/2ipr4mi0/LDtDFH7NeXq4//xcWaQxWCqHZ2IjZg30pZf m1ILrkJRiUgQkJkvPWy/+Ru2UzLx3fMZgan66TxCMURYrX5nz6GKcbxxjMH/KH83HT60ZvQ== X-Received: by 2002:a17:903:166e:b0:2b0:a957:304 with SMTP id d9443c01a7336-2b5f9e85b42mr284954535ad.6.1776945656232; Thu, 23 Apr 2026 05:00:56 -0700 (PDT) X-Received: by 2002:a17:903:166e:b0:2b0:a957:304 with SMTP id d9443c01a7336-2b5f9e85b42mr284953925ad.6.1776945655576; Thu, 23 Apr 2026 05:00:55 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:55 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:09 +0530 Subject: [PATCH v2 5/7] media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-5-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1359; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=sQLrP2R+ayqIMN4Y0Qvfw1jSXTWgtZe2Gt3wtSGJnbM=; b=3cNEHUszUEwGzF2oPIFZak+dnNv05TzMRC52Bzl3lDmJ2hmBPxHfLOAKEVpqjZWrQA+DvasA3 bl2vqQsGptaD+HqV070ULVPDaWPO1Ts2gZrOAzC4repZcT7Guu6ysyd X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX2QUkuE1CwkKi a+K10Ksp1ygQCtFNzg2GVbrzbNtuS6JCg7cK9TqWKhyP8efhbYlGmeQDbhbJfyhsTPzRmTECHF7 fAjEDBaA4tluPddC/DvPPMz8o33BIHQAWm5M8FSJwzkh3BpNlWQB1P88B6rVjZmzBcm/zOPDUUH Hcyc8j7bn6lN0JxsnY+DJc/xZpYd8Aly9yTmewfofG5Qe+bPQDgS6Hf4GjzEFnVJq/ZV3OBUhyt STFz5WHaJO+H/CBVesYMxqHYXnkdfz+hSVmm3YSZERFe6XMOUtf819kkKwPnqRgukxixOUmcj8b 24Hcbrus1dnltNM1S+BZYeVFHETqsl1pA7dKqWV3zKO0Ku0voVZx3AWLe2zGSlbzm1BrcKBtIp+ mlTxQaS3OIasAzI2LzrI3Dqr1/gO7su/SU/V0KSTAuwbWHBWXBohrkSRT3ypJAqHdWZpRz4jkuu NveBOFLccokzTdcDY7Q== X-Authority-Analysis: v=2.4 cv=dL+WXuZb c=1 sm=1 tr=0 ts=69ea09fb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=jSGZT_DOcC9zL5wkuQYA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: 2xsVdBfQXpldjmWSXTWqTtAO2nWB4Cag X-Proofpoint-ORIG-GUID: 2xsVdBfQXpldjmWSXTWqTtAO2nWB4Cag X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 HFI_PROP_OPB_ENABLE/iris_hfi_gen2_set_opb_enable appeared twice in the dispatch table, causing the property to be sent to firmware twice on every config-params call. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index bbecee1cc2d02a8283b3465afa686319792d98c7..cf3386437102b814cf4b042a0a2= 7f25a886dcf36 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -623,7 +623,6 @@ static int iris_hfi_gen2_session_set_config_params(stru= ct iris_inst *inst, u32 p {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate = }, {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain = }, {HFI_PROP_AV1_SUPER_BLOCK_ENABLED, iris_hfi_gen2_set_super_block = }, - {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable = }, }; =20 if (inst->domain =3D=3D DECODER) { --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEB63EC2EF for ; Thu, 23 Apr 2026 12:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945665; cv=none; b=OKqrlO6uYTf1d/QPm1UqHyuXZ/+LKTP9nGV4cmoqn0MxI7bALZINmXBb9w2M+90EShxWH+xaTU3fWCl7eUGM9CG9NpYj4WJ+POBCyZFQ9TjS9vHWhkrvC+d7OZSEgwiPTzwWPVANm0Xms5TF1BDSBIdWugfeaNwZhOTvPaP7MgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945665; c=relaxed/simple; bh=HeQbfzBZxtAvx8sqFyD8eutBlpfwbgcN8L7xmMcTs+4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P8XtLNMOFChpuZPDeuRxfQekWqLqeJxAaVKThCgzMXtWROujiPVj5GnZ331rmfmesojwx4jXV8X+4sycGzjQm9cl4nFqi2oYatYtqYoOdXCcI6P5ZXScq3nM746GMB397UWNGt4l0LKJfEFOfKFFL1SjMAKBc8YMQMY9+B+ub18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n7c2DpDM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T6TV21bG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n7c2DpDM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T6TV21bG" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u43R3769013 for ; Thu, 23 Apr 2026 12:01:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DWu+M18Oh4d1GMifcY3gZ9BMwszgGFVkypbPKVidZrU=; b=n7c2DpDMENbdI0sa +lT1nQZNEnnswgXt8ucfdHMKRu5TX0OGaDf700iTylJrifGL369rjY3aY2dG3YDR RUeM7w6A7TFQf/1ydEOYIIJmBsaOmTD+Zr83acH27y+XCSg66Ued3tgF+jzo77In UlVuo7V1YPm0qsOjqvIfnCnd5dwbDTzOerN55bZ39pRIcz82czhChHKPldmww1ps RieOS6+hwV82EQz/47wCslieDuIOJ9iMnfeOF0OT9+Pd8GeSTT2NpH+LQFJH4HFE ReSXTBuIO+O2mvZyGchcGNvwVQJC9Ldfjx/u2XzyceeHYZru+2x2yMp6QPaCUxXR YvU5Fg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hq3rhd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:01:03 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b79f4b35b7so7025255ad.0 for ; Thu, 23 Apr 2026 05:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945662; x=1777550462; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DWu+M18Oh4d1GMifcY3gZ9BMwszgGFVkypbPKVidZrU=; b=T6TV21bGJ2SQGZMJ2Xh7Fx0cQ55KhmEXBlPyHFoYceO6Gp6grCAAMB8ZH/EXUCCRTt oP0snoe8QlCk8kUWKzu59V2JdWQtj+j1jeiM055pIhAMGVy1dn5s+I5Fke4d/PGH2PSX urbFqodp4rNoUumbrdvvShvlaTfLqHDKOPR6d01dV3vpIbJ+2/U8PaqyalekuVMv8qtv Z0m/JSD1RSxr2e3YOqKvXY2Rlh0nsafyBvQbXmQ+M9Mc6ounqYpE1JxqaY7IQl/tQQzw dfjF77NoiYAw20GxAPXCH4YKSsTQynMOtS0l56iSISG4D9m0+XqVRCkAhD+hHCrjC8hv Hhbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945662; x=1777550462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DWu+M18Oh4d1GMifcY3gZ9BMwszgGFVkypbPKVidZrU=; b=EU40+i/YyaHybiQcTX3O98AkQL4nb36Raz1S3j04VVGzxtywxvMENVC8IRIW8IISi5 n6hFiYZ0qIEwcBQDhjBHqO2aLH308jZ+715vsf/FFbbDjVYXtrYsOgOIdkPi3xOJxxLu LWwwmgJr52bwh4qjoIne1vtmMK7hd61Wd9eSJ6lHCTdlwN80992JOL0Mek0IEyJP+NP6 qMfmLsEue8ptj3Y1Ch1fYlZfspW24Ygfh1WB29rwcmXInoQEuu4IQIAgMF+En8IRRWCb pRHlmoTOLc5ro+wQPOTCP8z8P+A8jnpgFZySdQL8qS6ZGsUaBuNUXJPio0oBPCRTkE78 To2Q== X-Forwarded-Encrypted: i=1; AFNElJ/SBGlf6DckGxmUjhQ91Tg3VB68RW5d9zIZUs1+ktNqQEcq+KcmqTlRQRRvdSxCtFgctZLL+/jRCL4Jmc0=@vger.kernel.org X-Gm-Message-State: AOJu0YzU7lR3tknnKU2o2xaXbAVHR+COTplH1Dsq0ckxsPuLsQUGacWS 2lnapl5jMFLS36LlyaohxwOP5s2CuUFCridb1lnePmU38hLQhPmBol4vlTp74uI/adTHwjCs0xr OQb0XUBpt5pVJm89uClubQM1xeeaqoSU/or7FnzP7ah4vC5vRJC/mmlw3X9MvIZb6ANE= X-Gm-Gg: AeBDiesNC0f8WRYT9+81EdpPwOnHTy+Ew+EC6mjVQOKTJ/hPATdggPW5tPvv1SXIISG 3n4eIK9YTU7vSiOpCZAndhGfQKBLIEuFGWBrwj6rowohqg1Gp+73YKBfDEhgpD8dvFjIWHJI7Fj CIvXSzZS+ISLS0FL5FLf1VdIuQr7wDfgz/JzWlHlw45G/hwQDnieZIj7XGCXpvqmqM0/kZttitS S/bAsUemUjrxZE2kebez0m3jNKVxYBio6HLDxoE8f2b98eLpXLck3tsdnnuRWrJkX0hH9hl9Oob seWc23hjky7M4b8vHY8h6cELQsH/s2O4DDnJHpKGuHvFWb/P5STmyR9BWkJ2sHl9RD3XAOjVzyH MEYzwfBERUeEX6EQh/opDIsCbE306r1hoOcGAb3O5FUyJzxKKjhsTxtNqpc35WTHfH/RLlg== X-Received: by 2002:a17:902:ce09:b0:2b4:5d87:a1fd with SMTP id d9443c01a7336-2b5f9fd21c5mr281095165ad.27.1776945661770; Thu, 23 Apr 2026 05:01:01 -0700 (PDT) X-Received: by 2002:a17:902:ce09:b0:2b4:5d87:a1fd with SMTP id d9443c01a7336-2b5f9fd21c5mr281093675ad.27.1776945660319; Thu, 23 Apr 2026 05:01:00 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:00:59 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:10 +0530 Subject: [PATCH v2 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-6-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=1002; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=HeQbfzBZxtAvx8sqFyD8eutBlpfwbgcN8L7xmMcTs+4=; b=MFvb/avwBQUHw1mATjVUho0TncKBj6ZokRDF4/aZOYG11kpwd6toJbTYSSs2elkAbj4U1CX5M FeqFDF1noxsBhEfT5qgpmw63n72ftCdKD28DQHc1Tf9L/K7jTGEvdVv X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX8T4C/jo85mue 9NxAwqos4vq0ajfqx+oU27LZq6jIsOOhIXtTmNQGIz2PmXmq8b4sD15KUO4a8vL9Ay6YKhQCVck oMW3RsIey1di+uOCS/aMUFbPNhjhqqdHfxxkFJvE3+D9qZO/kNg9aMBg1FZqAjvmirTHOsmopLD hWZmY2aEHizqP6mAaeLR3l2l/cSiOloMYU+3lVAUV+P9Al3+Rgd9wtfgpelAmkqi79641L3AP4D +QpNU2oLURvN9CaxT9Hiz/z/2Zoae9Q4nrCIKAJZDV32Ztf3d/M0Zs+N1E0BBRm1l9QhwcbD34Q DfnW6p9FF/Ckkyq6p2dfcJ4mrY3nQ6HiJk62qywFOrbW/YRe66YXPnmAhVJslEi/8zgkjz0XzzZ ujy+a5/rv9yUsk/jd/WkMt37uEXTxgyh/IzgOymfWZdW2/m4gD5ESXvAoM+qiSl0IyXsFst7GxR zxOGINr6/aKH9UcaWng== X-Proofpoint-ORIG-GUID: jyhN3bgyaZn8dFhQczLLOotGMV5b3Xr3 X-Proofpoint-GUID: jyhN3bgyaZn8dFhQczLLOotGMV5b3Xr3 X-Authority-Analysis: v=2.4 cv=TJt1jVla c=1 sm=1 tr=0 ts=69ea09ff cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=TZpohm96M3O9q7pB9U4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 Without the break the AV1 case falls through, risking unintended behaviour if new cases are added after it. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index cf3386437102b814cf4b042a0a27f25a886dcf36..693fe3b34b078b12a738ae36fd1= 2e9b1edf4a13b 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -696,6 +696,7 @@ static int iris_hfi_gen2_session_set_codec(struct iris_= inst *inst) break; case V4L2_PIX_FMT_AV1: codec =3D HFI_CODEC_DECODE_AV1; + break; } =20 iris_hfi_gen2_packet_session_property(inst, --=20 2.34.1 From nobody Wed Jun 17 06:03:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97D4B3BD25A for ; Thu, 23 Apr 2026 12:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945672; cv=none; b=hcZXmza593XpXYfcurInfDkiwmSSYOwDT8IHRDWM0S7jfBqGFmERiN9ZDQyDApHPOgS3kmAovw3GC7Y4k16fsHHZYflTCD09CQTK6Hma10pl/ldsVjDZCFNeAnaNv6o5jomafWq+9yESo0bSHpAnVIMdnGVRbl9B/aXPD3wteoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776945672; c=relaxed/simple; bh=LYwZO2ou7DHYoL0tkPw/Y4um6kGHBm+U1RyH6lTuf80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QuIV5PPhj/Hp01kVskb7XIUcm6lsGhvItS4yjlYMJFqiY2ErNuvKOTVaM41LGW0HUWZgcDcfCKKpTv2W5hBFkpqkIEsgT7WFIVdsbCP9dURxd9T+qQXIBUKcsYACd8Ozdz3hAHjdaIlNbn9pAqf9E4Hf79iGVHss8AAFRf52HB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PlsvOcNe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BBtZeE/7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PlsvOcNe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BBtZeE/7" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N94gQh2319297 for ; Thu, 23 Apr 2026 12:01:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=PlsvOcNeaEt6+Dfn heTGZZ/VEa7JQbMn3n9B1NLOrNkNknje4NDKuUEbpHpZh3myvSVAtpq5RfLXi2oC qkxp7gi+yzlUbxKLwgjrvXDKkcCSAkhIDf1Pi0zuckniZeZ6Pk3lxRx8lQLNAPYK oPo/hbnBB7F3u1gnnlZoqGPVKeNJvA9/OUc+PlC529DwJo2D/gsKE56CRY+e22o5 4cMw8Lg9cD/RDpbirtkJvwZIMFNGfYqhMI1EQ80bQ0RkME8A3IGOwooCuthaJods RAaN1S/ueSOcnEJrHa1qFuQc9xGyfpXSplma5QBAffCGNZU5aeA14aU2VzbkZJz1 Bz+lRQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqgfsrq4p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 12:01:10 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b24e9b4d82so68146235ad.1 for ; Thu, 23 Apr 2026 05:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776945670; x=1777550470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=BBtZeE/70lBkFNzFPxaeuoK9qsyYcrA9F9nMffWSyCssQv1D5rfc3hQfvh6dqQLZGx L6bytkBFwsClCGpDSx5OODUd8+RwPv9Q/8l/T1H/M0vYq/1cdBAcX0zi6Or0QO/Rd+sf cZPh4I2BwxUdLZFNCVeIZXaRc/PJizkE2odyM/E/qJXyVJ9Niaq7q8+i5+hDPSxZY5BI OTw7hbC3tI1ABbWIUtA+2Gqp1AicrCRtFHgUnwQTL/Hy1BOdXOL3Dcb7LGbLbEuAEVjp 6eog6aW+fVQ4v1I7vXhBOJ7wzbqfalCCl7p9z5cYxCaxnI6n5QLCknZOxreONsi9nBYA IlOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776945670; x=1777550470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hWNO4fG1aSCsYkc2wD8k8eSJ2NDKUAaIuJR5mkEx0AQ=; b=tVYnTRuIVGoLqG3HU+JH5uouFZKcwlaY4TCZlTyAqInXt9rIT+NROCSWT6QAt1qg6G b3M2/040GVICzz/nFjTRc9ArWnOIXME2kfXLsxdC3vBMz5y4pLhnpnNrvuKsjRGl8QUC q7+6lBi7Bg8hscV0wPXr5pijeRZWtCOrpLpNtm8Zdi+UXnMo56qIt32jrBKQ6SD4ZV3o NJ2DmxrP2gytf0s7VwosPFDgQ0s1sKLh+lHl98NBkINPb6tl3nr68PcwbUktu8zuzUjU coW/PHsakYBnF7FwsyBP/E3p+dsKyrTzEQeYXO7+dYhl5+mXrj/jp3S8LDhbeMSRSLVO zO8g== X-Forwarded-Encrypted: i=1; AFNElJ9ZxhfHq7oKejWVq2YNORyB+SbcprF3nuBMMOb/1OozeTGwOQQBb3yTp8tT9+C1oIet9vNUnZLzKX+QPb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6wbLrUBRRvC6FgUjtUG5OV/12sBNcTMwMFR+OReTCUgI9umbU zGzRvECp0Rg1aSaesaJ6uF7P9UnLAfD7UhWdyGjhWY8wFowDOviNtncRVDMYx8f5osMXipDSMvV IGR1GLwcSU0ROxZtJbJjzZE/eIqUuiEhIjP7BX8/s3RTGUfVA34CbxG7EePScxH0gqwY= X-Gm-Gg: AeBDietfO2G6LwYuK+n1V5QSN4Lxr1Br01LacH/SJqbBFyPnWbti1W7/NVCBHMjJ1lH RYkEc8J0egQBUSLZl0HsmORuKxi1lEzm1nsX5714aYTscV9FgI4LBAV3Y7Unqcc9iN2SpHvyaPF SmZEhwI+9ocXYPdvZBdAJz4BWWIMDMfNezBUtsOGVO8ipRBLXiOtCjQKLRRL7a1y2mtpgcPAClV dAmuip+XR9vR6BEvBDqUlhvP0Vau9+C3qA+VbMx8Yt9YJ7jCQN5mxUSDzaJBkgmK46YmGFTQFOM Aioo4Z23OTls+EjIi6jmcJvJG0CqpkEUOs6ceIXTWTVXK9PXDDWtgtvOSdksulb/Xeycch1tIct PNoNjx70w8F7kfyWc+vWcfKz8F/J8uPdemX5NaBAcZfxsbeSPSUWK4QJw9kyW9VHbPgdEnA== X-Received: by 2002:a17:903:1b2b:b0:2b4:6529:7b9e with SMTP id d9443c01a7336-2b5f9e145a1mr234983095ad.12.1776945666119; Thu, 23 Apr 2026 05:01:06 -0700 (PDT) X-Received: by 2002:a17:903:1b2b:b0:2b4:6529:7b9e with SMTP id d9443c01a7336-2b5f9e145a1mr234982205ad.12.1776945665189; Thu, 23 Apr 2026 05:01:05 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa4f092sm194790355ad.36.2026.04.23.05.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 05:01:04 -0700 (PDT) From: Dikshita Agarwal Date: Thu, 23 Apr 2026 17:30:11 +0530 Subject: [PATCH v2 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260423-iris-code-improvement-v2-7-9e9cbf00f9c9@oss.qualcomm.com> References: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> In-Reply-To: <20260423-iris-code-improvement-v2-0-9e9cbf00f9c9@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776945627; l=5224; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=LYwZO2ou7DHYoL0tkPw/Y4um6kGHBm+U1RyH6lTuf80=; b=qzoPRQI/vaFBWmkZPwEdPm0gCzC09Q59QxumJrDtGj3tXtxfoNmW5MbOElbqB9qLWbvXmRhB5 zwldabj57WUAfkuajHVH7IrxR/TrOtu0m4OCRLqOYkcW21gFhOBEAhb X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: QckH17aKaHUkyBrje1vJ-SBfr1MWyIXe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExOSBTYWx0ZWRfX65XC1lCs2I4M LRZjQc85Gj9Bmgt4HFKLPb19YfeYjoQGMVVmVWGHiTDHJ/H7p0Hekwwqg6+uvyrQadVXAOvSc9w /R7wP4LrJmHc4cQX/VeIsgDvYyYu/5zxhnP9OaelpC/1V5tA3jQcELVoQYVC4Z+IfM6hMGzqxty 4QvuwqI+FLst2OnsfdfrBpUwPGc0xvZoRpV++Sd65y0e319ztiM8E4ZFPJ55NfBCLWd478SaZKd pZFzi9mWFL8YNljE7jgfZPNkbfmsEeo9V4odTJh685+1gNl1Lctat2dqqiBNyUQl4juNOW0bqus gVitoZ59a1DAK4iSS3Dji4W93rS1c2U7wiDqmZRuM5ss/6em4sXaMvwSWu/6cqiHURd4BJUpvGJ 9hAaUSYG45jv/KccldidbQqsGas3juo8yQ7wBr/2Kt9e87lYamExFRiFWatOcRc9HxXc+qwNd+y JafKDD2QXf1H5qIDQqg== X-Authority-Analysis: v=2.4 cv=AvbeGu9P c=1 sm=1 tr=0 ts=69ea0a06 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=CWBAsx5YQZKXPYp8bPkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: QckH17aKaHUkyBrje1vJ-SBfr1MWyIXe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230119 iris_destroy_internal_buffer() is guaranteed to succeed and never reports an error. Returning an int is misleading and forces callers to handle a meaningless status value. Convert it to return void to match its behavior and simplify callers. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_buffer.c | 16 ++++--------= ---- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 4 +++- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 5b31c511da6e735943e2561683016cb9414d760c..390a48d8cf788e17760f901a6a0= 73c5b9e5a9dc9 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -455,7 +455,7 @@ int iris_queue_internal_buffers(struct iris_inst *inst,= u32 plane) return 0; } =20 -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer) +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer) { struct iris_core *core =3D inst->core; =20 @@ -463,8 +463,6 @@ int iris_destroy_internal_buffer(struct iris_inst *inst= , struct iris_buffer *buf dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, buffer->device_addr, buffer->dma_attrs); kfree(buffer); - - return 0; } =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) @@ -473,7 +471,6 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; - int ret; =20 iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 @@ -488,9 +485,7 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool if (!force && buf->attr & BUF_ATTR_QUEUED) continue; =20 - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; + iris_destroy_internal_buffer(inst, buf); } } =20 @@ -500,11 +495,8 @@ static int iris_destroy_internal_buffers(struct iris_i= nst *inst, u32 plane, bool else buffers =3D &inst->buffers[BUF_ARP]; =20 - list_for_each_entry_safe(buf, next, &buffers->list, list) { - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; - } + list_for_each_entry_safe(buf, next, &buffers->list, list) + iris_destroy_internal_buffer(inst, buf); } =20 return 0; diff --git a/drivers/media/platform/qcom/iris/iris_buffer.h b/drivers/media= /platform/qcom/iris/iris_buffer.h index 75bb767761824c4c02e0df9b765896cc093be333..ab8e5d953101a786ade20540ee3= c3ed226160cbe 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.h +++ b/drivers/media/platform/qcom/iris/iris_buffer.h @@ -112,7 +112,7 @@ void iris_get_internal_buffers(struct iris_inst *inst, = u32 plane); int iris_create_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_deferred_buffers(struct iris_inst *inst, enum iris= _buffer_type buffer_type); -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer); +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer); int iris_destroy_all_internal_buffers(struct iris_inst *inst, u32 plane); int iris_destroy_dequeued_internal_buffers(struct iris_inst *inst, u32 pla= ne); int iris_alloc_and_queue_persist_bufs(struct iris_inst *inst, enum iris_bu= ffer_type buf_type); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index e42d17653c2c37f526e6b26c6e29cc45ae29a747..d1114e5ce7788c5e803ac7aec50= 5a6115997eb27 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -442,7 +442,7 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir =20 ret =3D iris_wait_for_session_response(inst, false); if (!ret) - ret =3D iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/dr= ivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index 8e19f61bbbf9e427f658471b4502bedb1ad5f616..f5c342f4c926a68b2017006a3c1= cfbb251605ae0 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -447,7 +447,9 @@ static int iris_hfi_gen2_handle_release_internal_buffer= (struct iris_inst *inst, =20 buf->attr &=3D ~BUF_ATTR_QUEUED; =20 - return iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); + + return 0; } =20 static int iris_hfi_gen2_handle_session_stop(struct iris_inst *inst, --=20 2.34.1