gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request()

[PATCH] gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request()

Posted by Felix Gu 2 months ago

In tegra_mipi_request(), when provider.np is not equal with args.np, it
returns without calling of_node_put(args.np), causing a reference leak.

Convert to use the existing goto out pattern to ensure proper cleanup.

Fixes: 767598d447aa ("gpu: host1x: mipi: Update tegra_mipi_request() to be node based")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/gpu/host1x/mipi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index 01513b775d89..988681423981 100644
--- a/drivers/gpu/host1x/mipi.c
+++ b/drivers/gpu/host1x/mipi.c
@@ -114,8 +114,10 @@ struct tegra_mipi_device *tegra_mipi_request(struct device *device,
 	if (err < 0)
 		return ERR_PTR(err);
 
-	if (provider.np != args.np)
-		return ERR_PTR(-ENODEV);
+	if (provider.np != args.np) {
+		err = -ENODEV;
+		goto out;
+	}
 
 	mipidev = kzalloc_obj(*mipidev);
 	if (!mipidev) {

---
base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659
change-id: 20260416-mipi-8dfb3cc647e4

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request()

Posted by Thierry Reding 2 weeks, 4 days ago

On Thu, Apr 16, 2026 at 08:09:29PM +0800, Felix Gu wrote:
> In tegra_mipi_request(), when provider.np is not equal with args.np, it
> returns without calling of_node_put(args.np), causing a reference leak.
> 
> Convert to use the existing goto out pattern to ensure proper cleanup.
> 
> Fixes: 767598d447aa ("gpu: host1x: mipi: Update tegra_mipi_request() to be node based")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
>  drivers/gpu/host1x/mipi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry