From nobody Tue Jun 16 05:08:09 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90B3B34D3BE for ; Thu, 16 Apr 2026 12:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776341374; cv=none; b=YsB0dcTin/LNBvRXiVchYtxNIy5Grmuvjg71hkYMRfhT2RaJij7mgiLA8ITwEp1/2tmprk+ThqeHV5NlDSEaRJhvUfgs0KUy5pQWvJojRghhQjqY22eTdFsgz0kgHqlR0+KFvA85/rjeWV9Esdsnh33bc3Rl7/kgZOIaxfGQaEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776341374; c=relaxed/simple; bh=knUH34kPAdl0Glqyp0IYrLw7Xc3rugSSyGH/rGCenqQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mYYcQKukeZMruH2a0/jnRf2Jr0vqMjuytsnlTNP5QJU9bUG9ed2hJQZmC1sMosAYbnKex567cucvs1ReYyySgprzoFKvPc3AjOmvluBRnS6Yqjd8QQ6zgMF6fx6HjFzyVnBUk6i5C7nDiU43Io2RUZke2lmH5GdK2fgcVYeyRko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cplZMRIY; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cplZMRIY" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c79467f124dso1578693a12.2 for ; Thu, 16 Apr 2026 05:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776341373; x=1776946173; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8l44xHaLOx+xTMPQRoRD77brBCTj78T5PJ1Dys9zxMU=; b=cplZMRIYnZWgs5WYg4ul6/69W6whZand3yF8bYY8pa28BQoXh4e8RacslSjzMlZTH9 uawGXarkqfJ+ql/L19r1b3GXQQySryFHlKR9++AzBHKTur/vf3Hi1ctr1ABfvr9Ak21r xNAaGz/cHhbi6+9gJplvuseVMNTWX1nSCUHIJ5T/DLVSfUsDTRXV6bfXxK+i6BXHcR7r JTUrsJ/U+Z2MtoSWPe0g4ASkoayUqcHBygC+m7yc93gYklmhsf0al0RbOi/4O2JY4pkA 7DrQh5zit//f5u1keH1ZzedtGghwPMbfIE8Iyrv/8IDReNG73fvsb106MiEu4h7xBWkp K77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776341373; x=1776946173; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8l44xHaLOx+xTMPQRoRD77brBCTj78T5PJ1Dys9zxMU=; b=hM+skx7ibqtvDf3nBRc7szy7XYuCOKTVX/fydVmDPijcdHT4CTupgu07uqekNXHiKl 5gH6T76aeHXIYN7/P3d1GBJWUnlIODnfxMbt2JvnAFOEvvJ6304B6+w0Wp0UxDZ33Cqg VhnMXiUvpU6SVWo2B8ntT7vryoBKEfR3fni7GjT2xtfU/UEP+CfDxtl9uY/ocwbuhsP/ t7qk2yG5tWvn50Wwy3pSND+R4DCsZu+cUryUj63AdbgUcCf5eQc+drDfHG2AItb4d8NS Cc8TDh1rVFerAsdCLEqb8GBtUQ12QJW3MtVxeB8WTm4sSLRaA+L40ynctU6DLgn2wPfj Hk1A== X-Forwarded-Encrypted: i=1; AFNElJ/Wy9SJei4Gxlv8+a5jEnFlIY5Tp1KTtwfPbX585n20THqQi1eTFPl3Zojmp1zBVf3QRIw/3ULZ3sfzUsw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLLxtSB1wyDrsK3OrrJy4l9hOFpD0zwa8+ElmOvjPorWjEsMMU +EbMrYcIaa9hOvs3l9w0NFU9kyhTFuPDE5HxOpCz6KkVSFDdnSXDCMmP X-Gm-Gg: AeBDieskDuddDu0G4p1n0koEdoLHYsq/4aN83h3sKhcyAtcWxOFXy85FX7TQ9GrUItt RQlXqKGO43iX3lVAbhhFEygzIxeaePsn0Vdw3withWb2KbqEbRO+UqV6sGkPmOb/l2sC5ptQ05g vvkaAPcm5l1mZyeM5wXmkvJjTV/A8jEnogpC7DCB5Q+caZGWrDgcehfOdXyLh4MpXla+6NqeKOw azdBwRzw3TuXx85vlp9uXJpglZON+9kq2SNf61kB9HYhszdZMKc/h1BlDUCayi2fe2NrkRV37za jX7+ibAdx1R5z7FGpGlDtgHUKdcBzYIrI5f//Rroke7OYXMd9I4h7YzkCquEOyx8ojRZ7ZMNkal YI5ue+t+iL1ZaPFnGhxIS0jAmeO+G01LztOWEep0eGfB23Sp7Qgm4UloxMjfgKqM5+NBg89uF7N 7JDWCJu3srYLaFskmT/cWvfDJ7KJEr5v+thDxRQhMUHemD9qMvcZhvgrqNqsrX4qOVGrNzuhfT7 Fo/QjQhlGinrz3pNyH2jo2Bnp5IHnA= X-Received: by 2002:a05:6300:6b08:b0:3a0:129a:973f with SMTP id adf61e73a8af0-3a0129a9ae6mr15918942637.52.1776341372798; Thu, 16 Apr 2026 05:09:32 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79581d6341sm4245089a12.30.2026.04.16.05.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 05:09:32 -0700 (PDT) From: Felix Gu Date: Thu, 16 Apr 2026 20:09:29 +0800 Subject: [PATCH] gpu: host1x: mipi: Fix device_node reference leak in tegra_mipi_request() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260416-mipi-v1-1-9c027175abdf@gmail.com> X-B4-Tracking: v=1; b=H4sIAHjR4GkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0Mz3dzMgkxdi5S0JOPkZDMT81QTJaDSgqLUtMwKsDHRsbW1ALbbWvN WAAAA X-Change-ID: 20260416-mipi-8dfb3cc647e4 To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Sowjanya Komatineni Cc: Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776341371; l=1103; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=knUH34kPAdl0Glqyp0IYrLw7Xc3rugSSyGH/rGCenqQ=; b=ufNI0wiXlc4OTOmmF0jxOLfRsiv8Bi35YYGkHIae5wkX/CW+StNB3w6KThINmGtHYzUbUOplE oltVs94d89BCzlnacTuP+TWPLL1gsEx0ZPZM0QE7qiWj8nQ0EB6728V X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In tegra_mipi_request(), when provider.np is not equal with args.np, it returns without calling of_node_put(args.np), causing a reference leak. Convert to use the existing goto out pattern to ensure proper cleanup. Fixes: 767598d447aa ("gpu: host1x: mipi: Update tegra_mipi_request() to be = node based") Signed-off-by: Felix Gu --- drivers/gpu/host1x/mipi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index 01513b775d89..988681423981 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -114,8 +114,10 @@ struct tegra_mipi_device *tegra_mipi_request(struct de= vice *device, if (err < 0) return ERR_PTR(err); =20 - if (provider.np !=3D args.np) - return ERR_PTR(-ENODEV); + if (provider.np !=3D args.np) { + err =3D -ENODEV; + goto out; + } =20 mipidev =3D kzalloc_obj(*mipidev); if (!mipidev) { --- base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659 change-id: 20260416-mipi-8dfb3cc647e4 Best regards, --=20 Felix Gu