[PATCH v2] staging: vme_user: add blank lines to struct fake_driver

Souradipto Das posted 1 patch 2 months ago
There is a newer version of this series
drivers/staging/vme_user/vme_fake.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2] staging: vme_user: add blank lines to struct fake_driver
Posted by Souradipto Das 2 months ago
Fix checkpatch.pl warnings regarding missing blank lines after
declarations. This improves readability by grouping related
Location Monitor variables together.

Signed-off-by: Souradipto Das <souradiptodas6@gmail.com>
---
 drivers/staging/vme_user/vme_fake.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index be4ad47ed526..7ec14bf15fbe 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,8 +67,10 @@ struct fake_driver {
 	unsigned long long lm_base;
 	u32 lm_aspace;
 	u32 lm_cycle;
+
 	void (*lm_callback[4])(void *);
 	void *lm_data[4];
+
 	struct tasklet_struct int_tasklet;
 	int int_level;
 	int int_statid;
-- 
2.52.0
Re: [PATCH v2] staging: vme_user: add blank lines to struct fake_driver
Posted by Greg KH 2 months ago
On Tue, Apr 14, 2026 at 02:32:17PM +0000, Souradipto Das wrote:
> Fix checkpatch.pl warnings regarding missing blank lines after
> declarations. This improves readability by grouping related
> Location Monitor variables together.
> 
> Signed-off-by: Souradipto Das <souradiptodas6@gmail.com>
> ---
>  drivers/staging/vme_user/vme_fake.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed526..7ec14bf15fbe 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,8 +67,10 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +
>  	void (*lm_callback[4])(void *);
>  	void *lm_data[4];
> +
>  	struct tasklet_struct int_tasklet;
>  	int int_level;
>  	int int_statid;
> -- 
> 2.52.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot