[PATCH v3] staging: vme_user: add blank lines to struct fake_driver

Souradipto Das posted 1 patch 2 months ago
drivers/staging/vme_user/vme_fake.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v3] staging: vme_user: add blank lines to struct fake_driver
Posted by Souradipto Das 2 months ago
Fix checkpatch.pl warnings regarding missing blank lines after
declarations. This improves readability by grouping related
Location Monitor variables together.

Signed-off-by: Souradipto Das <souradiptodas6@gmail.com>
---

v3:
  - Added this changelog (missing in v2).
  - No changes to code itself.
v2:
  - Fixed author name/email to use real identity.
  
 drivers/staging/vme_user/vme_fake.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index be4ad47ed526..7ec14bf15fbe 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,8 +67,10 @@ struct fake_driver {
 	unsigned long long lm_base;
 	u32 lm_aspace;
 	u32 lm_cycle;
+
 	void (*lm_callback[4])(void *);
 	void *lm_data[4];
+
 	struct tasklet_struct int_tasklet;
 	int int_level;
 	int int_statid;
-- 
2.52.0
Re: [PATCH v3] staging: vme_user: add blank lines to struct fake_driver
Posted by Joe Perches 2 months ago
On Tue, 2026-04-14 at 17:37 +0000, Souradipto Das wrote:
> Fix checkpatch.pl warnings regarding missing blank lines after
> declarations. This improves readability by grouping related
> Location Monitor variables together.
> 
> Signed-off-by: Souradipto Das <[souradiptodas6@gmail.com](mailto:souradiptodas6@gmail.com)>
> ---
> 
> v3:
>   - Added this changelog (missing in v2).
>   - No changes to code itself.
> v2:
>   - Fixed author name/email to use real identity.
>   
>  drivers/staging/vme_user/vme_fake.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed526..7ec14bf15fbe 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,8 +67,10 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +
>  	void (*lm_callback[4])(void *);
>  	void *lm_data[4];
> +
>  	struct tasklet_struct int_tasklet;
>  	int int_level;
>  	int int_statid;

The first blank line is a checkpatch false positive.
The second is not necessary.