[v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

[PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by Venkat Rao Bagalkote 2 months, 1 week ago

On the latest linux-next following modpost warning is reported:

  WARNING: modpost: missing MODULE_DESCRIPTION() in
  fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
Changes in v2:
- Fix typo in MODULE_DESCRIPTION

 fs/smb/client/smb1maperror_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
index 820c0dd3bcce..b93d3ac41f91 100644
--- a/fs/smb/client/smb1maperror_test.c
+++ b/fs/smb/client/smb1maperror_test.c
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
 kunit_test_suite(maperror_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("SMB1 error mapping selftest module");
-- 
2.45.2

Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by ChenXiaoSong 2 months, 1 week ago

Thanks for your patch. It is "KUnit test" rather than "selftest".

Perhaps the following description would be better: "KUnit tests of SMB1 
maperror".

On 2026/4/10 14:40, Venkat Rao Bagalkote wrote:
> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");

Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by Venkat Rao Bagalkote 2 months, 1 week ago

On 10/04/26 7:22 pm, ChenXiaoSong wrote:
> Thanks for your patch. It is "KUnit test" rather than "selftest".
>
> Perhaps the following description would be better: "KUnit tests of 
> SMB1 maperror".
>
> On 2026/4/10 14:40, Venkat Rao Bagalkote wrote:
>> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");

Thank you for the review. I have sent v3, with proposed changes. Please 
review v3.

https://lore.kernel.org/all/20260410150247.93178-2-venkat88@linux.ibm.com/


Regards,

Venkat.

Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by Saket Kumar Bhaskar 2 months, 1 week ago

On Fri, Apr 10, 2026 at 12:10:30PM +0530, Venkat Rao Bagalkote wrote:
> On the latest linux-next following modpost warning is reported:
> 
>   WARNING: modpost: missing MODULE_DESCRIPTION() in
>   fs/smb/client/smb1maperror_test.o
> 
> Add MODULE_DESCRIPTION() to the test module to fix the warning.
> 
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> Changes in v2:
> - Fix typo in MODULE_DESCRIPTION
> 
>  fs/smb/client/smb1maperror_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
> index 820c0dd3bcce..b93d3ac41f91 100644
> --- a/fs/smb/client/smb1maperror_test.c
> +++ b/fs/smb/client/smb1maperror_test.c
> @@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
>  kunit_test_suite(maperror_suite);
>  
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");
> -- 
> 2.45.2
> 
LGTM, feel free to add below tag:
Reviewed-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>