[v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

[PATCH v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by Venkat Rao Bagalkote 2 months ago

On the latest linux-next following modpost warning is reported:

  WARNING: modpost: missing MODULE_DESCRIPTION() in
  fs/smb/client/smb1maperror_test.o

Add MODULE_DESCRIPTION() to the test module to fix the warning.

Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
Changes in v3:
- Update MODULE_DESCRIPTION as suggested in review

 fs/smb/client/smb1maperror_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
index 820c0dd3bcce..2caaf11228ef 100644
--- a/fs/smb/client/smb1maperror_test.c
+++ b/fs/smb/client/smb1maperror_test.c
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
 kunit_test_suite(maperror_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");
-- 
2.45.2

Re: [PATCH v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by ChenXiaoSong 2 months ago

Looks good to me. Feel free to add:
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>

On 4/10/26 23:02, Venkat Rao Bagalkote wrote:
> On the latest linux-next following modpost warning is reported:
> 
>    WARNING: modpost: missing MODULE_DESCRIPTION() in
>    fs/smb/client/smb1maperror_test.o
> 
> Add MODULE_DESCRIPTION() to the test module to fix the warning.
> 
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> Changes in v3:
> - Update MODULE_DESCRIPTION as suggested in review
> 
>   fs/smb/client/smb1maperror_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
> index 820c0dd3bcce..2caaf11228ef 100644
> --- a/fs/smb/client/smb1maperror_test.c
> +++ b/fs/smb/client/smb1maperror_test.c
> @@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
>   kunit_test_suite(maperror_suite);
>   
>   MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");

-- 
ChenXiaoSong <chenxiaosong@kylinos.cn>
Chinese Homepage: chenxiaosong.com
English Homepage: chenxiaosong.com/en

Re: [PATCH v3] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test

Posted by Steve French 2 months ago

added to cifs-2.6.git for-next

On Fri, Apr 10, 2026 at 10:59 AM ChenXiaoSong
<chenxiaosong@chenxiaosong.com> wrote:
>
> Looks good to me. Feel free to add:
> Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
>
> On 4/10/26 23:02, Venkat Rao Bagalkote wrote:
> > On the latest linux-next following modpost warning is reported:
> >
> >    WARNING: modpost: missing MODULE_DESCRIPTION() in
> >    fs/smb/client/smb1maperror_test.o
> >
> > Add MODULE_DESCRIPTION() to the test module to fix the warning.
> >
> > Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> > ---
> > Changes in v3:
> > - Update MODULE_DESCRIPTION as suggested in review
> >
> >   fs/smb/client/smb1maperror_test.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
> > index 820c0dd3bcce..2caaf11228ef 100644
> > --- a/fs/smb/client/smb1maperror_test.c
> > +++ b/fs/smb/client/smb1maperror_test.c
> > @@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
> >   kunit_test_suite(maperror_suite);
> >
> >   MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("KUnit tests of SMB1 maperror");
>
> --
> ChenXiaoSong <chenxiaosong@kylinos.cn>
> Chinese Homepage: chenxiaosong.com
> English Homepage: chenxiaosong.com/en
>
>


-- 
Thanks,

Steve