.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +---- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------ drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 5 +---- 9 files changed, 29 insertions(+), 40 deletions(-)
This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
majorly focusing on fixing checkpatch warnings of constant being on right
side of test in comparisons, deletion of empty if block ,use of
read_poll_timeout_atomic(), and other code simplifications.
Changes since v3:
- Rebased the patches on top of staging-next
- Remove compilation output from cover letter
- Add changes in each patch version in cover letter
v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
Changes since v2:
- Create patch series, each doing one logical thing
- Use read_poll_timeout_atomic() in _is_fw_read_cmd_down()
- Use single return statement instead of if-else blocks containing return
true and return false, in IsFrameTypeCtrl()
- Remove unnecessary changes from the patches
- Convey testing status of the patches
v2 link: https://lore.kernel.org/linux-staging/20260403094647.fmgop6xh2cjpit3s@inspiron/T/#m3d08fd012119772ea55df48eea80abbea34e8548
Changes since v1:
- Check for more changes of the type of placing constant on right side of
comparison/test in drivers/staging/rtl8723bs/
v1 link: https://lore.kernel.org/linux-staging/20260323145214.ubhshy2gwp52j5zh@inspiron/T/#mc3b693b37c49fbdde89171b7f1bf61b7ba8eb964
This patch series is compile tested using the following commands, which
include setting the necessary configurations:
1. make defconfig
2. scripts/config --enable CONFIG_STAGING
3. scripts/config --module CONFIG_MMC
4. scripts/config --module CONFIG_RTL8723BS
5. make olddefconfig
6. make -j$(nproc)
7. git rebase -i --exec "make -j$(nproc) M=drivers/staging/rtl8723bs" HEAD~5
However, as Luka reviewed v3 - since these are only style changes, testing
is not necessary, so I dropped RFT tag from the patch series.
Prithvi Tambewagh (5):
staging: rtl8723bs: move constant to right side of test in comparison
staging: rtl8723bs: remove empty if statement block
staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()
staging: rtl8723bs: use read_poll_timeout_atomic in
_is_fw_read_cmd_down
staging: rtl8723bs: remove duplicate rate checks in
PHY_GetTxPowerIndexBase()
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++--
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +----
drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++-----------
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++---------
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++--
drivers/staging/rtl8723bs/include/wifi.h | 5 +----
9 files changed, 29 insertions(+), 40 deletions(-)
--
2.34.1
On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, > majorly focusing on fixing checkpatch warnings of constant being on right > side of test in comparisons, deletion of empty if block ,use of > read_poll_timeout_atomic(), and other code simplifications. > > Changes since v3: > - Rebased the patches on top of staging-next > - Remove compilation output from cover letter > - Add changes in each patch version in cover letter > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 ... Hi Prithvi, this seems better, but I have one question. Did patch series appear on mailing list to you, because I cant find it and my emails sent today don't appear either. Not to be misunderstood I don't believe this is your fault but I would like to know if you are experiencing the same problem. Best regards, Luka Gejak
On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, > > majorly focusing on fixing checkpatch warnings of constant being on right > > side of test in comparisons, deletion of empty if block ,use of > > read_poll_timeout_atomic(), and other code simplifications. > > > > Changes since v3: > > - Rebased the patches on top of staging-next > > - Remove compilation output from cover letter > > - Add changes in each patch version in cover letter > > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 > > ... > > Hi Prithvi, > this seems better, but I have one question. Did patch series appear on > mailing list to you, because I cant find it and my emails sent today > don't appear either. Not to be misunderstood I don't believe this is > your fault but I would like to know if you are experiencing the same > problem. > Best regards, > Luka Gejak Hi Luka, I just observed I am also facing the same issue - I am not able to see the patch series on the mailing list, no idea why :( However I received the sent patches as well as your reviewed by tags on mail but I am not sure why the patch series is not visible on the mailing list. Shall I resend the patch series? Best Reagrds, Prithvi
On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, >> > majorly focusing on fixing checkpatch warnings of constant being on right >> > side of test in comparisons, deletion of empty if block ,use of >> > read_poll_timeout_atomic(), and other code simplifications. >> > >> > Changes since v3: >> > - Rebased the patches on top of staging-next >> > - Remove compilation output from cover letter >> > - Add changes in each patch version in cover letter >> > >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 >> >> ... >> >> Hi Prithvi, >> this seems better, but I have one question. Did patch series appear on >> mailing list to you, because I cant find it and my emails sent today >> don't appear either. Not to be misunderstood I don't believe this is >> your fault but I would like to know if you are experiencing the same >> problem. >> Best regards, >> Luka Gejak > >Hi Luka, > >I just observed I am also facing the same issue - I am not able to see the >patch series on the mailing list, no idea why :( However I received the >sent patches as well as your reviewed by tags on mail but I am not sure why >the patch series is not visible on the mailing list. > >Shall I resend the patch series? > >Best Reagrds, >Prithvi Not necessarily, that is probably caused by mailing list lagging behind, so let's just wait and see(it should stop lagging in some time). Patches as well as reviews should appear then. Also, did you receive two emails per patch from me or one because my email client is saying two. Best regards, Luka Gejak
On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote: > On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: > >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: > >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: > >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, > >> > majorly focusing on fixing checkpatch warnings of constant being on right > >> > side of test in comparisons, deletion of empty if block ,use of > >> > read_poll_timeout_atomic(), and other code simplifications. > >> > > >> > Changes since v3: > >> > - Rebased the patches on top of staging-next > >> > - Remove compilation output from cover letter > >> > - Add changes in each patch version in cover letter > >> > > >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 > >> > >> ... > >> > >> Hi Prithvi, > >> this seems better, but I have one question. Did patch series appear on > >> mailing list to you, because I cant find it and my emails sent today > >> don't appear either. Not to be misunderstood I don't believe this is > >> your fault but I would like to know if you are experiencing the same > >> problem. > >> Best regards, > >> Luka Gejak > > > >Hi Luka, > > > >I just observed I am also facing the same issue - I am not able to see the > >patch series on the mailing list, no idea why :( However I received the > >sent patches as well as your reviewed by tags on mail but I am not sure why > >the patch series is not visible on the mailing list. > > > >Shall I resend the patch series? > > > >Best Reagrds, > >Prithvi > > Not necessarily, that is probably caused by mailing list lagging > behind, so let's just wait and see(it should stop lagging in some > time). Patches as well as reviews should appear then. Also, did you Okay...thanks > receive two emails per patch from me or one because my email client is > saying two. I received just one email per patch from you > Best regards, > Luka Gejak Best Reagrds, Prithvi
On April 9, 2026 5:30:10 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote: >> On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >> >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: >> >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: >> >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, >> >> > majorly focusing on fixing checkpatch warnings of constant being on right >> >> > side of test in comparisons, deletion of empty if block ,use of >> >> > read_poll_timeout_atomic(), and other code simplifications. >> >> > >> >> > Changes since v3: >> >> > - Rebased the patches on top of staging-next >> >> > - Remove compilation output from cover letter >> >> > - Add changes in each patch version in cover letter >> >> > >> >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 >> >> >> >> ... >> >> >> >> Hi Prithvi, >> >> this seems better, but I have one question. Did patch series appear on >> >> mailing list to you, because I cant find it and my emails sent today >> >> don't appear either. Not to be misunderstood I don't believe this is >> >> your fault but I would like to know if you are experiencing the same >> >> problem. >> >> Best regards, >> >> Luka Gejak >> > >> >Hi Luka, >> > >> >I just observed I am also facing the same issue - I am not able to see the >> >patch series on the mailing list, no idea why :( However I received the >> >sent patches as well as your reviewed by tags on mail but I am not sure why >> >the patch series is not visible on the mailing list. >> > >> >Shall I resend the patch series? >> > >> >Best Reagrds, >> >Prithvi >> >> Not necessarily, that is probably caused by mailing list lagging >> behind, so let's just wait and see(it should stop lagging in some >> time). Patches as well as reviews should appear then. Also, did you > >Okay...thanks > You are always welcome. >> receive two emails per patch from me or one because my email client is >> saying two. > >I received just one email per patch from you > Thanks for the info, I guess my email client is messing with me for this patch series(idk why). >> Best regards, >> Luka Gejak > >Best Reagrds, >Prithvi
On April 9, 2026 5:32:33 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote: >On April 9, 2026 5:30:10 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >>On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote: >>> On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >>> >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: >>> >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: >>> >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, >>> >> > majorly focusing on fixing checkpatch warnings of constant being on right >>> >> > side of test in comparisons, deletion of empty if block ,use of >>> >> > read_poll_timeout_atomic(), and other code simplifications. >>> >> > >>> >> > Changes since v3: >>> >> > - Rebased the patches on top of staging-next >>> >> > - Remove compilation output from cover letter >>> >> > - Add changes in each patch version in cover letter >>> >> > >>> >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 >>> >> >>> >> ... >>> >> >>> >> Hi Prithvi, >>> >> this seems better, but I have one question. Did patch series appear on >>> >> mailing list to you, because I cant find it and my emails sent today >>> >> don't appear either. Not to be misunderstood I don't believe this is >>> >> your fault but I would like to know if you are experiencing the same >>> >> problem. >>> >> Best regards, >>> >> Luka Gejak >>> > >>> >Hi Luka, >>> > >>> >I just observed I am also facing the same issue - I am not able to see the >>> >patch series on the mailing list, no idea why :( However I received the >>> >sent patches as well as your reviewed by tags on mail but I am not sure why >>> >the patch series is not visible on the mailing list. >>> > >>> >Shall I resend the patch series? >>> > >>> >Best Reagrds, >>> >Prithvi >>> >>> Not necessarily, that is probably caused by mailing list lagging >>> behind, so let's just wait and see(it should stop lagging in some >>> time). Patches as well as reviews should appear then. Also, did you >> >>Okay...thanks >> >You are always welcome. >>> receive two emails per patch from me or one because my email client is >>> saying two. >> >>I received just one email per patch from you >> >Thanks for the info, I guess my email client is messing with me for >this patch series(idk why). >>> Best regards, >>> Luka Gejak >> >>Best Reagrds, >>Prithvi > I want to add that as the mailing list is slowly getting uncluttered, the patch series appeared, and it applies cleanly on top of the staging-next. Best regards, Luka Gejak
On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote: > On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: > > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: > > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, > > > majorly focusing on fixing checkpatch warnings of constant being on right > > > side of test in comparisons, deletion of empty if block ,use of > > > read_poll_timeout_atomic(), and other code simplifications. > > > > > > Changes since v3: > > > - Rebased the patches on top of staging-next > > > - Remove compilation output from cover letter > > > - Add changes in each patch version in cover letter > > > > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 > > > > ... > > > > Hi Prithvi, > > this seems better, but I have one question. Did patch series appear on > > mailing list to you, because I cant find it and my emails sent today > > don't appear either. Not to be misunderstood I don't believe this is > > your fault but I would like to know if you are experiencing the same > > problem. > > Best regards, > > Luka Gejak > > Hi Luka, > > I just observed I am also facing the same issue - I am not able to see the > patch series on the mailing list, no idea why :( However I received the > sent patches as well as your reviewed by tags on mail but I am not sure why > the patch series is not visible on the mailing list. > > Shall I resend the patch series? No, please wait, lore.kernel.org is currently having some problems. But next time, trim your "who do I cc:" list, as it is _way_ too big, how did you generate it? thanks, greg k-h
On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote: > On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote: > > On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: > > > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: > > > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, > > > > majorly focusing on fixing checkpatch warnings of constant being on right > > > > side of test in comparisons, deletion of empty if block ,use of > > > > read_poll_timeout_atomic(), and other code simplifications. > > > > > > > > Changes since v3: > > > > - Rebased the patches on top of staging-next > > > > - Remove compilation output from cover letter > > > > - Add changes in each patch version in cover letter > > > > > > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 > > > > > > ... > > > > > > Hi Prithvi, > > > this seems better, but I have one question. Did patch series appear on > > > mailing list to you, because I cant find it and my emails sent today > > > don't appear either. Not to be misunderstood I don't believe this is > > > your fault but I would like to know if you are experiencing the same > > > problem. > > > Best regards, > > > Luka Gejak > > > > Hi Luka, > > > > I just observed I am also facing the same issue - I am not able to see the > > patch series on the mailing list, no idea why :( However I received the > > sent patches as well as your reviewed by tags on mail but I am not sure why > > the patch series is not visible on the mailing list. > > > > Shall I resend the patch series? > > No, please wait, lore.kernel.org is currently having some problems. > > But next time, trim your "who do I cc:" list, as it is _way_ too big, > how did you generate it? > > thanks, > > greg k-h Understood...here I used all the email addresses generated from the get_maintainer.pl script. Next time, I'll be sure to trim it down just to maintainers and reviewers. Thanks, Prithvi
On April 9, 2026 5:39:58 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: >On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote: >> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote: >> > On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote: >> > > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote: >> > > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs, >> > > > majorly focusing on fixing checkpatch warnings of constant being on right >> > > > side of test in comparisons, deletion of empty if block ,use of >> > > > read_poll_timeout_atomic(), and other code simplifications. >> > > > >> > > > Changes since v3: >> > > > - Rebased the patches on top of staging-next >> > > > - Remove compilation output from cover letter >> > > > - Add changes in each patch version in cover letter >> > > > >> > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534 >> > > >> > > ... >> > > >> > > Hi Prithvi, >> > > this seems better, but I have one question. Did patch series appear on >> > > mailing list to you, because I cant find it and my emails sent today >> > > don't appear either. Not to be misunderstood I don't believe this is >> > > your fault but I would like to know if you are experiencing the same >> > > problem. >> > > Best regards, >> > > Luka Gejak >> > >> > Hi Luka, >> > >> > I just observed I am also facing the same issue - I am not able to see the >> > patch series on the mailing list, no idea why :( However I received the >> > sent patches as well as your reviewed by tags on mail but I am not sure why >> > the patch series is not visible on the mailing list. >> > >> > Shall I resend the patch series? >> >> No, please wait, lore.kernel.org is currently having some problems. >> >> But next time, trim your "who do I cc:" list, as it is _way_ too big, >> how did you generate it? >> >> thanks, >> >> greg k-h > >Understood...here I used all the email addresses generated from the >get_maintainer.pl script. Next time, I'll be sure to trim it down just to >maintainers and reviewers. > >Thanks, >Prithvi Upon testing myself, get_maintainer.pl doesn't list all of those people when ran on a directory or a file in staging. Best regards, Luka Gejak
On Thu, Apr 09, 2026 at 05:44:24PM +0200, Luka Gejak wrote: > On April 9, 2026 5:39:58 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: > >On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote: > >> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote: ... > >> But next time, trim your "who do I cc:" list, as it is _way_ too big, > >> how did you generate it? > > > >Understood...here I used all the email addresses generated from the > >get_maintainer.pl script. Next time, I'll be sure to trim it down just to > >maintainers and reviewers. > > Upon testing myself, get_maintainer.pl doesn't list all of those > people when ran on a directory or a file in staging. Also you may check my script [1] that I use on everyday basis to send patches to Linux kernel. It has some heuristics that showed to be almost suitable. [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh -- With Best Regards, Andy Shevchenko
On Thu, Apr 09, 2026 at 06:55:28PM +0300, Andy Shevchenko wrote: > On Thu, Apr 09, 2026 at 05:44:24PM +0200, Luka Gejak wrote: > > On April 9, 2026 5:39:58 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote: > > >On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote: > > >> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote: > > ... > > > >> But next time, trim your "who do I cc:" list, as it is _way_ too big, > > >> how did you generate it? > > > > > >Understood...here I used all the email addresses generated from the > > >get_maintainer.pl script. Next time, I'll be sure to trim it down just to > > >maintainers and reviewers. > > > > Upon testing myself, get_maintainer.pl doesn't list all of those > > people when ran on a directory or a file in staging. > > Also you may check my script [1] that I use on everyday basis to send patches > to Linux kernel. It has some heuristics that showed to be almost suitable. > > [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh > > -- > With Best Regards, > Andy Shevchenko > Yes I directly ran the get_maintainer.pl script on the patches, without any flags due to which I got a very long 'to' and 'cc' list for the patches. Thanks Andy for sharing the script - it is indeed optimized for this purpose :) Best Regards, Prithvi
© 2016 - 2026 Red Hat, Inc.