From nobody Sun Jun 14 18:57:05 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CDAA3D2FFC for ; Thu, 9 Apr 2026 13:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742661; cv=none; b=lntvPmGTIttCT6e/F/X9szPnhW99V8Jd3OXW24nXRxE7sKdv0J0vzVRs83/tmhDhWWkRCm9ay9sMKnslYhwPriQVjuhBSWtTFG8n9pA1x7QHm+e24IourB/gBRyHR0TbPAgTpOEP4JSk7h138b5IjNOe5BiCwJyanJLZiOBx0UA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742661; c=relaxed/simple; bh=GoJd8xoFax/fUYid/kkt0blxgC9juHJhA+KIYsEv7U0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I52t5y1gkvVZnuEOXoTXMuh3XAue806lPzsikW8N4ZRr/boYw6iV25PGLpkGhsWKp8gjXN/nOR4LbZirWBlXMZ+OtCTvr0xwpgbUhTNmM6fMiI1BEfbnHuE18pnsLPxxoYVewgS096k+yUXmvX05ejntmqS1LolSHazJORFIOlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ej80kEiZ; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ej80kEiZ" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c736261ee8dso388317a12.1 for ; Thu, 09 Apr 2026 06:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742655; x=1776347455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MOX+Dn3sD+9VHEa9uJa98TAYdd3Svmy0/RHJyTRf6N4=; b=Ej80kEiZQvIo27gngWtltDcvLeeTeQe4+8/+j8fPS/kYOvCtc3uQKBv4nfTIZutbFV YqRYkWTtPpP005Fb4u33Cnlyr6SHexveJNAFEYw19rLufrBUErwqOxAN4CcBrnaQ/J/e y4tUO80G6fswjImVqARvbvhL7sgReAAsH2k3acJnxRCvtcaZFLKn1ddTrXRr1gh/FuJ6 Il3M4GNe8okB5+h1bd4yCZVmNaGlMLy5hUkyBDTpA7AQJ6S+PC6cff+5XGDiSteSSrO6 kJIwetSQ+j59dGdxUsfrm/Jpktd4gWdPog8+tt/kGRLosWcfUKI7Tt8RiUg3ipor3BMm o4WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742655; x=1776347455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MOX+Dn3sD+9VHEa9uJa98TAYdd3Svmy0/RHJyTRf6N4=; b=rsoFLoWxgVb46azxcL7RqDwC1pz0BL8XKyGl4iDleqV9N3gbEBG881HUeZ311ixbEQ 1/3Zs2E5eE+XyxbYVLscRJmEyForr3unjQR9n4hIRZUeV7WVhwlaQibIYU/lspN8LHB8 2aWxOGAuaglpIwxXhMEjeWxs+TDxOfozGA9H5s9IjmYUGeIxhQWOmAQld2JBGOf/x5hp Z6wSV0KuS0Eq2adzOr/spsggM6ZK52jh6H8TvNl2SwdeboVKmPuX1h3QC0zKmA+me/cT TaLhlGRffDzqWRBfe8+YhqPxei8LR7R9QwbL6BNYFc+xU2WKqcz7CnpcZLyiUuaIObNJ rxig== X-Forwarded-Encrypted: i=1; AJvYcCWV2Ov1vl30NUE7m3Kl74jgGlhzpGkJsaXLZtjL5+UKae337urkaqvN9LZoY+6vSH3+dhbLej3QQaTrboI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm1uYwL77UYz2yE/hp+5kBlCLTMBSYhnzSHkoTXbKW317THeju sxAM2maHgEzG0838R6KfpfcE7lyWCtJdgpmCTj7PhENK+xMGqw2dGSia X-Gm-Gg: AeBDieuuageJZRQkM9CHaZtTNvMSSGHWG0nh9b5CbF3OzUsrJz/axbDKLMlWmXBxvNr wBekO75QZ1Nu+vP0RDL5HaYHPhmV4MWB00UmH36aSLc8tXvqPQDnUm2vTsYzJiSMT29xQbT5ACA dtTuXA/i/yl9jJQAwPrNMGHNSCoiwUrwB/nWrTKtjYNgaRtS4cwZ4ZdTJQNSGg1Ndlbm6e+GSfo v/Nsj8nH8mdbM9UOUvsbPN3QpSH/nqwrBemdOF/g1lUkhNvRZll/dwy96EnW8u0Ip2fhLi6jpeN yazOxgPBIlbFWxFe7/y82SKGF8eFOflucuJAE3jalxU5RMvCTnXafFuHmzqTzkRAdFYXwMpTzFY cQu0QRtS9jypJ3H4ExCkEUmVIIHS7NZOya5yS5et57C8z8L0+EZMkJLNvq0ESjTVaDJNimm9UjP 00WITLmpFwO7YTr12kqefM3o/rA4s0DgqDeg8tC+Dx X-Received: by 2002:a17:902:f60f:b0:2b0:b1e2:583 with SMTP id d9443c01a7336-2b2817d9616mr287882085ad.2.1775742654620; Thu, 09 Apr 2026 06:50:54 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:50:54 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 1/5] staging: rtl8723bs: move constant to right side of test in comparison Date: Thu, 9 Apr 2026 19:20:22 +0530 Message-Id: <20260409135026.137904-2-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move constant from the left side to the right side of the test in a comparison, where =3D=3D, !=3D, <=3D, >=3D, <, > operators are used, fixing= the checkpatch warning: Comparisons should place the constant on the right side of the test. Signed-off-by: Prithvi Tambewagh Reviewed-by: Luka Gejak --- .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 ++-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index d32dbf94858f..58f6cf063498 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -2211,7 +2211,7 @@ static void halbtc8723b2ant_RunCoexistMechanism(struc= t btc_coexist *pBtCoexist) } =20 algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); - if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS !=3D al= gorithm)) { + if (pCoexSta->bC2hBtInquiryPage && (algorithm !=3D BT_8723B_2ANT_COEX_ALG= O_PANHS)) { halbtc8723b2ant_ActionBtInquiry(pBtCoexist); return; } else { @@ -2490,7 +2490,7 @@ void EXhalbtc8723b2ant_BtInfoNotify( return; } =20 - if (BT_INFO_SRC_8723B_2ANT_WIFI_FW !=3D rspSource) { + if (rspSource !=3D BT_INFO_SRC_8723B_2ANT_WIFI_FW) { pCoexSta->btRetryCnt =3D pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [3:= 0] */ =20 pCoexSta->btRssi =3D pCoexSta->btInfoC2h[rspSource][3] * 2 + 10; diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 8f6849f2277e..0780847e287d 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -301,7 +301,7 @@ static void GetDeltaSwingTable_8723B( u16 rate =3D *(pDM_Odm->pForcedDataRate); u8 channel =3D pHalData->CurrentChannel; =20 - if (1 <=3D channel && channel <=3D 14) { + if (channel >=3D 1 && channel <=3D 14) { if (IS_CCK_RATE(rate)) { *TemperatureUP_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P; *TemperatureDOWN_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N; diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 728a2171fbcb..5473dca13695 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan( pHalData->bDisableSWChannelPlan =3D false; chnlPlan =3D def_channel_plan; =20 - if (0xFF =3D=3D hw_channel_plan) + if (hw_channel_plan =3D=3D 0xFF) auto_load_fail =3D true; =20 if (!auto_load_fail) { diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index bdd595a99b98..2746da0a9846 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -466,11 +466,11 @@ u8 PHY_GetTxPowerIndexBase( =20 if (IS_CCK_RATE(Rate)) txPower =3D pHalData->Index24G_CCK_Base[RFPath][chnlIdx]; - else if (MGN_6M <=3D Rate) + else if (Rate >=3D MGN_6M) txPower =3D pHalData->Index24G_BW40_Base[RFPath][chnlIdx]; =20 /* OFDM-1T */ - if ((MGN_6M <=3D Rate && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) + if ((Rate >=3D MGN_6M && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) txPower +=3D pHalData->OFDM_24G_Diff[RFPath][TX_1S]; =20 if (BandWidth =3D=3D CHANNEL_WIDTH_20) { /* BW20-1S, BW20-2S */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3caf9d..b15899580893 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -405,11 +405,11 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapte= r, bool bUsedWoWLANFw) break; } _FWDownloadEnable(padapter, false); - if (_SUCCESS !=3D rtStatus) + if (rtStatus !=3D _SUCCESS) goto fwdl_stat; =20 rtStatus =3D _FWFreeToGo(padapter, 10, 200); - if (_SUCCESS !=3D rtStatus) + if (rtStatus !=3D _SUCCESS) goto fwdl_stat; =20 fwdl_stat: @@ -1165,15 +1165,15 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter) =20 static void hal_get_chnl_group_8723b(u8 channel, u8 *group) { - if (1 <=3D channel && channel <=3D 2) + if (channel >=3D 1 && channel <=3D 2) *group =3D 0; - else if (3 <=3D channel && channel <=3D 5) + else if (channel >=3D 3 && channel <=3D 5) *group =3D 1; - else if (6 <=3D channel && channel <=3D 8) + else if (channel >=3D 6 && channel <=3D 8) *group =3D 2; - else if (9 <=3D channel && channel <=3D 11) + else if (channel >=3D 9 && channel <=3D 11) *group =3D 3; - else if (12 <=3D channel && channel <=3D 14) + else if (channel >=3D 12 && channel <=3D 14) *group =3D 4; } =20 @@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( =20 memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); =20 - if (0xFF =3D=3D PROMContent[eeAddr+1]) + if (PROMContent[eeAddr+1] =3D=3D 0xFF) AutoLoadFail =3D true; =20 if (AutoLoadFail) { @@ -2037,7 +2037,7 @@ static void hw_var_set_bcn_func(struct adapter *padap= ter, u8 variable, u8 *val) val8 &=3D ~(EN_BCN_FUNCTION | EN_TXBCN_RPT); =20 /* Always enable port0 beacon function for PSTDMA */ - if (REG_BCN_CTRL =3D=3D bcn_ctrl_reg) + if (bcn_ctrl_reg =3D=3D REG_BCN_CTRL) val8 |=3D EN_BCN_FUNCTION; =20 rtw_write8(padapter, bcn_ctrl_reg, val8); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index f50726d2ed0c..ff39077deb69 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -415,7 +415,7 @@ int rtl8723bs_xmit_thread(void *context) if (signal_pending(current)) { flush_signals(current); } - } while (_SUCCESS =3D=3D ret); + } while (ret =3D=3D _SUCCESS); =20 complete(&pxmitpriv->SdioXmitTerminate); =20 diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/stagin= g/rtl8723bs/include/ieee80211.h index fbb12fe31a6c..a3f519e2f6d2 100644 --- a/drivers/staging/rtl8723bs/include/ieee80211.h +++ b/drivers/staging/rtl8723bs/include/ieee80211.h @@ -394,8 +394,8 @@ enum { }; =20 #define IS_HT_RATE(_rate) (_rate >=3D MGN_MCS0 && _rate <=3D MGN_MCS31) -#define IS_CCK_RATE(_rate) (MGN_1M =3D=3D _rate || _rate =3D=3D MGN_2M = || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) -#define IS_OFDM_RATE(_rate) (MGN_6M <=3D _rate && _rate <=3D MGN_54M &= & _rate !=3D MGN_11M) +#define IS_CCK_RATE(_rate) (_rate =3D=3D MGN_1M || _rate =3D=3D MGN_2M = || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) +#define IS_OFDM_RATE(_rate) (_rate >=3D MGN_6M && _rate <=3D MGN_54M &= & _rate !=3D MGN_11M) =20 =20 /* NOTE: This data is for statistical purposes; not all hardware provides = this --=20 2.34.1 From nobody Sun Jun 14 18:57:05 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D5603AB294 for ; Thu, 9 Apr 2026 13:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742674; cv=none; b=crGrjakqJ6Qy2zs+zX6SExUu76Ermy4btaoFwLOAd84zvCjb7mVrZfTvchqyQBjmTMB66ky4APqe1aaBUFHIg/wimqdi1OjttZauMeFWwHCfeuU/m/CzdSOsc22H8zaqo6ZLo0wZcFRDlvmCVSmgXloJh2zAKJS3u1RNblGtqjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742674; c=relaxed/simple; bh=1LwJM37Q7NKIw50Cf3+KN9/jRGOQih8ktE+fD8cOp2E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NQ2B4qKerK+VR0DiUPPCqgiI8GWr2qnJo2AUzRe0ZaWyS0X2hN79cKcW9y4Paa3zztG5STEcPXxKdQ5toOuQEpnGukTIZ6rm5BPwj6HpchUn58PJ/Y/TTHq6WGmeDEfY9ukptJiPYtMef5jCKl2kGEfQ+emvMSkMBg+R+YcnrlY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BKrKn4SX; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BKrKn4SX" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b0afa0210bso4164565ad.2 for ; Thu, 09 Apr 2026 06:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742673; x=1776347473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uIQUUz8HJK10CN2cyTrf7XlnfenCpDOYTcZ2fDMqU78=; b=BKrKn4SXRImmCfHMBhUg7NTG2Nzm+LmVJ0ukUgX6jgSU/cWPz4IxF70Qpqmdl3cZKw eVF2PGRkJefXSXOzZL0XJy/DzkeQqZRrq52HBd2TJuzoP9zlOBxad0tIft0nl+sFBgUR DTFfQIpM2NY3J22x2t3lOZtrp62UnAshszIK9UwH3NS0k0G1LhzYqgwc85KGJZ2EbXb3 GFQpL8o/JgLKx3J4NhbAJZQ06GFUrYgUCGxeGTy+JT3uFirGqMtEAVQJposIo/QLHfji H5yJFym4rHKeb1wjEsr/4tpUzn4ONBGSar+mlJB+3XZqZvcZRDA4XBTlwuLNqjoQ9blG dssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742673; x=1776347473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uIQUUz8HJK10CN2cyTrf7XlnfenCpDOYTcZ2fDMqU78=; b=I8CyjCcfXahbqll4ZbyBO6mQKyPUbwgRzoFBATVtG82ba02Z8IKYlRI2+ZxDUdUECN 1oR2hzFMejlukVsAzZEKqxHT7pXyCByO3VMCzhhhGTiWN9bHNqxjIsRgW442PRMzmHho Yi3idij0qEhoISKGAHW3IgWF7wZR/CNHGusMausuJAN2vvAgXhLsYiOKvZY5VROj9t/5 63JGzRwngj+VPuIi0xy9lPWALkQrBbWaUl+Yv6HjLyEaGv1MPTI8Bc4n8sCHmQxK7byR snez/8IvjmFjaqguBDDVvQKsl/N6RefHegyVGEWv9Nd5AszWso95HQmCZV+fOODPtFlV zlbg== X-Forwarded-Encrypted: i=1; AJvYcCWykJVrNLy9H3xzjwUNnQkBO68euSP/DbCS6Ka6lP6FCCNQfGPvaoRam4U9dIWA0J6YylVkdh+CtK0ljPc=@vger.kernel.org X-Gm-Message-State: AOJu0YxrFLiemRtPu7DBF9bs2JrJuJ/GGGssgTthHJahXp6nNjDISqQo Dyy45PsXG0yPxujPlyYH6yGH/pspsO0JzSKS2seuqffCZS9Hz+jyOOjC X-Gm-Gg: AeBDieu0xC+AUNjCU3cNOiiaJFoqZ0lOMm76ulYhsWpnl0r5Hylw82KZPD/RyYNSeiJ GBQxzU2Gz+CQeDHFnghSEHR7mBeFys1ofjjQWBbne7rW7s/xSSdcg8RTys1Bw4CjKA7e8VieZpO yNjQBNIP0Bysb4edFgmMW9ffCJghtrndrTZoRBDNMinZWZs6x46FvoQC/x5QD/F4t3IPFVN9puU OXr8ehlf5J3YlY7bkZCzFQaYxdh42W9UA7WZppfxJ5Hvrux/kbErk1i1aibgxX6SVgEDgdIk7d3 m4b3RVz/0GsGv9s6EUtcjJsNpNaB7lokbMLSoSe6whN18Do21aDL9HK7WVCYscKmEDf47ZNORU4 zAFiTq/gElVvfC41DgGfSx5LMQLoFGaRNXKXXCSyIm7cJRcVYFmu2/7mvey7mogDbHZY2etq7EW BbD7dOY9UNxBL8wHShDSGtyJTg+yfqkIWyG7f/yF8P X-Received: by 2002:a17:903:37c4:b0:2b0:7b57:830f with SMTP id d9443c01a7336-2b2818e4f2amr259026645ad.33.1775742672900; Thu, 09 Apr 2026 06:51:12 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:51:12 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block Date: Thu, 9 Apr 2026 19:20:23 +0530 Message-Id: <20260409135026.137904-3-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove empty if statement block for cleaning up code. Signed-off-by: Prithvi Tambewagh Reviewed-by: Luka Gejak --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 0780847e287d..6ab65e9e8bee 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -1415,9 +1415,6 @@ static void phy_IQCalibrate_8723B( } } =20 - if (0x00 =3D=3D PathAOK) { - } - /* path B IQK */ if (is2T) { =20 --=20 2.34.1 From nobody Sun Jun 14 18:57:05 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C59A3D348F for ; Thu, 9 Apr 2026 13:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742689; cv=none; b=g4Jgv1nVrGiWALYBdCCEIZl2TjaF2U5UloNtEM6ifsgtz68jhi2OJGEYk740nlnNFXQQh12/CJKxRRdoKw20A30e6xsd+i9TLprlcwkfmL+sQGjCVtu/09RZoIKFYo+SuCRuZ9ZeHZOiNRNHr/oOi/fAHwC/4XQ2SmPd9uJUqjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742689; c=relaxed/simple; bh=cgZY4JYcYNuxKFJSK6ipW5wyPi1mPE0bqbjnMORWqN8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lKsaaVW8ITdmHBw7oxsAkvXvSO3erUAazqakdUdAAB91v+c/ghVOpmpOxVhCU6iqwiMvEZHtu8t/GFPY31qqcvBx5YJGmd8sSREWDuU2zU3ZD6UuzMIePyTxlbPWH9U/75wjniYn+G4jcF2K0kR5OWA0zdxiMWbAyRTAC5BgH7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dT3kDQZz; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dT3kDQZz" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c76b95e652bso427240a12.3 for ; Thu, 09 Apr 2026 06:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742687; x=1776347487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pmjALA6V37PHOvR1b73ZH9/lB8Vpxb+o5ifXzvgJEJI=; b=dT3kDQZzkZn4Hrxe7HCJlsM7WH+lFMHyBRmRp3xtSojIZvWh5YlGiRfnbXqLuU0yTZ oWDe1ZdBRkNPh667LapF6kFvXZzQZ7niY179S9945UdZxrVthz7Z2hqCd/iMr872jIEM 4gQ6KNHnnEVCK3ytxMukE5fBde/J732OHpy6Tf3YM+Bb1SkZUVFc8dlWCtC61q1YkRvy +f3P9BBsP6HplwJ49FmMOoU8oAgK59LEqMtcvvk4soMxeYC7V5TPSiX0tlfSBynK+h1I 767IUB+YBTq+Gk/rOkORrxNsOjkvF3Tt4KnVkql2UqawVFK3CNoxnTffB/hhlljf+LkD 9cnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742687; x=1776347487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pmjALA6V37PHOvR1b73ZH9/lB8Vpxb+o5ifXzvgJEJI=; b=N/Q6y80eKVhz922gwVMDPixAB9eEe1LxGXTQ24C953Fx/Z/iPArgH7KqpqMHrpJlkk e19sE2xQi8KZ+j/Yxxt0VVRVjlISK2uQNpEWFK77bCywrHb7dMf0JesRZhk0jm4JzuvK KaO8SNsV/Zldqa1BWB/TBXt8xjBK14uLhCX59Ssn3c1VKIaUh3b1xy6uQrivKWEMFAVu juOpcB1DDm2xS1WsLY3FLC9gOrdHBb1PfSW4X5gkOdqQgKr3SnEcE6NYoIveJWDFwyG1 //z/Q+yEfBC5cUXJMkHw5k+SQptb78fDJmdcb+lJYmgM1FtwImJB76MNkckabwRw2nej ggRA== X-Forwarded-Encrypted: i=1; AJvYcCXqFjvFlbozYFwc4A8oSnW/sL/maKDWHX+UljoZY9ImDfDniXXdYSrTLdnm4nT4vm4J+x6QGENP67SxIWs=@vger.kernel.org X-Gm-Message-State: AOJu0YxDZAUe38yHk+rrpV8+LOVKJWCVLNdZrGIS8oiQlas7DfEqSzoV wtReenp3jy6J+e7eP5eAldIS/BhdJilGh1dDf2f0xNvQk86Va4fshfjb X-Gm-Gg: AeBDievxcNAp4Sni5c7S1HpW9SACN5S85wMPyUzyyNp4Pb/aJSvDcXqa1Guebs5UkMd tdIYX42ngNPYsGSdVuRWVrPGfCet9jAic2yMOHiRcSeOfH5t8UZRlGdu1S9tQ6aAFFct6+lCV32 jHAbCaoWCQbfr/kntY/7LAvPkpmVIgwcOpcssFxPBmkaFwEHLAvlvsQ7zgoNxuOrA/wNFUV1wDm ZNJaDqIH9lbsFZEUtg5SAOHRjeB2dp9pys7HqYyFT/5BnbCNuMvuLk93I3lLIUrebfUUYDWDgYo Qp8GNXRVS/9Qo00BggUZSLnXbQtV0qdF32+PVyHaGIEbFcmBXY2vVVMMigX7JVqxizHtjZuCjvc QXc61i/tlVjdwadnFv8kIr27gWsslsfb4EpBBjMokxmsNW2z+jOtjd8YnKClJf42xhUXvDIk5RH lpR88jxWHcwrGDjH9AaGNqSIFHht2EOFNbVAL0PIy0xLtAuJ74vaM= X-Received: by 2002:a17:903:2ed0:b0:2b2:5091:1c26 with SMTP id d9443c01a7336-2b2816d8626mr286574105ad.22.1775742686802; Thu, 09 Apr 2026 06:51:26 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:51:26 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 3/5] staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl() Date: Thu, 9 Apr 2026 19:20:24 +0530 Message-Id: <20260409135026.137904-4-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the simple if-else statement which checked value of GetFrameType(pframe), if equal to WIFI_CTRL_TYPE, function IsFrameTypeCtrl() returned true else false, with a single return statement returning true only if GetFrameType(pframe) =3D=3D WIFI_CTRL_TYPE otherwise returns false. Signed-off-by: Prithvi Tambewagh Reviewed-by: Luka Gejak --- drivers/staging/rtl8723bs/include/wifi.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl= 8723bs/include/wifi.h index 230b2c4ffd3b..2876f15f13d1 100644 --- a/drivers/staging/rtl8723bs/include/wifi.h +++ b/drivers/staging/rtl8723bs/include/wifi.h @@ -275,10 +275,7 @@ static inline unsigned char *get_hdr_bssid(unsigned ch= ar *pframe) =20 static inline int IsFrameTypeCtrl(unsigned char *pframe) { - if (WIFI_CTRL_TYPE =3D=3D GetFrameType(pframe)) - return true; - else - return false; + return GetFrameType(pframe) =3D=3D WIFI_CTRL_TYPE; } /*------------------------------------------------------------------------= ----- Below is for the security related definition --=20 2.34.1 From nobody Sun Jun 14 18:57:05 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD053D3CE5 for ; Thu, 9 Apr 2026 13:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742700; cv=none; b=iNtiNgsPrX7jaP82IHhnyujxv8f6XeL46uxmbxVxweL4xYfKFMi4lk7KWf4hGLtmnHr9wRr6klxC68ljIu+YXQnj04CjTXc05YMsyIiqjphSVuEhNHNxhgwJg3JNAO0REhfj3rnByY8+YcqVqcQ3OzxBwDpjMiXQ/ru9NzvWY8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742700; c=relaxed/simple; bh=b9XVrchuap9fqBpVQL3AJRB7as8Aiw+odeeQjTqQVaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sEZ5f+jlngFRFE8wR5QtRIKFOFC2yceYagYgOsSzMtbDWbpO2KOtxRdL0MxENcNMjuzCO2VHuQ5JRKKyMF0b/KjFYzvHRaPvR22Ed6Kr0cNJx7muOtVst9ZrT8A2z1eRowC5TCki+pjM6Z7p3EYUhBMCpwF94Qs/qK4VSNmoKI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DbbBwBV3; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DbbBwBV3" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b0afa0210bso4170235ad.2 for ; Thu, 09 Apr 2026 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742698; x=1776347498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MVEWLl/Od3ufIPmI59zrfVuf3ZvRBpYOxIc+qkV+R0o=; b=DbbBwBV3/TPydc5/yc3clUvAHUPHAFMIyQGRDZeXNjavgkNMT1ox0URU/Do5z80mnr KsYYMVFKrT2H65wiM9cHR0VxVlFQI53Umds3bskhN9sk0oBP4BIw99vVxfTvKEof9lQz 4oDQ+nbFSyM5J9QShpuosb3+r/zjC/wYgODwHzw+5OFxprkUExc4Ux9DoQ5+fEneB+yu u5HS7RGYb2aP+9XKySzBJSBWZr3qSb1NoLHdcQZMVNn3hPpSJ1xmlods42xK3mg7n6ik o4bSajZ7734EK+uCuzpy8g/k6Gx9yoCKYpqf0opOBOSOBtxuB2QjPMuze8ABj1oS9duo XDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742698; x=1776347498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MVEWLl/Od3ufIPmI59zrfVuf3ZvRBpYOxIc+qkV+R0o=; b=B6h3rKJH1rhDnHYyXEteJLRTVPu4D4H+jkEfM0XLp3aCEQTq8GxVES+rCvkeWlY52i wLAoDaJ0v42PEgNx+kKRCBuRXfhRjJsULqjtIzAsj5zQAOrweRJ3jFOIMirTtToMLxUk P8S0kwz4feec/H12qxemIcrLZmpE65tz89rOT4466EMVkBW/Y3W3Qk2T5jiwo0iqO1fK uqTx217ejDB4QJdBCHxqjB/Eio1yNmCUwY59j6+vwSoYdEVjWtPS/ZAdbZd6syXv0wCS vqw2FH+lONI4PTDGTFGGwhcyKutGKnAgxls4TkCJ+GWWs+iXjh7TXJBV+KoCU0MUZp9f 5j2A== X-Forwarded-Encrypted: i=1; AJvYcCUfkmntDEmjgWuyCEqkr1XkhIg83rTmyRJ8kTVG8FwbgF9tzbRMm81qTRSTk3SKS29ADc0N2dNAUUowXuA=@vger.kernel.org X-Gm-Message-State: AOJu0YydZW9RfmsS00OXmK0bVsvfT5HN3LJgsAAQpUBX5/MYNVGnKO03 pEXJAF0egHQQrh3AJfUNt4HWctUFJhUtAQ5qG1K4qesVgmsL4a+46Hp5 X-Gm-Gg: AeBDietJN3oH4x679wUlgQ65LHpVtvNch0dfSc305r0nhdQwOKz8ScM+YAl4o3ObDQU 8FA09D1aNHUps9lKoaEAzwEyIy4jhX/x89UeMasEF30T56MHNlx3c6QIY7sbIGQc79llIZLq/+U VdF+o/SSkOqUI+LGIAYs3io8IyDtllDcQvx77lAb/yIa211oBe5iwLrSdqoJR+9NiZcLLw8qkkr PcFkCen5FppzVVSM/NoTK9OeHJVQGu/06HFcKRAEyj7oSzwWpMW+/QrcFhVYMW5YotAPkvJMApD BCP3d53t49tBec7DB8V+EZEkRtFBviF58Sg65yBvGx6NtB9K+RAqRH4NJRlWoEEXTtOyQnW7NdN B0iBSllfN0e1iKXNp+ApBSgE/cmoGHRG31jboY47NAjVv3v+cS5tXn973nIZ2MZfzS2aW8S6r6u bGEOLxrPrVbyUeh1jcahwvPWQWEwTSLIXl+qkAjwtC X-Received: by 2002:a17:902:ccc7:b0:2ae:c5fc:b2ef with SMTP id d9443c01a7336-2b2818b3b4amr288059425ad.30.1775742698107; Thu, 09 Apr 2026 06:51:38 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:51:37 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down Date: Thu, 9 Apr 2026 19:20:25 +0530 Message-Id: <20260409135026.137904-5-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the existing rtw_read8() and do-while loop mechanism with read_poll_timeout_atomic() from , in _is_fw_read_cmd_down() which is a standard Linux macro, ensuring polling REG_HMETFR efficiently. Signed-off-by: Prithvi Tambewagh Reviewed-by: Luka Gejak --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 12416e499ac3..4bdc8e314015 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "hal_com_h2c.h" =20 #define MAX_H2C_BOX_NUMS 4 @@ -18,20 +19,15 @@ =20 static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num) { - u8 read_down =3D false; - int retry_cnts =3D 100; - u8 valid; + int ret; =20 - do { - valid =3D rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); - if (0 =3D=3D valid) { - read_down =3D true; - } - } while ((!read_down) && (retry_cnts--)); - - return read_down; + ret =3D read_poll_timeout_atomic(rtw_read8, + valid, !(valid & BIT(msgbox_num)), + 0, 500, false, + padapter, REG_HMETFR); =20 + return !ret; } =20 =20 --=20 2.34.1 From nobody Sun Jun 14 18:57:05 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F353D9DDE for ; Thu, 9 Apr 2026 13:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742715; cv=none; b=WO/jSWrc5CbU+xcVFV4YVETUT2KBNDdBAKoOz6c1pGP4v9mCL+xXN5yoguMfxfIydO+9ux8/eNwaYRlU27P2Scv7UH0xkkc+G97vDQWwugA6exmcqE+r1bcR6qEHULKExskSPySt034OQ+OZU1muWjN1MW6aHEIevszmRdfQark= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742715; c=relaxed/simple; bh=FRKDWcaI2dd+q/YHsz5EPwK/dwR9fegXhSXr8oRgp+4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ozVVsIBTzm7y9WqIMaqA4Y+nSkceGMbSmP+JZLAhEYd7pQXzsS6b5p7kuSWuFQqa6pMYPJJNaw2Fw6tH1MVddemJ/m7qvlZRZ2BccETtS/kP+13fYWA3SZTgebencPfeB1ORHYhkOrkMgAaL2VIvpW8MMktO6QIWUJYonJBWMiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P5pPFzYh; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P5pPFzYh" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ad21f437eeso5077425ad.0 for ; Thu, 09 Apr 2026 06:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742710; x=1776347510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lqVqgMnpwts9PCufMDBF0YteLxaKZEFLyzQXe30weDc=; b=P5pPFzYhEjKbUg8gOrhRzN+TrPq/ECy79a9qXuvg2vyKUbobjVhPnXBlKFOgXRbAhW kCPt0zGGICyTAqUQgJfkRhErZK2TKp4bh4i0X9EEyPoR4DYwnJmmoVWZlNiVTx/2K4lW 5RqtkZhuuhti5DT33+aA73IXrHVAds1+lQ9FSnrfnhau/brvXsV3t3NWvhoaiTgbB27k QDxXCeCEV2JFkJ5gLncIxLJMUoJFJZC3NXQ+ScXqA3zefOu6QZxwzbRRnzNegjECFOKM LdyeEoZ6MHEyND14aZGF0SHMB9mG1+HODBT36oAL4QswP0vtlcJucaaNP5cwYVrRzQ4U fscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742710; x=1776347510; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lqVqgMnpwts9PCufMDBF0YteLxaKZEFLyzQXe30weDc=; b=Gu/CAYjOF1+cRHeUVU+A0Lii/pINFhqZ/WXZeiiwJTdKHotsikqhnRX9NJEMsyF5ed LVVsvSMIFSO3GORq/6Iqzebh6RIrP5PMWF5oxkFyXbqLmqh2bZ0ju9BuqVIXROVz2irW aW9Hc0kPsGdIJ2QzwxNWLPTGLhviq0bXYxZpiYfCfofNvDIKmiI8JghQ/8LB4PGkxsdU u46OxbzMojxwuzVI7449tTOWc5WRJEkEmS2i/ekOKU00LXJV9KHWLHA2flyMhOkLLt6h IznaEpdnIWuYj8POt5fSlpZ/IgYkCKQdqF9n9gMDLaGuARWIFv/66IxN8vJvqRSiHjnh ibbw== X-Forwarded-Encrypted: i=1; AJvYcCWqh5Ti5q7Wmvixao48VLpSZ02ALHfdVGfXR5XztHWlZr7LS9laiI0y2Hvnw+d0G7h9VXSXkL+NWFwPMqI=@vger.kernel.org X-Gm-Message-State: AOJu0YwaHz68+Opl6CiN05+h51LKQcktaihQ8JwKe1tvi7D+VFuD62Oc Zv2CAAesEjUxIR8ED0WSeozuBAJ+l7ctqupc/D3/MlHGLeJWibEx5JTU X-Gm-Gg: AeBDievmAar6i4JfxUxGP+J3s24285MKsXl98pkO0h4Ybqs8aZuGjJ8yUmGY9KAUhX0 1btlUJnr8/n3oj2Z0go+cplSec5WZSbtNkyE5ewILGzuQWa1frNxzgQiZ/9PjBH8FMCeeQ7MnRB Hn62jQ9O+dkmZ+Hjf2dgsgiZCla73jr2ZqyNRxEbyD5h3q/0xkeOwHgmallA+MPSV49hZD/h0vq t9ZYE9dBPKh4NIA88cFjxbfA1uN17/Gjop+0ecCIF/cc8MKuznqOEzcBxAvvW8s4JljpObdObsw vQVCrPM+Qk6V53YrXB4hE9sXl7WJSgoT10/1JFauAbPSUGAr56ltQRK2SMItbTyhyuNbsL3/OdB 8DLNmLIyJGj8qLUslLwggZkmeTOYItC2FeW0wAziJpwht6LzOZRJ0ZOy/9KkHPcnM4N3j0jOLLe iPxgbMUYKy8rWpK5sVmIL2qrqaSP2+bK5GK0p5uthELgr770Fo+u4= X-Received: by 2002:a17:902:b18f:b0:2b2:4f43:b49a with SMTP id d9443c01a7336-2b2c736e506mr23268085ad.22.1775742710472; Thu, 09 Apr 2026 06:51:50 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:51:50 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 5/5] staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase() Date: Thu, 9 Apr 2026 19:20:26 +0530 Message-Id: <20260409135026.137904-6-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code previously checked (Rate >=3D MGN_MCS0 && Rate <=3D MGN_MCS7) condition twice - once for the (BandWidth =3D=3D CHANNEL_WIDTH_20) check and once for the (BandWidth =3D=3D CHANNEL_WIDTH_40) check. Fix if statement formatting to move that if check as an outer if check to improve code formatting. Signed-off-by: Prithvi Tambewagh --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index 2746da0a9846..45dbe1782bae 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -473,11 +473,10 @@ u8 PHY_GetTxPowerIndexBase( if ((Rate >=3D MGN_6M && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) txPower +=3D pHalData->OFDM_24G_Diff[RFPath][TX_1S]; =20 - if (BandWidth =3D=3D CHANNEL_WIDTH_20) { /* BW20-1S, BW20-2S */ - if (MGN_MCS0 <=3D Rate && Rate <=3D MGN_MCS7) + if (Rate >=3D MGN_MCS0 && Rate <=3D MGN_MCS7) { + if (BandWidth =3D=3D CHANNEL_WIDTH_20) /* BW20-1S, BW20-2S */ txPower +=3D pHalData->BW20_24G_Diff[RFPath][TX_1S]; - } else if (BandWidth =3D=3D CHANNEL_WIDTH_40) { /* BW40-1S, BW40-2S */ - if (MGN_MCS0 <=3D Rate && Rate <=3D MGN_MCS7) + else if (BandWidth =3D=3D CHANNEL_WIDTH_40) /* BW40-1S, BW40-2S */ txPower +=3D pHalData->BW40_24G_Diff[RFPath][TX_1S]; } =20 --=20 2.34.1