This patch removes the obsolete TODO comment regarding fan speed
presets in fan_write_cmd_speed. After discussion with the
maintainers, it was decided that fixed presets (low/medium/high)
are not suitable due to platform-specific variations.

Signed-off-by: Daniil Bulgar <bulgardaniil18@gmail.com>
---
v2:
 - Removed the preset implementation as requested by Mark Pearson
   and only removed the TODO comment.
v1: 
 - Initial attempt to implement low/medium/high presets.
 
 drivers/platform/x86/lenovo/thinkpad_acpi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
index 8982d92df..75e141304 100644
--- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
+++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
@@ -9249,9 +9249,6 @@ static int fan_write_cmd_speed(const char *cmd, int *rc)
 {
 	int speed;
 
-	/* TODO:
-	 * Support speed <low> <medium> <high> ? */
-
 	if (sscanf(cmd, "speed %d", &speed) != 1)
 		return 0;
 
-- 
2.53.0

On Tue, 07 Apr 2026 21:05:46 +0200, Daniil Bulgar wrote:

> This patch removes the obsolete TODO comment regarding fan speed
> presets in fan_write_cmd_speed. After discussion with the
> maintainers, it was decided that fixed presets (low/medium/high)
> are not suitable due to platform-specific variations.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: remove obsolete TODO comment
      commit: a29b5cd42f5bc6ba1be6422f61f3f05bab707ce8

--
 i.

On Tue, Apr 7, 2026, at 3:05 PM, Daniil Bulgar wrote:
> This patch removes the obsolete TODO comment regarding fan speed
> presets in fan_write_cmd_speed. After discussion with the
> maintainers, it was decided that fixed presets (low/medium/high)
> are not suitable due to platform-specific variations.
>
> Signed-off-by: Daniil Bulgar <bulgardaniil18@gmail.com>
> ---
> v2:
>  - Removed the preset implementation as requested by Mark Pearson
>    and only removed the TODO comment.
> v1: 
>  - Initial attempt to implement low/medium/high presets.
> 
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c 
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 8982d92df..75e141304 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -9249,9 +9249,6 @@ static int fan_write_cmd_speed(const char *cmd, 
> int *rc)
>  {
>  	int speed;
> 
> -	/* TODO:
> -	 * Support speed <low> <medium> <high> ? */
> -
>  	if (sscanf(cmd, "speed %d", &speed) != 1)
>  		return 0;
> 
> -- 
> 2.53.0

Looks good - thanks :)
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark