From nobody Mon Jun 15 03:54:02 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A563368A3 for ; Tue, 7 Apr 2026 19:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775588825; cv=none; b=ARtzqcSyyHus9h/orTSdAfOb8QET8e13Hv8bXsjJJ4/l5dcY0P6MDdsICF9OA95ghO8zQDSbZkKccyFNHlI2rcht5FYX29sJyoMj7LRDcObOhaT5UPr2/hH10qWYIKHVm7rOy6o7aHfWJtXgemgQa7udgKKdkoA2IRZTkldXG8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775588825; c=relaxed/simple; bh=uhFg3+9ZgdJm9nasdum5F6EMA45wwyoRtQZ6fZ/mEQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ks1qadiwbErsABRneY1g/hR4UNtuapVO1nbUCTe5IoWzu/1WR1PEKS7n1VsbNH/ZzEPxqJfMAyL7loPGXqvjCsNYTNpoMdXDk1iEJ8Z086pEWjuej31nMgVA5XiVg4fExv/JYBiAW34ejC1EbmG8z6TZNoRkyYpxqZeA/dooNSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W6VFtn+Y; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W6VFtn+Y" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so32913215e9.0 for ; Tue, 07 Apr 2026 12:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775588822; x=1776193622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5Ba51T9mIu5soKJaKA7rM/Odtxo9E0170cndvfoVPno=; b=W6VFtn+YEXipjHqx9V258lU7daDGI6+MUy5hKDeJzf/8WrtO91XU647aV0+Csn2LkL ok9ldHk0lGxGqtoW7jNLdmkQ7mDyKVu1e2PXcKBFZZVi0m0qXUA/MxTfCPFjOPEONwH3 6M9nkOg1x47Hdn0NnqXixE/fIsOZJVQ3PCJaX+KztTMN8sSgaysZvhJAW3r4deYzfZq3 5EeKczOFGyUkbWxax9sM/WOXoHtGk3IYCyYuKZ5GlmUFBSkvJXgehV3XFxdlPoyMY1l4 ZW77WMe4+WcLL7GgXoVfSIrqPqiGtDW8u4iNp+/ysM7C1ftq1qEM1exES6tBEgTbYxHi 1Nqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775588822; x=1776193622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5Ba51T9mIu5soKJaKA7rM/Odtxo9E0170cndvfoVPno=; b=N4Q0msKSntBLyJholtf748hFP4ne2y00NsTZhY+ByirAGDZm7Cgbba8nqI46bt1PRh jIofetXPEhZekCtZnw0IYlm52gbNXs3raiOSIhYUlw2mipbLYVZp3Z1EZ3MN/X/7Zn4G QE1+2iZmDReRw4IxcwZPS5IHtXMpdlZl40fjx3134bt4asgyVSb0lrcEv1GAOtIwIR8d 3mKbPupD0QkYlJqEqSmgjSr2qUM7d9AO5FpZc7JiOqJgQMOhzBMieizhSzgJr1Xo3T2e VHiSfjw4K3lAaZuUOlhSUGwKYwXluQPpoQPF9JPUhgK63pxSwXKrHDBXcgqCYQWHimc6 hwUw== X-Forwarded-Encrypted: i=1; AJvYcCWYOaJk/++4SkIsu2G8B7i/dhyZec0BLhGpRFqOjcLbjz+emUZVEjZr3ohSKb9TK3TMAbuX9tESs351ViA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAaSIPSAIsimvH+Axie+vq8Qq3DxLti603Y5lmiWWFUvChrknC Hs2ZZ0NJtbMQdOXapamqPVr0k47YBNcAJJnh1f8UmUp89mskm8b8f4JF X-Gm-Gg: AeBDies/dphEzp3WYrupJ8j44XQSwDy0ajEApc+Vl5SGOp0dVHOQgDT6clSdB5T32bQ KfCN1ic5+qHLi5Qw39z+mg/lT3RMfrjl/bX7XiyDwzp9yPageRiqDgSdAtJQORrFbGWI6ii1s9D jUi8S/P3LS+JIqG35nu7D5H0KA25O1AaDc/kW/h3bKsNJR+4eLLSvoSvZIyv4TvOTDoV1syVr4p pByXAA5SUbInFShPiNGrEJomAF8tZ1v86sWOaVEE1+bbwUv+baMmP+eyjaP0eoYODw5pbzfFgYI Bep47F9uPUzNa/Yv9/TcxQPTH3H9GbLnHmJSX2yP9q2dFU79vxz4BjljJ4hXezb03kSy+qmIHLI 7ScciGM3d2D+EFMdfNOqwjVvz+Nf1bQugl/HvSZqjFdaGUFek57SmjzkCBk981prKGIJWq0sxA3 GtDSCChQWe5ZYMcbRzHRbV X-Received: by 2002:a05:600c:8b03:b0:488:81b1:ae36 with SMTP id 5b1f17b1804b1-488997d3188mr261053425e9.23.1775588822338; Tue, 07 Apr 2026 12:07:02 -0700 (PDT) Received: from MEROWN ([85.93.99.108]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488c524fecasm12983465e9.1.2026.04.07.12.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 12:07:01 -0700 (PDT) From: Daniil Bulgar To: Mark Pearson , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Henrique de Moraes Holschuh , "Derek J . Clark" , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Daniil Bulgar Subject: [PATCH v2] platform/x86: thinkpad_acpi: remove obsolete TODO comment Date: Tue, 7 Apr 2026 21:05:46 +0200 Message-ID: <20260407190546.109900-1-bulgardaniil18@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch removes the obsolete TODO comment regarding fan speed presets in fan_write_cmd_speed. After discussion with the maintainers, it was decided that fixed presets (low/medium/high) are not suitable due to platform-specific variations. Signed-off-by: Daniil Bulgar Reviewed-by: Mark Pearson --- v2: - Removed the preset implementation as requested by Mark Pearson and only removed the TODO comment. v1:=20 - Initial attempt to implement low/medium/high presets. =20 drivers/platform/x86/lenovo/thinkpad_acpi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform= /x86/lenovo/thinkpad_acpi.c index 8982d92df..75e141304 100644 --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c @@ -9249,9 +9249,6 @@ static int fan_write_cmd_speed(const char *cmd, int *= rc) { int speed; =20 - /* TODO: - * Support speed ? */ - if (sscanf(cmd, "speed %d", &speed) !=3D 1) return 0; =20 --=20 2.53.0