[PATCH v3 0/3] perf addr2line: Rework disable_add2line_warn

Thomas Richter posted 3 patches 2 months ago
tools/perf/Documentation/perf-config.txt |  6 ++++++
tools/perf/builtin-diff.c                |  4 ++--
tools/perf/util/addr2line.c              | 20 ++++++++++----------
tools/perf/util/addr2line.h              |  2 --
tools/perf/util/block-info.c             |  2 +-
tools/perf/util/config.c                 |  6 ++++--
tools/perf/util/libbfd.c                 |  2 +-
tools/perf/util/symbol_conf.h            |  3 ++-
8 files changed, 26 insertions(+), 19 deletions(-)
[PATCH v3 0/3] perf addr2line: Rework disable_add2line_warn
Posted by Thomas Richter 2 months ago
Introduce configurable addr2line_disable_warn entry in the .perfconfig
file. Clean up addr2line configuration.

V2 --> V3: Added comments from Kim Namhyung
           - Use perf_config_bool() to read addr2line-disable-warn
	     value
	   - Move perfconfig.txt update to proper patch file.
	   - Fix invalid default value in documentation.
V1 --> V2: Update perf-config documentation.

Patch 1:
   Rename disable_add2line_warn to addr2line_disable_warn (with 'r')
   and start name with prefix addr2line_ to make it consistent with
   other addr2line_xxx configuration parameters.
Patch 2:
   Enable symbol_conf::addr2line_disable_warn set via config file.
Patch 3:
   Remove global variable addr2line_timeout_ms and make it a member

Thomas Richter (3):
  perf config: Rename symbol_conf::disable_add2line_warn
  perf config: Make symbol_conf::addr2line_disable_warn configurable
  perf addr2line: Remove global variable addr2line_timeout_ms

 tools/perf/Documentation/perf-config.txt |  6 ++++++
 tools/perf/builtin-diff.c                |  4 ++--
 tools/perf/util/addr2line.c              | 20 ++++++++++----------
 tools/perf/util/addr2line.h              |  2 --
 tools/perf/util/block-info.c             |  2 +-
 tools/perf/util/config.c                 |  6 ++++--
 tools/perf/util/libbfd.c                 |  2 +-
 tools/perf/util/symbol_conf.h            |  3 ++-
 8 files changed, 26 insertions(+), 19 deletions(-)

-- 
2.53.0
Re: [PATCH v3 0/3] perf addr2line: Rework disable_add2line_warn
Posted by Namhyung Kim 2 months ago
On Tue, 07 Apr 2026 12:08:32 +0200, Thomas Richter wrote:
> Introduce configurable addr2line_disable_warn entry in the .perfconfig
> file. Clean up addr2line configuration.
> 
> V2 --> V3: Added comments from Kim Namhyung
>            - Use perf_config_bool() to read addr2line-disable-warn
> 	     value
> 	   - Move perfconfig.txt update to proper patch file.
> 	   - Fix invalid default value in documentation.
> V1 --> V2: Update perf-config documentation.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung