From nobody Fri Jun 12 22:32:58 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B924E3A7852; Tue, 7 Apr 2026 10:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775556533; cv=none; b=AN0zjGFtlPjxAVTjGqAreKEe80gMy1daIEcYuqHVW7iLLyYgtcJJjuoVqCSI+cj9Byqa18Z5IQsRo5kWRQUgNcVBJ5CyNMamxuwvJVVRy4IYNZIhlgWwKvFN1BvwnO86DXLXX8Glx8oQ8ok/GNDXx+KOTH1ktLHTjpq1ERCQWVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775556533; c=relaxed/simple; bh=Bg8q27kugCuCb4kv51z81u98NnqQzWtwCDQmlXWiFjY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=agnbpSqgVxaiXk8JHINndAPInt37rIWggqu1ElqWv3eFZosqyyCABJGVbl46vqo9GyKicH6DjLyB49vMgcSPwvSvPi48oMBSKq30Rc33F5bJP6mS/PIlKMmfIzUMV0ql3jRNgVF949YIkH1lTBrIYsPTKrEockA7RxMyy6A0lSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=aUrLh2V5; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="aUrLh2V5" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LmIo02297727; Tue, 7 Apr 2026 10:08:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=MrLflxXQ/K6dlH9fE FuDRdqQaNxkarZeYpe6V/xNXxk=; b=aUrLh2V5deuyYVNqFUmYSo3I4QiHib/Ug WT4U09EjXxNykj2rgaPNkM1vtC6I27PKe5uHS2McrNa+aqoVTV6E2A60KQ3q7+pE EJB1DmcJ1xJDwNDOCFAD0wc4Zti1/3LCJ2JHNgSqtlO2eyHlIvgu35fo9bM4Kb4W 3BLf8vvYKay+RgeeDpm99l9oWp50yHKxM9vuOHjA3ih5BDnQdbZCay6JU3I5vnO5 SSJ9qlwbzn2SwsJaD4a72WEBMWarqo3D0YJhQUF6xvX6NC8NEdOyqRrTuuPjQB8J OCEBqJtl2lNwFRgSFe95b/JkSjNKPSVzMb1tNBhFI3YmD3vwIQSyA== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2ft4ct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:08:48 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 6379BKJf018987; Tue, 7 Apr 2026 10:08:47 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dcme9a1xc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:08:46 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 637A8g2831588754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Apr 2026 10:08:42 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A9A80200A5; Tue, 7 Apr 2026 10:08:42 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75920200A7; Tue, 7 Apr 2026 10:08:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Apr 2026 10:08:42 +0000 (GMT) From: Thomas Richter To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com, Thomas Richter , Ian Rogers Subject: [PATCH v3 1/3] perf config: Rename symbol_conf::disable_add2line_warn Date: Tue, 7 Apr 2026 12:08:33 +0200 Message-ID: <20260407100835.3488645-2-tmricht@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260407100835.3488645-1-tmricht@linux.ibm.com> References: <20260407100835.3488645-1-tmricht@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=KeridwYD c=1 sm=1 tr=0 ts=69d4d7b0 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=1XWaLZrsAAAA:8 a=AHe9je6IJdT7xRrbWhoA:9 X-Proofpoint-ORIG-GUID: _1LyE9pGEtpRuA-AmpEzo66z6isawNWx X-Proofpoint-GUID: E--Vo--90vC8EQoQuYI-utU2q6LwTI13 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA5MCBTYWx0ZWRfX3XDR8H4bpI74 o2wW1HrjN7bBt/CLN16PiRqgsRcbp4nOczrI1jWHUw44y9NHr45mS0Ncj3JyKzCa4IxALBJXPcA dnZGRtooUEkK66Wzl5j9jvkY+bjjCrdhS3yMp9sk5LpwdXYdBlzhz6TC5lycdZT5uwe+btvrfkY ZhlKTGK6ULJh53oc/U71ZWLx3jvaxnY8NLZl1Y3Hm33dmKjwuNyG/eOiP488Phn/Qd2CyOrTOaE FyQSTntegkr4AGOcKp9bYYXVSHdAsUXWDCBdqY7aqt0KWk444Xu8nUog9E4Zy+K6+94SdU3cUew hX0anakfAnpW5LqHy5pcrr5mqlxWzjgMwyVSDvZZTm0kJk2oJ/asQOjLqa0dNK0roq/7dnp8vII wQPs6m5Bh47zZKbLAhbgjP/0aN+nWhBH4gdgxjcivKAGpLzUx0nUmxseOsbpjM3JzehW4u1twVP tL8tLY2PqIkGHnt1u0w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070090 Content-Type: text/plain; charset="utf-8" Rename member symbol_conf::disable_add2line_warn to symbol_conf::addr2line_disable_warn to make it consistent with other addr2line_xxx constants. Signed-off-by: Thomas Richter Reviewed-by: Ian Rogers --- tools/perf/builtin-diff.c | 4 ++-- tools/perf/util/addr2line.c | 12 ++++++------ tools/perf/util/block-info.c | 2 +- tools/perf/util/libbfd.c | 2 +- tools/perf/util/symbol_conf.h | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 69069926dd0b..35d599d5c9fa 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -1352,7 +1352,7 @@ static int cycles_printf(struct hist_entry *he, struc= t hist_entry *pair, /* * Avoid printing the warning "addr2line_init failed for ..." */ - symbol_conf.disable_add2line_warn =3D true; + symbol_conf.addr2line_disable_warn =3D true; =20 bi =3D block_he->block_info; =20 @@ -1986,7 +1986,7 @@ int cmd_diff(int argc, const char **argv) =20 if (compute =3D=3D COMPUTE_STREAM) { symbol_conf.show_branchflag_count =3D true; - symbol_conf.disable_add2line_warn =3D true; + symbol_conf.addr2line_disable_warn =3D true; callchain_param.mode =3D CHAIN_FLAT; callchain_param.key =3D CCKEY_SRCLINE; callchain_param.branch_callstack =3D 1; diff --git a/tools/perf/util/addr2line.c b/tools/perf/util/addr2line.c index 31c0391fffa3..e9f084db0802 100644 --- a/tools/perf/util/addr2line.c +++ b/tools/perf/util/addr2line.c @@ -123,7 +123,7 @@ static enum cmd_a2l_style cmd_addr2line_configure(struc= t child_process *a2l, con lines =3D 3; pr_debug3("Detected binutils addr2line style\n"); } else { - if (!symbol_conf.disable_add2line_warn) { + if (!symbol_conf.addr2line_disable_warn) { char *output =3D NULL; size_t output_len; =20 @@ -310,7 +310,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, } =20 if (a2l =3D=3D NULL) { - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("%s %s: addr2line_subprocess_init failed\n", __func__, dso_n= ame); goto out; } @@ -330,7 +330,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, len =3D snprintf(buf, sizeof(buf), "%016"PRIx64"\n,\n", addr); written =3D len > 0 ? write(a2l->in, buf, len) : -1; if (written !=3D len) { - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("%s %s: could not send request\n", __func__, dso_name); goto out; } @@ -339,7 +339,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, switch (read_addr2line_record(&io, cmd_a2l_style, dso_name, addr, /*first= =3D*/true, &record_function, &record_filename, &record_line_nr)) { case -1: - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("%s %s: could not read first record\n", __func__, dso_name); goto out; case 0: @@ -355,7 +355,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, /*addr=3D*/1, /*first=3D*/true, NULL, NULL, NULL)) { case -1: - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("%s %s: could not read sentinel record\n", __func__, dso_name); break; @@ -363,7 +363,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, /* The sentinel as expected. */ break; default: - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("%s %s: unexpected record instead of sentinel", __func__, dso_name); break; diff --git a/tools/perf/util/block-info.c b/tools/perf/util/block-info.c index 649392bee7ed..8d3a9a661f26 100644 --- a/tools/perf/util/block-info.c +++ b/tools/perf/util/block-info.c @@ -303,7 +303,7 @@ static int block_range_entry(struct perf_hpp_fmt *fmt, = struct perf_hpp *hpp, char buf[128]; char *start_line, *end_line; =20 - symbol_conf.disable_add2line_warn =3D true; + symbol_conf.addr2line_disable_warn =3D true; =20 start_line =3D map__srcline(he->ms.map, bi->sym->start + bi->start, he->ms.sym); diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c index 63ea3fb53e77..c1c12308cc12 100644 --- a/tools/perf/util/libbfd.c +++ b/tools/perf/util/libbfd.c @@ -233,7 +233,7 @@ int libbfd__addr2line(const char *dso_name, u64 addr, } =20 if (a2l =3D=3D NULL) { - if (!symbol_conf.disable_add2line_warn) + if (!symbol_conf.addr2line_disable_warn) pr_warning("addr2line_init failed for %s\n", dso_name); return 0; } diff --git a/tools/perf/util/symbol_conf.h b/tools/perf/util/symbol_conf.h index ac1b444a8fd8..21a1f096d4f0 100644 --- a/tools/perf/util/symbol_conf.h +++ b/tools/perf/util/symbol_conf.h @@ -51,7 +51,7 @@ struct symbol_conf { report_block, report_individual_block, inline_name, - disable_add2line_warn, + addr2line_disable_warn, no_buildid_mmap2, guest_code, lazy_load_kernel_maps, --=20 2.53.0 From nobody Fri Jun 12 22:32:58 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FDE38B7DB; Tue, 7 Apr 2026 10:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775557887; cv=none; b=L55bZEMz7VcZAEM2CQLNWKd+cNhhTONA2JI/7zHu0mtVGWS1ROhZYBZQtatoPbKXgZT2vAlhWlGEENU/Xo+MVFJJcMvq0Z3oTDkcsE53XT5eqEzeoDUYVhONV6zYuYfbGadevKebzk+dHWeEic3mogflYQUcO5JmcSiSGvP0/xA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775557887; c=relaxed/simple; bh=OwR/etfBC7wQiPvBrNl3qQJ4kiVO153rG2KqBxAE9/Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FpX+TD/XkpPywIxS+Uqq8or7aEzyW/yDdvREQJgRhypl9H046u8S8w+PHyV1y0zssABuYKFtbrUwWj3kub6Qe2bSgkas4/XcxQk0bfF3D5hHY/jJ/Jz63rzypwM6Rms2c7e3vIizV55ayDHezCrTdlXN1DO6Av8wTzpzpAlMGQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=cqgp0VYa; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="cqgp0VYa" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LlueD2591301; Tue, 7 Apr 2026 10:31:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=tYVTMXR2tIb8FF7Xj A8qKhppXWNCUyTP16s1kfR5hh8=; b=cqgp0VYaJZxFXyCXV4FsoDb4sEBX9KNv1 85CaC6O+9l5D/whEVJQRLM5qmnET0jtlQiDDF6MvJsYHydlQJb916e7F7EQd9/RT 0Ayl6CW/qoMAsTPlZpaxtMRlAy11CRdmU5m2kERRQaSzQ37DdLgZ/WZJxcISpOX6 rk3uDnhP/ovyjZUvP0+S3LHUpwGIqNADkK4YmG93L6xqKXKWYk7JaqN96gFqFNq4 s2N1lONKG1ErX3taQiUTSYDc6igr1yeLWjTb7XW9/VmiSZQN+9WI8un+JHX2ieGY WYFq4ZGcFnFzkaoXKDL0Wspg6iySy6cyf5WfInBOe3Mn5Qz6MGG7g== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2e2efq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:31:23 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 63793upj007881; Tue, 7 Apr 2026 10:31:22 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dcmg2a7as-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:31:22 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 637AVITZ20119938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Apr 2026 10:31:18 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF823200A7; Tue, 7 Apr 2026 10:08:43 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7B4D4200A6; Tue, 7 Apr 2026 10:08:43 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Apr 2026 10:08:43 +0000 (GMT) From: Thomas Richter To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com, Thomas Richter , Ian Rogers Subject: [PATCH v3 2/3] perf config: Make symbol_conf::addr2line_disable_warn configurable Date: Tue, 7 Apr 2026 12:08:34 +0200 Message-ID: <20260407100835.3488645-3-tmricht@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260407100835.3488645-1-tmricht@linux.ibm.com> References: <20260407100835.3488645-1-tmricht@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: 3G5SyTnT-FO-ZqPGHG5Lsi8ebWaF5exn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA5NSBTYWx0ZWRfX9T3/arNp9rLb kD+rgBBHZXcdIAzttDNUfJeow05N85QJyMhtXuc7DDDCsk1d0h1ouKojPXAI8oEifnQmsFQd+Bw vhO+q5FUU2TPTcBja6CBvniSptYMKf0aykLuIuQbzEUn+25IKFXeE5P6zVBJ/r/37Qjaw+ua0m/ zEcOLl9qvPSN3sQPRJ9njoIQs439f0HMes5ble/4go14rpmq395Hcbqi5em7SBUz1Xv+7cxzrIr 8O5/DfnA9k4YTTrA4D0VkOyyAI5u5coGhHkHPcu+EaHecNN8Ew3O8DytwkgclI1lszbFHOVlke/ HVjzB0pK2k8xb5UBPxcvFYNIK8tDDPPSyHTxENpqUVzN3t1tKhpYgrc8y3NRUy//7WprOjADvkT ttViHXT+SoCd4d4VOZY3szq6KMKpvSMa6ErYv2cC5gzmBtzOZK34uwyobV9dEZEdDXmXwrlHID2 7/+Ez1KoR65o9ndD0tQ== X-Authority-Analysis: v=2.4 cv=Cfw4Irrl c=1 sm=1 tr=0 ts=69d4dcfb cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=DK11Rftqn3b6i-WP93oA:9 X-Proofpoint-GUID: MYZpoxdiShXyf-vFBEJpoJukC57LhwYh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070095 Content-Type: text/plain; charset="utf-8" Make symbol_conf::addr2line_disable_warn configurable by reading the perfconfig file. Use section core and addr2line-disable-warn =3D value. Update documentation. Example: # perf config -l core.addr2line-timeout=3D5000 core.addr2line-disable-warn=3D1 # Signed-off-by: Thomas Richter Suggested-by: Namhyung Kim Reviewed-by: Ian Rogers Cc: Ian Rogers --- tools/perf/Documentation/perf-config.txt | 6 ++++++ tools/perf/util/config.c | 3 +++ 2 files changed, 9 insertions(+) diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Document= ation/perf-config.txt index 642d1c490d9e..9b223f892829 100644 --- a/tools/perf/Documentation/perf-config.txt +++ b/tools/perf/Documentation/perf-config.txt @@ -210,6 +210,12 @@ core.*:: Sets a timeout (in milliseconds) for parsing /proc//maps files. Can be overridden by the --proc-map-timeout option on supported subcommands. The default timeout is 500ms. + addr2line-disable-warn:: + When set to 'true' disable all warnings from 'addr2line' output. + Default setting is 'false' to show these warnings. + addr2line-timeout:: + Sets a timeout (in milliseconds) for parsing 'addr2line' + output. The default timeout is 5s. =20 tui.*, gtk.*:: Subcommands that can be configured here are 'top', 'report' and 'annotate= '. diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 0452fbc6c085..8e30def2b1f7 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -461,6 +461,9 @@ static int perf_default_core_config(const char *var, co= nst char *value) if (!strcmp(var, "core.addr2line-timeout")) addr2line_timeout_ms =3D strtoul(value, NULL, 10); =20 + if (!strcmp(var, "core.addr2line-disable-warn")) + symbol_conf.addr2line_disable_warn =3D perf_config_bool(var, value); + /* Add other config variables here. */ return 0; } --=20 2.53.0 From nobody Fri Jun 12 22:32:58 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD843A782C; Tue, 7 Apr 2026 10:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775556534; cv=none; b=S9+cBjnU5K39pZauzAeKR/qWTGQzuNho/3ZOgLmdN0Uc1L3bH5ah4c6mrCoiXZ5pVTW699LmX2WcCtnK0T7UySk+G3ZpqS8KjpWHpcQXL9vQKpWbOyQQJxf/rdBe4IytqWO1pJeQoa2LA4V8sRqFMIeLFUHhyk7zcCCy2R0yITw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775556534; c=relaxed/simple; bh=Buma9OP6UORjm+C2IWsGZvDJNdQfeIlGHgpczGX6clU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CQL7lcequwPW6oBi3PNxs76Bo3nUiE1OeqKnn7DflhwyrcbKxcombXiUlfQ39UpwYcxvZ4jdRcq5lO1+LtSFBR1dBz3oppxiHm/hYypNW4MR2eGb8UjO6+4l08CNSMJijfNnZuF+/MBqDKj0BESWUebQ/0fQbfXBgABb3y3gQhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=FJ4h/yz0; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="FJ4h/yz0" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LmUP72211703; Tue, 7 Apr 2026 10:08:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=7oPCF1WK0MJjWVRp0 MyOFF4sObRxm4O89kOJ3CGj+Pk=; b=FJ4h/yz0/yBhMiLw89NanACx/pooCh1v0 vcM5RN4KlQlrdYaQwOUZoryB0Hs4Af9E8cbyw+mG8KE17hc4wO7XZRxc3wotp+c7 Tn4nnStKyPcJmvZG//+IKplL7dcoskzDpK6c1bNhIBaxhEdpWWEN3XfAfHojOMuG eQJfAw0cLQ1N41kfnLrr/mYZ7fQrOGHTvOGM1QPdmZ/8Vu3J6S+isOQDbKqIm1s+ +HxoisdUe+3H1D9lxHCN8TNU5LhuY5/3NwQvWS4srBcbfSGZIse2jfKnaLMh7fkw 5vTYJZE0V/+GBKuhF6ic5K/M9s1ptDy4zEdd6rqV8vSSFWPNSxdEg== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2ha3ju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:08:49 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 637991Bw013902; Tue, 7 Apr 2026 10:08:49 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dcmf421ma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2026 10:08:48 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 637A8i0745941188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Apr 2026 10:08:44 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 989DB200AA; Tue, 7 Apr 2026 10:08:44 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63EDB200A5; Tue, 7 Apr 2026 10:08:44 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Apr 2026 10:08:44 +0000 (GMT) From: Thomas Richter To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com, Thomas Richter , Ian Rogers Subject: [PATCH v3 3/3] perf addr2line: Remove global variable addr2line_timeout_ms Date: Tue, 7 Apr 2026 12:08:35 +0200 Message-ID: <20260407100835.3488645-4-tmricht@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260407100835.3488645-1-tmricht@linux.ibm.com> References: <20260407100835.3488645-1-tmricht@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA5MCBTYWx0ZWRfX3AZAalKj/8K8 uK6vGHEYvb4FOTvnK3EyN+hMFZuWft4XxxJZEy4bMDRjjSQKYo5Wd0bYaE9iSY4s1eLTE2uAqOs DdIFreMvBthBfVDbjAoW9TVQfsOyhSBI5ktObedawxTtbMnHoflm6EO25eF3bcc1NYn4pWEgeDZ ZZuV1B7tKPZ+v82AP10howKaLGCAOs9w/qk6YMW2R9c3JxW9yYtD5x9LmNzuod1wIRSlAYhlI1X 5CyzBw9XqOXkG40dv2tpYyZhxsznrpJVeT3d4WHerVU1oFsw7aq12BYdc3Zyx1X2as1bW1eJUAe uGbOel+tamYSwAXYLOkdMq8y69U6G+ZR8F9lBYkAjL5PwYfk9RZJ/hclWs+DbS8CJhmeEcXjMCb RHuyYd2tXr5atsOSSSNYr7fIXjGA2H8lHoJkl1vIZTdpGgROP2GKavbUZ3QIVS/qr/bRp7Vp/hB QNDLzEXbDhBv6i/iA3w== X-Proofpoint-GUID: mDaSs_VhqiiHTbcFbFX_HMWIX0C1CLO6 X-Authority-Analysis: v=2.4 cv=a/wAM0SF c=1 sm=1 tr=0 ts=69d4d7b1 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=1XWaLZrsAAAA:8 a=4Ms4tONn8Qn1zPKtktQA:9 X-Proofpoint-ORIG-GUID: hfx0O2xkeWtunIZfXm6DQkOAX-B1xwDm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070090 Content-Type: text/plain; charset="utf-8" Remove global variable addr2line_timeout_ms and add is as member to symbol_conf structure. Signed-off-by: Thomas Richter Reviewed-by: Ian Rogers Cc: Ian Rogers --- tools/perf/util/addr2line.c | 8 ++++---- tools/perf/util/addr2line.h | 2 -- tools/perf/util/config.c | 3 +-- tools/perf/util/symbol_conf.h | 1 + 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/addr2line.c b/tools/perf/util/addr2line.c index e9f084db0802..1b7f66ece570 100644 --- a/tools/perf/util/addr2line.c +++ b/tools/perf/util/addr2line.c @@ -18,9 +18,6 @@ =20 #define MAX_INLINE_NEST 1024 =20 -/* If addr2line doesn't return data for 5 seconds then timeout. */ -int addr2line_timeout_ms =3D 5 * 1000; - static int filename_split(char *filename, unsigned int *line_nr) { char *sep; @@ -87,6 +84,9 @@ static struct child_process *addr2line_subprocess_init(co= nst char *addr2line_pat return NULL; } =20 + if (!symbol_conf.addr2line_timeout_ms) + symbol_conf.addr2line_timeout_ms =3D 5 * 1000; + return a2l; } =20 @@ -335,7 +335,7 @@ int cmd__addr2line(const char *dso_name, u64 addr, goto out; } io__init(&io, a2l->out, buf, sizeof(buf)); - io.timeout_ms =3D addr2line_timeout_ms; + io.timeout_ms =3D symbol_conf.addr2line_timeout_ms; switch (read_addr2line_record(&io, cmd_a2l_style, dso_name, addr, /*first= =3D*/true, &record_function, &record_filename, &record_line_nr)) { case -1: diff --git a/tools/perf/util/addr2line.h b/tools/perf/util/addr2line.h index d35a47ba8dab..75989a92f16b 100644 --- a/tools/perf/util/addr2line.h +++ b/tools/perf/util/addr2line.h @@ -8,8 +8,6 @@ struct dso; struct inline_node; struct symbol; =20 -extern int addr2line_timeout_ms; - int cmd__addr2line(const char *dso_name, u64 addr, char **file, unsigned int *line_nr, struct dso *dso, diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 8e30def2b1f7..087002fb1b9b 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -19,7 +19,6 @@ #include "util/hist.h" /* perf_hist_config */ #include "util/stat.h" /* perf_stat__set_big_num */ #include "util/evsel.h" /* evsel__hw_names, evsel__use_bpf_counters */ -#include "util/addr2line.h" /* addr2line_timeout_ms */ #include "srcline.h" #include "build-id.h" #include "debug.h" @@ -459,7 +458,7 @@ static int perf_default_core_config(const char *var, co= nst char *value) proc_map_timeout =3D strtoul(value, NULL, 10); =20 if (!strcmp(var, "core.addr2line-timeout")) - addr2line_timeout_ms =3D strtoul(value, NULL, 10); + symbol_conf.addr2line_timeout_ms =3D strtoul(value, NULL, 10); =20 if (!strcmp(var, "core.addr2line-disable-warn")) symbol_conf.addr2line_disable_warn =3D perf_config_bool(var, value); diff --git a/tools/perf/util/symbol_conf.h b/tools/perf/util/symbol_conf.h index 21a1f096d4f0..6cd454d7c98e 100644 --- a/tools/perf/util/symbol_conf.h +++ b/tools/perf/util/symbol_conf.h @@ -80,6 +80,7 @@ struct symbol_conf { *bt_stop_list_str; const char *addr2line_path; enum a2l_style addr2line_style[MAX_A2L_STYLE]; + int addr2line_timeout_ms; unsigned long time_quantum; struct strlist *dso_list, *comm_list, --=20 2.53.0