[PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it

Mateusz Guzik posted 1 patch 17 hours ago
fs/inode.c | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it
Posted by Mateusz Guzik 17 hours ago
I failed to notice the change which added get_kernel_nofault() usage
removed it. It very much is still applicable.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
 fs/inode.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/inode.c b/fs/inode.c
index 5e5cddd76a9d..912831645f38 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -3100,6 +3100,12 @@ EXPORT_SYMBOL(mode_strip_sgid);
  *
  * If inode is an invalid pointer, we don't want to crash accessing it,
  * so probe everything depending on it carefully with get_kernel_nofault().
+ *
+ * TODO:
+ * - add more fields
+ * - pretty print flags instead of merely showing numerical values
+ * - consider extending inode ops with a ->dump_inode func so that filesystems
+ *   can print additional information
  */
 void dump_inode(struct inode *inode, const char *reason)
 {
-- 
2.48.1