From nobody Wed Apr 1 09:43:49 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379453090C2 for ; Tue, 31 Mar 2026 15:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969631; cv=none; b=doyfgVPUOvr0oGfca4vzRx5Zk2ijGVcYoic/r/swZG6YRtHaVdkovnuE+KOcwPFM975Pu7VnRL8u1gsBPSJ4s95v1WxEKLNNW8c2+2XumVp4OD1qcT8Am0ce/Usvnn8N8Vz6LYIS+H1ahYwRUse3PHqlSxP0oMKxRuxsmtcOong= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774969631; c=relaxed/simple; bh=sIq+HA1bMYdqH2Erp3qSFPRM2QQJsMwhWFNyPrpPIs8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IdeKQtOvgm8Yzd/Uo920jG7h6k/KQUKBWdpQReXXJNRxLm6yFW8J1+QCRGrOYwp1uKMjMLPnAAiGoGTcPqbbAP5682Ax117f6Ec3uh8xdzq6QqH4JsKCAzNmCKTKxHvmnmQcSPzj0eUtzGVo1tjI5P0THxdkmo8cZG+9qjvMbf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PubqxeHm; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PubqxeHm" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43cf7683a28so1581662f8f.2 for ; Tue, 31 Mar 2026 08:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774969628; x=1775574428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QP1+m9jjLQoVTaKevZQc6+yN+9p/W/azRVm4avbLCr4=; b=PubqxeHm3vMgGIoLSR3va5Y2X3G6N+VIJWE369wABM6hdb7iNOL5EBTnSAHEae4di4 OU77f+FKF4KGuHj8UJvlor6tX4pKwVi1HRMoCxy7Wgu8BzP48q7OF5DcJoNGoWQoygjj HIH72Yp7ROOqJjDk7z9JpJTD0A9J+VlwOcXh1HHnWv9wqm2fC8BjZzR4sRSDLlGPexBB wC/61LLF9wqLWGjrbAg0j5VnzdFM3xQjRqT5hPuCAe9vR4IIsk4jFkCP85nQiWghBFr0 c65aNwx6EXqluKKDAIvHqVtznVZYpFiWngwSWdKGsBdaQ6S/BrFxNgrYJY3spgcXWega VqLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774969628; x=1775574428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QP1+m9jjLQoVTaKevZQc6+yN+9p/W/azRVm4avbLCr4=; b=gwhfnRmXOxSp7t4nytvtejaT/gkXdBCB1n6xk/kdkkrq9jjv1113SDtnwuM68DWV94 R2vZ65xDTor74MYDWGYB/Mw/xMPz5rYlb/U1e98yrYXvr8kwTBsXJLBekFwspGEW3xU8 D3r1FK6tziQY9kBzKZHOiwBUBVSqDnO8DDyUaT2PMoF/ffKBUIXfUtkTjJASwgkN6+Bz jwyiJGgv34iTuf9cLkAyUDfgX3vv7kfmowDi/+AtfCEXruc9PIze+YPY4tLZ5XomHlgl g4XYTkFiUuRoEPi4LAygCou6mymrEjA3daRH2pQVntojsNjmjBcijfLrqDMvme7RnjZL 22PA== X-Forwarded-Encrypted: i=1; AJvYcCV1ElQGEbIBxcXWHnhO/D6F1bx6N8MYtYqpE3zLk8nwHTmgET70ptOFZ/d612Mppzrhp5ZusQUwVoLFEew=@vger.kernel.org X-Gm-Message-State: AOJu0YzXHloS2T8vQQdagwicA/V5RDyVezzJ6ge6uB9uudX3KyP8+UJ5 bES/9HzBuE0poJxkEsQmhQosYYuxd++MN/KtpFisqdm+lLuWQBMnaiRJ X-Gm-Gg: ATEYQzx9P8013FZOcL2r5ywCPF91+Xt6nfm7ruK7XLjIwaWAyiK+8OL11sHQCLY8rgy Z9S205mJ4gsvZtgf5NTOTyN73zRXvae5d9T3h532b/O8gJYsHZ79GZcDzUljbO+Qcw1uZWzu0EN fwLAOZhmgICc9y1/Kf79BIW7rg4cruu3sW0y2Ye+Fp9elRGPFoZZzhNm30HVFi4pi+nimHy0rNJ PpfLhTweMilxuQ6hKk+QDcm6Onaa/SfSyVmW0JPVlOhqA9/0HcykouiN44+cwSmXpYYXmtDwgnL s8ZkZhyF+9rEkUTeUtNlnK6F4X4W1DAopulaEQBx/t+lVEE/Xxxtnj9BRtCwXWsP4UvjWOVXh4h 15aRK0WmzGmJUZfzteiS83BuLYTHbsBlqXBs788JQTetsH4z/4tnb7c2YzVRmmLRv11/lQdcc3O JIvUhQs7NSG2eoe7RKpXWx6cjXpqk6Ene03xqeq4fe5OtsRO4F2jNAuPko8b4JIwZU7RF1stTN8 w== X-Received: by 2002:a05:6000:184d:b0:43b:4469:d106 with SMTP id ffacd0b85a97d-43b9e9fa20fmr28599844f8f.40.1774969628281; Tue, 31 Mar 2026 08:07:08 -0700 (PDT) Received: from f.. (cst-prg-89-171.cust.vodafone.cz. [46.135.89.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e9e24sm26882128f8f.10.2026.03.31.08.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:07:07 -0700 (PDT) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH] fs: add back TODO concerning printed info to dump_inode() and expand it Date: Tue, 31 Mar 2026 17:07:01 +0200 Message-ID: <20260331150701.3844815-1-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I failed to notice the change which added get_kernel_nofault() usage removed it. It very much is still applicable. Signed-off-by: Mateusz Guzik --- fs/inode.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/inode.c b/fs/inode.c index 5e5cddd76a9d..912831645f38 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -3100,6 +3100,12 @@ EXPORT_SYMBOL(mode_strip_sgid); * * If inode is an invalid pointer, we don't want to crash accessing it, * so probe everything depending on it carefully with get_kernel_nofault(). + * + * TODO: + * - add more fields + * - pretty print flags instead of merely showing numerical values + * - consider extending inode ops with a ->dump_inode func so that filesys= tems + * can print additional information */ void dump_inode(struct inode *inode, const char *reason) { --=20 2.48.1