[PATCH v6 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

Marco Nenciarini posted 4 patches 1 day, 3 hours ago
There is a newer version of this series
drivers/platform/x86/intel/int3472/discrete.c | 16 ++++-
drivers/platform/x86/intel/int3472/led.c      | 62 +++++++++++--------
include/linux/platform_data/x86/int3472.h     | 13 ++--
3 files changed, 59 insertions(+), 32 deletions(-)
[PATCH v6 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)
Posted by Marco Nenciarini 1 day, 3 hours ago
Add support for INT3472 GPIO type 0x02 which controls an IR flood LED
used for face authentication on some laptops (e.g. Dell Pro Max 16
Premium). Without this, the kernel logs "GPIO type 0x02 unknown; the
sensor may not work" and IR sensors paired with a flood LED cannot
function.

The series first refactors the existing LED code (patches 1-3), then
adds the new IR flood LED type with multi-LED support (patch 4).

Changes in v6:
- Renamed LED from "strobe" back to "ir_flood" to describe what the
  hardware actually does, per Hans de Goede's review. The internal
  define INT3472_GPIO_TYPE_STROBE is kept to match the ACPI _DSM name.
- Used local `led` variable from patch 1 (was `pled`, now `led`
  throughout), per Andy's suggestion to reduce churn
- Renamed function parameter from `name` to `con_id` in patch 3
- Replaced `has_lookup` bool with INIT_LIST_HEAD/list_empty check and
  renamed parameter to `add_lookup` in patch 4, per Andy's review
- Added #include <linux/list.h> in patch 4

Marco Nenciarini (4):
  platform/x86: int3472: Use local variable for LED struct access
  platform/x86: int3472: Rename pled to led in LED registration code
  platform/x86: int3472: Parameterize LED con_id in registration
  platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)

 drivers/platform/x86/intel/int3472/discrete.c | 16 ++++-
 drivers/platform/x86/intel/int3472/led.c      | 62 +++++++++++--------
 include/linux/platform_data/x86/int3472.h     | 13 ++--
 3 files changed, 59 insertions(+), 32 deletions(-)

-- 
2.47.3
Re: [PATCH v6 0/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED)
Posted by Andy Shevchenko 1 day ago
On Tue, Mar 31, 2026 at 09:52:00AM +0200, Marco Nenciarini wrote:
> Add support for INT3472 GPIO type 0x02 which controls an IR flood LED
> used for face authentication on some laptops (e.g. Dell Pro Max 16
> Premium). Without this, the kernel logs "GPIO type 0x02 unknown; the
> sensor may not work" and IR sensors paired with a flood LED cannot
> function.
> 
> The series first refactors the existing LED code (patches 1-3), then
> adds the new IR flood LED type with multi-LED support (patch 4).

Almost. A few cosmetic changes and I'm glad to see it's done.

Also please note, when sending a new version make sure it starts a new email
thread (no In-Reply-To should be filled by the cover letter).

-- 
With Best Regards,
Andy Shevchenko