From nobody Wed Apr 1 12:36:57 2026 Received: from spark.kcore.it (spark.kcore.it [49.13.27.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F23F43D75CF; Tue, 31 Mar 2026 07:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.13.27.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943535; cv=none; b=sT20Mzapz2RFHl/d8Bg8QMJfpRpLxZTROyuaBkvyGELTkQNOmvxYAY4EI3W0hHZ6pFW6kVG4vjJtX1G+UUzc1os1yMpRq3WbXcxvaN5lHJVBSP4IRTsbVC6/m1s5MGsli/5F/8tvijnryQzkPBmJgJV+rzRm0Y8gbPle8W3fZ3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943535; c=relaxed/simple; bh=X8FBR4Kz7FmEdJLG7GWh2Z1f19493eUzRr9kNgYRx30=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MyC1iuBo4r6c3Y3kE4QS+o5GzUFpPEhU9/vicyo+jf7nHhNSDfiepDeciym3EagjVXo8hMcRJNuFLRq7KvDCL6mXH4cNHHaEpfxeZCyE7kSajeHyvJNVNcZ+bYsYEI3zGiiRbNBBLceS7NJWorEHtWdJ/L3pz4zCoof9s6FQ7R0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it; spf=pass smtp.mailfrom=kcore.it; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b=QDdT/ZMs; arc=none smtp.client-ip=49.13.27.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kcore.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b="QDdT/ZMs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kcore.it; s=spark; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=A+gdA3VJhQR1GVOvTKFRBP67MbojnPhGodMPDkM3zfo=; b=QDdT/ZMsUJJqu0pZkuBcY1IEMp rRoW8TJmOSNN/7UjJ+iEJdWKaZDHi+4SgTlsOUvFFvemxs1XaSSSsTTAQfgvAY1jmfYgENDFzaqQB MBR4H0flc+ky2voxop6SH2TZDd5FhGZQzc8ybcfLt5tW5oMuLlYlLsctLAg1rqqqv82o=; Received: from mnencia by spark.kcore.it with local (Exim 4.96) (envelope-from ) id 1w7TtN-006ZoP-07; Tue, 31 Mar 2026 09:52:05 +0200 From: Marco Nenciarini To: Daniel Scally , Sakari Ailus , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Nenciarini Subject: [PATCH v6 1/4] platform/x86: int3472: Use local variable for LED struct access Date: Tue, 31 Mar 2026 09:52:01 +0200 Message-Id: <20260331075204.1567624-2-mnencia@kcore.it> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260331075204.1567624-1-mnencia@kcore.it> References: <20260331075204.1567624-1-mnencia@kcore.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a local struct int3472_pled pointer in the LED registration, unregistration, and brightness callback functions to avoid repeatedly dereferencing int3472->pled. In the brightness callback, use container_of() to get the int3472_pled struct directly instead of going through int3472_discrete_device. No functional change. Signed-off-by: Marco Nenciarini Reviewed-by: Andy Shevchenko --- Cc: Andy Shevchenko drivers/platform/x86/intel/int3472/led.c | 42 +++++++++++++----------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x8= 6/intel/int3472/led.c index b1d84b9..86df81a 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -7,54 +7,56 @@ #include =20 static int int3472_pled_set(struct led_classdev *led_cdev, - enum led_brightness brightness) + enum led_brightness brightness) { - struct int3472_discrete_device *int3472 =3D - container_of(led_cdev, struct int3472_discrete_device, pled.classdev); + struct int3472_pled *led =3D container_of(led_cdev, struct int3472_pled, = classdev); =20 - gpiod_set_value_cansleep(int3472->pled.gpio, brightness); + gpiod_set_value_cansleep(led->gpio, brightness); return 0; } =20 int skl_int3472_register_pled(struct int3472_discrete_device *int3472, str= uct gpio_desc *gpio) { + struct int3472_pled *led =3D &int3472->pled; char *p; int ret; =20 - if (int3472->pled.classdev.dev) + if (led->classdev.dev) return -EBUSY; =20 - int3472->pled.gpio =3D gpio; + led->gpio =3D gpio; =20 /* Generate the name, replacing the ':' in the ACPI devname with '_' */ - snprintf(int3472->pled.name, sizeof(int3472->pled.name), + snprintf(led->name, sizeof(led->name), "%s::privacy_led", acpi_dev_name(int3472->sensor)); - p =3D strchr(int3472->pled.name, ':'); + p =3D strchr(led->name, ':'); if (p) *p =3D '_'; =20 - int3472->pled.classdev.name =3D int3472->pled.name; - int3472->pled.classdev.max_brightness =3D 1; - int3472->pled.classdev.brightness_set_blocking =3D int3472_pled_set; + led->classdev.name =3D led->name; + led->classdev.max_brightness =3D 1; + led->classdev.brightness_set_blocking =3D int3472_pled_set; =20 - ret =3D led_classdev_register(int3472->dev, &int3472->pled.classdev); + ret =3D led_classdev_register(int3472->dev, &led->classdev); if (ret) return ret; =20 - int3472->pled.lookup.provider =3D int3472->pled.name; - int3472->pled.lookup.dev_id =3D int3472->sensor_name; - int3472->pled.lookup.con_id =3D "privacy"; - led_add_lookup(&int3472->pled.lookup); + led->lookup.provider =3D led->name; + led->lookup.dev_id =3D int3472->sensor_name; + led->lookup.con_id =3D "privacy"; + led_add_lookup(&led->lookup); =20 return 0; } =20 void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472) { - if (IS_ERR_OR_NULL(int3472->pled.classdev.dev)) + struct int3472_pled *led =3D &int3472->pled; + + if (IS_ERR_OR_NULL(led->classdev.dev)) return; =20 - led_remove_lookup(&int3472->pled.lookup); - led_classdev_unregister(&int3472->pled.classdev); - gpiod_put(int3472->pled.gpio); + led_remove_lookup(&led->lookup); + led_classdev_unregister(&led->classdev); + gpiod_put(led->gpio); } --=20 2.47.3 From nobody Wed Apr 1 12:36:57 2026 Received: from spark.kcore.it (spark.kcore.it [49.13.27.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 346143CF699; Tue, 31 Mar 2026 07:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.13.27.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943531; cv=none; b=I/uMm+MAczOXLTN0q08bVc2xno8snh+HkJUBZ4FnvT1aAffWu0yeVTdPVAiMgEpgGBxSeUTutZEceehDhoLlvH2d5tQquekjmqb/JE7TuaXiQX+vcvDWz4pgH/3epbuhavY+YVvD3Sz+/n/n1+V5VaYmX+9vBQqESXEbTmLixPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943531; c=relaxed/simple; bh=URNEaxw6vAOJt8cft7knqxbMf6Mjx2CEMk0L7LtFkBM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HLrrjMMYJHfQunTkSgx3GYJwrkNQyG9hpD1JZkcj9ORZLbkmHOJRVLMmtYQob7sGf5aUQtTq4Qxvd7ewhczAszuC+ty8soHCh9+vQ5hpsvjWwj2RtYLzDFX5bhi0vxKdKRfH5zukUvNIfRtnQvfPqlHwrcj7Dn2/ChzNiZSD6XM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it; spf=pass smtp.mailfrom=kcore.it; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b=T1tQH4xE; arc=none smtp.client-ip=49.13.27.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kcore.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b="T1tQH4xE" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kcore.it; s=spark; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TfsGma0HRCaJckPSwJSzEW3BVGLaKzUj4B4X7nOd5S0=; b=T1tQH4xEpfOqu6Q2EsXCNOsgzI vBTIT/h7KHc50Veg0TB+G8jHsEEtTzUVJWhs2zN145F0YBOF0kPNc1tf2EM1EkqZ8FXWVov5QDzHJ +1bQfhNeRT7zP9mgSbqMDFxeDq8IKzopTjW7++zu2CFrdSIeotIJE/cEZbVJD8xxLegQ=; Received: from mnencia by spark.kcore.it with local (Exim 4.96) (envelope-from ) id 1w7TtN-006ZoS-0C; Tue, 31 Mar 2026 09:52:05 +0200 From: Marco Nenciarini To: Daniel Scally , Sakari Ailus , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Nenciarini Subject: [PATCH v6 2/4] platform/x86: int3472: Rename pled to led in LED registration code Date: Tue, 31 Mar 2026 09:52:02 +0200 Message-Id: <20260331075204.1567624-3-mnencia@kcore.it> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260331075204.1567624-1-mnencia@kcore.it> References: <20260331075204.1567624-1-mnencia@kcore.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the privacy LED type, struct member, and functions from "pled" to "led" in preparation for supporting additional LED types beyond just the privacy LED. No functional change. Signed-off-by: Marco Nenciarini Reviewed-by: Andy Shevchenko --- Cc: Andy Shevchenko drivers/platform/x86/intel/int3472/discrete.c | 4 ++-- drivers/platform/x86/intel/int3472/led.c | 14 +++++++------- include/linux/platform_data/x86/int3472.h | 8 ++++---- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platfo= rm/x86/intel/int3472/discrete.c index 1505fc3..cb24763 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -348,7 +348,7 @@ static int skl_int3472_handle_gpio_resources(struct acp= i_resource *ares, =20 break; case INT3472_GPIO_TYPE_PRIVACY_LED: - ret =3D skl_int3472_register_pled(int3472, gpio); + ret =3D skl_int3472_register_led(int3472, gpio); if (ret) err_msg =3D "Failed to register LED\n"; =20 @@ -422,7 +422,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_d= evice *int3472) gpiod_remove_lookup_table(&int3472->gpios); =20 skl_int3472_unregister_clock(int3472); - skl_int3472_unregister_pled(int3472); + skl_int3472_unregister_led(int3472); skl_int3472_unregister_regulator(int3472); } EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE"); diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x8= 6/intel/int3472/led.c index 86df81a..8bd4903 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -6,18 +6,18 @@ #include #include =20 -static int int3472_pled_set(struct led_classdev *led_cdev, +static int int3472_led_set(struct led_classdev *led_cdev, enum led_brightness brightness) { - struct int3472_pled *led =3D container_of(led_cdev, struct int3472_pled, = classdev); + struct int3472_led *led =3D container_of(led_cdev, struct int3472_led, cl= assdev); =20 gpiod_set_value_cansleep(led->gpio, brightness); return 0; } =20 -int skl_int3472_register_pled(struct int3472_discrete_device *int3472, str= uct gpio_desc *gpio) +int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio) { - struct int3472_pled *led =3D &int3472->pled; + struct int3472_led *led =3D &int3472->led; char *p; int ret; =20 @@ -35,7 +35,7 @@ int skl_int3472_register_pled(struct int3472_discrete_dev= ice *int3472, struct gp =20 led->classdev.name =3D led->name; led->classdev.max_brightness =3D 1; - led->classdev.brightness_set_blocking =3D int3472_pled_set; + led->classdev.brightness_set_blocking =3D int3472_led_set; =20 ret =3D led_classdev_register(int3472->dev, &led->classdev); if (ret) @@ -49,9 +49,9 @@ int skl_int3472_register_pled(struct int3472_discrete_dev= ice *int3472, struct gp return 0; } =20 -void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472) +void skl_int3472_unregister_led(struct int3472_discrete_device *int3472) { - struct int3472_pled *led =3D &int3472->pled; + struct int3472_led *led =3D &int3472->led; =20 if (IS_ERR_OR_NULL(led->classdev.dev)) return; diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/plat= form_data/x86/int3472.h index b1b8375..7af6731 100644 --- a/include/linux/platform_data/x86/int3472.h +++ b/include/linux/platform_data/x86/int3472.h @@ -121,12 +121,12 @@ struct int3472_discrete_device { u8 imgclk_index; } clock; =20 - struct int3472_pled { + struct int3472_led { struct led_classdev classdev; struct led_lookup_data lookup; char name[INT3472_LED_MAX_NAME_LEN]; struct gpio_desc *gpio; - } pled; + } led; =20 struct int3472_discrete_quirks quirks; =20 @@ -160,7 +160,7 @@ int skl_int3472_register_regulator(struct int3472_discr= ete_device *int3472, const char *second_sensor); void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3= 472); =20 -int skl_int3472_register_pled(struct int3472_discrete_device *int3472, str= uct gpio_desc *gpio); -void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472); +int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio); +void skl_int3472_unregister_led(struct int3472_discrete_device *int3472); =20 #endif --=20 2.47.3 From nobody Wed Apr 1 12:36:57 2026 Received: from spark.kcore.it (spark.kcore.it [49.13.27.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC29A3CEB98; Tue, 31 Mar 2026 07:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.13.27.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943532; cv=none; b=lY6KHHeCJo78S/YMR+XJJbdlv2KcRb7blxK6LrqSC7sr8b+6HfnHStiO9LokzDMhM1YXOKcyQJN+3JvtZKmB8owzVk7LHhFaw/2IB2jFqnfT4u9YWa+z4rYhvwvhLECzx5tny+Y9TvzFvTLxp2jACd04wEEF8/iBRLtqha2o9lA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943532; c=relaxed/simple; bh=JNdbpaNiFGKuDB4+iCAS3uYPQ6ziOtCtEWlCCF0XRmQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SbBeXIMYD9JoZ7xqtUUPl21GlHfRNQUSYq61q8qF/UtkovQe6H8wCFQHx6RjlDPxKMMDx98k1LhHbC07dPQMQO/FUnXdSNZmiG0wBAu+RR/Yi3P9SO10MHCK6kFTXT6hA4baR/2ExgaiA4mR0EuBSmejf04B/9+xOXPDIOxFG/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it; spf=pass smtp.mailfrom=kcore.it; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b=oan5T/Gs; arc=none smtp.client-ip=49.13.27.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kcore.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b="oan5T/Gs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kcore.it; s=spark; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CvcZ1ZaM/VH0POy5eaDjcEdZEK/vz9XxQVnBC6mc9o8=; b=oan5T/GsPPofCw4JBux3duUFf0 3Kpbi/WGjzLzBkHxhc+Ostt31IPFDE2ES6sb7v8DhHpR/enRga85HJKKGOmq08rq6kXhC2yR6wDeN m28OfWMa8OS/EjqllwSpJ9IXDkcu4bR3pZXbNxALnaYom0tgVxnr4r0FFKkaR7cXjYLs=; Received: from mnencia by spark.kcore.it with local (Exim 4.96) (envelope-from ) id 1w7TtN-006ZoV-0G; Tue, 31 Mar 2026 09:52:05 +0200 From: Marco Nenciarini To: Daniel Scally , Sakari Ailus , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Nenciarini Subject: [PATCH v6 3/4] platform/x86: int3472: Parameterize LED con_id in registration Date: Tue, 31 Mar 2026 09:52:03 +0200 Message-Id: <20260331075204.1567624-4-mnencia@kcore.it> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260331075204.1567624-1-mnencia@kcore.it> References: <20260331075204.1567624-1-mnencia@kcore.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a con_id parameter to skl_int3472_register_led() to allow callers to specify both the LED name suffix and lookup con_id instead of hardcoding "privacy". This prepares for registering additional LED types with different names. No functional change. Signed-off-by: Marco Nenciarini Reviewed-by: Andy Shevchenko --- Cc: Andy Shevchenko drivers/platform/x86/intel/int3472/discrete.c | 2 +- drivers/platform/x86/intel/int3472/led.c | 7 ++++--- include/linux/platform_data/x86/int3472.h | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platfo= rm/x86/intel/int3472/discrete.c index cb24763..57c3b2c 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -348,7 +348,7 @@ static int skl_int3472_handle_gpio_resources(struct acp= i_resource *ares, =20 break; case INT3472_GPIO_TYPE_PRIVACY_LED: - ret =3D skl_int3472_register_led(int3472, gpio); + ret =3D skl_int3472_register_led(int3472, gpio, "privacy"); if (ret) err_msg =3D "Failed to register LED\n"; =20 diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x8= 6/intel/int3472/led.c index 8bd4903..39466d4 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -15,7 +15,8 @@ static int int3472_led_set(struct led_classdev *led_cdev, return 0; } =20 -int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio) +int skl_int3472_register_led(struct int3472_discrete_device *int3472, + struct gpio_desc *gpio, const char *con_id) { struct int3472_led *led =3D &int3472->led; char *p; @@ -28,7 +29,7 @@ int skl_int3472_register_led(struct int3472_discrete_devi= ce *int3472, struct gpi =20 /* Generate the name, replacing the ':' in the ACPI devname with '_' */ snprintf(led->name, sizeof(led->name), - "%s::privacy_led", acpi_dev_name(int3472->sensor)); + "%s::%s_led", acpi_dev_name(int3472->sensor), con_id); p =3D strchr(led->name, ':'); if (p) *p =3D '_'; @@ -43,7 +44,7 @@ int skl_int3472_register_led(struct int3472_discrete_devi= ce *int3472, struct gpi =20 led->lookup.provider =3D led->name; led->lookup.dev_id =3D int3472->sensor_name; - led->lookup.con_id =3D "privacy"; + led->lookup.con_id =3D con_id; led_add_lookup(&led->lookup); =20 return 0; diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/plat= form_data/x86/int3472.h index 7af6731..5213911 100644 --- a/include/linux/platform_data/x86/int3472.h +++ b/include/linux/platform_data/x86/int3472.h @@ -160,7 +160,8 @@ int skl_int3472_register_regulator(struct int3472_discr= ete_device *int3472, const char *second_sensor); void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3= 472); =20 -int skl_int3472_register_led(struct int3472_discrete_device *int3472, stru= ct gpio_desc *gpio); +int skl_int3472_register_led(struct int3472_discrete_device *int3472, + struct gpio_desc *gpio, const char *con_id); void skl_int3472_unregister_led(struct int3472_discrete_device *int3472); =20 #endif --=20 2.47.3 From nobody Wed Apr 1 12:36:57 2026 Received: from spark.kcore.it (spark.kcore.it [49.13.27.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345863CD8BE; Tue, 31 Mar 2026 07:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.13.27.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943531; cv=none; b=mvDSyaoLwaUuZaVKzRs+42Dugh5o2SWa5UB36Bj+R1oqWnz3LnkiCyxGJS2pWQqH+6T8wUuYgfBA1FVGOxNP/d8cLJaROrwo35YbPi/mln+DkrsyPllLiDagoZdl4iJ4GBxM+22g65v74aGy80+SSTpH1X+YpK6BE5oM+UJxiBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774943531; c=relaxed/simple; bh=2qXKWqVqgm/7crcPDCVD5wGUmdAXHS24+CCFfwmlnDA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SdksGnKg+KSRvr9TPuZbSujyBDE6fSL1VK7rumyiiwRmjKK6ZU0zE7uq8qrQhN7++q4lyaKFjUFXXCKadLGAz/pBdOZS6nY+tR/p6u5dx5XBZskTbqGBK14v02wYnJ32IleKjxACMnDARjV8xg+TskLRyRsHvG2SmRmUH0N1EXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it; spf=pass smtp.mailfrom=kcore.it; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b=V+aTdJAx; arc=none smtp.client-ip=49.13.27.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kcore.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kcore.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kcore.it header.i=@kcore.it header.b="V+aTdJAx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kcore.it; s=spark; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NpriGdcD5NbsT32LA4dS/KzK3W30O4gcHtIkK8mv3SI=; b=V+aTdJAxlu4WcktRFDDSSjE0yf zEa+laAxGRMfHhyb6uM9V8EmbAzemhJRfPomAapXUghVeZrpqVnCL4thGLkiL0BT5sVX5cJ8zpVrz IYRzuUeUEqL4NHDok6j0TRvtK+4b/XJ6998SWWhxCNYa4MHwEK+sHlqapNetRbcRj7Cw=; Received: from mnencia by spark.kcore.it with local (Exim 4.96) (envelope-from ) id 1w7TtN-006ZoY-0L; Tue, 31 Mar 2026 09:52:05 +0200 From: Marco Nenciarini To: Daniel Scally , Sakari Ailus , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Andy Shevchenko , Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Nenciarini Subject: [PATCH v6 4/4] platform/x86: int3472: Add support for GPIO type 0x02 (IR flood LED) Date: Tue, 31 Mar 2026 09:52:04 +0200 Message-Id: <20260331075204.1567624-5-mnencia@kcore.it> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260331075204.1567624-1-mnencia@kcore.it> References: <20260331075204.1567624-1-mnencia@kcore.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for GPIO type 0x02, which controls an IR flood LED used for face authentication on some laptops (e.g. Dell Pro Max 16 Premium). Without this patch, the kernel logs "GPIO type 0x02 unknown; the sensor may not work" and IR sensors paired with a flood LED cannot function. The flood LED is registered through the LED subsystem like the existing privacy LED. Unlike the privacy LED, it does not have a lookup entry since there is no consumer driver expecting it via led_get(). To support multiple LEDs per INT3472 device, convert the single led struct member to an array with a counter. Signed-off-by: Marco Nenciarini Reviewed-by: Andy Shevchenko --- The ACPI _DSM tables refer to this GPIO type as "strobe", hence the INT3472_GPIO_TYPE_STROBE define. The userspace-visible LED name uses "ir_flood" instead, as the hardware is an IR flood illuminator, not a flash strobe. Cc: Andy Shevchenko drivers/platform/x86/intel/int3472/discrete.c | 16 +++++++- drivers/platform/x86/intel/int3472/led.c | 39 +++++++++++-------- include/linux/platform_data/x86/int3472.h | 10 +++-- 3 files changed, 44 insertions(+), 21 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platfo= rm/x86/intel/int3472/discrete.c index 57c3b2c..78111e5 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -215,6 +215,10 @@ static void int3472_get_con_id_and_polarity(struct int= 3472_discrete_device *int3 *con_id =3D "privacy-led"; *gpio_flags =3D GPIO_ACTIVE_HIGH; break; + case INT3472_GPIO_TYPE_STROBE: + *con_id =3D "ir_flood"; + *gpio_flags =3D GPIO_ACTIVE_HIGH; + break; case INT3472_GPIO_TYPE_HOTPLUG_DETECT: *con_id =3D "hpd"; *gpio_flags =3D GPIO_ACTIVE_HIGH; @@ -248,6 +252,7 @@ static void int3472_get_con_id_and_polarity(struct int3= 472_discrete_device *int3 * * 0x00 Reset * 0x01 Power down + * 0x02 Strobe * 0x0b Power enable * 0x0c Clock enable * 0x0d Privacy LED @@ -331,6 +336,7 @@ static int skl_int3472_handle_gpio_resources(struct acp= i_resource *ares, break; case INT3472_GPIO_TYPE_CLK_ENABLE: case INT3472_GPIO_TYPE_PRIVACY_LED: + case INT3472_GPIO_TYPE_STROBE: case INT3472_GPIO_TYPE_POWER_ENABLE: case INT3472_GPIO_TYPE_HANDSHAKE: gpio =3D skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, = gpio_flags); @@ -348,7 +354,13 @@ static int skl_int3472_handle_gpio_resources(struct ac= pi_resource *ares, =20 break; case INT3472_GPIO_TYPE_PRIVACY_LED: - ret =3D skl_int3472_register_led(int3472, gpio, "privacy"); + ret =3D skl_int3472_register_led(int3472, gpio, "privacy", true); + if (ret) + err_msg =3D "Failed to register LED\n"; + + break; + case INT3472_GPIO_TYPE_STROBE: + ret =3D skl_int3472_register_led(int3472, gpio, "ir_flood", false); if (ret) err_msg =3D "Failed to register LED\n"; =20 @@ -422,7 +434,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_d= evice *int3472) gpiod_remove_lookup_table(&int3472->gpios); =20 skl_int3472_unregister_clock(int3472); - skl_int3472_unregister_led(int3472); + skl_int3472_unregister_leds(int3472); skl_int3472_unregister_regulator(int3472); } EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE"); diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x8= 6/intel/int3472/led.c index 39466d4..e7cd144 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -4,6 +4,7 @@ #include #include #include +#include #include =20 static int int3472_led_set(struct led_classdev *led_cdev, @@ -16,16 +17,19 @@ static int int3472_led_set(struct led_classdev *led_cde= v, } =20 int skl_int3472_register_led(struct int3472_discrete_device *int3472, - struct gpio_desc *gpio, const char *con_id) + struct gpio_desc *gpio, const char *con_id, + bool add_lookup) { - struct int3472_led *led =3D &int3472->led; + struct int3472_led *led; char *p; int ret; =20 - if (led->classdev.dev) - return -EBUSY; + if (int3472->n_leds >=3D INT3472_MAX_LEDS) + return -ENOSPC; =20 + led =3D &int3472->leds[int3472->n_leds]; led->gpio =3D gpio; + INIT_LIST_HEAD(&led->lookup.list); =20 /* Generate the name, replacing the ':' in the ACPI devname with '_' */ snprintf(led->name, sizeof(led->name), @@ -42,22 +46,25 @@ int skl_int3472_register_led(struct int3472_discrete_de= vice *int3472, if (ret) return ret; =20 - led->lookup.provider =3D led->name; - led->lookup.dev_id =3D int3472->sensor_name; - led->lookup.con_id =3D con_id; - led_add_lookup(&led->lookup); + if (add_lookup) { + led->lookup.provider =3D led->name; + led->lookup.dev_id =3D int3472->sensor_name; + led->lookup.con_id =3D con_id; + led_add_lookup(&led->lookup); + } =20 + int3472->n_leds++; return 0; } =20 -void skl_int3472_unregister_led(struct int3472_discrete_device *int3472) +void skl_int3472_unregister_leds(struct int3472_discrete_device *int3472) { - struct int3472_led *led =3D &int3472->led; + for (unsigned int i =3D 0; i < int3472->n_leds; i++) { + struct int3472_led *led =3D &int3472->leds[i]; =20 - if (IS_ERR_OR_NULL(led->classdev.dev)) - return; - - led_remove_lookup(&led->lookup); - led_classdev_unregister(&led->classdev); - gpiod_put(led->gpio); + if (!list_empty(&led->lookup.list)) + led_remove_lookup(&led->lookup); + led_classdev_unregister(&led->classdev); + gpiod_put(led->gpio); + } } diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/plat= form_data/x86/int3472.h index 5213911..7366a25 100644 --- a/include/linux/platform_data/x86/int3472.h +++ b/include/linux/platform_data/x86/int3472.h @@ -23,6 +23,7 @@ /* PMIC GPIO Types */ #define INT3472_GPIO_TYPE_RESET 0x00 #define INT3472_GPIO_TYPE_POWERDOWN 0x01 +#define INT3472_GPIO_TYPE_STROBE 0x02 #define INT3472_GPIO_TYPE_POWER_ENABLE 0x0b #define INT3472_GPIO_TYPE_CLK_ENABLE 0x0c #define INT3472_GPIO_TYPE_PRIVACY_LED 0x0d @@ -31,6 +32,7 @@ =20 #define INT3472_PDEV_MAX_NAME_LEN 23 #define INT3472_MAX_SENSOR_GPIOS 3 +#define INT3472_MAX_LEDS 2 #define INT3472_MAX_REGULATORS 3 =20 /* E.g. "avdd\0" */ @@ -126,11 +128,12 @@ struct int3472_discrete_device { struct led_lookup_data lookup; char name[INT3472_LED_MAX_NAME_LEN]; struct gpio_desc *gpio; - } led; + } leds[INT3472_MAX_LEDS]; =20 struct int3472_discrete_quirks quirks; =20 unsigned int ngpios; /* how many GPIOs have we seen */ + unsigned int n_leds; /* how many LEDs have we registered */ unsigned int n_sensor_gpios; /* how many have we mapped to sensor */ unsigned int n_regulator_gpios; /* how many have we mapped to a regulator= */ struct gpiod_lookup_table gpios; @@ -161,7 +164,8 @@ int skl_int3472_register_regulator(struct int3472_discr= ete_device *int3472, void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3= 472); =20 int skl_int3472_register_led(struct int3472_discrete_device *int3472, - struct gpio_desc *gpio, const char *con_id); -void skl_int3472_unregister_led(struct int3472_discrete_device *int3472); + struct gpio_desc *gpio, const char *con_id, + bool add_lookup); +void skl_int3472_unregister_leds(struct int3472_discrete_device *int3472); =20 #endif --=20 2.47.3