This patch series modernizes the mkiss driver, which is used for
AX.25 communication over serial lines.

The series starts by moving variable assignments out of 'if'
conditions to improve code safety and readability.
The second patch removes redundant static initializations to 0.
The third patch fixes missing spaces around assignment operations.
The fourth patch modernizes the logging system by replacing legacy
printk() calls with netdev_* and pr_* macros for better
device-specific context.
The fifth patch addresses remaining checkpatch.pl issues, primarily
converting space-based indentation to tabs, aligning parameters, and
fixing comment formats.

These changes have been compile-tested.

Mashiro Chen (5):
  hamradio: mkiss: move assignments out of if conditions
  hamradio: mkiss: remove redundant static initialization to 0
  hamradio: mkiss: fix spacing around assignment operator
  hamradio: mkiss: modernize logging with netdev and pr macros
  hamradio: mkiss: cleanup indentation and coding style

 drivers/net/hamradio/mkiss.c | 98 ++++++++++++++++--------------------
 1 file changed, 44 insertions(+), 54 deletions(-)

-- 
2.53.0

On Sun, 29 Mar 2026 22:34:03 +0800 Mashiro Chen wrote:
> This patch series modernizes the mkiss driver, which is used for
> AX.25 communication over serial lines.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject

Hi Jakub,

Thank you for the quick review and for pointing out the Netdev policy
regarding clean-up patches. I apologize for the noise; I was not fully
aware of the specific guidelines for the Netdev subsystem in this regard.

I will respect these guidelines and focus my further contributions on
functional improvements or bug fixes.

Regarding the current series, I understand them do not meet the Netdev
Standard for clean-up patches and I will drop these submissions.

Thank you again for your time and guidance.

Best Regards,
Mashiro Chen