From nobody Thu Apr 2 10:57:41 2026 Received: from mout-y-209.mailbox.org (mout-y-209.mailbox.org [91.198.250.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 528CB36C9C1; Sun, 29 Mar 2026 14:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.250.237 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794900; cv=none; b=XThl+/+JPdNRIhI4wlrpg2O05bpdKE3Cz1IL+WHDiwdu5bRioLH9KXr1pl3riFYDWpPCwD4di6+9FMb1tb5Oie41SEB7hp+CgTNrhdWGOnaIGyH4dAj1FyrbeVsCWftXxhLsHJgD6F+DZ1Zzs5pMA3ksjKNZdAI1dl01bd2WODQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794900; c=relaxed/simple; bh=H4OReyZYEJw+EIZJLYdpcrMXwbdzfOq5Y9BMVzx1P4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ijWsGwE9z6r0MUzcr6exbpHgy2Z/jnVeXlmm2oasdTBoMg9st0SwACw+8FpibxsSoD1St54DKIdgIFikcqYfXkToZlnm7D0ccf/abSQLP1p/W4TXVNN9X1XkTuNsMzoCQW2j8+WLJIgN1Tfkkp8hGVW1VIxXH+rKSTrtguDIFNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=iaqFPkuT; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=c2ujkUkX; arc=none smtp.client-ip=91.198.250.237 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="iaqFPkuT"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="c2ujkUkX" Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4fkH344kWWzB15q; Sun, 29 Mar 2026 16:34:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1aqDfbFa1iCuB28C+Gs91A6jzgvXiA0+cvmHO8xRGaw=; b=iaqFPkuTZwrwRDzWbAxsF9iYplpq6P/Q+8oioKT0e+47AfYbQ+pR8ypWlMEB0UaxmXW88F SxmV/Yp05rOOWdkCBiSs4ZgLdxLTqbXBIe6AJOGZMBchXVRoUbmOGYkKIMpjg432QDX6Ch Q+hNlZdgw23iidajcOIVDRDyiTl/ZLo64/c3YisBR244ZP0fCOOgUd1hV1oynoj1Icae4i ststdHhAlcUxLsRz4QB2DSrXyvjZv7dzR4+zsqdJRlGAd3FG/Mpm/1nZQpKOKVt/X5BMfY ZU59j0lYjfbMXNTH2kVW4MRA3mpcB+ckNtMAVa2ie94Nl/OFJWzJLJzSRfEPRA== Authentication-Results: outgoing_mbo_mout; dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=c2ujkUkX; spf=pass (outgoing_mbo_mout: domain of mashiro.chen@mailbox.org designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=mashiro.chen@mailbox.org From: Mashiro Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1aqDfbFa1iCuB28C+Gs91A6jzgvXiA0+cvmHO8xRGaw=; b=c2ujkUkX65BRGGaK42XzDOf/OdKqtPfEQ53TeK+iLzMpTWrmV/oPnzTGi14P6CSKO80MkK gRt/0yRhH2ww+ZAgUNayiTky+eM2Uksd1BTCoyCWedEVe0lPI0/e31EpI6vZdRGqbDkBlh 2H8q8+wU4wp42Vc4CqY79OiC2Mnok1TNAa9VoDBgwDR7Q5o6UgUi8+Ss6UBScZIdJzbLxR JNf1w2Lw/iuejH8rMPLVnTsBhs8NbtS7zFyeETC/UJuISMH3nG5JiVGFUylnjkhgyS9ICh r+NmPRdNBgLstLJZxMc/9ruuTESGNis+SQuDJalhw7Fmgy3jWAWxYIEJsGptNw== To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, Mashiro Chen Subject: [PATCH 1/5] hamradio: mkiss: move assignments out of if conditions Date: Sun, 29 Mar 2026 22:34:04 +0800 Message-ID: <20260329143408.747197-2-mashiro.chen@mailbox.org> In-Reply-To: <20260329143408.747197-1-mashiro.chen@mailbox.org> References: <20260329143408.747197-1-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-META: egixi1dqeihowp7jpbqq3usbs77tnjgn X-MBO-RS-ID: be6bcb8adc1f6aa82d0 X-Rspamd-Queue-Id: 4fkH344kWWzB15q Content-Type: text/plain; charset="utf-8" Move assignments out of if conditions to comply with the Linux Kernel coding style and improve code readability. This also switches to the preferred 'if (!ptr)' idiom for NULL pointer checks. Signed-off-by: Mashiro Chen --- drivers/net/hamradio/mkiss.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 5f38a002b..eac45d936 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -282,7 +282,8 @@ static void ax_bump(struct mkiss *ax) =20 count =3D ax->rcount; =20 - if ((skb =3D dev_alloc_skb(count)) =3D=3D NULL) { + skb =3D dev_alloc_skb(count); + if (!skb) { printk(KERN_ERR "mkiss: %s: memory squeeze, dropping packet.\n", ax->dev->name); ax->dev->stats.rx_dropped++; @@ -591,10 +592,12 @@ static int ax_open(struct net_device *dev) if (len < 576 * 2) len =3D 576 * 2; =20 - if ((ax->rbuff =3D kmalloc(len + 4, GFP_KERNEL)) =3D=3D NULL) + ax->rbuff =3D kmalloc(len + 4, GFP_KERNEL); + if (!ax->rbuff) goto norbuff; =20 - if ((ax->xbuff =3D kmalloc(len + 4, GFP_KERNEL)) =3D=3D NULL) + ax->xbuff =3D kmalloc(len + 4, GFP_KERNEL); + if (!ax->xbuff) goto noxbuff; =20 ax->mtu =3D dev->mtu + 73; --=20 2.53.0 From nobody Thu Apr 2 10:57:41 2026 Received: from mout-y-209.mailbox.org (mout-y-209.mailbox.org [91.198.250.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D9883793A4; Sun, 29 Mar 2026 14:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.250.237 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794907; cv=none; b=lHS+Tv9oJXxz05egL/wfmuV1sOpJ0/peIleOyzh0r3zcCOJ5PuojvALHrICM0X7sWBdDcXuZnGJJ5jrV9RbbbdwvTBqRUGvAYnTmSV5ajR7AEzAa4oJV2J5GbhoC6W1umQB5DwLoKPioqq8C5e/CtnvM1IY78hdYfIcFn3qkXTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794907; c=relaxed/simple; bh=HPSfrOSyflEDsPPutOyoR+lBR/dwTkjyv1EHtxr8G7c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZWEhH0ehM9ZXQvXxg9IZ4+dCty5FjwZanPw8ZrKFQk4P2wfA8q2fi0xOtWxGmCUtHMVioXDSdw16FkDBXHRzpyeyDrklUP+ekpSspc+ncOMgwIi1XFbViccmegmQxB340wF7g4FDWSGDcpHCgQ/qagROaF9IGGujm8N+WMEgkI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=yRoSPapY; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=mApmdXbU; arc=none smtp.client-ip=91.198.250.237 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="yRoSPapY"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="mApmdXbU" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4fkH3C4wQBzB12J; Sun, 29 Mar 2026 16:35:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjlUEvmvkigT1ah8ECWudjKocEQAAMyY51iehZYxEbE=; b=yRoSPapY7cE4gG/gFIIm9cCuyVrt1wZRDsaQtUuT7PunTNsbg9CmLYbag5k3iJJxOsVx3M A3Is7r8l8twGOXaM53YFn+/Rv/KA1rNMjtY4Q5/K9/KRzty3fV2Tj6K9G9dckMS0f5FZSH aIW6gMlmd+MMtq7/zCSD6k1QduGPKG3i2DLP/DOQeTaP3kben0P1YXSzGEZqYvHQsznvYh rlfEq07es75G6b/wz9RI1BdVQJMCh8ccZTYpU6mn6vKmmfb9ryAoWDjQ+bQcByYnWivqtl GncVuiuBdVF/k3tmLvNTep/nGT4wjeZbWefQ34dlJ7TDeH7SPM31qgnbw5nmOA== From: Mashiro Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SjlUEvmvkigT1ah8ECWudjKocEQAAMyY51iehZYxEbE=; b=mApmdXbUH/Di4UcFU+/PZx6RYTTlDs2oIOTWmCb/o1g7gO0nDbMJXwkoIqAC7tz7rJGUwe Xwb3qaDYzhOIEg00SIGPQw9GZAhXDqqADpa6FLszO2+etuBVcu31y6Ufsb3XKUkbL2nCZi JmzZl6yvIGKedoKgK7YLJMyePOsMDu1f7Z62+trKuakfM9MI9nb7JexIx61JtjGZiSu2Sc 95CgKHG0797MpH78tkcpDwFxTQcyBH1uZ8Hv2MCUe5yPHvsUDgTU/T6x/1OgpYAqvexRy7 82bOblZWHUahUXwAgjjU2m46RNcJtxLOMMTdHGsKvRulZnAU9llhFuNZSle5cw== To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, Mashiro Chen Subject: [PATCH 2/5] hamradio: mkiss: remove redundant static initialization to 0 Date: Sun, 29 Mar 2026 22:34:05 +0800 Message-ID: <20260329143408.747197-3-mashiro.chen@mailbox.org> In-Reply-To: <20260329143408.747197-1-mashiro.chen@mailbox.org> References: <20260329143408.747197-1-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-ID: f200503a6cd8f425546 X-MBO-RS-META: 7ieh53i41ut41w89trnt6trzo5djdcxb Content-Type: text/plain; charset="utf-8" Static variables are automatically initialized to 0 by the compiler. Remove the explicit initialization to comply with the Linux Kernel coding standards. Signed-off-by: Mashiro Chen --- drivers/net/hamradio/mkiss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index eac45d936..3721572ce 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -686,7 +686,7 @@ static void mkiss_put(struct mkiss *ax) complete(&ax->dead); } =20 -static int crc_force =3D 0; /* Can be overridden with insmod */ +static int crc_force; /* Can be overridden with insmod */ =20 static int mkiss_open(struct tty_struct *tty) { --=20 2.53.0 From nobody Thu Apr 2 10:57:41 2026 Received: from mout-y-111.mailbox.org (mout-y-111.mailbox.org [91.198.250.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5D55313552; Sun, 29 Mar 2026 14:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.250.236 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794923; cv=none; b=NUqZM27OEPHYkSg0YEt6XhBxmTypRAYHStC5+w86KWV+frIIzfgKkV3A0b19T306QZFhJlMfS/QCw6DtgWpSOHDWTkxVdfJHncVA3TfWefFVrhTMpqaKOJkNkTJl4MTOL2Wt76Bjs0PIQu4SkXZ0+lNCfqSpoYx1EoqrzidSErU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794923; c=relaxed/simple; bh=tUxbiSgA/s0Xx7o7+3Y8m8kSwCRGLgBGXbEjRR534JQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s+07Xf+6h12vSLu8pFMZRZrnUWpMYa4tr8VbdrvFvmBQVykhW2INImAwtMd6JchA8S0g3tS+l70CTKRMYYC94mSjfjpnzKePKrpSIAqLMP7v2Asq242M58753uNY13XWDQE1VNN0S1TwLmZ231R1hPjNyRjqykbfZ8OfoX4tzo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=LOkHatM1; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=Ya64C7CR; arc=none smtp.client-ip=91.198.250.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="LOkHatM1"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="Ya64C7CR" Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4fkH3P564jz9ygk; Sun, 29 Mar 2026 16:35:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DFxFghpFoPQdi7SGn2QhRMR5os5nzruxLc6IA7icWvc=; b=LOkHatM1KR9v6aaNn5QUVUq0sI2M6nJDIYVc+rXcdC5wv7vvbAJpraEKJ/eBUHhkscTgXj MmVpkA6dDonpATZ3I2yxu8LUP4MccbgOt4KdGoWl4IzO5U0is6SoEtI4H3DjDqbUt3eYw4 CH3qqTql0QpYFlD75zU21AZ5qqvkg3H1Eh+9qIpG0842Ias2uLHHXX54DFo/V6LZEba1Ke WeaC13edw7Str3haxgyJhn4GJq9tq7X7OIVQccDnRzfpTPUvmEs6qSTPMa/7SaHyDe6lPx U0R6i9CNUZ9I5ApkateDDaehrxu4ljiV44DV+2+VqBc39IT7Q4ASSCm5Do/YEg== Authentication-Results: outgoing_mbo_mout; dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=Ya64C7CR; spf=pass (outgoing_mbo_mout: domain of mashiro.chen@mailbox.org designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=mashiro.chen@mailbox.org From: Mashiro Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DFxFghpFoPQdi7SGn2QhRMR5os5nzruxLc6IA7icWvc=; b=Ya64C7CRF7d85Keb9V8f3ng9LLTwsJVDKlWcX1gJjKyMeQ/eWDk0oJK5E3qZPD70BB0nbF oN96XGVe1vQzwnXTdF2e5zIwp5cEwLoJHIAvGm0gHJVJIs+pUheMwoowCPwqSNOTr6HWTm 80ryyGxbPMHKsHhrReSJpcdgd0/JvCUxGGpw3q+Ei9IQ5MD4Xp6xu5EMEMAF5gvBPxj52D jwb72awDwjrkZoBZrv7GXrkuyHAVqQCytso8iqNpHJkzwJ1UHoAjR5gwRaORl3rI2d2sYr NFepI/95ZOOPIzLbjyF3kPqBCCV9Gn017Tl9l/Bg/K+rLomQmaHDIt5bWGKNBg== To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, Mashiro Chen Subject: [PATCH 3/5] hamradio: mkiss: fix spacing around assignment operator Date: Sun, 29 Mar 2026 22:34:06 +0800 Message-ID: <20260329143408.747197-4-mashiro.chen@mailbox.org> In-Reply-To: <20260329143408.747197-1-mashiro.chen@mailbox.org> References: <20260329143408.747197-1-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-ID: b741d444fa07ae12c2e X-MBO-RS-META: psuwxqrsimaxyt7h1bt8k6ymon7zjdp5 X-Rspamd-Queue-Id: 4fkH3P564jz9ygk Content-Type: text/plain; charset="utf-8" Add missing spaces around the assignment operator to adhere to the Linux Kernel coding style. Signed-off-by: Mashiro Chen --- drivers/net/hamradio/mkiss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 3721572ce..b9160b95f 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -201,7 +201,7 @@ static int kiss_esc_crc(unsigned char *s, unsigned char= *d, unsigned short crc, int len) { unsigned char *ptr =3D d; - unsigned char c=3D0; + unsigned char c =3D 0; =20 *ptr++ =3D END; while (len > 0) { --=20 2.53.0 From nobody Thu Apr 2 10:57:41 2026 Received: from mout-y-209.mailbox.org (mout-y-209.mailbox.org [91.198.250.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CB736EAB8; Sun, 29 Mar 2026 14:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.250.237 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794926; cv=none; b=MCZTaS4w24nM8KPx7DNyIYu0QnRZ7EOPNsvredhDsqZBq6JAn98HJbxgUb3Fc/HpPFmimdXibe/gKdiewKCCkWJ//D7LSYtZ0V8FBz6FxVBXbPaMgb1gBGhb+zp/sTrzdRB5Ne67DRErLKj9F8LFwY/Jw9nfKMPM4CqyPMvePOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794926; c=relaxed/simple; bh=s3/VKpFq2ZVvYcAhvpWyg0QzeZ+ObTgNF74YA20D090=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=loaO2caiBlMUu3wqjZlnX1hjovn7+XQ4huubB1U0kFU49lokRd+tQO/MphUeKLZ9pM6m6Q8Pax0AlqF/6KQcCszLmTm1s0i+wfu1JvxDdhtAJWwxIupbWLKng0RJkMMcIjb3lqr3GifBzL/A3HkBzhDWK8G1Gr9De0PyPddUXQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=lWKIRLFL; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=FTUThhHj; arc=none smtp.client-ip=91.198.250.237 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="lWKIRLFL"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="FTUThhHj" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4fkH3Z4FFxzB15Y; Sun, 29 Mar 2026 16:35:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSHEf+vOm07DUwuFZuNsd+xmh9OA334UYTdjyDKm8JM=; b=lWKIRLFLL2VEVe4uBzByTpCkJzto+CqnHV3ZB4cBrox+42dIPh/5rO2rUUD6fgGGRbiePf HJPrz/L+Iwpw7C3K3WeS3oqyNwbqlr/3mIXOF1iPsToAAajF33J1VtEqxuMvmTo863lN0I Tt00i/Vy28p8L0FEA4jPaUMl3Iu9C0JpW5VI4EDpAbCNXGS33MB2iliwKbudUnndyYv8zB HpuhaoZkIlUkz56rC4sTFlcZn7qKIEYNHj3xhf2gjqLo1lnpmPUjzW70Vtxphh/ZgLCzf+ A5B2P2R/JjE4W0qxNj8NYeA1nSh/5C9mHBqaefarNGButbo677EfE/+Z891Zgg== From: Mashiro Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSHEf+vOm07DUwuFZuNsd+xmh9OA334UYTdjyDKm8JM=; b=FTUThhHjp0fAC0Kx/lb1F9AgkwkqztJ1fPD6iU1KA2ZZuOgZuDf6MY570Ox92oAM9Gvd5y JOPOLxcHbsnXUQLMfdzL/T3chKB7bPuyRgNXcxD6vdwyaGapXJ8ef/RtnAj4EiPlKng+mp 2ssHsWiAht/LRrwYnDO1leuGAzERVKHRx9OiWJyr5s8W+IwoWao32QQHOtjUwfWLhhi+j5 XbRmpkCnAjasowIL5rhL2X8xTNU98yzMGtADV3Ek0pfl9unAxjrnie2Hr0VyuK1Z5SmhIH iOq9sj/JRpVnSp2kIniYGpWfPU8j7rtbLEGg8DjwnhV2V8ErzOqkY+IDXJxN6A== To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, Mashiro Chen Subject: [PATCH 4/5] hamradio: mkiss: modernize logging with netdev and pr macros Date: Sun, 29 Mar 2026 22:34:07 +0800 Message-ID: <20260329143408.747197-5-mashiro.chen@mailbox.org> In-Reply-To: <20260329143408.747197-1-mashiro.chen@mailbox.org> References: <20260329143408.747197-1-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-ID: e24e158184cdcadac5d X-MBO-RS-META: qqikef4qtbimyw6zz684nkett7ayd995 Content-Type: text/plain; charset="utf-8" Replace legacy printk() calls with modern logging macros. This allows for better device-specific context by using netdev_err() and netdev_info() where possible. For global module-level messages, use pr_info() and pr_err(). This modernization also allows the removal of the redundant 'banner' and 'msg_regfail' static strings, simplifying the driver initialization logic. Signed-off-by: Mashiro Chen --- drivers/net/hamradio/mkiss.c | 51 ++++++++++++------------------------ 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index b9160b95f..75b9bd2e1 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -249,9 +249,7 @@ static void ax_bump(struct mkiss *ax) return; } if (ax->crcmode !=3D CRC_MODE_SMACK && ax->crcauto) { - printk(KERN_INFO - "mkiss: %s: Switching to crc-smack\n", - ax->dev->name); + netdev_info(ax->dev, "Switching to crc-smack\n"); ax->crcmode =3D CRC_MODE_SMACK; } ax->rcount -=3D 2; @@ -263,9 +261,7 @@ static void ax_bump(struct mkiss *ax) return; } if (ax->crcmode !=3D CRC_MODE_FLEX && ax->crcauto) { - printk(KERN_INFO - "mkiss: %s: Switching to crc-flexnet\n", - ax->dev->name); + netdev_info(ax->dev, "Switching to crc-flexnet\n"); ax->crcmode =3D CRC_MODE_FLEX; } ax->rcount -=3D 2; @@ -284,8 +280,7 @@ static void ax_bump(struct mkiss *ax) =20 skb =3D dev_alloc_skb(count); if (!skb) { - printk(KERN_ERR "mkiss: %s: memory squeeze, dropping packet.\n", - ax->dev->name); + netdev_err(ax->dev, "memory squeeze, dropping packet.\n"); ax->dev->stats.rx_dropped++; spin_unlock_bh(&ax->buflock); return; @@ -376,9 +371,7 @@ static void ax_changedmtu(struct mkiss *ax) rbuff =3D kmalloc(len + 4, GFP_ATOMIC); =20 if (xbuff =3D=3D NULL || rbuff =3D=3D NULL) { - printk(KERN_ERR "mkiss: %s: unable to grow ax25 buffers, " - "MTU change cancelled.\n", - ax->dev->name); + netdev_err(ax->dev, "unable to grow ax25 buffers, MTU change cancelled.\= n"); dev->mtu =3D ax->mtu; kfree(xbuff); kfree(rbuff); @@ -433,7 +426,7 @@ static void ax_encaps(struct net_device *dev, unsigned = char *icp, int len) ax_changedmtu(ax); =20 if (len > ax->mtu) { /* Sigh, shouldn't occur BUT ... */ - printk(KERN_ERR "mkiss: %s: truncating oversized transmit packet!\n", ax= ->dev->name); + netdev_err(ax->dev, "truncating oversized transmit packet!\n"); dev->stats.tx_dropped++; netif_start_queue(dev); return; @@ -469,8 +462,7 @@ static void ax_encaps(struct net_device *dev, unsigned = char *icp, int len) cmd =3D 0; } ax->crcauto =3D (cmd ? 0 : 1); - printk(KERN_INFO "mkiss: %s: crc mode set to %d\n", - ax->dev->name, cmd); + netdev_info(ax->dev, "crc mode set to %d\n", cmd); } spin_unlock_bh(&ax->buflock); netif_start_queue(dev); @@ -484,7 +476,7 @@ static void ax_encaps(struct net_device *dev, unsigned = char *icp, int len) switch (ax->crcmode) { case CRC_MODE_SMACK_TEST: ax->crcmode =3D CRC_MODE_FLEX_TEST; - printk(KERN_INFO "mkiss: %s: Trying crc-smack\n", ax->dev->name); + netdev_info(ax->dev, "Trying crc-smack\n"); fallthrough; case CRC_MODE_SMACK: *p |=3D 0x80; @@ -493,7 +485,7 @@ static void ax_encaps(struct net_device *dev, unsigned = char *icp, int len) break; case CRC_MODE_FLEX_TEST: ax->crcmode =3D CRC_MODE_NONE; - printk(KERN_INFO "mkiss: %s: Trying crc-flexnet\n", ax->dev->name); + netdev_info(ax->dev, "Trying crc-flexnet\n"); fallthrough; case CRC_MODE_FLEX: *p |=3D 0x20; @@ -526,7 +518,7 @@ static netdev_tx_t ax_xmit(struct sk_buff *skb, struct = net_device *dev) return ax25_ip_xmit(skb); =20 if (!netif_running(dev)) { - printk(KERN_ERR "mkiss: %s: xmit call when iface is down\n", dev->name); + netdev_err(ax->dev, "xmit call when iface is down\n"); return NETDEV_TX_BUSY; } =20 @@ -540,8 +532,8 @@ static netdev_tx_t ax_xmit(struct sk_buff *skb, struct = net_device *dev) return NETDEV_TX_BUSY; } =20 - printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name, - (tty_chars_in_buffer(ax->tty) || ax->xleft) ? + netdev_err(ax->dev, "transmit timed out, %s?\n", + (tty_chars_in_buffer(ax->tty) || ax->xleft) ? "bad line quality" : "driver error"); =20 ax->xleft =3D 0; @@ -735,24 +727,20 @@ static int mkiss_open(struct tty_struct *tty) switch (crc_force) { case 3: ax->crcmode =3D CRC_MODE_SMACK; - printk(KERN_INFO "mkiss: %s: crc mode smack forced.\n", - ax->dev->name); + netdev_info(ax->dev, "crc mode smack forced.\n"); break; case 2: ax->crcmode =3D CRC_MODE_FLEX; - printk(KERN_INFO "mkiss: %s: crc mode flexnet forced.\n", - ax->dev->name); + netdev_info(ax->dev, "crc mode flexnet forced.\n"); break; case 1: ax->crcmode =3D CRC_MODE_NONE; - printk(KERN_INFO "mkiss: %s: crc mode disabled.\n", - ax->dev->name); + netdev_info(ax->dev, "crc mode disabled.\n"); break; case 0: default: crc_force =3D 0; - printk(KERN_INFO "mkiss: %s: crc mode is auto.\n", - ax->dev->name); + netdev_info(ax->dev, "crc mode is auto.\n"); ax->crcmode =3D CRC_MODE_SMACK_TEST; } ax->crcauto =3D (crc_force ? 0 : 1); @@ -949,20 +937,15 @@ static struct tty_ldisc_ops ax_ldisc =3D { .write_wakeup =3D mkiss_write_wakeup }; =20 -static const char banner[] __initconst =3D KERN_INFO \ - "mkiss: AX.25 Multikiss, Hans Albas PE1AYX\n"; -static const char msg_regfail[] __initconst =3D KERN_ERR \ - "mkiss: can't register line discipline (err =3D %d)\n"; - static int __init mkiss_init_driver(void) { int status; =20 - printk(banner); + pr_info("mkiss: AX.25 Multikiss, Hans Albas PE1AYX\n"); =20 status =3D tty_register_ldisc(&ax_ldisc); if (status !=3D 0) - printk(msg_regfail, status); + pr_err("mkiss: can't register line discipline (err =3D %d)\n", status); =20 return status; } --=20 2.53.0 From nobody Thu Apr 2 10:57:41 2026 Received: from mout-y-111.mailbox.org (mout-y-111.mailbox.org [91.198.250.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24764175A77; Sun, 29 Mar 2026 14:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.250.236 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794936; cv=none; b=EMe33bh36RtU+U6Y+FH/pd2GLnD5+Dy7m8gCVQSjmAgEYIUKWDWk3uooqavO3i2rMkI3Ssbtz+uCTk9Nvre7phzU21jvbfnI7Czp2Dr/OCVCPeal16RhsvmG2CgMSFb0RjTB5v8/1IqL7CQgAppVf+akTz0JFmoznYZfyi5SsP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774794936; c=relaxed/simple; bh=R9AYP534H4yxPtjSPAG6yLFF2Kpi6mkRfxJEuVcZ5r8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RnAzj9+O8OwpDjZI6TWubOrRvp1mfRfHqPvxc86FUT7A4ug4xylRBeM+ddvu2mrAkkmwGeHGcNngnlZDenv09IjfU6sAvY5JXV6TcAQUS933luGwhWCQJxR3aunWn+b6lpOT41SGCHMGWyo+Yjy+Elv/55MplLdJNbjDI52FAnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=ykcIg/Ni; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=Oce4hFIg; arc=none smtp.client-ip=91.198.250.236 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="ykcIg/Ni"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="Oce4hFIg" Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4fkH3m3cwpzB02y; Sun, 29 Mar 2026 16:35:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cA6uD+0oCzRov5b9jthEp24abkpw//foWgsmdeyirZw=; b=ykcIg/NibXxMTRWOd05/d4dur7zGN4hSvoTbtH6PotAm+m3/KuACFncVno+yYfQluLd1kR 4PxaReYjiA2F2mj1qR/xMVBxYbj2wGK14++eTUNc4Cxm7JbL23rIWg9WxcLw9ehXrSTnQE Wias0D3KWPn0K0uix2j1/oQgPDRjqeEynoDMdd44Scdpc6/RRQsUpDMI7m3FrPF6c3nQux XyyLtwiVdtQqocA13qrN77Pg5KCNLwXZwvJClTQelKZ8K63ItWYEkuJTzM+6CrAOr9BNnl ALuE4yyHCv441zYCFuBbz7Zx4ssKf/9KQ2MvMMfdM2lpaPl1BemiF54SfHDMlQ== Authentication-Results: outgoing_mbo_mout; dkim=pass header.d=mailbox.org header.s=mail20150812 header.b=Oce4hFIg; spf=pass (outgoing_mbo_mout: domain of mashiro.chen@mailbox.org designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=mashiro.chen@mailbox.org From: Mashiro Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1774794930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cA6uD+0oCzRov5b9jthEp24abkpw//foWgsmdeyirZw=; b=Oce4hFIgBdU6z0eMtfyKFWvCs77AWDuEi+J9Q87yNjLBrA4CzFwFEoJFfEv76sLeiBzcua Yyp65TxlwWOme/M0CCZT5LDtnAkkyl/AK/rXtTh45ZlM80XCDgAAKs5yvH0t4Kv0SZmiU7 O0TPUDb2PxfdZ1e/JBwsym7Ivh4lQt8UChuSnI+Jh+EFP0ITyU02gTsLQ87Eoks/PE8xfd L6TCTjQKTZz4JQS0Kg6jWWAq3D0jbs3TfzMTlSwnKPVAg2ujQUhiCx6pSBZhDRj+UKhCSz 2F2AmNgMq1LsXQ0+y1nRHSoUdoZKz1ZB8u27X0W2YtNulLSLHsAGtrsHnmuOrA== To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org, Mashiro Chen Subject: [PATCH 5/5] hamradio: mkiss: cleanup indentation and coding style Date: Sun, 29 Mar 2026 22:34:08 +0800 Message-ID: <20260329143408.747197-6-mashiro.chen@mailbox.org> In-Reply-To: <20260329143408.747197-1-mashiro.chen@mailbox.org> References: <20260329143408.747197-1-mashiro.chen@mailbox.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MBO-RS-META: r4bj1y3pjkpg8d8dmq1f1o1wsz9ofcn7 X-MBO-RS-ID: 2ca30c21dee261337ac X-Rspamd-Queue-Id: 4fkH3m3cwpzB02y Content-Type: text/plain; charset="utf-8" Clean up the remaining coding style issues in mkiss.c to follow the Linux Kernel coding standards. The primary changes include fixing indentation and alignment issues by using tabs instead of spaces where possible. Additionally, add missing spaces after keywords and blank lines after variable declarations. Block comment formatting is also adjusted to use a separate line for the trailing delimiter. Signed-off-by: Mashiro Chen --- drivers/net/hamradio/mkiss.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 75b9bd2e1..8939582ac 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -64,7 +64,7 @@ struct mkiss { #define AXF_OUTWAIT 4 /* is outpacket was flag */ =20 int mode; - int crcmode; /* MW: for FlexNet, SMACK etc. */ + int crcmode; /* MW: for FlexNet, SMACK etc. */ int crcauto; /* CRC auto mode */ =20 #define CRC_MODE_NONE 0 @@ -439,27 +439,30 @@ static void ax_encaps(struct net_device *dev, unsigne= d char *icp, int len) /* Configuration Command (kissparms(1). * Protocol spec says: never append CRC. * This fixes a very old bug in the linux - * kiss driver. -- dl9sau */ + * kiss driver. -- dl9sau + */ switch (*p & 0xff) { case 0x85: /* command from userspace especially for us, - * not for delivery to the tnc */ + * not for delivery to the tnc + */ if (len > 1) { int cmd =3D (p[1] & 0xff); - switch(cmd) { + + switch (cmd) { case 3: - ax->crcmode =3D CRC_MODE_SMACK; - break; + ax->crcmode =3D CRC_MODE_SMACK; + break; case 2: - ax->crcmode =3D CRC_MODE_FLEX; - break; + ax->crcmode =3D CRC_MODE_FLEX; + break; case 1: - ax->crcmode =3D CRC_MODE_NONE; - break; + ax->crcmode =3D CRC_MODE_NONE; + break; case 0: default: - ax->crcmode =3D CRC_MODE_SMACK_TEST; - cmd =3D 0; + ax->crcmode =3D CRC_MODE_SMACK_TEST; + cmd =3D 0; } ax->crcauto =3D (cmd ? 0 : 1); netdev_info(ax->dev, "crc mode set to %d\n", cmd); @@ -473,6 +476,7 @@ static void ax_encaps(struct net_device *dev, unsigned = char *icp, int len) } } else { unsigned short crc; + switch (ax->crcmode) { case CRC_MODE_SMACK_TEST: ax->crcmode =3D CRC_MODE_FLEX_TEST; @@ -812,7 +816,7 @@ static int mkiss_ioctl(struct tty_struct *tty, unsigned= int cmd, switch (cmd) { case SIOCGIFNAME: err =3D copy_to_user((void __user *) arg, ax->dev->name, - strlen(ax->dev->name) + 1) ? -EFAULT : 0; + strlen(ax->dev->name) + 1) ? -EFAULT : 0; break; =20 case SIOCGIFENCAP: @@ -828,7 +832,7 @@ static int mkiss_ioctl(struct tty_struct *tty, unsigned= int cmd, ax->mode =3D tmp; dev->addr_len =3D AX25_ADDR_LEN; dev->hard_header_len =3D AX25_KISS_HEADER_LEN + - AX25_MAX_HEADER_LEN + 3; + AX25_MAX_HEADER_LEN + 3; dev->type =3D ARPHRD_AX25; =20 err =3D 0; @@ -838,7 +842,7 @@ static int mkiss_ioctl(struct tty_struct *tty, unsigned= int cmd, char addr[AX25_ADDR_LEN]; =20 if (copy_from_user(&addr, - (void __user *) arg, AX25_ADDR_LEN)) { + (void __user *)arg, AX25_ADDR_LEN)) { err =3D -EFAULT; break; } --=20 2.53.0