On Mon, 30 Mar 2026 00:47:07 +0200, Dmitry Torokhov
<dmitry.torokhov@gmail.com> said:
> spi_setup() specifies that it returns 0 on success or negative error on
> failure. Therefore we can simply check for the return code being 0 or
> not.
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/iio/adc/ti-ads7950.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
> index 6e9ea9cc33bf..c31c706c92a9 100644
> --- a/drivers/iio/adc/ti-ads7950.c
> +++ b/drivers/iio/adc/ti-ads7950.c
> @@ -520,7 +520,7 @@ static int ti_ads7950_probe(struct spi_device *spi)
> spi->bits_per_word = 16;
> spi->mode |= SPI_CS_WORD;
> ret = spi_setup(spi);
> - if (ret < 0) {
> + if (ret) {
> dev_err(&spi->dev, "Error in spi setup\n");
> return ret;
> }
>
> --
> 2.53.0.1018.g2bb0e51243-goog
>
>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>