From nobody Thu Apr 2 10:58:16 2026 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D60536CE16 for ; Sun, 29 Mar 2026 22:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774824436; cv=none; b=qlTJyS9EXUyZpxmGsUadjop0fJM7SJ9ZZRo+EWSm9YblShwwBlnSNG0P63hli3nmuRMf/IkVxRRrCLrtSYUuYkKy2HyLAN5Gkb5hlHdJDC5sA7SesBTMal3u7NyZ2nfgIm3icCNHSBj6n93HeNufI0r3NlsFUELeUyhxfGMSrxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774824436; c=relaxed/simple; bh=fuZck8myQoX8k0WCv45I/UW0qdwIBbPx5XxBl9G6Pa8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gZInOYSh4nhizqr5GY+CKfd9R+1Pkhhvboq6EltEHnhAQgRwuVxFmzRuPEr0eZW82E6brsKTXNbx16R1WnwbXFQB4N5HKDePznmBvCfgkAYmvGrSC6kjOFQODASfOSgGivrWIuUdc4qi47sfTl9CeDrTKi1LbI7RkVaI0PZhN88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c8Ez01XZ; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c8Ez01XZ" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso3327828eec.1 for ; Sun, 29 Mar 2026 15:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774824435; x=1775429235; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TKnXDyPHxP+Y+5jS7Wois35p2rZi45QRMmQZExuHS7U=; b=c8Ez01XZ20lPhRSjFztQaSiOooyWOLC/zUH1IxSOM4gnDe35As2xPkWAdKr6RYqpRA 6nMA5dWfws/sfvul0aeMfrqBhGirC/YsgoPA2w5nv7dqWe0RKUgg88sIjE/oxasMKqpq TFWu0FVaziDi37+Kd33tnJh2q7rtIzX2A/9OYQxUFRPF3AOppVSf/lJvoDEl5yMw64v4 7yPIEjv/Z0sLa5OdivySGGnhIvYIhCki6PmK8xG5vLwsNJ5JroE5A00l5Os2QNbx5n3Z 65Irthiq31dE+BWY2YEXVugOLsnp7idnvMFDewBVsvTNA3VYTqUyK/k4YeLCmwYnHzoj htqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774824435; x=1775429235; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TKnXDyPHxP+Y+5jS7Wois35p2rZi45QRMmQZExuHS7U=; b=NBFDztcSlYLXVXCwOjfZ2JRExxesFe8X5C4XzmQyVxJqvLZ/GPrDWJ2ZL4VO2yr4Hk atPPIe+EX8/LQqtEJ4xx/oDQd5KhxS6COVcPc41HopXwb7MoZ6/utR6J2I3d/qJcUEva Ti18ib8TB8oq+1xhcw170Y/IzM5hJOglrASfy3vFWy6/VWc5sxC/C9F/TwXl5RB9HZ6c /bjMb0SNkTguuGPIomJEoeKRbIQN5hXdlW/36ADkfJhdJZ/+XrUIo3tJUQSgJtPkA+2q Ve2KgXchXCBzu8fpcjKfBpUDpvLhZCawEKTV+QzC0vsH+jZ8VcG7qDOSP1IJ+t6G4KD6 xBbw== X-Forwarded-Encrypted: i=1; AJvYcCXDY5WcCHJU0a6loyObBJiu44ZqrF0oZyQlyUU9aXCL6pAVwzqP1uwjTXivG6mjuuEMYV/31DbZrshTKAU=@vger.kernel.org X-Gm-Message-State: AOJu0YxBkZrCJvaHQ9ic/JalsW1tyjaKR38PrnuX3AsyJoBgln8+j5Zz FKvHOi1TS5y6q5HKeQ/pc8M1wOv+V+T192kEUBB4iFTDTLhTEnlM5yrY X-Gm-Gg: ATEYQzzjahT5EWAd/WZxUefyDTDzbftqIP4GVTcEbsRPxfgJTB4Nu9XZtvUtM6caq91 Me73H7KQY3TQo4dZ9PdxGwFHEB55w27ARCgNJOinJcReFqx8bnXKCclEgbvddtTHdmDZJTcYGwP /nIrSW8b7wPm8sXr0f7WUM6CBBN8gFDpP0DC00caigd2nqU9r+vDOvCND0NSymvyr0uGCdDx8Gv 98qd6UGJ4xcZySUVAbAfbeEAL5pFdhEuebX4UMOnOHmY7Bi8PI/MYHFODQ7XzqJk06Hzpk0sJ8E DDfWELqQI4iS6haCHp51+zXY40BTPTZpoY0W7Q+lDwyEMVihNSEfaRuQ+TdzYL43EbL+l9dMT7v aNaoV3GEwlUyrl2P23SAU5RWNoscXB+gLDSFXOHU2Vmhu2F8qLvZLq/AoN+6tLQpVL/3x1eLGjE iTnV2Gp4EC7r5doL0iRHujRBbcMK3J//lNphzS7w2hFzaN5fMOor2OPSkwc7NNp9c48rffxoKmK KBI3JEsB91+sWE= X-Received: by 2002:a05:7301:6781:b0:2c0:c9ba:1192 with SMTP id 5a478bee46e88-2c185e069eamr5267348eec.18.1774824434599; Sun, 29 Mar 2026 15:47:14 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm5840295eec.30.2026.03.29.15.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 15:47:13 -0700 (PDT) From: Dmitry Torokhov Date: Sun, 29 Mar 2026 15:47:07 -0700 Subject: [PATCH v4 2/4] iio: adc: ti-ads7950: simplify check for spi_setup() failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260329-ti-ads7950-facelift-v4-2-c568c508c49a@gmail.com> References: <20260329-ti-ads7950-facelift-v4-0-c568c508c49a@gmail.com> In-Reply-To: <20260329-ti-ads7950-facelift-v4-0-c568c508c49a@gmail.com> To: Jonathan Cameron , David Lechner Cc: =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Cameron X-Mailer: b4 0.15-dev-a6826 spi_setup() specifies that it returns 0 on success or negative error on failure. Therefore we can simply check for the return code being 0 or not. Reviewed-by: David Lechner Signed-off-by: Dmitry Torokhov Reviewed-by: Bartosz Golaszewski --- drivers/iio/adc/ti-ads7950.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c index 6e9ea9cc33bf..c31c706c92a9 100644 --- a/drivers/iio/adc/ti-ads7950.c +++ b/drivers/iio/adc/ti-ads7950.c @@ -520,7 +520,7 @@ static int ti_ads7950_probe(struct spi_device *spi) spi->bits_per_word =3D 16; spi->mode |=3D SPI_CS_WORD; ret =3D spi_setup(spi); - if (ret < 0) { + if (ret) { dev_err(&spi->dev, "Error in spi setup\n"); return ret; } --=20 2.53.0.1018.g2bb0e51243-goog