Hello,
This is the v4 of the patchset to add support to the amd-pstate driver
for a new feature named "CPPC Performance Priority" that will be
available on some of the future AMD processors.
Details of the feature can be found in the AMD Publication titled
"AMD64 Collaborative Processor Performance Control (CPPC) Performance
Priority" (https://docs.amd.com/v/u/en-US/69206_1.10_AMD64_CPPC_PUB)
v3--> v4 changes:
* Modified Patch 8 to run a subset of test-cases specified as
comma-seperated list while loading the module [Mario, Prateek]
v2-->v3 changes:
* Picked up the Reviewed-by: tags from Mario except for Patches 5 and
6 which have major changes (see below)
* Patch 3: Fixed the subtle bug in amd_pstate_driver_cleanup() by cleaning
setting current_pstate_driver->attr to NULL [Claude Opus 4.6 +
review-prompts]
* Patch 5: Added bios_floor_perf field to struct amd_cpudata to cache
boot-time floor_perf value [New]
* Patch 5: Moved policy->driver_data = cpudata assignment earlier in
amd_pstate_cpu_init() (before amd_pstate_cppc_enable()) so that
policy->driver_data is valid when amd_pstate_init_floor_perf() is
called inside amd_pstate_cppc_enable() [Bug discovered while
running amd-pstate-ut tests]
* Patch 5: Added policy->driver_data = NULL in error paths of both
amd_pstate_cpu_init() and amd_pstate_epp_cpu_init() to clean up on
failure. [Code-Hardening]
* Patch 5: Restores bios_floor_perf via amd_pstate_set_floor_perf() in both
amd_pstate_cpu_exit() and amd_pstate_epp_cpu_exit() [New]
* Patch 6: Added input validation in store_amd_pstate_floor_freq():
rejects frequencies outside [cpuinfo_min_freq, scaling_max_freq]
with -EINVAL. [Code Hardening]
* Patch 6: Removed stray blank line between
show_amd_pstate_floor_freq() and
show_amd_pstate_floor_count(). [Mario]
* Patch 6: Reset the floor_perf to bios_floor_perf in the suspend,
offline, and exit paths, and restore the value to the cached
user-request floor_freq on the resume and online paths mirroring
how bios_min_perf is handled for MSR_AMD_CPPC_REQ [New]
* Patch 8: Add the capability to run a single test from amd_pstate_ut [New]
* Patch 9: New unit test to validate the driver->attrs [Mario]
* Patch 10 and 11: Split the Documentation fixes for
amd_pstate_hw_prefcore and amd_pstate_prefcore_ranking into two
different patches [Mario]
v1 --> v2 Changes:
* Picked up the Reviewed-by: tags from Boris and Mario for a couple of patches.
* Defined AMD_CPPC_FLOOR_PERF_CNT_MASK via GENMASK_ULL() instead of
GENMASK() to fix the build errors reported by the kernel test robot
(https://lore.kernel.org/lkml/202603070431.ykswVnpp-lkp@intel.com/)
* Moved the code from amd_pstate_cache_cppc_req2() into
amd_pstate_init_floor_perf() since there are no other callers of
amd_pstate_cache_cppc_req2().
* Cached the user requested amd_pstate_floor_freq into
cpudata->floor_freq [Prateek] and return the same when the user
reads the syfs file.
Description:
This feature allows userspace to specify different floor performance
levels for different CPUs. The platform firmware takes these different
floor performance levels into consideration while throttling the CPUs
under power/thermal constraints.
The presence of this feature is advertised through bit 16 of EDX
register for CPUID leaf 0x80000007. The number of distinct floor
performance levels supported on the platform will be advertised
through the bits 32:39 of the MSR_AMD_CPPC_CAP1. Bits 0:7 of a new MSR
MSR_AMD_CPPC_REQ2 (0xc00102b5) will be used to specify the desired
floor performance level for that CPU.
Key changes made by this patchset:
* Fix a memory leak bug and a control-flow bug.
* Plumb in proper visibility controls for the freq_attr attributes
so that only relevant attributes can be made visible depending on
the underlying platform and the current amd-pstate driver mode.
* Add support for the new CPUID bits, the new MSR and parsing bits
32:39 of MSR_AMD_CPPC_CAP1.
* Set the default value for MSR_AMD_CPPC_REQ2[0:7] (Floor perf) to
CPPC.nominal_perf when the value at boot-time is lower than
CPPC.lowest_perf
* Add sysfs support for floor_freq and floor_count
* Add the capability to only run a subset of unit-tests in the
amd-pstate-ut module.
* Add a new unit-test in amd-pstate-ut to validate the driver
freq_attrs.
* Introduce a tracepoint trace_amd_pstate_cppc_req2 for tracking
the updates to MSR_AMD_CPPC_REQ2.
* Add documentation for amd_pstate_floor_{freq,count}
Gautham R. Shenoy (12):
amd-pstate: Fix memory leak in amd_pstate_epp_cpu_init()
amd-pstate: Update cppc_req_cached in fast_switch case
amd-pstate: Make certain freq_attrs conditionally visible
x86/cpufeatures: Add AMD CPPC Performance Priority feature.
amd-pstate: Add support for CPPC_REQ2 and FLOOR_PERF
amd-pstate: Add sysfs support for floor_freq and floor_count
amd-pstate: Introduce a tracepoint trace_amd_pstate_cppc_req2()
amd-pstate-ut: Add module parameter to select testcases
amd-pstate-ut: Add a testcase to validate the visibility of driver attributes
Documentation/amd-pstate: List amd_pstate_hw_prefcore sysfs file
Documentation/amd-pstate: List amd_pstate_prefcore_ranking sysfs file
Documentation/amd-pstate: Add documentation for amd_pstate_floor_{freq,count}
Documentation/admin-guide/pm/amd-pstate.rst | 42 ++-
arch/x86/include/asm/cpufeatures.h | 2 +-
arch/x86/include/asm/msr-index.h | 5 +
arch/x86/kernel/cpu/scattered.c | 1 +
drivers/cpufreq/amd-pstate-trace.h | 35 +++
drivers/cpufreq/amd-pstate-ut.c | 170 ++++++++++-
drivers/cpufreq/amd-pstate.c | 312 +++++++++++++++++---
drivers/cpufreq/amd-pstate.h | 12 +
tools/arch/x86/include/asm/cpufeatures.h | 2 +-
9 files changed, 531 insertions(+), 50 deletions(-)
--
2.34.1