This series lets sdio_init() propagate standard kernel error codes 
instead of returning _SUCCESS/_FAIL.  There are two callers for this
function.  rtw_resume_process_normal() already returns negative values 
but the caller doesn't check for errors so changing this doesn't
affect anything.  sdio_dvobj_init() returns NULL on
error so leave that as-is.

Signed-off-by: Omer El Idrissi <omer.e.idriss@gmail.com>
---
v3:
- Add one commit that lets sdio_dvobj_init() use more readable error
  handling
- Add v3 and v2 tags

v2:
- Add one commit that lets rtw_resume_process_normal cleanly check
  errors and return errno instead of using vendor-defined slop

v1:
- Use direct returns in sdio_dvobj_init()
- Cleanup return in sdio_init()

Omer El Idrissi (4):
  staging: rtl8723bs: use direct returns in sdio_dvobj_init()
  staging: rtl8723bs: cleanup return in sdio_init()
  staging: rtl8723bs: clean up callees for sdio_init function
  staging: rtl8723bs: Choose slightly more readable error check

 drivers/staging/rtl8723bs/os_dep/os_intfs.c  |  8 +++----
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 25 ++++++++------------
 2 files changed, 14 insertions(+), 19 deletions(-)

-- 
2.51.0

On Thu, Mar 26, 2026 at 09:16:22AM +0100, Omer El Idrissi wrote:
> This series lets sdio_init() propagate standard kernel error codes 
> instead of returning _SUCCESS/_FAIL.  There are two callers for this
> function.  rtw_resume_process_normal() already returns negative values 
> but the caller doesn't check for errors so changing this doesn't
> affect anything.  sdio_dvobj_init() returns NULL on
> error so leave that as-is.
> 
> Signed-off-by: Omer El Idrissi <omer.e.idriss@gmail.com>

You sent v3 twice, was that on purpose?

confused,

greg k-h

Nope.
The signed-off-by tag was off by one letter. so i fixed that and resent it.

Best,
Omer El Idrissi

On Thu, Mar 26, 2026 at 11:37 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Mar 26, 2026 at 09:16:22AM +0100, Omer El Idrissi wrote:
> > This series lets sdio_init() propagate standard kernel error codes
> > instead of returning _SUCCESS/_FAIL.  There are two callers for this
> > function.  rtw_resume_process_normal() already returns negative values
> > but the caller doesn't check for errors so changing this doesn't
> > affect anything.  sdio_dvobj_init() returns NULL on
> > error so leave that as-is.
> >
> > Signed-off-by: Omer El Idrissi <omer.e.idriss@gmail.com>
>
> You sent v3 twice, was that on purpose?
>
> confused,
>
> greg k-h

On Thu, Mar 26, 2026 at 12:10:36PM +0100, Omer wrote:
> Nope.

Please do not top-post :(

> The signed-off-by tag was off by one letter. so i fixed that and resent it.

Then that would be a new version, not the same version twice, otherwise
how would we know which to pick?

Please remember, some of us get 1000+ emails a day to deal with, and
when reviewing patches for a subsystem, have to handle hundreds of them
at the same time.  Think about what you would want the messages to look
like if you were on the recieving end.

As a bit of help, why not take some time to review other patches on the
staging list to reduce the overall load and to get more familiar with
how the process works?

thanks,

greg k-h

Sorry, I'm going to ask that you send these one last time. It should
just be 2 patches.  patch 1 stays the same, and patches 2, 3 and 4 get
squashed into the same patch.

The thing is that right now we're changing sdio_init() and then
cleaning up the callers.  We should change it and clean up the callers
all in one go.  One thing per patch means "One complete thing" not
"half a thing per patch".  It makes it easier to review when it's done
in one go, because otherwise, when I'm reviewing patch 2, I have to
check all the callers anyway.

regards,
dan carpenter