From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A956437F741 for ; Thu, 26 Mar 2026 08:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513001; cv=none; b=MgPU9osZSAulfROdZy/00uj/QUbv8ybzp2fFCLk64Co2ECtCkV8+M7xTzjGMa8DJLe5Uw3HINMTMk6Z/Geja7/8L6t9JmxCq0MNOwhoJFJchQaVSeXDZ8a6w5j9aQzG6toAae7VpsF11h+8Hb2zTJuf/g490/pgJrdVoDZIQY8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513001; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KBx6jjlGO+cEQ69kJ8jhyXOnBVE7GILOMUo8VokMA9EbYR9VImAjF/8T925FDGcH7L/ra1bTRk2T7bIFTFPoDbcW1iAyj68Pl/kUSs3x707WYLxlfBAYDK7h+XphmlISlN2eIEGhKt8GvROMt0W7cFuLKCgSsyxOul0h3ycKO1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RLN5QEFJ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RLN5QEFJ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fe655187so7601045e9.2 for ; Thu, 26 Mar 2026 01:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774512998; x=1775117798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=RLN5QEFJ69B2olshhgm2Tw0qH8RhmVdJJ6011e6j9GC8KM+oVYFK337e6z0hOGypAX /oPKVtq8yMj3HLZQA6k0X6sUMp9StZkbX3+4NtdcVYvO+rph+Th5HObi6C8cvZtd9x1+ ar66bnt5IJu6TrFfDYxyRNb1WUjhsRFvIv+CUOtsoGCbrYP58oHwzR/rJXAAUCygoWBu P54uaM52RBEt7pCOrkBjoiR+d9KAEMRuBfR42quhQsfhy7Y9s7o7WtULF+GHnHTKRhKD 4PBiz5H2Kbquhc5p3OJs91CLq1hdVE07VoKeAmipUJh5d2A5q5e0Y3cFDhdiOMH4bJjU gOqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774512998; x=1775117798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=EKnCl0r3ykBVNE/+0V7f1dvbwkKPFTXrBioELfFTubBIk4TjF+YusSZwi9A4N0M3FN hC+cA7oV8kPIAIJm+XYjbtLMymKnT5ayo410ks9VCtdzSwIy4VmHcPWy0QTxgGPK9+YO ZWMWSY0Mda3BPsP6vwmt+gq4gFLrgQTQhB8dwfpHV12GNaMbWg4eEODSzjt0EvnmH1QB kSI9gmiittl19Hz95Gk1vM59wgZanikN05PVi926i5bvNQFb+kFrmLei87swLLbcMIMY masd7HPVyavCTpyCqLBvyLqSBWnRzJHTljCbvsKqhpC/fuhdsn/9Na4FwrYGHvC8WN/T RqwA== X-Forwarded-Encrypted: i=1; AJvYcCWHz6OsxwtCERw5iwKetlWuHPqfOfBCEwB5ClXfD2TfAUjCB0fYDsugaIPJZYCao0eEFVs2UUY7lCgMhCU=@vger.kernel.org X-Gm-Message-State: AOJu0YwMo9z9yyztQtltzh8b7FMiUWQMF19Tbh6o1H1Fwei1zxI8R1dp E7WW1kgUV9qSj2HcYK9CI/R/bLSX/bgZXI+GxnHGRjXNMOMJD5+S5/zK X-Gm-Gg: ATEYQzy3j/+c2XFYYhlrGSid4PFl5p8FyTR5761vEjImoUJGZzzkzW6v4bGFyoCM2Bf p5HtYpAzrky6RITW6evA0SdNbjVDo8tAEUJo+fmHm3IbVGGzxhNKWgHKhTJ/4trlfmZGsAY2Yfc qIXI2FhGHaVp0mD9dlR2lCy8HiAgT9vjKEoKMRL6/fM44Hf4cylPeBMSeF1ApgxjBuyep2hL1pK llxP0onThbNLBGdssCKU+uP+HfgcKXEQSabu0Dji3IbdOaBC09KA3s2k6e2HZ6aBmDnrG0QoNck NQx3P818H91tam5RF1PMZF/v3IZjJZuI3YNF2TFJQk3BoKXqjdGKw2gcrQyC7GzF0ycJiyPT3xc z4RJwORjaniS57Uo4tGHj3NBOVSMzfxY7nPygwjYii4BE/IR6jC96aZop83JhzQBRigA+Pv9dOd MjX9dyj1MT13x//7cgHdqdjz4= X-Received: by 2002:a05:600c:34ca:b0:485:3a27:a960 with SMTP id 5b1f17b1804b1-48715f0369fmr97165755e9.0.1774512997950; Thu, 26 Mar 2026 01:16:37 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm32886045e9.2.2026.03.26.01.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:16:37 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 1/4] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Thu, 26 Mar 2026 09:16:23 +0100 Message-ID: <20260326081627.5841-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081627.5841-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BFC3A3825 for ; Thu, 26 Mar 2026 08:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513002; cv=none; b=Lmn1vC8xcyU5Ny8f8Owg8Ynh6hqssuJwvA0UWpYWBMLfgMi/zzb6Q3wOXms2lp5RpuXZhgXkomjtPrkQbth5mp0QL3lvdemGIBcRLfiVHX/2hDFz5LRTYCfdEVpN7HMlo4V86fTR3CrHn0Iak/Y02N8d9i9B4mdjLb2prgO+gfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513002; c=relaxed/simple; bh=UoObvnnZRPgdvTgqoymjmAp+D17szqmEHwzVj+aDlXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a7ZtpoA/HtsRNT7LRQ/kHlSgzLXB2YSRSLkA+J2DLakYE2OZuLf6egOoSRvulbbWOi8GJHsyyiR93SluH5gxhmPPMkGbBuSnt9aNKRxn/ROFlxsqXkn/o0EOMcSPZoLz1+Pp6bNwTzapfnWM7Efv9mB4g4++kI+/IYpZVo7IaDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pc7ou8U3; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pc7ou8U3" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-486fd27754bso6093035e9.3 for ; Thu, 26 Mar 2026 01:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774512999; x=1775117799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=pc7ou8U35lO+xwYvhZjJMOnZxC6oi26q9p+3zPqx65aOvsTNFRkdGCoTB1/t4rXdme gLU2FmVvsn8iPgTu7vqBWBkicqcq0HD4YwMZ9UaVZnehmd8Xt+jDYyLJwFt5dePS2SnM MoEQ+eRCMwEmPMQCzUay5NJU5591sXkLoHjkbU1ln3/sbqxnlqP6d16DZqvpQBJBrJuC Z2OCJRybFiDHxz32ZSBRTtAYxkDrJhL0QBTXGMWxiWcp+EPtN1Wnp2a5J8aOc0F+vCrR 8yooHtc2GQzI7Tq2cj516FT9DPvZep19pteL8sjNvTE6eQSgH7kXU0LrtyeIgsgfnd37 g5gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774512999; x=1775117799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=KCzRwdiudCy1hKsqVe0wtTK87LdrJJqEiLdTMzgnO0MI+r5EjF6QlZ+himXtDdnJZb f4gvXUbFzZ1QmxWxnyhMQLBrYG3HZpdrqJWy4wFmFGWohBlLFdqfYQilopjDXoAtp89C OInC19FPKHzH9txO4UR12U9jEWuiekD5kLSy5dTdkZQkV9cb/rnAsh0sZjs5+jZhYzc1 BFid/Bg6StuJEaObm8OR9fi23el7cmzrKzNdTZkIea6RAZKrHhONAMsOXOkDeM3aPN7g upLjAV/FbpWpPk1i7YBq+klztPqJmxW0+/xPGR4M4TFYR0A+Zgn8Ar0R7LmDE/0KJ2p7 dt/w== X-Forwarded-Encrypted: i=1; AJvYcCVsFkJ55RmhzUJsRAbrtBNS1j/7729zoUG0m0CJo+s8OLbTWuoPeb9wWWDNwVvDHfFJWczEq9dPotscl9M=@vger.kernel.org X-Gm-Message-State: AOJu0Yze8P7We+YDf9bX5ErDBvaxCZNjppX6UV3R6Nw9Au04XytysO/I LDR4pIU/hzm2prHCEamC4qVGsqR8ho/PmXUH5HC4KGqbwGEoicMX3o/0 X-Gm-Gg: ATEYQzwSBoxHYTSQ9DM0GlnOSQ1KYPlyAdm5HbJv6ObhqZ+9f3oXSw1JvK4Djuq9mOv 70Um9IeblAoZKhrx+mUo3rNYQHEvCRsVGP+7pCoHpEJ5AaRxQe7TNd6lVrvchHbfnNqUN/VeOEY SFBE3J4ol8hDu/nG30XY4Lp1aGF0pVGO4NVULzVc/M2ChEDZ8Bvw5ockKkgJl9zXC+LnQAX1sIR ID8I5eXxd++H1mQs1tecKDVW9XNiH+/nMEx9ifd9H9WTuMWqt0wFDvugdhW3pXz9t2UmtAeoioe UJKFIE3CyrKHKWMc3EJ3lH2oZMakUqlVjmOCEHKe1P6EoR25OKFMQ5ZEvob8wQMZ+0LZlePu2gd GBDtNyPMhYc004oMdy4cQ8UpUy5OUdKbU91r1H5UdN3I3f4FOmSsvQvfqg7nGycFO1XrwD9IQLN Dei2S++vvL1MP8bP8c/dwWvCcxFnMat9kdGw== X-Received: by 2002:a05:600c:4f89:b0:477:7bca:8b34 with SMTP id 5b1f17b1804b1-48715fd4667mr89614655e9.6.1774512999121; Thu, 26 Mar 2026 01:16:39 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm32886045e9.2.2026.03.26.01.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:16:38 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 2/4] staging: rtl8723bs: cleanup return in sdio_init() Date: Thu, 26 Mar 2026 09:16:24 +0100 Message-ID: <20260326081627.5841-3-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081627.5841-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_init() return errno from sdio_enable_func or sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined macros. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 358eac0837cf..01b5d8a70072 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAC83B19DB for ; Thu, 26 Mar 2026 08:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513004; cv=none; b=LR90G6R+vhMJyRa7IasYZJclcX3oOQFeOdp1HAKBTXvFEowKL+v9+yVO7b6q78LtOQE3SQRd8ukEIiudEZAyreBNBJzXcKUgid2w7fTDxMN6vG1x6sisY4BVat3iQityYwgVI6UfipZowcVil8VIE+F21IljtCls4HJwiJa+oPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513004; c=relaxed/simple; bh=Bd/5OfzV7Sarf3QWBs7/bSDFPUaIF5mzDS/I9XfZQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=izn37mvYNRaisA66MER76wqhDx9DSA1eE+K5m3Vaq7CM7LffWSNqRHaXRQGT4kNsHxbJvS3WpZHHMezKFTjKP4G0sNYnvrgnVw6O6pIEuyuMqmCDmoorhH5ev5WDHb1j69G2ynNBaewD8rZA4dYre3UGXIqrj8tFr3XJ5ACmVH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EBF2PfN9; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EBF2PfN9" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48704db565eso9246755e9.1 for ; Thu, 26 Mar 2026 01:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513000; x=1775117800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=EBF2PfN9/2K7XJ11xaeQuKbgS6O75qYmKl6bHyfLl7eVvPsnp4f4qXDvzIPxFKwkiv Hx5JBY5yr8SlPvSYrPg9XokkyhT8tIEWVSh2y8Jr0iJMq6bRm6ccW4TRp6HYleP2p4rW Bo2NlEyjpWyz82njLFOpHUYkhb0yc04p83ixe4ABeVy47JsdPLQ9p+nw50a9ZCFKmmuB T+tzGOLHQexmQyFst6RlH58AfgdtiXCIOE71uV61DnrgniRZ435ZmHNYx3UEWJTjgjsH X2BG4MMVmSWuiSgHs7ZwNLmGByCTDE9z8hUocJnxCMchnKIrrGNF2WkVaPiSxAqWkX5E OjSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513000; x=1775117800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=JOimNwEfoPPudRG+MqhJd0kOYXPsRr+UyKgi2eYfXm7NY9/DmBVgYoexZFEU9NqWfX o/LMAFspMZsi5N5r4c0Gj3+EyvnVKG2WemyQQvzuRM/w55JwAkK1L9wRi/MClADdtuts 0neseFGp0QlCgo8S/5msRBDmewmoV3VuUpbTnccYXLyNLl8OgbtJE5Z/p0Rvbhk1SIpO iviV0i3qnv32BDWCKLMkSMdOgRgGeh3ibFScGL1SH7F2InO6JBUjqibDUoG8btEMGNjL g0+bw4Hz14+iwPb7eEHDr/PUqI0reWOIQwJGjRoCxqiPscQyemKnc7I1aYAJMjPlfkgB JVRw== X-Forwarded-Encrypted: i=1; AJvYcCWlAsR1m/lUKolo+K58IFqT/7Z/gLQdrU61AV5jxRCoPrxD74I8nhmcX2dBBJwdpYPjKVhcySru4xJybw4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWtLIp5fbTuLDj2fRkItjLyDBxlwllJjGVMiSovjWcCBxqXh+k vMHK+NzELTsmgpdcug1IH+htZ+a65DNpYVX+hvvOjs+6mtve9bsX3jFAV8ig3f4D X-Gm-Gg: ATEYQzyI9TpBAvuAc0PL5C8d5+r9w2GrMd0v35yzvFG+Ii+CflVsG7/PnARLlidX/gj eHpICkjgO4N+b82fp/7+TeyL8BNS4c/5zv1VSdNvz4zoXq7FP3h88WewDZWzzey7/Mt3qi5CSEN lUkljE1XiA5S+KHHdwtpLVIyjW60Uf3GQzNBbQXq7Gv3bplcacn3AqD1kS/fhPIVz5/fmOxv6QS UlyGFIsvLPGJO7F2AqzN3GCWx+rO83pnoXWEou4Kv4E4GyhH5vgoYbqngVXiqE+A0sUNbxHocTP VlfWnDXVxgmzoPF6JDnAD0SPSv3J6i3bbiSYKzxXhpfAUdh8Gpx1JRShVmnogEsKqH4eFZnvKt6 f7zG5ooQ+Lw63bk2wmY01QkMlIRmR2M7pk7G5a/t8mwY/UNN3ygonUVlKKDLMuYxq4HBj1+x4Kg w5vMNmCMfXf+cP1mfuHC1Wl/Y= X-Received: by 2002:a05:600c:8489:b0:485:ae14:8173 with SMTP id 5b1f17b1804b1-48715fc3532mr96601995e9.1.1774513000080; Thu, 26 Mar 2026 01:16:40 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm32886045e9.2.2026.03.26.01.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:16:39 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 3/4] staging: rtl8723bs: clean up callees for sdio_init function Date: Thu, 26 Mar 2026 09:16:25 +0100 Message-ID: <20260326081627.5841-4-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081627.5841-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 360BA396D2E for ; Thu, 26 Mar 2026 08:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513004; cv=none; b=hFx9tBzt2g2Tvj7T0e2QXafXgXuYgmtD/baTdIPQhWIxyHOX+47F/DlIpEvneglLB3YbUZ0frDbGzh8kU3KAFR3a9POqLmqd++uhpQ3iAbpuW8AmgZQH/m7m/0o5WbfOqhIDQH5K1CWBijoRiZhumNQrY7VRBP1/RsWlgmJlL4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513004; c=relaxed/simple; bh=mMeeJuaZNxecKvFROX7Q1UPzFZzGa8Hph6hnSmJw7K0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kY3eS/Hs9LoS9Ua9PajhdHZoeICOcOTOhcQ2SiGJVPgygrcgKxBV+TOND4XfmHdGydbNnSaPve5EZUf81pGZnUEkvu9OPgLlR/o+our3KslYEb5wYGPDaWT0nkZphHM7+G4Gf+QGGUI5ZsPlUDMxmqhp8JbnwoouV1wgw66Vkzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KQwFdVsH; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KQwFdVsH" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so592397f8f.0 for ; Thu, 26 Mar 2026 01:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513001; x=1775117801; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l9cHpCwLSJWHYVjnLpxFvTWscwNHAujvygDF0mECPT4=; b=KQwFdVsH39DOPUteYr1hpeGL9YElSFzmx/gazJSwaziXsoYWp6g/cBvT/wPq+ajT0Z bItz1XAs9ezUVRyMEpbDrdnbflKaM+yG7oGRymaTFLEdEeVnfvwqE2c9wShhANKD4MFa MbI14/2Z8pxH74yWzLC6BAR2gUJpgh19+R1vSlYb9nN8fN4Mxt5FVIinFZpTjsXARCNV eIcNc6eNR1WMuuIPFzvIN/+DjXSswaq1pbrsjCEPtFka65c26Y3/pGoBh0X20HrXnVuk kz1LbvC68w6XT8qFEqBYojN4H6A4uJFtI7DEpjoTBlq5JyD7H/Ap9e5hTVYIb7RXh73Q Zn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513001; x=1775117801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l9cHpCwLSJWHYVjnLpxFvTWscwNHAujvygDF0mECPT4=; b=UY1s6OcDRvixsYojXcQh2BkvQ8CdAKi+I1rQP/2GOd+FQ/MwTnjwTXciwm2BRfWic1 FSmfQzj7qnYZnEA2QbehwtCLPF+lfNa2WnWkJyQX7jMYev1vWeWhOEEIRxyZ5nD4dt/C sppslXAT/lZtLdBWS1d7jFHenMiCwjuHjQVkJokc3yloQ/gV72qmaWHuXEOym3FpP+BU D4ik9/UIzVDHwtG8FkyK0OlOZN/Veim7HK4b0hw4ldTJaaEuVnHndVyHi8MRifFUBPoP v5gjS0phRi2LewdJBow9vKTd7iOM0rshr+SMvRCIybNIHQd75VPHc0VAveSq+ADrNHq8 GhzA== X-Forwarded-Encrypted: i=1; AJvYcCUEfAQMSsQ5IC1/msFcObjKbW0D1PT2ndJTVoPbVTCukUl5blpQSSb/VxX6gyn4yujHHeYembml+Vl2oww=@vger.kernel.org X-Gm-Message-State: AOJu0YyjBoCF3ArM+DCJRRllYnL6B62XwVHPHLFIuSfFqxDTotf3c2Xb t5a6kK2Uto3nApjtNzrXy8i6q3AGUNB9TLZUPO04Lewbqoz5vzGZNjIY X-Gm-Gg: ATEYQzypW7Z35GXh8QCRnw1RgU2DYZ2Bx8a85kFExgD0hiwedGHtCmwI9bANeXfOhju DGxr7A8IbnsHN20oQbxvvwsMo3REOaEJPvj+AAVAKKUxt9L1B6Etdnn5uMrcZGny+NsAwMDmjFK 7veYl5DYnYaVy2alM38ri6AbJOhsjge+7X3/OaboIS8omndz/B3+rghUAAty5Olhb7wcOrhaEHw D0sAgAy4r1AFQPN0kix0bMLLT9JqDEv5u9l0G0rPG3lC5DGhXOz8w7jLyExkv+WrG0/JWGnOhgu mSGXHeY6NFO+bCDBJGpgTZTpcg+xq+Z8fTuDDk+ZdrFKUFu3b/c9N3yATajuaHYBhPERYh5/fjY wv8ymQBlWLJcy3SQUZYrAvwnQ+T8IVOnuZnUxa8OuaXIxnXQt2mo+ESPKpk27Cs6+ZgJDoxj2Au 3/Olujt7wo3ezecqlaBjpRPIg= X-Received: by 2002:a05:600c:8b18:b0:485:3b9e:caa7 with SMTP id 5b1f17b1804b1-4871606d79cmr93205225e9.23.1774513001429; Thu, 26 Mar 2026 01:16:41 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm32886045e9.2.2026.03.26.01.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:16:40 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 4/4] staging: rtl8723bs: Choose slightly more readable error check Date: Thu, 26 Mar 2026 09:16:26 +0100 Message-ID: <20260326081627.5841-5-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081627.5841-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081627.5841-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let sdio_dvobj_init use a slightly more readable and conventional error check for sdio_init(). Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 01b5d8a70072..d0feb28b7043 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,6 +155,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) { struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; + int ret; =20 dvobj =3D devobj_init(); if (!dvobj) @@ -165,7 +166,8 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) psdio =3D &dvobj->intf_data; psdio->func =3D func; =20 - if (sdio_init(dvobj) !=3D _SUCCESS) + ret =3D sdio_init(dvobj); + if (ret) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); --=20 2.51.0