[PATCH net-next v4 0/3] r8152: add helper functions for PLA/USB/PHY OCP registers

Chih Kai Hsu posted 3 patches 1 week ago
drivers/net/usb/r8152.c | 1800 ++++++++++++++-------------------------
1 file changed, 634 insertions(+), 1166 deletions(-)
[PATCH net-next v4 0/3] r8152: add helper functions for PLA/USB/PHY OCP registers
Posted by Chih Kai Hsu 1 week ago
v4:
- Add a new patch for original #1. We need to fix a typo first before
  original #1 patch.

- For patch #2, replace redundant ocp_word_set_bits() with ocp_word_w0w1().

v3:
- For patch #1, fix the issue identified by the AI review.
  In v2, ocp_byte_set_bits() was used to update the USB_LPM_CTRL register.
  However, since its function only perform a bitwise OR operaion, it fails
  to clear the old bits when updating a multi-bit field like LPM_TIMER.
  Therefore, use ocp_write_byte() to maintain the original direct-write 
  semantics.

- For patch #2, fix the line length exceeding 80 columns

v2:
For patch #2, remove variable set but not used from r8153_init(),
r8153b_init() and r8153c_init()

v1:
Add bitwise operaion functions for PLA/USB/PHY OCP registers 
to simplify the code.

Chih Kai Hsu (3):
  r8152: fix incorrect register write to USB_UPHY_XTAL
  r8152: add helper functions for PLA/USB OCP registers
  r8152: add helper functions for PHY OCP registers

 drivers/net/usb/r8152.c | 1800 ++++++++++++++-------------------------
 1 file changed, 634 insertions(+), 1166 deletions(-)

-- 
2.34.1