.../devicetree/bindings/pwm/pwm-amlogic.yaml | 27 ++++++++++++++++++ drivers/pwm/pwm-meson.c | 32 ++++++++++++++++++++-- 2 files changed, 57 insertions(+), 2 deletions(-)
Add bindings and driver support Amlogic S7/S7D/S6 SoCs.
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
Junyi Zhao (1):
dt-bindings: pwm: amlogic: Add new bindings for S6 S7 S7D
Xianwei Zhao (1):
pwm: meson: Add support for Amlogic S7
.../devicetree/bindings/pwm/pwm-amlogic.yaml | 27 ++++++++++++++++++
drivers/pwm/pwm-meson.c | 32 ++++++++++++++++++++--
2 files changed, 57 insertions(+), 2 deletions(-)
---
base-commit: 8ab1fc9104158045f68fde2d0ae16f5fbcf8bfbd
change-id: 20260325-s6-s7-pwm-281658b88736
Best regards,
--
Xianwei Zhao <xianwei.zhao@amlogic.com>
Hi Xianwei Zhao, thanks for your contribution! On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote: > > Add bindings and driver support Amlogic S7/S7D/S6 SoCs. There is an old report that got lost, stating that the current pwm-meson driver has an off-by-one error with the hi and lo fields: [0] Since you are working on bringing up a new platform: is this something you can verify in your lab? To be clear: I'm not expecting you to work on this ad-hoc or bring a patch into this series. However, it would be great if you could verify if the findings from [0] are correct and send an updated patch in future. Thank you and best regards Martin [0] https://lore.kernel.org/all/20241225105639.1787237-3-gnstark@salutedevices.com/
Hi Martin,
I confirmed with Junyi Zhao that the current implementation counts
from zero, so this submission is correct.
We agree this should be fixed and will address it in a follow-up patch.
Thanks for pointing it out.
On 2026/3/31 05:54, Martin Blumenstingl wrote:
> Hi Xianwei Zhao,
>
> thanks for your contribution!
>
> On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay
> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
>> Add bindings and driver support Amlogic S7/S7D/S6 SoCs.
> There is an old report that got lost, stating that the current
> pwm-meson driver has an off-by-one error with the hi and lo fields:
> [0]
> Since you are working on bringing up a new platform: is this something
> you can verify in your lab?
> To be clear: I'm not expecting you to work on this ad-hoc or bring a
> patch into this series. However, it would be great if you could verify
> if the findings from [0] are correct and send an updated patch in
> future.
>
> Thank you and best regards
> Martin
Hello Martin, Xianwei On 3/31/26 10:10, Xianwei Zhao wrote: > Hi Martin, > I confirmed with Junyi Zhao that the current implementation counts > from zero, so this submission is correct. > We agree this should be fixed and will address it in a follow-up patch. > Thanks for pointing it out. > > On 2026/3/31 05:54, Martin Blumenstingl wrote: >> Hi Xianwei Zhao, >> >> thanks for your contribution! >> >> On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay >> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote: >>> Add bindings and driver support Amlogic S7/S7D/S6 SoCs. >> There is an old report that got lost, stating that the current Xianwei Zhao thanks for the confirmation. I am the author of the old report and the corresponding patch and it's not lost. So if the patch is correct I'll be glad to add relevant tested-by tags. >> pwm-meson driver has an off-by-one error with the hi and lo fields: >> [0] >> Since you are working on bringing up a new platform: is this something >> you can verify in your lab? >> To be clear: I'm not expecting you to work on this ad-hoc or bring a >> patch into this series. However, it would be great if you could verify >> if the findings from [0] are correct and send an updated patch in >> future. >> >> Thank you and best regards >> Martin > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Best regards George
Hi George, On 2026/3/31 15:33, George Stark wrote: > Hello Martin, Xianwei > > > On 3/31/26 10:10, Xianwei Zhao wrote: >> Hi Martin, >> I confirmed with Junyi Zhao that the current implementation counts >> from zero, so this submission is correct. >> We agree this should be fixed and will address it in a follow-up patch. >> Thanks for pointing it out. >> >> On 2026/3/31 05:54, Martin Blumenstingl wrote: >>> Hi Xianwei Zhao, >>> >>> thanks for your contribution! >>> >>> On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay >>> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote: >>>> Add bindings and driver support Amlogic S7/S7D/S6 SoCs. >>> There is an old report that got lost, stating that the current > > Xianwei Zhao thanks for the confirmation. > I am the author of the old report and the corresponding patch and it's > not lost. So if the patch is correct I'll be glad to add relevant > tested-by tags. > I will use your patch and won't send a separate one. Do you mean I should add a Tested-by tag to your patch? >>> pwm-meson driver has an off-by-one error with the hi and lo fields: >>> [0] >>> Since you are working on bringing up a new platform: is this something >>> you can verify in your lab? >>> To be clear: I'm not expecting you to work on this ad-hoc or bring a >>> patch into this series. However, it would be great if you could verify >>> if the findings from [0] are correct and send an updated patch in >>> future. >>> >>> Thank you and best regards >>> Martin
Hello Xianwei Zhao On 3/31/26 10:59, Xianwei Zhao wrote: > Hi George, > > On 2026/3/31 15:33, George Stark wrote: >> Hello Martin, Xianwei >> >> >> On 3/31/26 10:10, Xianwei Zhao wrote: >>> Hi Martin, >>> I confirmed with Junyi Zhao that the current implementation counts >>> from zero, so this submission is correct. >>> We agree this should be fixed and will address it in a follow-up patch. >>> Thanks for pointing it out. >>> >>> On 2026/3/31 05:54, Martin Blumenstingl wrote: >>>> Hi Xianwei Zhao, >>>> >>>> thanks for your contribution! >>>> >>>> On Thu, Mar 26, 2026 at 7:35 AM Xianwei Zhao via B4 Relay >>>> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote: >>>>> Add bindings and driver support Amlogic S7/S7D/S6 SoCs. >>>> There is an old report that got lost, stating that the current >> >> Xianwei Zhao thanks for the confirmation. >> I am the author of the old report and the corresponding patch and it's >> not lost. So if the patch is correct I'll be glad to add relevant >> tested-by tags. >> > > I will use your patch and won't send a separate one. > Do you mean I should add a Tested-by tag to your patch? Yes since you've confirmed the problem exists then your tested-by tag would be appropriate. And I'm ok if you resend the patch. Thanks. >>>> pwm-meson driver has an off-by-one error with the hi and lo fields: >>>> [0] >>>> Since you are working on bringing up a new platform: is this something >>>> you can verify in your lab? >>>> To be clear: I'm not expecting you to work on this ad-hoc or bring a >>>> patch into this series. However, it would be great if you could verify >>>> if the findings from [0] are correct and send an updated patch in >>>> future. >>>> >>>> Thank you and best regards >>>> Martin -- Best regards George
© 2016 - 2026 Red Hat, Inc.