1. Patchew
  2. linux
  3. View series

[PATCH v7] staging: rtl8723bs: remove commented-out code

Aadarsh Mandal posted 1 patch 1 week, 3 days ago
There is a newer version of this series
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
1 file changed, 17 deletions(-)
[PATCH v7] staging: rtl8723bs: remove commented-out code
Posted by Aadarsh Mandal 1 week, 3 days ago 
Remove code that is not used anywhere in driver.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
---
v6:
 - No change.
v5:
 - No change.
v4:
 - Remove extra space insertion.
 - Delete remaining commented-out code.
v3:
 - Add the extra space that count as insertion.
 - Remove unwanted addition.
v2:
 - Restore braces for standalone code blocks {}.
 - Delete reindented commented-out code and extra space.
v1:
 - Reindented commented-out code;extra space remained.

 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
 {
	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);

-	/*  Tx aggregation setting */
-/*	sdio_AggSettingTxUpdate(padapter); */
-
	/*  Rx aggregation setting */
	HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
		return _SUCCESS;
	}

-	/*  Disable Interrupt first. */
-/*	rtw_hal_disable_interrupt(padapter); */
-
	ret = _InitPowerOn_8723BS(padapter);
	if (ret == _FAIL)
		return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

	rtl8723b_InitializeFirmwareVars(padapter);

-/*	SIC_Init(padapter); */
-
	if (pwrctrlpriv->reg_rfoff)
		pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

-	/*  Record original value for template. This is arough data, we can only use the data */
-	/*  for power adjust. The value can not be adjustde according to different power!!! */
-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
	rtl8723b_InitAntenna_Selection(padapter);

	/*  */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
	/* ack for xmit mgmt frames. */
	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
	{
		pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
	_ReadEfuseInfo8723BS(padapter);
 }

--
2.43.0
Re: [PATCH v7] staging: rtl8723bs: remove commented-out code
Posted by Dan Carpenter 1 week, 3 days ago 
On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
> Remove code that is not used anywhere in driver.
> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> ---
> v6:
>  - No change.
> v5:
>  - No change.

Why are you resending with no change?

Also you're not working against staging-next.

regards,
dan carpenter
Re: [PATCH v7] staging: rtl8723bs: remove commented-out code
Posted by Luka Gejak 1 week, 3 days ago 
On March 24, 2026 7:54:43 AM GMT+01:00, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
>> Remove code that is not used anywhere in driver.
>> 
>> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>> ---
>> v6:
>>  - No change.
>> v5:
>>  - No change.
>
>Why are you resending with no change?
>
>Also you're not working against staging-next.
>
>regards,
>dan carpenter
>

He probably means no code changes as the last 
two versions were related to commit messages 
and Signed-off-by field.
Sincerely,
Luka Gejak
Re: [PATCH v7] staging: rtl8723bs: remove commented-out code
Posted by Dan Carpenter 1 week, 3 days ago 
On Tue, Mar 24, 2026 at 09:12:20AM +0100, Luka Gejak wrote:
> On March 24, 2026 7:54:43 AM GMT+01:00, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >On Tue, Mar 24, 2026 at 09:37:18AM +0530, Aadarsh Mandal wrote:
> >> Remove code that is not used anywhere in driver.
> >> 
> >> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
> >> ---
> >> v6:
> >>  - No change.
> >> v5:
> >>  - No change.
> >
> >Why are you resending with no change?
> >
> >Also you're not working against staging-next.
> >
> >regards,
> >dan carpenter
> >
> 
> He probably means no code changes as the last 
> two versions were related to commit messages 
> and Signed-off-by field.

Thanks, Luka.  Changes to the commit message count as a change.

regards,
dan carpenter
Re: [PATCH v7] staging: rtl8723bs: remove commented-out code
Posted by Luka Gejak 1 week, 3 days ago 
On March 24, 2026 5:07:18 AM GMT+01:00, Aadarsh Mandal <aadarshmandal9354@gmail.com> wrote:
>Remove code that is not used anywhere in driver.
>
>Signed-off-by: Aadarsh Mandal <aadarshmandal9354@gmail.com>
>---
>v6:
> - No change.
>v5:
> - No change.
>v4:
> - Remove extra space insertion.
> - Delete remaining commented-out code.
>v3:
> - Add the extra space that count as insertion.
> - Remove unwanted addition.
>v2:
> - Restore braces for standalone code blocks {}.
> - Delete reindented commented-out code and extra space.
>v1:
> - Reindented commented-out code;extra space remained.
>
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>index 063a0737933e..96a0c8e304da 100644
>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
> {
>	struct hal_com_data	*pHalData = GET_HAL_DATA(padapter);
>
>-	/*  Tx aggregation setting */
>-/*	sdio_AggSettingTxUpdate(padapter); */
>-
>	/*  Rx aggregation setting */
>	HalRxAggr8723BSdio(padapter);
>
>@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>		return _SUCCESS;
>	}
>
>-	/*  Disable Interrupt first. */
>-/*	rtw_hal_disable_interrupt(padapter); */
>-
>	ret = _InitPowerOn_8723BS(padapter);
>	if (ret == _FAIL)
>		return _FAIL;
>@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>
>	rtl8723b_InitializeFirmwareVars(padapter);
>
>-/*	SIC_Init(padapter); */
>-
>	if (pwrctrlpriv->reg_rfoff)
>		pwrctrlpriv->rf_pwrstate = rf_off;
>
>@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
>		CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);
>
>-	/*  Record original value for template. This is arough data, we can only use the data */
>-	/*  for power adjust. The value can not be adjustde according to different power!!! */
>-/*	pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
>-/*	pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
>-
>	rtl8723b_InitAntenna_Selection(padapter);
>
>	/*  */
>@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>	/* ack for xmit mgmt frames. */
>	rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));
>
>-/*	pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
>-
>	{
>		pwrctrlpriv->rf_pwrstate = rf_on;
>
>@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
>	pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
>	pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;
>
>-/*	pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
>-
>	_ReadEfuseInfo8723BS(padapter);
> }
>
>--
>2.43.0

Hi Aadarsh,
It seems patch is corrupted, so please regenerate it and don't edit the file manually.
Best regards,
Luka Gejak

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.