From nobody Sun Apr 5 13:14:56 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 292E1398919 for ; Tue, 24 Mar 2026 04:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774325249; cv=none; b=AVvnsfbfRnl1VMCCI3LlzWcRAWNNGsQq6J+fijjOqkuAOouPlbF/9FPAlMcCF1S8gD2cPjSmwoPuCMKH8zqEOWP30dFByT0WVcHvD0zfH+gI8LxXopVurI9FT/Ui1HHV19dsvlEFLaWXbhz46rnEswyh1G74tmVIJn5YKuUUa4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774325249; c=relaxed/simple; bh=log6x1Cso3z8mljz7H6OVlB0/lBZc8CRpHipqfyzq5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gqHF0LIMCKt2d7xRe7qvgK4QahKrsDbdEeZM02FQ+hHsm7XiHEnoeDyUncLHPvTYS/bps2wutA+CNaMVnTVPbhpjpozhpEn0ezX5id6Cwt7Ki2d0Pd1o9ZhT5/B34VVql5O/RhB6lRr9FS2cbPzmepJvOk49Nqd5gxBy14yKXUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rc+a92EL; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rc+a92EL" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35ba2ae4df3so2396035a91.2 for ; Mon, 23 Mar 2026 21:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774325247; x=1774930047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/f3X90Dmfzg30Il1bhE0PbQYqZfL8+0ddOr/f8ySy/c=; b=Rc+a92ELszAicqkMvoVtQvpZHCADjgOj8RBAEdk8Gvv+fr9XkLAKGLi518HEq57vR5 QSD+vD3Xup3Lbrnsbkm4JVwmG6kK8tTi8NOlWUbqSceGRWfsON8RlYL3ir2ABygBaGEh +HCKOqR2mTANdyIN9YWNv3DXS9P+hCvAXGASqCGuas/o1HzmceDbcRo1pCBVl3GDv/3N J8mi7sHNCeXFiXTyoGSXST34vejfxt/b0Pm+NRGruXzTCn0XUWqJLvpT3cmLT+CnkzV6 XHX8eqXn4TUT1TgJRik1UONbTdNvtY6inrccO8yWC6mKqOjKLmJopJNqeV+SBIqg6jYB FFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774325247; x=1774930047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/f3X90Dmfzg30Il1bhE0PbQYqZfL8+0ddOr/f8ySy/c=; b=QS0hCP6jJ4hrpw+Xx924n+eWh0F2ZmAqGThEZZcP24m4h5hVd2JOltxuLTLh8Q/S+o JJSf+gcrjRLwET+SdyqeDVXWzYJo1Nev9OKfQ6ksZDw9GH+jJuibV9v7xylpJbcLBMgO EdJ4DZBLTO8sbg/42NTTK3q4BrxD7CjH19GjXwFwUATdsJWk9B8xpwbwx0hZ7B8kVDpY NUmQo20WgFrpV7wcj/prpVqU48POOQuc4wKdgo4374o27ECy8I8U1mo7xIICSgP+Sy5n mtHKEI5zil9hPvny+TZyk+fQYJOrPMxTVtvdIgLPssi9yp64gR0NAuPskUXO6NVje/FW FsMg== X-Forwarded-Encrypted: i=1; AJvYcCWR6mG7Vc+9QX4RScpgoQpjndW3n5QfnAungZKZkYPKoASttWDdSPOLpUqUKig2hZQ4HZiKIor2R5dCkU8=@vger.kernel.org X-Gm-Message-State: AOJu0YztFAAw2MNTTxXMj33Apc6/8X+zI1SMvOdtVnFbengsQk2gWL6Z kSKNuAdawpm4tc9O63oPsOlHVbNtn4YOaeE8ON8r2jpcsL3mC82h4Qd6 X-Gm-Gg: ATEYQzwxfWzcA1V0BsUECTyiOjG2rBAEGKUKu8KunBM6Sks/tYGSn6WhaqA7L6KtO8w 9G4bmc3ld5lRYtfHi7+uC2QW41nkRllrX1YyBN22Lq8IOlECWaesD6X8PlAWpWghe8XJabxHBOi 2UHsRX5tICNNMs2b5Q+ZjSdCKqhnxYFtsnQuZBoRi7/LcoRGnEgdRIq8M6oFVpJ1xpzOEmv27zx imd4Eaer2ZZeeV+rL/AbSIBBOTaGAuvUMkIGvUk8bMro3qu2eHd44+NCkoJ0zKdORdrt59l7TIU UckKyLWrv5iJOh02T28/qozNiNd2ZcEKhM7/pVYfBdoSRhZcLFL7nQovTdm0JXqV1RxXInO5+ze RFXEHmep1gt1sTrI4EmxRPxXuuaC/03DqJP0oYrFtgNL4Qk0oSStBzADiu5vP5Lz7zznMQxUjmQ FXF++KjgqUo5jkcBuf3J1s5cKPmwHccJRyIw== X-Received: by 2002:a17:90b:554e:b0:35b:9ab6:1d65 with SMTP id 98e67ed59e1d1-35bd2d52dc5mr12051122a91.25.1774325247493; Mon, 23 Mar 2026 21:07:27 -0700 (PDT) Received: from aadarsh.. ([2401:4900:1cd7:c8ff:2d2f:5231:1645:4549]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-35c031ecf44sm677434a91.11.2026.03.23.21.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 21:07:26 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v7] staging: rtl8723bs: remove commented-out code Date: Tue, 24 Mar 2026 09:37:18 +0530 Message-ID: <20260324040718.7777-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318021005.6346-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove code that is not used anywhere in driver. Signed-off-by: Aadarsh Mandal --- v6: - No change. v5: - No change. v4: - Remove extra space insertion. - Delete remaining commented-out code. v3: - Add the extra space that count as insertion. - Remove unwanted addition. v2: - Restore braces for standalone code blocks {}. - Delete reindented commented-out code and extra space. v1: - Reindented commented-out code;extra space remained. drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..96a0c8e304da 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtl8723b_InitializeFirmwareVars(padapter); -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_= DONT_CARE); - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ - rtl8723b_InitAntenna_Selection(padapter); /* */ @@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ= _CTRL) | BIT(12)); -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } -- 2.43.0