On Wed, Mar 18, 2026 at 11:22:26AM +0530, Manikandan Muralidharan wrote:
> Add the microchip,sama7d65-i3c-hci compatible string to the MIPI I3C
> HCI binding. The Microchip SAMA7D65 I3C controller is based on the
> MIPI HCI specification but requires two clocks, so add a conditional
> constraint when this compatible is present.
>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> Changes in v4:
> - Define and describe the clock in the top-level properties
> ---
> .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 26 ++++++++++++++++---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> index 39bb1a1784c9..a946a8920046 100644
> --- a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> +++ b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml
> @@ -9,9 +9,6 @@ title: MIPI I3C HCI
> maintainers:
> - Nicolas Pitre <npitre@baylibre.com>
>
> -allOf:
> - - $ref: /schemas/i3c/i3c.yaml#
> -
> description: |
> MIPI I3C Host Controller Interface
>
> @@ -28,7 +25,13 @@ description: |
>
> properties:
> compatible:
> - const: mipi-i3c-hci
> + enum:
> + - mipi-i3c-hci
> + - microchip,sama7d65-i3c-hci
> + clocks:
> + items:
> + - description: Peripheral bus clock
> + - description: System Generic clock
Missing blank lines. Also, clocks go after reg.
> reg:
> maxItems: 1
> interrupts:
> @@ -39,6 +42,21 @@ required:
> - reg
> - interrupts
>
> +allOf:
> + - $ref: /schemas/i3c/i3c.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,sama7d65-i3c-hci
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
Drop, pointless. You already said in top-level they are exactly two
items.
> + required:
> + - clocks
else - clocks: false. See example schema. Or explain in the commit msg
why existing compatible gets clocks now.
Best regards,
Krzysztof